Age | Commit message (Collapse) | Author |
|
...avoid setting bad values from generic qadevOOo property set tests, and throw
an IllegalArgumentException if bad values do get set. Found via
-fsanitize=enum. The TODO about ScLkUpdMode vs. LinkUpdateModes mismatch looks
worrying.
Change-Id: Ibc01845e7e3179dc693fe8c59c1f1ffad5282420
|
|
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.
Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
|
|
Change-Id: I8be2ee13652ed7223e41765811db577ecc1c85d6
|
|
Change-Id: Iae7530a52eda020f9074a6de0ef9e4b9779593f6
|
|
Change-Id: Ic8dffc4ed757c74ce383b3dcf204d1c899a0c4f5
|
|
so I can turn PopertyNames into an enum
Change-Id: I939a83c0962813302a3653e75976147b2300cb18
|
|
Change-Id: I3e465987ef3dd502faecaf3c5ce151013a5bf314
|
|
Change-Id: I2e66a6acfd50b929d43ffdb3e468042875b6b23d
|
|
Change-Id: I37790675619b2dde3fe303ba3adc527fc1dfdcf5
|
|
Change-Id: I4bc4208a80a41a43f9a1145a2e674f37d1333424
|
|
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere
Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
|
|
since all of it's methods and fields are static.
Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
|
|
Change-Id: I9746158dfdffafd138160c2491e57b269d04e22b
|
|
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
|
|
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
these methods did nothing but call their super implementation.
found by CodePro
Change-Id: Iba40d10ca1db0b4a3b4b971cacc2f299c4d5f389
|
|
found by CodePro
Change-Id: I5f7e5b75b0345a1d917638e57a7d8ad60efb1475
|
|
found by CodePro
Change-Id: If1b75e43f81d70984422e437147048a491395b66
|
|
found by CodePro
Change-Id: I01c18ddc842fd89105fa95daaa482fba8fcb7bec
|
|
found by CodePro
Change-Id: Idf67521a46d73afe2f7656bb1a9f81e755eabbdb
|
|
.. more obvious
found by CodePro
Change-Id: I60b05b01819a756a07d2358e3cfe8b0d7d4436a6
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by FindBugs.
Change-Id: I4f457cd8f6f28f0429fc50529c8d38d80b80c560
|
|
not ==
Found by FindBugs.
Change-Id: I74805f1187bd623433ad097dec1015a3cf5f45ac
|
|
found by PMD
Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
found by UCDetector
Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
|
|
Change-Id: I5e753737a0dfd024da4ce076645a4ddc2e7550e0
|
|
Found by FindBugs.
Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
|
|
Change-Id: Ief2bf7d3e98186a2268b873c4c5f7114057bd10f
|
|
Change-Id: I7866959b9ea36c81003259cd387a001e9f34f26a
|
|
Just remove this field altogether, it was not being used for
anything other than synchronisation.
Change-Id: I982385f9eb7aed3fff0adf85d2a37bfe003d937b
|
|
It is just being used as a Runnable
Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
|
|
Change-Id: Ifefb5de196a3e5cbaa8945759da42886c69daacf
|
|
and just use OOoRunner, there is no point in having a stripped down
jar, the cost of firing up the Java VM completely dwarfs any benefit
of having a smaller jar.
Change-Id: Ibcc3c5bd6e9b9c918041142dd32db0ea5dddc25b
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7
Reviewed-on: https://gerrit.libreoffice.org/13477
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
This reverts commit 2d724f086f0ac9ee9a340610e0fa2c4fff110565.
Apparently other bits of code are referencing the default .sce
file
|
|
much easier to copy and paste an existing test anyhow, and more likely
to be accurate and up-to-date
Change-Id: I4deed6d14b0e860e394a537e2a2092387c62b657
|
|
found by running UCDetector over the code many times, like peeling
an onion
Change-Id: I54d5147eb1b5c921ad236331bc4c1f765b13ca83
Reviewed-on: https://gerrit.libreoffice.org/13445
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8
Reviewed-on: https://gerrit.libreoffice.org/13435
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6
Reviewed-on: https://gerrit.libreoffice.org/13408
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I51118fecf9de27407b4c5a66cd6577574939e001
|
|
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
|
|
found by PMD
Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873
Reviewed-on: https://gerrit.libreoffice.org/13097
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
than an empty @deprecated tag
Change-Id: I1646ce1c0c8823ac5be0153aeb8eb2b830e7ebfa
Reviewed-on: https://gerrit.libreoffice.org/12525
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|