Age | Commit message (Collapse) | Author |
|
This addresses some of cppcheck's "redundantAssignment" warnings
("Variable '<varName>' is reassigned a value before the old one
has been used").
Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e
Reviewed-on: https://gerrit.libreoffice.org/17926
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Id2654555c4042f8c0bdbd6bab6507e705f08326b
|
|
Change-Id: I72bdd6627a191a65d5c3b479c100e30442a8bb9e
|
|
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.
So far, I have only run the plugin up till the VCL module.
Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.
Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
|
|
Change-Id: I07d9567da23094836134a54afce660500bf1b3f5
|
|
since after my converting stuff in include/registry/types.h to use 'enum
class', it can obviously no longer be "extern C", so drop the "extern C"
and rename the file to reflect that.
Change-Id: Ia30f5731316525e48531c4785ab7471a428bcf6f
|
|
Change-Id: I8320f6f42d5579fbd09450ddca61c4c066de98e4
|
|
Change-Id: I81599570698eb92abf14fa6386d8545c2031e863
|
|
Change-Id: Ifef0aaae6208f18c1352fef7c471deb60a97820d
|
|
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
|
|
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
|
|
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
|
|
Change-Id: I192bc9653d8492a850a5e259e15782bd3bb24922
|
|
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
|
|
This addresses some cppcheck warnings.
Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018
Reviewed-on: https://gerrit.libreoffice.org/13540
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If4db6a631ad6b24ca6ecfef81a0a20b766ed6324
|
|
Change-Id: I9489f90a63d477e8802634e7850d3a3fa8e4d133
|
|
Change-Id: Ibeab8e1b64f3185eaca81a31bd131d11994386f3
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I1d7c1fa2fffe20a0bc60cf5533b8f8c28e360a1d
|
|
Change-Id: Ica0c7fe04dae3c52583cc2324bae1cfa5af1e197
Reviewed-on: https://gerrit.libreoffice.org/8292
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iaf118eca7a7b24945afbc1959ad78c712e4a299b
|
|
Change-Id: I60fc93beb58c548c7278eaf69f1d0a448b5c27f1
|
|
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
Change-Id: I63a244ececcdaba5837b028bc73cbd26e8555aa4
|
|
Change-Id: I0057b9174af6a83f3fde0e27c3a91a4aeca95873
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.
Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
|
|
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
Change-Id: I15f6ad0a760a28cbac53f99ba4d14ff5c24ce005
|
|
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
|
|
...that had once been workarounds for compilers that did not yet support the
C++98 scoping rules for declarations in for-init-statements.
Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
|
|
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: I3c442b7c3743684f62cc5ffc3c4b0926ff0db999
|
|
|
|
This is hopefully a better fix for c589fa17b8f3e6ded0d1e04120781eb5d6735bc7
"Dalvik enforces byte constants being in range (-128..127)."
|
|
|
|
Please find attached a partial fix for Easy Hack FDO43460
Part XXVII
Modules
padmin, pyuno, rdbmaker, regexp, registry, rsc, sal
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
the code was correct; it was wrongly detected by some gcc versions;
the warning was considered as an error in openSUSE build service;
the change does not cause any harm;
|
|
|
|
|
|
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)
Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
|
|
|
|
|
|
avoid redundant closeKey()/flush() calls.
|