Age | Commit message (Collapse) | Author |
|
* Client code must replace uses of idlc and regmerge with uses of unoidl-write,
see the changes to odk/examples/ and ure/source/uretext/ in
40f2aee6584eafcf4cd1d95fcf1f775e5435440d "Provide unoidl-write also for the
SDK" for examples.
* The new types.rdb format is not compatible with LibreOffice < 4.1. Clients
generating extensions containing such files are advised to use appropriate
LibreOffice-minimal-version elements.
* For compatibility with old extensions, reading the legacy types.rdb format is
still supported.
* The SDK no longer ships an idl/ sub-directory containing the udkap and offapi
.idl files (as, unlike idlc, unoidl-write does not need them).
odk/config/cfgWin.js had to be adapted to look (somewhat arbitrarily) for an
examples/ sub-directory instead of idl/ when checking for "an sdk folder".
gb_UnoApi_package_idlfiles became unused and has been removed.
* The idlc and regmerge executables have been removed. Module idlc has been
removed except for idlc/test/parser/, which is also used by
CustomTarget_unoidl/unoidl-write_test, and which may eventually be moved into
module unoidl. Module external/ucpp and the corresponding configure options
have also been removed.
Change-Id: I42a0231699b863b5ebe2bee63bc32c8f79278cc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122363
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I2da242fcb59709ebdd0819ec04d051d794da71e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127277
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I57dbd6b8c944f2adb158db9c3086b3ad26c5c084
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105697
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
used
git grep -lw namespace
| xargs perl -i -p0e 's/(\w+)\s*.\{.\s*namespace\s*(\w+)/\1::\2/smg;'
to do the initial replace, then compiled and fixed.
Change-Id: If69904d75940c851aeffab0e78c4ba02cc968d44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98526
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This reverts commit 31138ff7729cbf179079a5e635d3a823e2971f08.
Now that we know that making fields has negative side effects
like disabling assignment operator generation.
Change-Id: I3f1ae65532f441c8be5ebca5866b8a1e1c69318c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90363
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend
loplugin:external to warn about enums".
Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:
filter/source/svg/svgexport.cxx
sc/source/filter/excel/xelink.cxx
sc/source/filter/excel/xilink.cxx
svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx
All other free functions mentioning moved classes appear to be harmless and not
give rise to (silent, even) ADL breakage. (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered by
computeAffectedTypes, even though they could also be affected by ADL-breakage---
but don't seem to be in any acutal case across the code base.)
For friend declarations using elaborate type specifiers, like
class C1 {};
class C2 { friend class C1; };
* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")
* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration
must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882>
"elaborated-type-specifier friend not looked up in unnamed namespace".
Apart from that, to keep changes simple and mostly mechanical (which should help
avoid regressions), out-of-line definitions of class members have been left in
the enclosing (named) namespace. But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of
template from unnamed namespace using unqualified-id in enclosing namespace".
Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.
And in some cases, mention of affected types in blacklists in other loplugins
needed to be adapted.
And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about
such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler
doesn’t give this warning for types defined in the main .C file, as those are
unlikely to have multiple definitions."
(<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The
warned-about classes also don't have multiple definitions in the given test, so
disable the warning when including the .cxx.
Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I819bb44e36bdb6ec671cf11bd779085767d82fd0
Reviewed-on: https://gerrit.libreoffice.org/67697
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b
"HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now"
Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937
Reviewed-on: https://gerrit.libreoffice.org/64800
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I9af0de0d0f3aed565ac396b15821812fd9922779
Reviewed-on: https://gerrit.libreoffice.org/61994
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie139490f2b008bf294910d002af711f8f41fe76d
Reviewed-on: https://gerrit.libreoffice.org/61727
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes.
This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from l10ntools to reportdesign
Change-Id: Ia2dc93dd848c2dc0b6a8cb6e19849c614ec55198
Reviewed-on: https://gerrit.libreoffice.org/58205
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I914fa6c6ef2f660eb6b8570c9c5f86cef477be80
Reviewed-on: https://gerrit.libreoffice.org/44093
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I499856ba451c71bb53e99d74c5a89f1a185c9386
|
|
Change-Id: I527920d3e970e5028ebc0a84d0b460cdee0f140b
Reviewed-on: https://gerrit.libreoffice.org/38077
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
with command
> git grep -l osl/diagnose.h *.cxx |
xargs grep -L -w 'OSL_\w*' |
xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'
headers need more work
Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
|
|
Change-Id: I10c3f9d26c3faf6bd2c47493dd83c3ee744dc711
|
|
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9
Reviewed-on: https://gerrit.libreoffice.org/31903
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I04b6d14d3dd8d55ccc4d4eb9313bc37959690672
Reviewed-on: https://gerrit.libreoffice.org/28824
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
|
|
Change-Id: I0fb06079ff8a9d0b2f5a2929f31846f91391f5c4
Reviewed-on: https://gerrit.libreoffice.org/22229
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...as the latter was the more flexible replacement for the former for LO-
internal use already. The only gotcha to watch out for is that unoidl-check
cannot be used to check "naked" .urd files, but only ones where the content has
been moved to /UCR via regmerge.
Leave registry/CustomTarget_regcompare_test.mk around to verify that
unoidl-check behaves the same as did regcompare on those old-format .urd/.rdb
files.
Change-Id: Ic13ede48535bf942126c810d88bac7e4081d984e
|
|
Change-Id: Ifdc2df9ba51ce8ef2c8793bb51c28a547f22214f
Reviewed-on: https://gerrit.libreoffice.org/21866
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
Change-Id: Ie5a37a49f1b1c08a20f89e167ca415fc645ed40d
|
|
Change-Id: I5b2b7044c77de899ce8dc1e44f3673835bd3ce4c
|
|
Change-Id: I5c6fae963c4aabe15d82a51f5801e62656188051
|
|
Change-Id: Ia058e42700c7724efd74fd6c5560ccca919fb2e8
|
|
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
|
|
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
|
|
Change-Id: Ie453a7c97a762932884c5c41b13607a170368107
|
|
Change-Id: I72bdd6627a191a65d5c3b479c100e30442a8bb9e
|
|
Change-Id: I8320f6f42d5579fbd09450ddca61c4c066de98e4
|
|
Change-Id: I81599570698eb92abf14fa6386d8545c2031e863
|
|
Change-Id: Ifef0aaae6208f18c1352fef7c471deb60a97820d
|
|
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
|
|
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
|
|
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: I52253f6b925a943edc2984ce4d9462bd1edb5f51
|
|
Change-Id: If0f47a78bbffec5c2ebd33c552d0d8a300b48eb1
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.
(cherry picked from commit 28206a7cb43aff5adb10f8235ad1680c3941ee3e)
Conflicts:
include/osl/file.hxx
include/osl/pipe_decl.hxx
include/osl/socket.h
include/osl/socket_decl.hxx
include/sal/main.h
include/svx/dbaexchange.hxx
include/svx/dlgctrl.hxx
include/svx/msdffdef.hxx
include/svx/sdr/contact/objectcontactofpageview.hxx
include/svx/svdpntv.hxx
include/ucbhelper/content.hxx
include/ucbhelper/interceptedinteraction.hxx
include/ucbhelper/resultsethelper.hxx
include/unotools/sharedunocomponent.hxx
include/unotools/viewoptions.hxx
include/vcl/pdfwriter.hxx
include/xmloff/txtparae.hxx
include/xmloff/uniref.hxx
rhino/rhino1_7R3.patch
rsc/inc/rscrsc.hxx
sal/inc/osl/conditn.h
sal/inc/osl/security.h
sal/inc/osl/semaphor.h
sal/inc/osl/semaphor.hxx
sal/inc/rtl/string.hxx
sal/inc/rtl/tres.h
sal/inc/systools/win32/StrConvert.h
sal/osl/os2/file_path_helper.h
sal/osl/os2/file_path_helper.hxx
sal/osl/os2/file_url.cxx
sal/osl/os2/file_url.h
sal/osl/os2/makefile.mk
sal/osl/os2/pipe.cxx
sal/osl/os2/process.c
sal/osl/os2/profile.c
sal/osl/os2/socket.c
sal/osl/os2/system.h
sal/osl/unx/asm/interlck_sparc.s
sal/osl/unx/file_url.cxx
sal/osl/unx/signal.c
sal/osl/unx/system.h
sal/osl/w32/MAKEFILE.MK
sal/osl/w32/interlck.c
sal/osl/w32/module.cxx
sal/osl/w32/security.c
sal/qa/buildall.pl
sal/qa/osl/file/osl_File.cxx
sal/qa/osl/module/osl_Module_Const.h
sal/qa/osl/mutex/osl_Mutex.cxx
sal/qa/osl/pipe/osl_Pipe.cxx
sal/qa/osl/process/osl_Thread.cxx
sal/qa/osl/socket/osl_StreamSocket.cxx
sal/qa/osl/socket/sockethelper.cxx
sal/qa/rtl_strings/rtl_OUString.cxx
sal/rtl/source/unload.cxx
sal/systools/win32/kill/kill.cxx
sal/systools/win32/uwinapi/MoveFileExA.cpp
sal/test/bootstrap.pl
sal/typesconfig/typesconfig.c
sal/workben/tgetpwnam.cxx
sax/inc/sax/parser/saxparser.hxx
sc/addin/datefunc/dfa.cl
sc/addin/datefunc/dfa.src
sc/addin/rot13/rot13.cl
sc/addin/rot13/rot13.src
sc/inc/attarray.hxx
sc/inc/chgtrack.hxx
sc/inc/column.hxx
sc/inc/compressedarray.hxx
sc/inc/document.hxx
sc/inc/table.hxx
sc/source/core/data/column.cxx
sc/source/core/data/dptablecache.cxx
sc/source/core/data/dptabres.cxx
sc/source/core/data/dptabsrc.cxx
sc/source/core/data/global.cxx
sc/source/core/tool/chgtrack.cxx
sc/source/core/tool/compiler.cxx
sc/source/filter/excel/xestyle.cxx
sc/source/filter/excel/xichart.cxx
sc/source/filter/inc/fapihelper.hxx
sc/source/filter/inc/xistyle.hxx
sc/source/filter/xml/xmlsubti.cxx
sc/source/ui/Accessibility/AccessibleCell.cxx
sc/source/ui/Accessibility/AccessibleContextBase.cxx
sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx
sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
sc/source/ui/Accessibility/AccessibleEditObject.cxx
sc/source/ui/Accessibility/AccessiblePreviewCell.cxx
sc/source/ui/app/inputwin.cxx
sc/source/ui/docshell/docfunc.cxx
sc/source/ui/drawfunc/fupoor.cxx
sc/source/ui/miscdlgs/linkarea.cxx
sc/source/ui/unoobj/chart2uno.cxx
sc/source/ui/unoobj/nameuno.cxx
sc/source/ui/vba/vbacharacters.hxx
sc/source/ui/vba/vbarange.cxx
sc/source/ui/vba/vbawindow.cxx
scaddins/source/analysis/analysishelper.cxx
scaddins/source/analysis/analysishelper.hxx
scaddins/source/datefunc/datefunc.cxx
scripting/examples/python/Capitalise.py
scripting/source/pyprov/officehelper.py
sd/source/filter/eppt/eppt.cxx
sd/source/filter/eppt/epptso.cxx
sd/source/ui/dlg/prltempl.cxx
sd/source/ui/dlg/tpoption.cxx
sd/source/ui/func/fuediglu.cxx
sd/source/ui/func/fupoor.cxx
sd/source/ui/func/fusel.cxx
sd/source/ui/func/smarttag.cxx
sd/source/ui/inc/OutlinerIteratorImpl.hxx
sd/source/ui/inc/SlideViewShell.hxx
sd/source/ui/inc/fuediglu.hxx
sd/source/ui/inc/fusel.hxx
sd/source/ui/slideshow/slideshowimpl.cxx
sd/source/ui/slidesorter/cache/SlsQueueProcessorThread.hxx
sd/source/ui/slidesorter/controller/SlsHideSlideFunction.cxx
sd/source/ui/slidesorter/controller/SlsSelectionCommand.hxx
sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx
sd/source/ui/slidesorter/view/SlsButtonBar.cxx
sd/source/ui/view/Outliner.cxx
sd/source/ui/view/drviewsh.cxx
sd/source/ui/view/frmview.cxx
sdext/source/presenter/PresenterFrameworkObserver.hxx
sdext/source/presenter/PresenterSlideShowView.cxx
setup_native/scripts/deregister_extensions
setup_native/scripts/register_extensions
setup_native/source/opensolaris/bundledextensions/README
setup_native/source/opensolaris/bundledextensions/svc-ooo_bundled_extensions
setup_native/source/win32/customactions/patch/swappatchfiles.cxx
setup_native/source/win32/customactions/reg4msdoc/registrar.cxx
setup_native/source/win32/customactions/reg4msdoc/userregistrar.cxx
sfx2/inc/sfx2/sfxbasemodel.hxx
sfx2/qa/complex/sfx2/DocumentProperties.java
sfx2/source/appl/appopen.cxx
sfx2/source/appl/appquit.cxx
sfx2/source/appl/appserv.cxx
sfx2/source/bastyp/sfxhtml.cxx
sfx2/source/dialog/dockwin.cxx
sfx2/source/doc/docfile.cxx
sfx2/source/doc/docvor.cxx
sfx2/source/doc/graphhelp.cxx
sfx2/source/doc/objcont.cxx
sfx2/source/doc/objserv.cxx
sfx2/source/doc/objstor.cxx
sfx2/source/doc/objuno.cxx
sfx2/source/doc/objxtor.cxx
sfx2/source/doc/printhelper.cxx
sfx2/source/doc/sfxbasemodel.cxx
sfx2/source/notify/eventsupplier.cxx
sfx2/source/view/frmload.cxx
sfx2/source/view/sfxbasecontroller.cxx
shell/qa/zip/ziptest.cxx
shell/source/backends/wininetbe/wininetbackend.cxx
shell/source/win32/shlxthandler/util/utilities.cxx
solenv/bin/build.pl
solenv/bin/build_release.pl
solenv/bin/cws.pl
solenv/bin/download_external_dependencies.pl
solenv/bin/make_download.pl
solenv/bin/make_installer.pl
solenv/bin/modules/Cws.pm
solenv/bin/modules/ExtensionsLst.pm
solenv/bin/modules/installer/control.pm
solenv/bin/modules/installer/downloadsigner.pm
solenv/bin/modules/installer/javainstaller.pm
solenv/bin/modules/installer/packagepool.pm
solenv/bin/modules/installer/patch/InstallationSet.pm
solenv/bin/modules/installer/scriptitems.pm
solenv/bin/modules/installer/windows/feature.pm
solenv/bin/modules/installer/windows/msiglobal.pm
solenv/bin/modules/installer/windows/sign.pm
solenv/bin/modules/installer/worker.pm
solenv/bin/modules/installer/xpdinstaller.pm
solenv/bin/modules/osarch.pm
solenv/bin/modules/packager/work.pm
solenv/bin/modules/pre2par/parameter.pm
solenv/bin/patch_tool.pl
solenv/bin/transform_description.pl
solenv/doc/gbuild/doxygen.cfg
solenv/gbuild/LinkTarget.mk
solenv/gbuild/gbuild.mk
solenv/inc/os2gcci.mk
solenv/inc/settings.mk
solenv/inc/startup/Readme
solenv/inc/target.mk
solenv/inc/tg_compv.mk
solenv/inc/tg_javav.mk
solenv/inc/unitools.mk
solenv/inc/unxbsdi.mk
solenv/inc/unxbsdi2.mk
solenv/inc/unxbsds.mk
solenv/inc/unxfbsd.mk
solenv/inc/unxlng.mk
sot/source/sdstor/stg.cxx
sot/source/sdstor/stgelem.cxx
sot/source/sdstor/ucbstorage.cxx
starmath/inc/toolbox.hxx
starmath/source/mathmlexport.cxx
starmath/source/node.cxx
starmath/source/toolbox.cxx
starmath/source/view.cxx
stoc/source/bootstrap/bootstrap.xml
stoc/source/corereflection/criface.cxx
stoc/source/invocation/invocation.cxx
stoc/source/security/access_controller.cxx
stoc/source/servicemanager/servicemanager.cxx
stoc/source/tdmanager/tdmgr.cxx
stoc/test/javavm/testjavavm.cxx
stoc/test/testconv.cxx
stoc/test/testcorefl.cxx
stoc/test/testintrosp.cxx
svl/inc/svl/inettype.hxx
svl/inc/svl/urihelper.hxx
svl/qa/complex/ConfigItems/helper/HistoryOptTest.cxx
svl/qa/complex/ConfigItems/helper/HistoryOptTest.hxx
svl/source/config/itemholder2.hxx
svl/source/items/itemset.cxx
svl/source/numbers/zforlist.cxx
svl/source/numbers/zformat.cxx
svl/source/numbers/zforscan.cxx
svtools/bmpmaker/bmp.cxx
svtools/inc/svtools/helpagentwindow.hxx
svtools/inc/svtools/menuoptions.hxx
svtools/inc/svtools/miscopt.hxx
svtools/inc/svtools/optionsdrawinglayer.hxx
svtools/inc/svtools/stringtransfer.hxx
svtools/inc/svtools/svlbitm.hxx
svtools/inc/svtools/svtdata.hxx
svtools/inc/svtools/valueset.hxx
svtools/source/brwbox/editbrowsebox.cxx
svtools/source/config/itemholder2.hxx
svtools/source/contnr/contentenumeration.hxx
svx/inc/svx/fmsrcimp.hxx
svx/inc/svx/svdobj.hxx
svx/inc/svx/xtable.hxx
svx/source/accessibility/DGColorNameLookUp.cxx
svx/source/accessibility/svxrectctaccessiblecontext.cxx
svx/source/dialog/pfiledlg.cxx
svx/source/fmcomp/fmgridcl.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/fmcomp/gridctrl.cxx
svx/source/form/filtnav.cxx
svx/source/form/fmPropBrw.cxx
svx/source/form/fmshimp.cxx
svx/source/form/fmsrcimp.cxx
svx/source/gallery2/galtheme.cxx
svx/source/inc/docrecovery.hxx
svx/source/sdr/event/eventhandler.cxx
svx/source/svdraw/svdedtv2.cxx
svx/source/svdraw/svdedxv.cxx
svx/source/svdraw/svdhdl.cxx
svx/source/svdraw/svdobj.cxx
svx/source/svdraw/svdograf.cxx
svx/source/svdraw/svdoole2.cxx
svx/source/svdraw/svdotxtr.cxx
svx/source/svdraw/svdundo.cxx
svx/source/svdraw/svdxcgv.cxx
svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
sw/inc/SwNumberTree.hxx
sw/inc/ndnotxt.hxx
sw/source/core/access/acccell.cxx
sw/source/core/access/acccell.hxx
sw/source/core/access/accframebase.cxx
sw/source/core/access/accframebase.hxx
sw/source/core/access/accmap.cxx
sw/source/core/access/accpage.cxx
sw/source/core/access/accpage.hxx
sw/source/core/access/accpara.cxx
sw/source/core/access/accpara.hxx
sw/source/core/bastyp/swrect.cxx
sw/source/core/crsr/findtxt.cxx
sw/source/core/doc/docdde.cxx
sw/source/core/doc/notxtfrm.cxx
sw/source/core/docnode/section.cxx
sw/source/core/draw/dcontact.cxx
sw/source/core/edit/edlingu.cxx
sw/source/core/inc/anchoredobjectposition.hxx
sw/source/core/layout/paintfrm.cxx
sw/source/core/layout/tabfrm.cxx
sw/source/core/layout/trvlfrm.cxx
sw/source/core/ole/ndole.cxx
sw/source/core/text/atrstck.cxx
sw/source/core/text/inftxt.cxx
sw/source/core/text/itratr.cxx
sw/source/core/text/itrform2.cxx
sw/source/core/text/itrform2.hxx
sw/source/core/text/porfld.cxx
sw/source/core/text/txtfly.cxx
sw/source/core/txtnode/thints.cxx
sw/source/core/txtnode/txtedt.cxx
sw/source/core/uibase/dochdl/swdtflvr.cxx
sw/source/core/uibase/docvw/PostItMgr.cxx
sw/source/core/uibase/docvw/SidebarWin.cxx
sw/source/core/uibase/docvw/edtwin.cxx
sw/source/core/uibase/envelp/labimg.cxx
sw/source/core/uibase/uiview/pview.cxx
sw/source/core/uibase/uno/unomailmerge.cxx
sw/source/core/undo/unattr.cxx
sw/source/core/undo/untbl.cxx
sw/source/core/unocore/unochart.cxx
sw/source/core/view/vdraw.cxx
sw/source/core/view/vnew.cxx
sw/source/filter/basflt/fltini.cxx
sw/source/filter/html/wrthtml.cxx
sw/source/filter/inc/wwstyles.hxx
sw/source/filter/rtf/rtffly.cxx
sw/source/filter/rtf/swparrtf.cxx
sw/source/filter/ww8/docxattributeoutput.cxx
sw/source/filter/ww8/dump/msvbasic.cxx
sw/source/filter/ww8/dump/ww8scan.cxx
sw/source/filter/ww8/dump/ww8scan.hxx
sw/source/filter/ww8/dump/ww8struc.hxx
sw/source/filter/ww8/wrtww8.cxx
sw/source/filter/ww8/ww8graf.cxx
sw/source/filter/ww8/ww8par.cxx
sw/source/filter/ww8/ww8par2.cxx
sw/source/filter/ww8/ww8par2.hxx
sw/source/filter/ww8/ww8par3.cxx
sw/source/filter/ww8/ww8par6.cxx
sw/source/filter/ww8/ww8scan.cxx
sw/source/filter/ww8/ww8scan.hxx
sw/source/ui/dbui/dbinsdlg.cxx
sw/source/ui/inc/tablemgr.hxx
sw/source/ui/inc/uitool.hxx
sw/source/ui/lingu/olmenu.cxx
sw/source/ui/uiview/viewport.cxx
sysui/desktop/productversion.mk
sysui/desktop/slackware/makefile.mk
testgraphical/source/CallExternals.pm
testgraphical/source/fill_documents_loop.pl
testgraphical/ui/java/ConvwatchGUIProject/src/IniFile.java
toolkit/doc/layout/notes.txt
toolkit/doc/layout/oldnotes.txt
toolkit/source/awt/vclxtabcontrol.cxx
toolkit/src2xml/source/srcparser.py
toolkit/workben/layout/editor.cxx
tools/inc/tools/simplerm.hxx
tools/inc/tools/solar.h
tools/source/communi/geninfo.cxx
tools/source/fsys/dirent.cxx
tools/source/fsys/filecopy.cxx
tools/source/fsys/os2.cxx
tools/source/inet/inetmime.cxx
tools/source/rc/resmgr.cxx
ucb/source/core/ucbcmds.cxx
ucb/source/ucp/file/filglob.cxx
ucb/source/ucp/odma/odma_content.cxx
ucb/source/ucp/tdoc/ucptdoc.xml
ucb/source/ucp/webdav/makefile.mk
ucbhelper/inc/ucbhelper/simplecertificatevalidationrequest.hxx
ucbhelper/source/client/content.cxx
ucbhelper/source/client/interceptedinteraction.cxx
udkapi/com/sun/star/beans/XPropertiesChangeListener.idl
udkapi/com/sun/star/io/ObjectOutputStream.idl
udkapi/com/sun/star/io/XMarkableStream.idl
udkapi/com/sun/star/io/XTextOutputStream.idl
udkapi/com/sun/star/reflection/CoreReflection.idl
udkapi/com/sun/star/reflection/XTypeDescriptionEnumerationAccess.idl
udkapi/com/sun/star/test/XSimpleTest.idl
unodevtools/source/skeletonmaker/skeletoncommon.cxx
unodevtools/source/skeletonmaker/skeletoncommon.hxx
unotools/inc/unotools/cacheoptions.hxx
unotools/inc/unotools/cmdoptions.hxx
unotools/inc/unotools/dynamicmenuoptions.hxx
unotools/inc/unotools/extendedsecurityoptions.hxx
unotools/inc/unotools/fontoptions.hxx
unotools/inc/unotools/historyoptions.hxx
unotools/inc/unotools/idhelper.hxx
unotools/inc/unotools/internaloptions.hxx
unotools/inc/unotools/localisationoptions.hxx
unotools/inc/unotools/moduleoptions.hxx
unotools/inc/unotools/printwarningoptions.hxx
unotools/inc/unotools/securityoptions.hxx
unotools/inc/unotools/startoptions.hxx
unotools/inc/unotools/workingsetoptions.hxx
unotools/source/config/cmdoptions.cxx
unotools/source/config/compatibility.cxx
unotools/source/config/configitem.cxx
unotools/source/config/configmgr.cxx
unotools/source/config/dynamicmenuoptions.cxx
unotools/source/config/fontcfg.cxx
unotools/source/config/itemholder1.hxx
unotools/source/config/moduleoptions.cxx
unotools/source/config/pathoptions.cxx
unotools/source/config/viewoptions.cxx
unotools/source/misc/sharedunocomponent.cxx
uui/source/fltdlg.cxx
uui/source/iahndl-filter.cxx
vbahelper/inc/vbahelper/collectionbase.hxx
vbahelper/source/msforms/vbacontrol.cxx
vbahelper/source/vbahelper/collectionbase.cxx
vcl/aqua/source/gdi/atsfonts.cxx
vcl/inc/aqua/salmathutils.hxx
vcl/inc/graphite_cache.hxx
vcl/inc/jobset.h
vcl/inc/os2/salgdi.h
vcl/inc/osx/saldata.hxx
vcl/inc/salgdi.hxx
vcl/inc/salwtype.hxx
vcl/inc/unx/wmadaptor.hxx
vcl/inc/vcl/print.hxx
vcl/inc/vcl/strhelper.hxx
vcl/os2/source/app/salinst.cxx
vcl/os2/source/app/saltimer.cxx
vcl/os2/source/gdi/salgdi2.cxx
vcl/osx/salframeview.mm
vcl/osx/salprn.cxx
vcl/qa/cppunit/dndtest.cxx
vcl/source/app/dbggui.cxx
vcl/source/control/ilstbox.cxx
vcl/source/gdi/cvtsvm.cxx
vcl/source/gdi/gdimtf.cxx
vcl/source/gdi/outdev4.cxx
vcl/source/gdi/outdev6.cxx
vcl/source/gdi/pdfwriter_impl.cxx
vcl/source/gdi/pdfwriter_impl2.cxx
vcl/source/gdi/print.cxx
vcl/source/gdi/print2.cxx
vcl/source/glyphs/gcach_layout.cxx
vcl/source/glyphs/glyphcache.cxx
vcl/source/glyphs/graphite_layout.cxx
vcl/source/window/printdlg.cxx
vcl/source/window/tabdlg.cxx
vcl/source/window/window.cxx
vcl/source/window/winproc.cxx
vcl/unx/generic/app/saldisp.cxx
vcl/unx/generic/dtrans/X11_selection.hxx
vcl/unx/gtk/app/gtkdata.cxx
vcl/win/source/gdi/salgdi2.cxx
vcl/win/source/gdi/salgdi3.cxx
vcl/win/source/window/salframe.cxx
vos/inc/vos/pipe.hxx
vos/inc/vos/process.hxx
vos/inc/vos/signal.hxx
vos/inc/vos/socket.hxx
vos/inc/vos/thread.hxx
vos/source/pipe.cxx
vos/source/socket.cxx
wizards/com/sun/star/wizards/agenda/AgendaTemplate.java
wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java
wizards/com/sun/star/wizards/agenda/TopicsControl.java
wizards/com/sun/star/wizards/web/FTPDialog.java
wizards/com/sun/star/wizards/web/ImageListDialog.java
wizards/com/sun/star/wizards/web/Process.java
wizards/com/sun/star/wizards/web/ProcessStatusRenderer.java
wizards/com/sun/star/wizards/web/TOCPreview.java
wizards/com/sun/star/wizards/web/WWD_Startup.java
wizards/com/sun/star/wizards/web/data/TypeDetection.java
wizards/com/sun/star/wizards/web/export/ImpressHTMLExporter.java
writerfilter/inc/doctok/WW8Document.hxx
writerfilter/source/dmapper/DomainMapper.cxx
writerfilter/source/dmapper/NumberingManager.cxx
writerfilter/source/dmapper/PropertyMap.cxx
writerfilter/source/dmapper/StyleSheetTable.cxx
writerfilter/source/doctok/WW8StructBase.hxx
writerfilter/source/doctok/resources.xmi
writerfilter/source/ooxml/README.efforts
xmerge/source/activesync/XMergeFilter.cpp
xmerge/source/minicalc/java/org/openoffice/xmerge/converter/xml/sxc/minicalc/SxcDocumentDeserializerImpl.java
xmerge/source/palmtests/qa/comparator/pdbcomparison.java
xmerge/source/palmtests/qa/test_spec/convertor_test_spec.html
xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefinedName.java
xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Workbook.java
xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Worksheet.java
xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/SymbolLookup.java
xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentDescriptor.java
xmerge/workben/jstyle.pl
xmlhelp/source/cxxhelp/provider/databases.hxx
xmlhelp/source/cxxhelp/provider/provider.cxx
xmlhelp/source/treeview/tvread.cxx
xmloff/inc/txtfldi.hxx
xmloff/inc/xmloff/xmlmultiimagehelper.hxx
xmloff/inc/xmloff/xmluconv.hxx
xmloff/source/core/xmlexp.cxx
xmloff/source/draw/shapeexport2.cxx
xmloff/source/draw/shapeexport3.cxx
xmloff/source/meta/xmlversion.cxx
xmloff/source/style/impastp4.cxx
xmloff/source/style/xmlaustp.cxx
xmloff/source/text/XMLSectionExport.cxx
xmloff/source/text/txtflde.cxx
xmloff/source/text/txtimp.cxx
xmloff/source/text/txtparae.cxx
xmloff/source/text/txtparai.cxx
xmloff/source/text/txtvfldi.cxx
xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx
Change-Id: Ie072e7c3a60c5dae16a67ac36d1f372c5065c99c
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
they both have the same value, so it doesn't matter much
Change-Id: Ic001cd2824248db8577dc69e240c46ec09d023ae
|
|
Change-Id: Iaf118eca7a7b24945afbc1959ad78c712e4a299b
|
|
Change-Id: I60fc93beb58c548c7278eaf69f1d0a448b5c27f1
|
|
Change-Id: I564ef5ebf16c0ee50da69f3d8b97a5452a1cd0b8
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|