summaryrefslogtreecommitdiff
path: root/registry
AgeCommit message (Collapse)Author
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-09loplugin:salboolNoel Grandin
Change-Id: Id4194f4d5bb6fcf064985fddc6f7344a4d34ca04
2015-04-09fix windows and android buildsNoel Grandin
more 'extern C' fallout from my conversion of enum to scoped enum Change-Id: I4c9aabbfbd255775a8f3edc2b7c8c62647f539eb
2015-04-09fix android buildNoel Grandin
since after my converting stuff in include/registry/types.h to use 'enum class', it can obviously no longer be "extern C", so drop the "extern C" and rename the file to reflect that. Change-Id: Ia30f5731316525e48531c4785ab7471a428bcf6f
2015-04-09convert RTReferenceType to scoped enumNoel Grandin
Change-Id: I8320f6f42d5579fbd09450ddca61c4c066de98e4
2015-04-09convert RTMethodMode to scoped enumNoel Grandin
Change-Id: I81599570698eb92abf14fa6386d8545c2031e863
2015-04-09convert RT_ACCESS fields to scoped enumNoel Grandin
Change-Id: Ifef0aaae6208f18c1352fef7c471deb60a97820d
2015-04-09convert RegError to scoped enumNoel Grandin
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
2015-04-09convert RegValueType to scoped enumNoel Grandin
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
2015-04-09remove reg keytype constants and related codeNoel Grandin
since we no longer support the RG_LINKTYPE stuff Change-Id: If388ecfa0c475471b99b26155ad554ec702ca734
2015-04-09convert REG_ constants to scoped enumNoel Grandin
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I192bc9653d8492a850a5e259e15782bd3bb24922
2015-03-27loplugin:staticfunctionNoel Grandin
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I32d7a1d4fed6ef5c56f485cd92464f2d0960e5fd
2015-03-19loplugin:constantfunction: registryNoel Grandin
Change-Id: I0556481aee672451221aa72a8a90d465f3670313
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I52253f6b925a943edc2984ce4d9462bd1edb5f51
2015-01-28Some more loplugin:cstylecast clean-upStephan Bergmann
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
2015-01-25loplugin:unreffunStephan Bergmann
Change-Id: Id7e0ddf60e32a27cb3922ae6c64feeec40f8e079
2015-01-25coverity#1266504 Useless callCaolán McNamara
Change-Id: I11a2760799937393bfa1a91c1d454ccb3c4027e4
2015-01-20Some more loplugin:cstylecast: registryStephan Bergmann
Change-Id: I5cfb42729b5d3d97076058edb108965f248f86af
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018 Reviewed-on: https://gerrit.libreoffice.org/13540 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24Bin commented-out unreachable 'break' statementsTor Lillqvist
Change-Id: If0f47a78bbffec5c2ebd33c552d0d8a300b48eb1
2014-11-21Silence unhelpful cid#1215304 untrusted loop bound warningsStephan Bergmann
Change-Id: If4db6a631ad6b24ca6ecfef81a0a20b766ed6324
2014-11-18Fix memchr checksStephan Bergmann
(thanks caolan for spotting) Change-Id: I17093b4173b9a2fca2760240375bcb14313224ef
2014-11-17Remove dead codeStephan Bergmann
Change-Id: I1edce9e336650cc3317de8883e08fb6536c58c70
2014-11-17cid#1213388 etc.: Make reflread.cxx more robustStephan Bergmann
incl. revert of and proper fix for 8f69c7a11bf31f7134caf4e03fbcd4c6ef86382d "coverity#1213373 Use of untrusted scalar value," the data is tainted after all Change-Id: I19e4d544ccf6d02afe8d6e441cae6bbdadb8a6be
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-01coverity#1213373 Use of untrusted scalar valueCaolán McNamara
Change-Id: Ia5cafdde1171f81ea7387e073026a2e860d36544
2014-10-29untaint registry dataCaolán McNamara
by using a byte-swapping pattern that coverity doesn't detect as such tested as a scratch coverity attempt with a smaller project which has a far higher allocation of coverity attempts per week :-) unsigned int readTaintedUINT32(const char* buffer) { unsigned int v = ( (buffer[0] << 24) | (buffer[1] << 16) | (buffer[2] << 8) | (buffer[3] << 0) ); return v; } unsigned int readUntaintedUINT32(const char* p) { unsigned int v = *p++; v <<= 8; v |= *p++; v <<= 8; v |= *p++; v <<= 8; return v | *p; } void foo(char *buffer) { char *pOne = new char[readTaintedUINT32(buffer)]; // ^ coverity only reports this delete [] pOne; char *pTwo = new char[readUntaintedUINT32(buffer)]; // ^ and not this delete [] pTwo; } should silence coverity#1213371 Untrusted value as argument coverity#1213372 Untrusted value as argument coverity#1213373 Use of untrusted scalar value coverity#1213374 Use of untrusted scalar value coverity#1213376 Untrusted loop bound coverity#1213388 Use of untrusted scalar value coverity#1213389 Use of untrusted scalar value coverity#1213390 Use of untrusted scalar value coverity#1213423 Untrusted value as argument coverity#1213424 Untrusted value as argument coverity#1213425 Untrusted value as argument coverity#1213432 Untrusted value as argument coverity#1215304 Untrusted loop bound Change-Id: Ib8c7fc9a8e8b36ca227c76577d991c10df7dcd5a
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30registry: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I9489f90a63d477e8802634e7850d3a3fa8e4d133
2014-09-25coverity#705672 Resource leakCaolán McNamara
Change-Id: Ibeab8e1b64f3185eaca81a31bd131d11994386f3 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-17Translate German comments.Michael Meeks
Change-Id: I1d7c1fa2fffe20a0bc60cf5533b8f8c28e360a1d
2014-08-17convert int to boolThomas Arnhold
Change-Id: I4fb95c90dc1f188f8088ba1e4b7bfd0ebc59eb60
2014-07-18cid#705673 Resource leakNoel Grandin
Change-Id: Ib4cf76e941541b7f09b6a0dfbdab2a2604a0311d
2014-07-18cid#705674 and cid#705675 Resource leakNoel Grandin
Change-Id: Id97e5de8433cc5dc9cb72c0d447ce6af50eb4918
2014-07-07DBG_ASSERT->assert when followed by dereferenceCaolán McNamara
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-04coverity#1213422 Tainted ScalarNorbert Thiebaud
Change-Id: I87e845f346fda225127e3439e768b31a8eb93be3
2014-07-01coverity#706020 Unintended sign extensionCaolán McNamara
Change-Id: I30c097ac6731b742779af5528200ff99451d04b0
2014-07-01clang scan-build: various warningsCaolán McNamara
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-06-18coverity#706034 Unintended sign extensionCaolán McNamara
also coverity#706033 coverity#706032 coverity#706031 coverity#706030 coverity#706029 coverity#706028 coverity#706027 coverity#706026 coverity#706025 coverity#706024 coverity#706023 coverity#706022 coverity#706021 coverity#706020 coverity#706019 coverity#706018 coverity#706017 coverity#706016 coverity#706015 coverity#706014 coverity#706013 coverity#706012 coverity#706011 coverity#706010 coverity#706009 Change-Id: I7b85e85c21cf57c9a95d3373af97593d4c3bee8f
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-01 06:07:15 +0000