summaryrefslogtreecommitdiff
path: root/reportdesign
AgeCommit message (Collapse)Author
2015-08-14remove default value from SfxPoolItem::PutValueNoel Grandin
more useful to make it explicit. Specifically, otherwise my defaultvalue clang plugin would want to remove lots of places that contains #define constants which, while technically the same as the default value, convey semantic information which is quite useful. Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-11tdf#92459 remove o3tl/compat_functional.hxxDaniel Robertson
Replace all uses of deprecated features from the o3tl included in compat_functional.hxx with lambda expressions in connectivity and reportdesign. The patch should not cause any side effects. The change is largely cosmetic. Change-Id: I2042b91bf0fa2b47cce9ea11c97fa4ca6734c5e2 Reviewed-on: https://gerrit.libreoffice.org/17588 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-10cppcheck: variableScopeCaolán McNamara
Change-Id: I41270ad017dd16567c9b68df6044f182eec0b4ce
2015-08-04-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I2d23f199d07b4a339f080263b27d13faddc11ffb
2015-08-03tdf#91112: pass by const reference to lambdasJorenz Paragas
Since the function returned by o3tl::compose1 had its parameter passed by const reference, the same should be done for the lambda expressions that replace o3tl::compose1. I overlooked this detail in my previous commits. Change-Id: I0db5eec4e74d4835e786742ee6de3805215f377f Reviewed-on: https://gerrit.libreoffice.org/17465 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24convert WindowAlign to scoped enumNoel Grandin
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-21loplugin:unusedmethods reportdesign,scaddinsNoel Grandin
Change-Id: I3e2ccdbc0dd97f276a96eae5c041c09e69cede91 Reviewed-on: https://gerrit.libreoffice.org/17235 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21loplugin:unusedmethods formulaNoel Grandin
Change-Id: I62ff278679638dda7e10c86c49b1966641418e8b Reviewed-on: https://gerrit.libreoffice.org/17223 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Ia11e61456f6d915aab9da798ce4a2f89e82c189d
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13Introduce generic sub toolbar controllerMaxim Monastirsky
Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-10do not include boost/utility.hppMichael Stahl
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-10tdf#83541 Fix also for reportdesignMaxim Monastirsky
Forgot about this ugly wrapper in reportdesign Change-Id: I8a1d7206165d8c6db8a506eaa0c56d019fdadfb2
2015-07-06remove some unnecessary typedefs around uno::ReferenceNoel Grandin
Not very useful these days, since we have the css:: prefix to reduce verbosity. Found with a search like: git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;' | grep -v 'std::' Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd Reviewed-on: https://gerrit.libreoffice.org/16730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04Fix typosAndrea Gelmini
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30tdf#91112 replace o3tl::compose1 with lambdas in reportdesignJorenz Paragas
Remove TReportPairHelper and TStartMarkerHelper as well since they were helper structs that were used solely for many of these o3tl::compose calls and are now unused. Change-Id: I75b366a7951a841c49a34709a3bdc1877952b64d Reviewed-on: https://gerrit.libreoffice.org/16606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-29fdo#39468 Translate German Comments - reportdesignPhillip Sz
fix after review Change-Id: Ie6a665e6e473cb774cfbcc805aeb944de5723639 Reviewed-on: https://gerrit.libreoffice.org/16527 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-28coverity#1308565 Uncaught exceptionCaolán McNamara
Change-Id: I961169b4da3daf34adc338ca913dab6f5c1edfae
2015-06-28coverity#1308554 Uncaught exceptionCaolán McNamara
Change-Id: I907dfd51b224b3bd7579b96b169be27f29364cb2
2015-06-28coverity#1308550 Uncaught exceptionCaolán McNamara
Change-Id: I87dfcbd5d124120bb107ff63a18e6d79f895ddbb
2015-06-28Fix typosAndrea Gelmini
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-23rendercontext: Mass fix of using the wrong size.Jan Holesovsky
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-22Add variadic PartialWeakComponentImplHelper, remove need for implbase_var.hxxStephan Bergmann
Change-Id: Iad3417822b2ab3afb75da09c311a0bf07af5e2e4
2015-06-18coverity#1307698 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1229b4cdfcc741899b3ae8694e7db5d7e506ce0c
2015-06-15more untranslatable UI stringsAndras Timar
Change-Id: I4c02d7613743a1b11594fd96f6131219afd102ef
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-14tdf#89830: Ambiguous naming of character backgroundZolnai Tamás
Use 'Highlighting' also on Character Dialog. Change-Id: Ie81d25651e5998a35b4e2646089b8f2c590cfb98
2015-06-11cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I2d629c48b6526fa5f37174921c068e1201a897ef
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I6449dc2ada17dbf07bba179091e9990520868a00
2015-06-08Resolves: tdf#91672 Crash in base report - right click in page header sectionCaolán McNamara
Change-Id: Ie7f9abc16e07c9ef44916e0cebe67486f3583449
2015-06-05Let JUnit take care of exceptionsNoel Grandin
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-02loplugin:loopvartoosmallNoel Grandin
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac
2015-05-28convert PARENTCLIPMODE constants to scoped enumNoel Grandin
Change-Id: I36a53112e75fca9208b2f91e224a7c671695509b
2015-05-26tdf#91577 - CRASH: when "Report Builder" closedNoel Grandin
audited commit 6d0c89123f353aed80d3a8a08ef5cd1ffaa1eea9 "vclwidget: fix more places that should be wrapping in VclPtr" and fixed up the one place that needed it. Change-Id: Iedb56353e6a967367f38fa847efb950acc869a93
2015-05-26convert SCROLL constants to scoped enumNoel Grandin
Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
2015-05-26convert INVALIDATE constants to scoped enumNoel Grandin
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-25tdf#91577 - fix unique_ptr conversion bugs in reportdesign.Michael Meeks
Change-Id: Icc94ce266d567e7aad5afb5eacf0e85699ef4107
2015-05-25Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-24Typo: m_pReportDefintionMultiPlexer -> m_pReportDefinitionMultiPlexerJulien Nabet
Change-Id: I90f2119d5b43e5d6efa18561a1b04d1c0178950e
2015-05-22loplugin:constantfunctionNoel Grandin
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-22convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22convert POINTER constants to scoped enumNoel Grandin
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-21convert SWIB constants to scoped enumNoel Grandin
Change-Id: If64368f22e748cc646a726cb962e60ad29a66df9 Reviewed-on: https://gerrit.libreoffice.org/15840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20convert DEFAULTCONSTANT constant to scoped enumNoel Grandin
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-19remove the last of the OUString #defines in header filesNoel Grandin
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-18fix Wundefined-bool-conversionTomaž Vajngerl
Change-Id: I99e57e3f4b3f5b9fa21cdf6bfbda4b15ce83eaac
2015-05-18refactor remaining reportdesign classes to use RenderContextTomaž Vajngerl
Change-Id: I23d7a2153bfc0446a972651a892eba8f6dc2bc54
generated by cgit (git 2.34.1) at 2024-08-03 11:05:49 +0000