summaryrefslogtreecommitdiff
path: root/reportdesign
AgeCommit message (Collapse)Author
2020-04-15tdf#91565: Report builder, missing insert field iconJulien Nabet
in Add Field dialog. Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=50cacaea4d8f2a27ea4d9e626dbb518a57eb9ffc, author Caolán McNamara <caolanm@redhat.com> 2016-09-27 09:47:00 +0100 committer Caolán McNamara <caolanm@redhat.com> 2016-09-27 10:43:36 +0100 commit 50cacaea4d8f2a27ea4d9e626dbb518a57eb9ffc (patch) tree a2cf1d1fb28231a6594e03e17c5e9ffe8748a655 parent e6fc195ae8a59d665395149ea5f06749c4c6a596 (diff) convert floating add field to .ui format Change-Id: Ica9adc19f370d6340d2f5fac552cf1b995b390e0 it was easier to analyze the problem. Change-Id: I2c7dda5969d4018689446725dc3e179c6ddc74c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92228 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in reportdesignNoel Grandin
Change-Id: I1caeeb8e0a6f02f1dd37f7399702af1b2a400b28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-07loplugin:unusedvariableplus in reportdesignNoel Grandin
Change-Id: Ie8568f524a1f804e07890ee7828a81f1752fcfd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-05update some pches that no longer need vcl.lstbox.hxxCaolán McNamara
Change-Id: I5990f519247df17ecbc4321d93bd12987c9194b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-02loplugin:flatten in reportdesignNoel Grandin
Change-Id: I6d8b2730cede4453e7afd581cc24ed101ca6c81b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91557 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-19loplugin:redundantpointerops add some more smart pointer typesNoel Grandin
Change-Id: Ia7f3441404d8d2e5de501e70da496b6fdc6c9a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-16remove unnecessary Window::Update() calls, which immediately follow InvalidateNoel Grandin
Update() is effectively "paint immediately". Rather just let the invalidate do it's thing and have the widget paint on the next paint loop, along with the rest of the stuff. This is probably mostly cargo-cult, from the days when our invalidate/paint timer could take a long time to kick in. Change-Id: Idff06526e9a2892244cfd8ce6947916032b0d1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90567 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-03-12Revert "loplugin:constfields in reportdesign,sal,sax"Noel Grandin
This reverts commit d4d37662b090cb237585156a47cd8e1f1cbe2656. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Idef4937b89a83d2efbfaf0ab87d059a0143c0164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90364 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09improve loplugin:unusedfieldsNoel Grandin
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-09tdf#130878 improvement to previous fixNoel Grandin
which does not cause tons of extra pages to show up Change-Id: Ia80d66de2056d78d8cecd2814239951d0de97018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-04use FastParser in OReportStylesContextNoel Grandin
Change-Id: I7894d862f2b2fa3206d81682dcbe17474a24d120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-03remove some dead codeNoel Grandin
GpgComponentFactory is unused since: commit 06d7dbb3568889aa50f46d6307a39fa53a17313b Date: Sun May 21 14:28:57 2017 +0200 gpg4libre: share static xmlsec lib between nss and gpg tableautoformatfield.cxx should have been removed in: commit 5990beed9aba690ea9487e2c4a64615b7504a0a1 Date: Fri Aug 29 16:37:43 2014 +0200 Dead code xmlRow is unused since initial import Change-Id: Ief186e9ef46238cc8cdb49f4adde52a45a98cbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02don't rely on parser ::characters callback only firing onceNoel Grandin
which is true for the old parser, but not always so for the FastParser. So pre-emptively fix some stuff Change-Id: I405834f1dfd28c98cae87b6de38d238f723edafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89712 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-29tdf#130878 Report does not show label-fieldsNoel Grandin
The critical part was (1) calling m_pFixedContent->Characters instead of m_pFixedContent->characters in OXMLCharContent (2) calling OXMLReportElementBase::EndElement instead of OXMLReportElementBase::endFastElement in OXMLFixedContent Also (3) add a bunch of debugging logging to help find this (4) fix various characters() methods that can no longer rely on being called once for text content in a node Change-Id: Ib8ea88c5ff377311ca70e4292cad6d1f7f7c7323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-28weld calc navigatorCaolán McNamara
note: non-standard dnd via parent so the treeview triggers the dnd but doesn't itself strictly speaking drive the dnd, see copying a range from the navigator where the calc main edit window shows the outline where the copy of the range from the calc main window will go Change-Id: Ideecbe779e3d9bb5b392357a93ec25f625180ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-27tdf#114441: Convert use of sal_uLong to better integer typesPelin Kuran
Change-Id: I29b3b76dcc7960938155be768ed110c090607fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87619 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-26new loplugin:xmlimportNoel Grandin
to help me maintain the invariants when updating code to use the FastParser APIs. One weird invariant is that you need to override startFastElement or the createFastChildContext will not get called. Not all of these changes are probably necessary - some of the classes are never constructured themselves, only their subclasses are constructed, and their subclasses maintain the invariants, but it is just easier to scatter a few more startFastElement around Change-Id: I3f70fb5a1e44c311cf4926fa7b0fcda605709eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-16use fwd decls of StatusBarCaolán McNamara
Change-Id: Ib7ba9978e348a824a23310f9a4e6cfb6b7c18f0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88811 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-15convert XML_STYLE_FAMILY to scoped enumNoel Grandin
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10reportdesign: Hide some internal commands from customizationMaxim Monastirsky
In addition: - .uno:BackColor was unused, and internally mapped to the same id as .uno:DBBackgroundColor which is used and has a label. So remove the former, and make the latter visible in the customization dialog instead. - .uno:DSBEditDoc is mapped to SID_EDITDOC, and handled by the code, but has no label. On the other hand, the toolbar has an .uno:EditDoc item, which has no mapping in reportdesign, but happens to be mapped to SID_EDITDOC elsewhere. So assume this was a mistake, and .uno:DSBEditDoc should be used instead of .uno:EditDoc. Change-Id: I9da2ed36167571627b32a4055b734847c3ea1e64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88342 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-09Fix undo and redo dropdowns in non-sfx2 modulesMaxim Monastirsky
after commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController") accidentally enabled them there, instead of the simple buttons those modules used to have. Just implement the necessary stuff, instead of hiding the dropdown again. Change-Id: Ic93114f7f3cec8e96f3389ceb0d52552cde02a83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88333 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-07reportdesign: Use .uno:UnderlineSimpleMaxim Monastirsky
So we get a simple button, like it used to be before commit c81afdb5118536b2e2365a9a9af6b6e162c87aeb ("rework TextUnderlinePopup to be a PopupWindowController"). The dropdown doesn't work in reportdesign anyway. Change-Id: I9cec636ecc983a353b807624cea6523a9a2b92ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88182 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-07tdf#54938: Adapt supportsService implementations to cppu::supportsServiceMehmet Emin Başoğlu
Change-Id: I5484047a8b0e87d012ca3a37466b9ebf718257b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-06drop unnecessary includeCaolán McNamara
Change-Id: Ifb7e34d5648238a1cf0a893a6713671fa6881161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88066 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-28tdf#96505: Get rid of cargo cult long integer literalsOnur Yilmaz
I checked return values. Long variables didn't affect the calculation. Change-Id: Ia3713eedf275de71b1096d1fe7e22da012a7f94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87493 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin
found by my new loplugin:unusedvariableplus Change-Id: Ic3f55f492d43a53d8850a97d44059ff127fd69a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28New loplugin:unsignedcompareStephan Bergmann
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-26iAvoid explicit casts to smaller sal_uInt32 from larger longStephan Bergmann
...in what might be attempts to avoid warnings about signed vs. unsigned comparisons. Change-Id: I0e689d8b730170f35107cbdf46c3d8cd9a593367 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87456 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-25Change some #define to constexprStephan Bergmann
...plus loplugin:unnecessaryparen fallout in sw/source/uibase/docvw/edtwin.cxx. Each of the files contained at least one #define that would have caused warnings with upcoming loplugin:unsignedcompare. For consistency, I changed all #defines in those files (using a variable of a specific type if the original #define used a cast to that type, otherwise using 'auto'). Change-Id: I66f71b2d83394c9dc6952ae19df774cdd4d0b76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87374 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-24loplugin:makeshared in reportdesignNoel Grandin
Change-Id: I3f7cb6010142c8bdce96bf541a7efb650233942e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87325 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23loplugin:unusedmethodsNoel Grandin
Change-Id: Ic2212a502bbd42217934884f4fce49f6f8d4765c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22inline some construction methodsNoel Grandin
only called from one constructor Change-Id: I082cf3b459c936b79a6df695fffac5e3cf43705b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22use fastparser in RptMLMasterStylesContext_ImplNoel Grandin
Change-Id: If66ee8d6441fea0a2bb9c6b8a956ecd94f025746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22use fastparser for XMLFontStylesContextNoel Grandin
Change-Id: I7b273cdc0f90f2a8c9527d1f19fed97672a74741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87175 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22Convert reportdesign to fastparserNoel Grandin
Change-Id: I0703344aad4ca6c72e494160b019c13e24cc843a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87160 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21Use FastParser in XMLDocumentSettingsContextNoel Grandin
and flatten the pImpl data Change-Id: I8d817cd2af0a3855d10dbfaa580c3379119d5067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20loplugin:unusedfieldsNoel Grandin
Change-Id: If130c8a4861998d7eafd2e9525592f3c811ec21c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20use more FastParser in ORptFilterNoel Grandin
Change-Id: I517a26a3ea64d86a1f494e3b9ea52ee28604e0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-16remove some unneeded includesCaolán McNamara
Change-Id: I993ed47c6b4a43f6293bdf5c2803599d75337bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16return nullptr from Create*Context methods in nullptr subclassesNoel Grandin
the calling class handles this nicely, and also tells us when we are not handling some part of the XML file Change-Id: Ic51a42b9d2dec96243e7f83b528d7455d4bc0504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86906 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14use FastParser in reportdesignNoel Grandin
Change-Id: Ib012e7c814184eaeaab57200107e8bf4887058f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-13loplugin:finalclasses in package..sfx2Noel Grandin
Change-Id: I2908abc13f16b0011fcb326e8405080cc30df74a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-10use more std::make_sharedNoel Grandin
found using 'git grep', I tried using clang-tidy, but it only successfully found a tiny fraction of these Change-Id: I61c7d85105ff7a911722750e759d6641d578da33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-15 18:49:24 +0000