Age | Commit message (Collapse) | Author |
|
Change-Id: Ic14584cdd1047b2cfc590861b623a7e1e8be4429
|
|
Change-Id: I665a56fcad10e136e949a10497f6ab8813af9968
|
|
Change-Id: Ic94359c544034b9e6f09bd02a377d906a5b820e6
|
|
Change-Id: Iead354b95b832edd72eb8e881855f228fd85be70
|
|
Change-Id: I7308e848d3f9ac391dc656a145139dabbc792df3
|
|
of which there are several.
There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
numeric values to the underlying code, but perhaps further fixing is necessary?
Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
|
|
...in preparation of enabling the __attribute__((format(...))) in
sal_detail_logFormat (include/sal/detail/log.h)
Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
|
|
Change-Id: I85993df91bd14966f9175c356966fbd8eb1a927d
|
|
Change-Id: Id3852abe9bc7bbe774331a7d691abd2a79ff59b4
|
|
Change-Id: I12290bed7e4f298ab90393b8de6e2b6e7061e53f
|
|
Change-Id: Id4ef36d6c80ad62306bdbaa7094c2cb0b8ff77da
|
|
Change-Id: I81b6f8af2b5c539b7adb507e787497b5ed51fa39
|
|
Change-Id: Ib40140b97b53ed7affaf3a209a0a12a60ee7434c
|
|
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
|
|
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
|
|
Change-Id: I6a988077a3a2e2adf33a2c00a84b929e8133133f
|
|
Change-Id: Iee20ca4523739eb082ea1fa8c1145891c0caed29
|
|
Change-Id: Ie1c92ff5f65b019d3f1306917cd924036eea7909
|
|
Change-Id: If6e0cbf8544ca7a4668cdc67fcf390d8835b7017
|
|
Change-Id: I08e99a019fd2ec16e2c995035e4bcc09678ef92b
|
|
to reduce code clutter like
pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos())
since this is a fairly frequent operation.
Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184
Reviewed-on: https://gerrit.libreoffice.org/14472
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1e61d3553795ed8e2b7bc6fa3d1c0f881e777b08
|
|
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157
Reviewed-on: https://gerrit.libreoffice.org/14292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...and assumed to be merely performance optimizations (so removing them should
hopefully not break any functionality).
Change-Id: I9f40118f5a4bd1526e0cfbf74715455d543bfd54
|
|
Change-Id: I32479fd238e720b9ba0fa0af55e8377ebd972a20
|
|
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
|
|
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
|
|
...in some places where it is obvious that it does not hurt that for an empty
vector the obtained pointer is not necessarily a nullptr.
Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
and dump the ones that nothing is listening to
Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
|
|
and drop DATACHANGED_DATETIME because no-one is using it
Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
|
|
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
This reverts commit 66c7dbbf7dfba8cfab63f8d1df72ace87e5bf7ca.
See https://gerrit.libreoffice.org/#/c/13554/ .
Conflicts:
include/xmloff/shapeexport.hxx
reportdesign/source/filter/xml/xmlExport.cxx
sc/source/filter/xml/xmlexprt.cxx
xmloff/source/draw/shapeexport.cxx
Change-Id: I14fed9ad043a756a9e2d390c76fa907c349c3a2e
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f
Reviewed-on: https://gerrit.libreoffice.org/13733
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
|
|
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
|
|
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
|
|
Change-Id: Idaa8f07c62b3ba93c27ca5fe286720254baac10d
|
|
Change-Id: Ia8c5913c60e3d509a906965d813c8d1380396dc6
|
|
This helps de-clutter action button groups and eases visual scanning.
This patch also contains little layout tweaks where needed to separate
the Help button from its neighbors when the dialog is too small.
Change-Id: I56aafdaf2a5351bd7bcb4db693e520fd5c5166ce
Reviewed-on: https://gerrit.libreoffice.org/13427
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599
Reviewed-on: https://gerrit.libreoffice.org/13719
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
|
|
...at least when we can easily not assume it.
shapes = shapes of the same XShapes
an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1
We replace the ZOrder property by the index of the XShape in the
XShapes (the same XShapes that is passed to seekShapes()... when that
is easy to find. Else, use ZOrder and hope for the best.
ZOrders are not always an enumeration. For example, in documents
(forms) created by the Base forms wizard, it is not the case.
The wrong assumptions was leading to the following bugs in the Base
form wizard:
- Only the first two controls in the form were successfully saved. The
others were just dropped.
- Whereas the labels had the proper style (background and text
colour) applied while creating the document, these were not saved
successfully
Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
|
|
This addresses some cppcheck warnings.
Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018
Reviewed-on: https://gerrit.libreoffice.org/13540
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ia9cfa61c05b4014a504a419ea0367b5ffd5668ce
|
|
Change-Id: Id1d5c3cf2f76dbb33606cec1c0f17d4a1f282247
|
|
Change-Id: If082f723383da72eac75ca660203aea2a33a7526
|