summaryrefslogtreecommitdiff
path: root/ridljar/com
AgeCommit message (Collapse)Author
2023-11-09enable unchecked lint for our java codeNoel Grandin
and annotate where necessary, mostly just suppressing the warnings Change-Id: I8e39d797cde6c7c3f4e3e1bd93a128965ecec81d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159205 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02'new Character' is deprecated in JavaNoel Grandin
replace with Character.valueOf Change-Id: I9938db0fce6490eba6f4900efc3c139a1b71d120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158786 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02'new Double' is deprecated in JavaNoel Grandin
replace with Double.valueOf Change-Id: If5be8e500e31ebf9d5fb20ea7dd474677d7c74ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02'new Float' is deprecated in JavaNoel Grandin
replace with Float.valueOf Change-Id: Ib6408b24dac2953789d0ec67e73b8be8aefca252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-02drop use of urp: followed by newline of spaceCaolán McNamara
and just use space Change-Id: Ib2765855971691aa72643d3e3d5c06cdcbd634ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-30cid#1545655 Dm: Dubious method usedCaolán McNamara
Change-Id: I76b447d51429c867e24c1bcdd357689c849ea103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157438 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-30cid#1545766 silence Unguarded readCaolán McNamara
a bit zealous here, its all on the same thread as it turns out Change-Id: Ic2e8d8eba4fea672fa56c88abedb853fd886cecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-29cid#1546393 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: I697830e97b3168aab3e41e96b744ab80edbad31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-05call WebSocketClient.close from XConnection.closeCaolán McNamara
to drop the connection, otherwise we stick around until we timeout after trying to exit Change-Id: Ia4ca95b022b9234219da4658512603ebf918ff35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-05websocket URP flush hangs with large bufferCaolán McNamara
over 4k hits limit so flush waits until something reads, but the read is in the same thread after the flush. We are just using _outputStream to accumulate the bytes to be send so change this to use a ByteArrayOutputStream and take over its bytes and clear it when we flush. Change-Id: I17b90e1c7d4302f153b5832e60ac0e0f2b86ace9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156565 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-03each websocket URP message is taking a full secondCaolán McNamara
because the data written here doesn't appear to the reader on the other end until a full second expires. https: //bugs.openjdk.org/browse/JDK-8014239 Change-Id: I9b6f4d51562f4dd0866ff0fccd5951b1efe38f25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-01prefix the UNO-Url example with recommended 'uno:'Caolán McNamara
as http://www.openoffice.org/udk/common/man/spec/uno-url.html suggests. Change-Id: Ifce9a9944f1a25bc0b6f89e5cec127a22bc6f990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156399 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-01Fix typoAndrea Gelmini
Change-Id: I63b019aa12eb4898374162b0226728fd49bef93c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156427 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-01Add a FunctionBasedURPConnection and a websocket URP connectorSkyler Grey
- FunctionBasedURPConnection is used to enable a client to open a URP connection to a fresh Kit instance in COOL. - This URP connector can be used with that and https://github.com/CollaboraOnline/online/pull/6992 to use a Java Uno Remote Protocol client over websockets - For interoperability with existing Collabora Online websockets a prefix (urp ) is added to each message sent and a similar prefix (urp: ) is expected on each message recieved. This allows sending over the same websocket as other data is being transmitted through. If you are writing a bridge to work with this, you will need to add/strip the prefixes accordingly - This commit uses Java WebSocket (https://github.com/TooTallNate/Java-WebSocket) to send data over websockets. Change-Id: I2bda3d0b988bef7883f9b6829eeb5b7ae8075f27 Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-01tdf#149069 Revert "ridljar: check UnoClassLoader used for NativeLibraryLoader"Hossein
This reverts commit 97b61ea3297e04e64aab1e1a4ec50202e9f86fff. It checked that the NativeLibraryLoader is an instance of the class com.sun.star.lib.unoloader.UnoClassLoader. If this is not the case, a warning was displayed. This was for java_uno bridge to work. On the other hand, as the comment in the code implies, "not a problem if this is using Java remote bridge or (in a) unit test". But, in the code there was no check for that. As a result, this warning is displayed in many places like the simple examples that want to connect to the LibreOffice process via Java API. Change-Id: I056ed372ad071573051024a63e51afd6b4425ce5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156302 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-02-28InputStreamToXInputStreamAdapter.readBytes() should read...Damjan Jovanovic
until the buffer is full, or the file ends. It shouldn't care about available(). (cherry-picked from f04910427d25ede98b84b90df7cc5a12d1adc695) Change-Id: I4ad17c614ba336ff21883248715861f6af1fbc2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147934 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-02-28Fix the java.lang.NullPointerException in readBytes() and readSomeBytes()...Damjan Jovanovic
methods in InputStreamToXInputStreamAdapter when called from the inter-process UNO bridge. XInputStream::readBytes() documents how the buffer is an "out" parameter, and isn't passed to the implementing end, which is why we get the buffer as a "byte[][] b" and b[0] == null. Its role is to box a byte[] array to be returned the client. Thus, allocate the buffer if it is missing or too small. Additionally, virtually all other readBytes() and readSomeBytes() implementations trim this sequence to the actual number of bytes read. This presumably reduces the inter-process traffic, but some callers even rely on the sequence to be trimmed, eg. main/sax/source/expatwrap/xml2utf.cxx. Thus trim our returned array too. (cherry-picked from 6cb06142790376a2c58e6392182eb071420a4221) Change-Id: I42eb209b68f7c13a34670d03c2ca61d76672385b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147933 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-02-28fix up misleading mismatching indent and add mode linesCaolán McNamara
Change-Id: Id0abfc6d2962223bd0f7f0864a53e94bb7ec5052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-13warning: empty <p> tagCaolán McNamara
Change-Id: I6fb9dd331fe6ff9e35477a122a84ab0a6d3d8426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19ridljar: check that UnoClassLoader is used for NativeLibraryLoaderMichael Stahl
The native libraries are local to class loaders, so System.load("java_uno.so") will fail with any other class loader. Change-Id: Ifa3b1b8dfef07b64828943654e28ff1f0fb5a494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120527 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2020-09-25socket cannot be null at this pointNoel Grandin
Change-Id: I2027478d1dfa64a3841027d94d8eaa140fe319dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I4733e6609ee99bef49c2771c83b450ee89d955b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101804 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typosAndrea Gelmini
Change-Id: I8dc0cdcfe6bd90efc596df28e6c6d968b92618b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101098 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-05-06Move all public Java classes to libreoffice.jarSamuel Mehrbrodt
This moves the classes from juh.jar and ridl.jar to libreoffice.jar The goal is to have one single jar (and Java module, will be added later) which developers can include to work with LO. juh.jar and ridl.jar are kept as basically empty jars with libreoffice.jar on its classpath to keep backwards compatibility. This is a continuation of ae855bf48163ff64d94cfc34aff8e37abdb5518d and a preparation to have Java 9 module support. Change-Id: Ifbbfb97f60373d14256e62ae3122913bd17d5bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-10Cleanup: Move files to ridljarSamuel Mehrbrodt
These files are now part of ridl.jar instead of jurt.jar, so move them accordingly. Follow-up cleanup for ae855bf48163ff64d94cfc34aff8e37abdb5518d Change-Id: I01df60d99f5296b6252b260f52160c3e62f4b8dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88007 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ia40e7a9031ae5a8385a84f177a9444f4d4f348b4 Reviewed-on: https://gerrit.libreoffice.org/77302 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-26Fix typosAndrea Gelmini
Change-Id: I60261b937215340d2eb6f439234e99a300b0e189 Reviewed-on: https://gerrit.libreoffice.org/76380 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-05-27@deprecated should be with @DeprecatedTomoyuki Kubota
Without this patch, warnings will be given when LibreOffice is built with JDK9 or later. Change-Id: I7aa6e99ace2377fbdb7dd732949ce10d9bd9df58 Reviewed-on: https://gerrit.libreoffice.org/72947 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-08Fix typoAndrea Gelmini
Change-Id: I1cc4544e807d7c04aa171358ccd1c204040dff55 Reviewed-on: https://gerrit.libreoffice.org/57078 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-26Fix typosAndrea Gelmini
Change-Id: I334f0bd5636940ea8105dcf93b95b3af28894aad Reviewed-on: https://gerrit.libreoffice.org/48546 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-25i#32546# - Java UnoRuntime.getUniqueKey/generateOid do not work reliablyDamjan Jovanovic
In the Java UNO bridge, UnoRuntime.generateOid() generated the object-specific part of the OID using java.lang.Object.hashCode(), which is only 32 bits long, and is commonly overriden and could thus return values from an even smaller range, so OID collisions were quite likely. This changes UnoRuntime.generateOid() to use 128 bit UUIDs for the object-specific part of the OID, and store these in an object => oid java.util.WeakHashMap, making OID collisions almost impossible. Patch by: me Suggested by: Stephan Bergmann (stephan dot bergmann dot secondary at googlemail dot com) (cherry picked from commit 6dd83d1c6c5c580d14ca3d0458be4020603ba118) Change-Id: I8e851a7a69ac2defefa15e9a00118d8f9fc0da95 Reviewed-on: https://gerrit.libreoffice.org/41576 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03TyposJulien Nabet
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52 Reviewed-on: https://gerrit.libreoffice.org/33900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-06-07error: unknown tag: internalStephan Bergmann
Change-Id: Ie96b4ed27060498a39bb5fb1ea7a4cb3e17408ff
2016-06-07[API CHANGE] Drop deprecated I*Description interfacesNoel Grandin
And make the fields of com.sun.star.uno.Type private Change-Id: Ied7698b4157460e9726f271092c92b6b382239fd Reviewed-on: https://gerrit.libreoffice.org/25971 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-13Related tdf#99272: Prevent bogus com.sun.star.uno.Type(Short[].class) etc.Stephan Bergmann
...so that the JNI UNO bridge will not accidentally reinterpret a Short[] as a short[]. <https://wiki.openoffice.org/wiki/Uno/Java/Specifications/Type_Mapping> makes it clear that the former is not a valid Java representation for UNO type "sequence of short". Needed one fix in bogus test code. Also fixed the two bogus places in odk/examples mentioned in f53e427291321eabe8d060a737e750a94739f911 "Resolves: tdf#99272 new Short[] used instead of new short[]". Change-Id: I8321eb1294ec77b3a9bf73cafb6e7fe337157bb7
2016-02-17ridljar: fix javadoc warningsMichael Stahl
Change-Id: Ifa85299dd3366fb9a9639e669a02678ea9268260
2015-10-20coverity#1326356 presumably a deliberate fall throughCaolán McNamara
Change-Id: I6338746911e279f934a0cb7113de81d7a02c6cb1
2015-10-15[API CHANGE] Remove deprecated com.sun.star.uno.Union classStephan Bergmann
...which had never been useful for anything, as UNOIDL does not have a union concept. In light of coverity#1327215 "UwF: Unwritten field," seems cleaner to just remove that class completely than to silence that somewhat bogus (as the class is non-final, so derivations could actually set m_value) Coverity warning. Change-Id: Iaef9003a84e2c2f73adb2744bd759460cb149f68
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18java: rather use @Deprecated annotationNoel Grandin
than an empty @deprecated tag Change-Id: I1646ce1c0c8823ac5be0153aeb8eb2b830e7ebfa Reviewed-on: https://gerrit.libreoffice.org/12525 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-19java: use 'Byte.valueOf' instead of 'new Byte'Noel Grandin
Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90
2014-08-19java: use 'Short.valueOf' instead of 'new Short'Noel Grandin
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19java: use 'Long.valueOf' instead of 'new Long'Noel Grandin
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
generated by cgit (git 2.34.1) at 2025-01-13 09:35:07 +0000