summaryrefslogtreecommitdiff
path: root/rsc/source
AgeCommit message (Collapse)Author
2016-04-05loplugin:constantparamNoel Grandin
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-23-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I7c0f1e37f3a53dfed09c4e13d10826022b3ca777
2016-03-23loplugin:constantparam in rscNoel Grandin
Change-Id: I54f80c9c759eec4b73d1fd194e3efc8156bd3e2d
2016-03-13Revert "tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals"Norbert Thiebaud
This reverts commit 0c3ff8ca07265304f9ea0a7aca8c83703cff01a1. that was breaking debug and dbgutil build on windows (at least) Change-Id: Ide58bd4551029bb4e1ef791bb65ad191fbb25cae
2016-03-12WaE: loplugin:stringconcatCaolán McNamara
Change-Id: I28a106e978cdfd70847737784f9bff6ae365fda7
2016-03-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 conditionals and in some places i used SAL_INFO(..)s Change-Id: I87e2e4d73be22630dbcce6df2650b924cba9f8ec Reviewed-on: https://gerrit.libreoffice.org/23005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-04-Werror,-Wunused-macrosStephan Bergmann
Appears to no (longer?) be relevant here, as reported by clang-cl. Change-Id: I339f8b04eb733a9c6a97fcd4b9b4758e6a84d5c3
2016-03-02loplugin:unuseddefaultparam in rscNoel Grandin
Change-Id: Ib4cbc48295e7c16683765d1c1420fcf73235517d
2016-03-01sal_uIntPtr/sal_uLong to Index (aka sal_uInt32) in UniqueIndexMatteo Casalin
Change-Id: I212cb3bb9d920741629fc4564bbd28b393e8fe00
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02Compiler warning battleStephan Bergmann
...where 05642b446c39c1551d2d703be18158c7ae0f0c36 "-Werror,-Wconstant-conversion (from 255 to -1)" caused MSVC to counter with "warning C4310: cast truncates constant value" Change-Id: I7d80825a01e49817d7989e00774fed1f162dea85
2016-02-02-Werror,-Wconstant-conversion (from 255 to -1)Stephan Bergmann
Change-Id: I9cce09bf729398a475d9d07fdfa002f325611546
2016-01-30ditch loading of SplitWindows from resource filesCaolán McNamara
Change-Id: Ic56aa8d3dcafc24e1a1a1d494d20b0d23b41677d
2016-01-15loplugin:unusedmethods unused return value in rscNoel Grandin
Change-Id: I6301aed80083c21e26851817220de6e135eb4da7
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-11new loplugin: memoryvarNoel Grandin
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I8df6c1c7d2312a4864750180561a3e63fe37003f
2015-10-26-Werror,-WformatStephan Bergmann
Change-Id: I9668268f15fbcd4af7432d4d0d403b74263fbb18
2015-10-26remove extra spaces around ::Noel Grandin
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-24cppcheck: invalidPrintfArgType_sintCaolán McNamara
Change-Id: I4103c8e1549db44055fbfcb8ced6ec36d27fc126
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: I80c422a961170f25d2a674bb347b9d330b6c7fc0
2015-10-12cppcheck:variableScopeNoel Grandin
Change-Id: I037feb335499629300309851dcda3bb661f03d4f Reviewed-on: https://gerrit.libreoffice.org/19316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01loplugin:unusedmethodsNoel Grandin
- improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini
Change-Id: I8f4500fc7a901c5cc73634ba6da6b9541452e5ae Reviewed-on: https://gerrit.libreoffice.org/18966 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-23convert Link<> to typedNoel Grandin
Change-Id: I80bd798ea5d36fa94d6b3348be713dbe2cbeab14 Reviewed-on: https://gerrit.libreoffice.org/18803 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-18Use a C99 flexible array memberStephan Bergmann
...so the following strcpy does not cause a false abort under _FORTIFY_SOURCE=2 Change-Id: I395136f11020064766db76f87ed8f5b01c083c3a Reviewed-on: https://gerrit.libreoffice.org/18681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-08loplugin:mergeclass, merge BiNode with NameNode, Obj0Type with ObjkTypeNoel Grandin
Change-Id: Icbc0dfc6096a6e2c651dad4fe9f78d176f389390
2015-09-05cppcheck: fix some redundantCondition warningsJulien Nabet
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2 Reviewed-on: https://gerrit.libreoffice.org/18353 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-08-28tdf#39468: Translate German comments in core/rsc/sourceLucas Satabin
Change-Id: Ia2d94a88d217a3b0ec9c78096b8d74a38216fbc9 Reviewed-on: https://gerrit.libreoffice.org/18066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-05loplugin:unusedmethodsNoel Grandin
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24convert WindowAlign to scoped enumNoel Grandin
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-09cppcheck: variableScopeCaolán McNamara
Change-Id: If0c56c89e2722d47a401363f3854331229856490
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I27516cc532e46b6e43a2f2f292246f1414e9f9b3
2015-06-02-fsanitize=nonnull-attribute in memcpy callStephan Bergmann
Change-Id: I4fc491906311781b9941c8f02d99d254542027ae
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: Ie100fc1048b076f94e7ef33b632df4264d37cf51
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann
Change-Id: I1e62523e08e6f1e7ec926b1a5e7c45d7c688f781
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann
...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
2015-04-29cppcheck: invalidPrintfArgType_uintCaolán McNamara
Change-Id: I5a0b5a4ff60c508f8ea11d613022ee7799900098
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-20rsc crash on WIN64 due to LP64Norbert Thiebaud
rsc stash stuff in a 'value' filed that was defined as 'long' saddly it stash also pointer there... which on WIN64 truncate 64 bits pointers in 32 bits scalar. That went unnoticed for years because on every other platform sizeof(long) = sizeof(void*) Change-Id: I218ae181c9d6b64ade457ee49942d1d07a933bb7 Reviewed-on: https://gerrit.libreoffice.org/15394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: I5be4952b732eab9a32aeaee7eb45a68698be4ad2
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I85d6761e72ba2f67a1d67a94cae674cbb271b43f
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I9f8a64433177ba871fa020c0922a539c3e277bc2
2015-03-26tdf#39440 cppcheck cleanliness, Fixing basic cpp errorsVarun
Initialized a non-initialized integer variable which is widely used in if else Change-Id: Ibd99c0baa4cd3d4d409310a9a70dc7b421f6a8b2 Reviewed-on: https://gerrit.libreoffice.org/14780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>