summaryrefslogtreecommitdiff
path: root/rsc
AgeCommit message (Collapse)Author
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-09convert SFX_SLOT_INFO to scoped enumNoel Grandin
Change-Id: Ib640fc2cfce23bf8ce92ec1549034078123c06aa Reviewed-on: https://gerrit.libreoffice.org/24752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert SFX_STYLE_ITEM to scoped enumNoel Grandin
Change-Id: I929603a12c29931074a467d1472ef686c1d4e8ee Reviewed-on: https://gerrit.libreoffice.org/24751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-01rsc - remove obsolete FILE_LOCAL macros.erdemdemirkapi
Change-Id: I92c19459646eaceffe87ef0f002c988595f221c5 Reviewed-on: https://gerrit.libreoffice.org/24549 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-30tdf#99587 - make rsc work in tr_TR.UTF-8 locale.Michael Meeks
toupper / tolower problematic with exciting Turkish 'i's, bug introduced: |* Ersterstellung MM 13.02.91 Change-Id: Ifa5cfa7cf28cc3948b9206cda426eb1409dd7cc7 Reviewed-on: https://gerrit.libreoffice.org/24519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-30Fix typosAndrea Gelmini
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26loplugin:nullptrStephan Bergmann
Change-Id: I699ce2c97d7874eac78b3afcd08ba011f56156bd
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I0a21a23a2f8b9e87f53283c88973109dd54af1b4
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-05loplugin:constantparamNoel Grandin
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-23-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I7c0f1e37f3a53dfed09c4e13d10826022b3ca777
2016-03-23loplugin:constantparam in rscNoel Grandin
Change-Id: I54f80c9c759eec4b73d1fd194e3efc8156bd3e2d
2016-03-13Revert "tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals"Norbert Thiebaud
This reverts commit 0c3ff8ca07265304f9ea0a7aca8c83703cff01a1. that was breaking debug and dbgutil build on windows (at least) Change-Id: Ide58bd4551029bb4e1ef791bb65ad191fbb25cae
2016-03-12WaE: loplugin:stringconcatCaolán McNamara
Change-Id: I28a106e978cdfd70847737784f9bff6ae365fda7
2016-03-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 conditionals and in some places i used SAL_INFO(..)s Change-Id: I87e2e4d73be22630dbcce6df2650b924cba9f8ec Reviewed-on: https://gerrit.libreoffice.org/23005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-04-Werror,-Wunused-macrosStephan Bergmann
Appears to no (longer?) be relevant here, as reported by clang-cl. Change-Id: I339f8b04eb733a9c6a97fcd4b9b4758e6a84d5c3
2016-03-02loplugin:unuseddefaultparam in rscNoel Grandin
Change-Id: Ib4cbc48295e7c16683765d1c1420fcf73235517d
2016-03-01sal_uIntPtr/sal_uLong to Index (aka sal_uInt32) in UniqueIndexMatteo Casalin
Change-Id: I212cb3bb9d920741629fc4564bbd28b393e8fe00
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-02Compiler warning battleStephan Bergmann
...where 05642b446c39c1551d2d703be18158c7ae0f0c36 "-Werror,-Wconstant-conversion (from 255 to -1)" caused MSVC to counter with "warning C4310: cast truncates constant value" Change-Id: I7d80825a01e49817d7989e00774fed1f162dea85
2016-02-02-Werror,-Wconstant-conversion (from 255 to -1)Stephan Bergmann
Change-Id: I9cce09bf729398a475d9d07fdfa002f325611546
2016-01-30ditch loading of SplitWindows from resource filesCaolán McNamara
Change-Id: Ic56aa8d3dcafc24e1a1a1d494d20b0d23b41677d
2016-01-15loplugin:unusedmethods unused return value in rscNoel Grandin
Change-Id: I6301aed80083c21e26851817220de6e135eb4da7
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-25loplugin:unusedfields variousNoel Grandin
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
2015-11-11new loplugin: memoryvarNoel Grandin
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I8df6c1c7d2312a4864750180561a3e63fe37003f
2015-10-26-Werror,-WformatStephan Bergmann
Change-Id: I9668268f15fbcd4af7432d4d0d403b74263fbb18
2015-10-26remove extra spaces around ::Noel Grandin
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-24cppcheck: invalidPrintfArgType_sintCaolán McNamara
Change-Id: I4103c8e1549db44055fbfcb8ced6ec36d27fc126
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: I80c422a961170f25d2a674bb347b9d330b6c7fc0
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12cppcheck:variableScopeNoel Grandin
Change-Id: I037feb335499629300309851dcda3bb661f03d4f Reviewed-on: https://gerrit.libreoffice.org/19316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01loplugin:unusedmethodsNoel Grandin
- improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini
Change-Id: I8f4500fc7a901c5cc73634ba6da6b9541452e5ae Reviewed-on: https://gerrit.libreoffice.org/18966 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-23convert Link<> to typedNoel Grandin
Change-Id: I80bd798ea5d36fa94d6b3348be713dbe2cbeab14 Reviewed-on: https://gerrit.libreoffice.org/18803 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-18Use a C99 flexible array memberStephan Bergmann
...so the following strcpy does not cause a false abort under _FORTIFY_SOURCE=2 Change-Id: I395136f11020064766db76f87ed8f5b01c083c3a Reviewed-on: https://gerrit.libreoffice.org/18681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-08loplugin:mergeclass, merge BiNode with NameNode, Obj0Type with ObjkTypeNoel Grandin
Change-Id: Icbc0dfc6096a6e2c651dad4fe9f78d176f389390
2015-09-05cppcheck: fix some redundantCondition warningsJulien Nabet
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2 Reviewed-on: https://gerrit.libreoffice.org/18353 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-08-30tdf#39468: Translate German comments in core/rsc/incLucas Satabin
Change-Id: I5d878192bde816e59ef570731113b526e8098d85 Reviewed-on: https://gerrit.libreoffice.org/18065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-28tdf#39468: Translate German comments in core/rsc/sourceLucas Satabin
Change-Id: Ia2d94a88d217a3b0ec9c78096b8d74a38216fbc9 Reviewed-on: https://gerrit.libreoffice.org/18066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-05loplugin:unusedmethodsNoel Grandin
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04sal,rsc,oox: inline some use-once typedefsNoel Grandin
Change-Id: I91bebe06c5c5f3ebe5fbeec83dcf3f5bdf563201
2015-07-24convert WindowAlign to scoped enumNoel Grandin
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52