Age | Commit message (Collapse) | Author |
|
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
|
|
detect when we can convert a new/delete sequence on a local variable to
use std::unique_ptr
Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc
Reviewed-on: https://gerrit.libreoffice.org/19884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8df6c1c7d2312a4864750180561a3e63fe37003f
|
|
Change-Id: I9668268f15fbcd4af7432d4d0d403b74263fbb18
|
|
just makes it harder to grep for methods
Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
|
|
Change-Id: I4103c8e1549db44055fbfcb8ced6ec36d27fc126
|
|
Change-Id: I80c422a961170f25d2a674bb347b9d330b6c7fc0
|
|
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
|
|
Change-Id: I037feb335499629300309851dcda3bb661f03d4f
Reviewed-on: https://gerrit.libreoffice.org/19316
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8f4500fc7a901c5cc73634ba6da6b9541452e5ae
Reviewed-on: https://gerrit.libreoffice.org/18966
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
|
|
Change-Id: I80bd798ea5d36fa94d6b3348be713dbe2cbeab14
Reviewed-on: https://gerrit.libreoffice.org/18803
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...so the following strcpy does not cause a false abort under _FORTIFY_SOURCE=2
Change-Id: I395136f11020064766db76f87ed8f5b01c083c3a
Reviewed-on: https://gerrit.libreoffice.org/18681
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Icbc0dfc6096a6e2c651dad4fe9f78d176f389390
|
|
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2
Reviewed-on: https://gerrit.libreoffice.org/18353
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I5d878192bde816e59ef570731113b526e8098d85
Reviewed-on: https://gerrit.libreoffice.org/18065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: Ia2d94a88d217a3b0ec9c78096b8d74a38216fbc9
Reviewed-on: https://gerrit.libreoffice.org/18066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I91bebe06c5c5f3ebe5fbeec83dcf3f5bdf563201
|
|
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
|
|
make it consistent across the codebase, no space between keyword
and the colon
Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
|
|
Change-Id: If0c56c89e2722d47a401363f3854331229856490
|
|
Change-Id: I27516cc532e46b6e43a2f2f292246f1414e9f9b3
|
|
Change-Id: I4fc491906311781b9941c8f02d99d254542027ae
|
|
Change-Id: Ie100fc1048b076f94e7ef33b632df4264d37cf51
|
|
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
|
|
Change-Id: I1e62523e08e6f1e7ec926b1a5e7c45d7c688f781
|
|
Change-Id: I52755c373f86490ba3e8910e71e3fab88b1ca38c
|
|
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
|
|
Change-Id: I44e4abb228394f99109f7d7e005cfeb26e4b95c1
|
|
...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline
Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
|
|
Change-Id: I5a0b5a4ff60c508f8ea11d613022ee7799900098
|
|
Change-Id: I86cec7670db8594a7563e86c6645c480d3f8702c
|
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
|
|
rsc stash stuff in a 'value' filed that was defined as 'long'
saddly it stash also pointer there... which on WIN64 truncate 64 bits
pointers in 32 bits scalar.
That went unnoticed for years because on every other platform
sizeof(long) = sizeof(void*)
Change-Id: I218ae181c9d6b64ade457ee49942d1d07a933bb7
Reviewed-on: https://gerrit.libreoffice.org/15394
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I5be4952b732eab9a32aeaee7eb45a68698be4ad2
|
|
Change-Id: I85d6761e72ba2f67a1d67a94cae674cbb271b43f
|
|
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
|
|
Change-Id: I9f8a64433177ba871fa020c0922a539c3e277bc2
|
|
Initialized a non-initialized integer variable which is widely used in if else
Change-Id: Ibd99c0baa4cd3d4d409310a9a70dc7b421f6a8b2
Reviewed-on: https://gerrit.libreoffice.org/14780
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I574bac6b25c9f36ff3d545420ea49d99a9c79b05
|
|
(better than making it implicitly declared, as defining it defaulted is
deprecated for that case because of the user-declared copy assignment op)
Change-Id: I0c2c4c063e19e3a15b06e75d0c080911acf26ca3
|
|
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
|
|
Change-Id: I90d7788208fb86c8aea36c4944ca11d881f11720
|
|
Change-Id: Ic8b41ec4bb6b46177b02f533b936ab678207f926
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|