summaryrefslogtreecommitdiff
path: root/rsc
AgeCommit message (Collapse)Author
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I85d6761e72ba2f67a1d67a94cae674cbb271b43f
2015-03-27loplugin:staticfunctionNoel Grandin
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I9f8a64433177ba871fa020c0922a539c3e277bc2
2015-03-26tdf#39440 cppcheck cleanliness, Fixing basic cpp errorsVarun
Initialized a non-initialized integer variable which is widely used in if else Change-Id: Ibd99c0baa4cd3d4d409310a9a70dc7b421f6a8b2 Reviewed-on: https://gerrit.libreoffice.org/14780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-24loplugin:constantfunction: rscNoel Grandin
Change-Id: I574bac6b25c9f36ff3d545420ea49d99a9c79b05
2015-03-05Explicitly default the copy ctorStephan Bergmann
(better than making it implicitly declared, as defining it defaulted is deprecated for that case because of the user-declared copy assignment op) Change-Id: I0c2c4c063e19e3a15b06e75d0c080911acf26ca3
2015-03-02V805: Decreased performanceCaolán McNamara
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
2015-03-02remove executable bit from c / h / cxx / hxx / l filesMichael Stahl
Change-Id: I90d7788208fb86c8aea36c4944ca11d881f11720
2015-03-01wrong length value for string lengthMarkus Mohrhard
Change-Id: Ic8b41ec4bb6b46177b02f533b936ab678207f926
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-09Werror: data lost during conversion from size_t to intDavid Ostrovsky
Change-Id: Iee080b89cf0588c8076ef4c0334d36a7aefce44d Reviewed-on: https://gerrit.libreoffice.org/14374 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-26coverity#1266502 Useless callCaolán McNamara
Change-Id: I443cc28b81508b32c49ba795583ed304729d3fa0
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: rscStephan Bergmann
Change-Id: If62d142481cb3520042a040325bdd9167ae178e7
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-06fdo#84938: replace BUTTONTYPE_ constants with 'enum class'Noel Grandin
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-31various other apparently unnecessary rsc stuffCaolán McNamara
Change-Id: I745695a92023e7a14ee547ca6bef5981dd329d19
2014-12-31drop dateformatter resource loadingCaolán McNamara
Change-Id: Ie94c7502b0a82ca406b8d76e18def7bab8233a00
2014-12-31drop timeformatter resource loadingCaolán McNamara
Change-Id: I11de468ab65aa4dec761fbcc1e9416528c332dd5
2014-12-31TimeFields not loaded from resource files anymoreCaolán McNamara
Change-Id: Idf69d375eff4bfff7115e59530b37200ee79f086
2014-12-28splitters no longer loaded from resource filesCaolán McNamara
Change-Id: I84ee0c754118882734301bf1d34c15ba640a3889
2014-12-22HelpButtons no longer loaded from .rsc filesCaolán McNamara
Change-Id: I0fe82e319ac44a189e93fabd932e3e0a891598d2
2014-12-19fdo#39440 rsc: reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I69454a75c8ce4aecf9e68f5887f38f8bf6fe6dca Reviewed-on: https://gerrit.libreoffice.org/13543 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-21document coverity#983096 Resource leakCaolán McNamara
Change-Id: If5a60dac2329432b30a7b5528e0fca05d4369b1a
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-03coverity#982297 EBCDIC-related cleanupCaolán McNamara
Change-Id: I8da7911c342ffe114d7b25b996602aabed7aa1ed
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28sal_Int16 as the underlying type of WindowBorderStyleTakeshi Abe
because g++ 4.7.2 generates [-Werror=type-limits] as follows: > [build CXX] vcl/source/window/settings.cxx > [build CXX] vcl/source/window/paint.cxx > [build CXX] vcl/source/window/resource.cxx > [build CXX] vcl/source/window/accel.cxx > [build CXX] vcl/source/window/accmgr.cxx > [build CXX] vcl/source/window/brdwin.cxx > [build CXX] vcl/source/window/accessibility.cxx > [build CXX] vcl/source/window/legacyaccessibility.cxx > [build CXX] vcl/source/window/clipping.cxx > [build CXX] vcl/source/window/stacking.cxx > [build CXX] vcl/source/window/debug.cxx > [build CXX] vcl/source/window/globalization.cxx > [build CXX] vcl/source/window/btndlg.cxx > [build CXX] vcl/source/window/builder.cxx > [build CXX] vcl/source/window/cmdevt.cxx > [build CXX] vcl/source/window/cursor.cxx > [build CXX] vcl/source/window/debugevent.cxx > [build CXX] vcl/source/window/decoview.cxx > In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0, > from /home/tabe/core/include/vcl/keycodes.hxx:23, > from /home/tabe/core/include/vcl/keycod.hxx:26, > from /home/tabe/core/vcl/inc/svdata.hxx:35, > from /home/tabe/core/vcl/source/window/brdwin.cxx:21: > /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]': > /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here > /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > cc1plus: all warnings being treated as errors > make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [vcl.all] Error 2 > tabe@thunk:~/build$ Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13coverity#982170 Unchecked return value from libraryCaolán McNamara
hopefully rsc is on the way out Change-Id: I270de6c4433560dbed0185e462237c3aa95a98a3
2014-10-06warning C4101: unreferenced local variableStephan Bergmann
Change-Id: I526e68b93f9665db25a824cc44ff231bcef29277
2014-10-04we really do not care about ebcdic do we ?Norbert Thiebaud
Change-Id: I1a2d8628fc2b1fe21e77019f12dc2a8adab877ed
2014-10-04coverity#706152 Copy into fixed size bufferNorbert Thiebaud
Change-Id: Ib347f650d060e7762a367133a1218c2d34c9ce73
2014-10-04cosmetic: start bringing rscpp in this century c-wiseNorbert Thiebaud
Change-Id: I469bc4c518c3ac299a18559cdd3e1b49d34b5ace
2014-10-02remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macroMichael Stahl
This has been supported by GCC and clang for a very long time. Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: I20eb45dda584c1c3a2e5d72425e49627fb7c3866
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-19warning C4701: potentially uninitialized local variableStephan Bergmann
Change-Id: I163033dc6f1fa17a96cb9da18f73ef8cdd367f00
2014-09-19cid#983095 Resource leakNoel Grandin
Change-Id: I2792afbfedbb256e0b79236505176f932ab25ce7
2014-09-19rsc: remove more DEC remnantsNoel Grandin
Change-Id: I6b084d6b08ff2e7bd9adfba4c9eda7c8c650305c