Age | Commit message (Collapse) | Author |
|
Change-Id: I85d6761e72ba2f67a1d67a94cae674cbb271b43f
|
|
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
|
|
Change-Id: I9f8a64433177ba871fa020c0922a539c3e277bc2
|
|
Initialized a non-initialized integer variable which is widely used in if else
Change-Id: Ibd99c0baa4cd3d4d409310a9a70dc7b421f6a8b2
Reviewed-on: https://gerrit.libreoffice.org/14780
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I574bac6b25c9f36ff3d545420ea49d99a9c79b05
|
|
(better than making it implicitly declared, as defining it defaulted is
deprecated for that case because of the user-declared copy assignment op)
Change-Id: I0c2c4c063e19e3a15b06e75d0c080911acf26ca3
|
|
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
|
|
Change-Id: I90d7788208fb86c8aea36c4944ca11d881f11720
|
|
Change-Id: Ic8b41ec4bb6b46177b02f533b936ab678207f926
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: Iee080b89cf0588c8076ef4c0334d36a7aefce44d
Reviewed-on: https://gerrit.libreoffice.org/14374
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I443cc28b81508b32c49ba795583ed304729d3fa0
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
Change-Id: If62d142481cb3520042a040325bdd9167ae178e7
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
|
|
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
|
|
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
|
|
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
|
|
Change-Id: I745695a92023e7a14ee547ca6bef5981dd329d19
|
|
Change-Id: Ie94c7502b0a82ca406b8d76e18def7bab8233a00
|
|
Change-Id: I11de468ab65aa4dec761fbcc1e9416528c332dd5
|
|
Change-Id: Idf69d375eff4bfff7115e59530b37200ee79f086
|
|
Change-Id: I84ee0c754118882734301bf1d34c15ba640a3889
|
|
Change-Id: I0fe82e319ac44a189e93fabd932e3e0a891598d2
|
|
This addresses some cppcheck warnings.
Change-Id: I69454a75c8ce4aecf9e68f5887f38f8bf6fe6dca
Reviewed-on: https://gerrit.libreoffice.org/13543
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If5a60dac2329432b30a7b5528e0fca05d4369b1a
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6
Reviewed-on: https://gerrit.libreoffice.org/12258
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8da7911c342ffe114d7b25b996602aabed7aa1ed
|
|
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a
Reviewed-on: https://gerrit.libreoffice.org/12179
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
because g++ 4.7.2 generates [-Werror=type-limits] as follows:
> [build CXX] vcl/source/window/settings.cxx
> [build CXX] vcl/source/window/paint.cxx
> [build CXX] vcl/source/window/resource.cxx
> [build CXX] vcl/source/window/accel.cxx
> [build CXX] vcl/source/window/accmgr.cxx
> [build CXX] vcl/source/window/brdwin.cxx
> [build CXX] vcl/source/window/accessibility.cxx
> [build CXX] vcl/source/window/legacyaccessibility.cxx
> [build CXX] vcl/source/window/clipping.cxx
> [build CXX] vcl/source/window/stacking.cxx
> [build CXX] vcl/source/window/debug.cxx
> [build CXX] vcl/source/window/globalization.cxx
> [build CXX] vcl/source/window/btndlg.cxx
> [build CXX] vcl/source/window/builder.cxx
> [build CXX] vcl/source/window/cmdevt.cxx
> [build CXX] vcl/source/window/cursor.cxx
> [build CXX] vcl/source/window/debugevent.cxx
> [build CXX] vcl/source/window/decoview.cxx
> In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0,
> from /home/tabe/core/include/vcl/keycodes.hxx:23,
> from /home/tabe/core/include/vcl/keycod.hxx:26,
> from /home/tabe/core/vcl/inc/svdata.hxx:35,
> from /home/tabe/core/vcl/source/window/brdwin.cxx:21:
> /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]':
> /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here
> /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> cc1plus: all warnings being treated as errors
> make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [vcl.all] Error 2
> tabe@thunk:~/build$
Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c
Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
|
|
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e
Reviewed-on: https://gerrit.libreoffice.org/12114
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328
Reviewed-on: https://gerrit.libreoffice.org/12104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
|
|
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
|
|
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51
Reviewed-on: https://gerrit.libreoffice.org/11983
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
hopefully rsc is on the way out
Change-Id: I270de6c4433560dbed0185e462237c3aa95a98a3
|
|
Change-Id: I526e68b93f9665db25a824cc44ff231bcef29277
|
|
Change-Id: I1a2d8628fc2b1fe21e77019f12dc2a8adab877ed
|
|
Change-Id: Ib347f650d060e7762a367133a1218c2d34c9ce73
|
|
Change-Id: I469bc4c518c3ac299a18559cdd3e1b49d34b5ace
|
|
This has been supported by GCC and clang for a very long time.
Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
|
|
Change-Id: I20eb45dda584c1c3a2e5d72425e49627fb7c3866
|
|
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
|
|
Change-Id: I163033dc6f1fa17a96cb9da18f73ef8cdd367f00
|
|
Change-Id: I2792afbfedbb256e0b79236505176f932ab25ce7
|
|
Change-Id: I6b084d6b08ff2e7bd9adfba4c9eda7c8c650305c
|