summaryrefslogtreecommitdiff
path: root/sal/Module_sal.mk
AgeCommit message (Collapse)Author
2021-03-03tdf#116983 tdf#136175: retry if failedMike Kaganski
Debugging the test case from the latter bug report shows that indeed the call to OleGetClipboard may fail first time, as jasonkres had suspected in the former bug. So follow the suggestion in tdf#116983, and retry the failing calls several times in case of failure. Many thanks to Telesto for preparing a clear bug report with reliable test case. Co-authored-by: jasonkres Change-Id: Ib3c497da830bc5faac586bcfe1eededa54bfa117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111825 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04Make many OUString functions take std::u16string_view parametersStephan Bergmann
...instead of having individual overloads for OUString, OUStringLiteral, and literal char16_t const[N]. (The variants taking OUString are still needed for !LIBO_INTERNAL_ONLY, though. The variants taking ASCII-only literal char const[N] are also left in place.) This nicely reduces the number of needed overloads. std::u16string_view allows to pass as arguments: * OUString * OUStringLiteral * OUStringChar (with the necessary conversion added now) * OUStringNumber * u"..." char16_t string literals * u"..."sv std::u16string_view literals * std::u16string, plain char16_t*, and more A notable exceptions is OUStringConcat, which now needs to be wrapped in OUString(...), see the handful of places that needed to be adapted. One caveat is the treatment of embedded NUL characters, as std::u16string_view(u"x\0y") constructs a view of size 1, while only u"x\0y"sv constructs a view of size 3 (which matches the old behavior of overloads for literal char16_t const[N] via the ConstCharArrayDetector<>::TypeUtf16 machinery). See the new checkEmbeddedNul in sal/qa/rtl/strings/test_oustring_stringliterals.cxx. The functions that have been changed are generally those that: * already take a string of determined length, so that using std::u16string_view, which is always constructed with a determined length, is no pessimization (e.g., there are operator == overloads taking plain pointers, which do not need to determine the string length upfront); * could not benefit from the fact that the passed-in argument is an OUString (e.g., the corresponding operator = overload can reuse the passed-in OUString's rtl_uString pData member); * do not run into overload resolution ambiguity issues, like the comparison operators would do. One inconsistency that showed up is that while the original replaceAll(OUString const &, OUString const &, sal_Int32 fromIndex = 0) overload takes an optional third fromIndex argument, the existing replaceAll overloads taking OUStringLiteral and literal char16_t const[N] arguments did not. Fixing that required a new (LIBO_INTERNAL_ONLY) rtl_uString_newReplaceAllFromIndexUtf16LUtf16L (with test code in sal/qa/rtl/strings/test_strings_replace.cxx). Another issue was posed by test code in sal/qa/rtl/strings/test_oustring_stringliterals.cxx that used the RTL_STRING_UNITTEST-only OUString(Except*CharArrayDetector) ctors to verify that certain function calls should not compile (and would compile under RTL_STRING_UNITTEST by taking those Except*CharArrayDetector converted to OUString as arguments). Those problematic "should fail to compile" tests have been converted into a new CompilerTest_sal_rtl_oustring. Change-Id: Id72e8c4cc338258cadad00ddc6ea5b9da2e1f780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23Reinstate CppunitTest_sal_rtlStephan Bergmann
...which had been dropped by 0f874472c672175135520101837ff0c9d4701d7f "size some stringbuffer to prevent re-alloc", presumably by accident Change-Id: I3b84e743c1adcdd8518114810dcee5c3f12c4290 Reviewed-on: https://gerrit.libreoffice.org/81388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21size some stringbuffer to prevent re-allocNoel Grandin
found by the simple expidient of putting asserts in the resize routine. Where an explicit const size is used, I started with 32 and kept doubling until that site did not need resizing anymore. Change-Id: I998787edc940d0a3ba23b5ac37131ab9ecd300f4 Reviewed-on: https://gerrit.libreoffice.org/81138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22tdf#39625 make sal/qa/systools/test_comtools.cxx work with CppUnitAndrés Maldonado
Change-Id: If467a13b03303656e51474b3ebd384db8782ed9b Reviewed-on: https://gerrit.libreoffice.org/68156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-30sal,external: remove checks for obsolete VCVER=120Michael Stahl
Change-Id: I4d32b7c4b2e545a8d979bc516f64cfcbf66ecd07
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2016-12-23tdf#97283: Merge sal rtl tests to one makefileMatúš Kukan
Change-Id: I1b78276e08feef9b6f49e5abe002391c50a8d2cc Reviewed-on: https://gerrit.libreoffice.org/32143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-12-23tdf#97283: Merge sal osl tests to one makefileMatúš Kukan
Leave sal_osl_security alone because it does not use CPPUNIT_PLUGIN_IMPLEMENT. Change-Id: Iced8bb80c3ae661d371c087d7178a373ffd802e0 Reviewed-on: https://gerrit.libreoffice.org/32142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-12-20bootstrap building with --disable-dynloading on standard linuxCaolán McNamara
Change-Id: I5baf70f0053612cba8b74f54aff11ce25cdeb95a Reviewed-on: https://gerrit.libreoffice.org/32202 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-19this textenc hack is for android and disable-dynamic-loadingCaolán McNamara
Change-Id: If2191161e82fc1e05b1442ae4b3b729cc1b8994d Reviewed-on: https://gerrit.libreoffice.org/32038 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-12[API CHANGE] Remove salcpprt static libraryStephan Bergmann
...containing replacements for global operator new/delete (that can be linked into executables), but which is no longer used. The mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2012-March/028690.html> "operator new no longer routes through rtl_AllocMemory in libsalcpprt under gbuild link rules" has the details of how this was used on some platforms (but not on others) before the switch to gbuild, and has been "lost" ever since---but apparently a loss not mourned much over the years. For the SDK, c5f974287fd04bb529de145113133b9e35687702 "INTEGRATION: CWS jsc3: #i62434# copy libsalcpprt.a" added the library (under Linux) and 6db9c5af960f9787e33e4addc56bddbb1695a402 "INTEGRATION: CWS jsc3: #i62434# extend link options for executbales to link libsalcpprt.a, LINUX only" added its use to odk/settings/settings.mk, but fc0ca57f2cd649c6330171445a06b80e2143a0e9 "INTEGRATION: CWS jsc21" removed that use again (for no documented reason). So this is an incompatible change, but unlikely to actually affect any users of the SDK. Change-Id: Ia38b4c439f21fca3f5d9af7d1a34054e992054e9 Reviewed-on: https://gerrit.libreoffice.org/31810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-10Add existing CppUnit test for sal/rtl/randomChristoph Brill
The tests itself already existed, we were just missing the .mk file Change-Id: I662eba5d955aa5cbd774dbb3b4c9f9010dc1d7d6 Reviewed-on: https://gerrit.libreoffice.org/22249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2015-11-06rtl::Reference Add move construction/assignmentDaniel Robertson
Add move constructor and appropriately overloaded assignment operator to rtl::Reference, and add basic unit tests for the reference counting of rtl::Reference. Change-Id: Ia7ff5d786bdf3b17709cec06608c91e22379746c Reviewed-on: https://gerrit.libreoffice.org/19762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-04Resurrect CppunitTest_sal_osl_getsystempathfromfileurlStephan Bergmann
Change-Id: I41007c46e945f4fe19a6dd197fded9fa503bf8c4 Reviewed-on: https://gerrit.libreoffice.org/19771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-30Combine individual gb_Module_add_check_targets, and sortStephan Bergmann
Change-Id: Ia625a33371d2278bd89274ed5ee18acb773810cf
2015-10-30CppunitTest_sal_osl_pipe can be added to gb_Module_add_check_targets nowStephan Bergmann
Change-Id: I13522370b2bd0ea1907660a55a74e830335ca4a4 Reviewed-on: https://gerrit.libreoffice.org/19686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-05-11sal: don't build cppunittester if cross-compilingMichael Stahl
Change-Id: I4e2d884b2f87572dc22fece897e384bdaa7506cc
2014-07-08Bypass CppunitTest_sal_osl_security with VS2013 for now, hangsTor Lillqvist
Change-Id: I8500b0cc4e541c96124425b713ba96226ff4715d
2014-04-28prefer makefile-gmake-modeTakeshi Abe
Change-Id: I9cc9bfbddd3a90e00eee3e674994e5d6207f9034
2014-04-24More hacking on --with-localesTor Lillqvist
Propagate the restriction of locales into <config_locales.h>. Note that in the normal case, with no locale restrictions, all the WITH_LOCALE_xx macros are zero anyway, but WITH_LOCALE_ALL is one. Restrict which character encodings are handled in sal/textencsal/textenc/tables.cxx based on the WITH_LOCALE_ macros. (Don't simply always do it for iOS.) Massage the affected unit tests to not crash when only partial character encoding information is present. Change-Id: Ie2c882c262ebd0d2b37dde66b8fe3c3e2570da14
2014-03-23sal: Rewrite digest tests to be simpler, enable them in checkTomaž Vajngerl
Change-Id: I610e615be498237e5cd9dd963bca60c7f8f62aac
2013-09-11fdo#39625 Make existing cppunittests workJelle van der Waa
Change-Id: Ia3a59456fe82926141ccb2921aa47df4183ead86 Reviewed-on: https://gerrit.libreoffice.org/5905 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-11sal: fdo#39625 Make existing cppunittests workJelle van der Waa
Change-Id: I6bd34f0deaf246bc5898532377d996fcefc88cbc Reviewed-on: https://gerrit.libreoffice.org/5906 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-04-24move sal_inc headers to include/David Tardon
Change-Id: I840c681b7c500640d3983e05e9895f3fa8bb1313 Reviewed-on: https://gerrit.libreoffice.org/3501 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24move URE headers to include/David Tardon
Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d Reviewed-on: https://gerrit.libreoffice.org/3499 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-13install SDK headers from filelistsDavid Tardon
... which allows us to drop gb_ZipPackage. Change-Id: Ib19f774c63d9b83ec07e99f963533eee431cc53a
2013-02-27sal: get rid of CustomTarget_generated.mkMichael Stahl
Change-Id: I2347f60ef922d32201beda47e59e0b345d07a3b1
2013-02-27sal: new ZipPackage_sal_odk_headers for public ODK headersMichael Stahl
Change-Id: I76cb00121d7b4c21137be70ab7a5bd5389037302
2013-02-22Not using NativeActivity means no lo_main() stuff used eitherTor Lillqvist
Hopefully also fixes build for iOS by re-introducing checks for DESKTOP. Also this commit partially reverts 52a8744afee2cd589813f0377d93f821fce7aedd. Change-Id: Ie94c771b72ba138bb0481b054285916618baf6eb
2013-02-21Revert "Clean up remains of NativeActivity-based Android app support"Michael Meeks
This reverts commit cecc926070ee3d2ad6296fc5e0cfcde8642bb140. Conflicts: sal/android/lo-bootstrap.c sal/inc/osl/detail/android-bootstrap.h
2012-11-26get textencoding tests working againCaolán McNamara
Change-Id: Ia3e0b7be14800e1d50c3e785153b45d2b4a7dd6d
2012-11-21Clean up remains of NativeActivity-based Android app supportTor Lillqvist
We haven't been able to build NativeActivity-based apps (like the android/qa/sc and anroid/qa/desktop thingies) since we switched to DISABLE_DYNLOADING and a single DSO liblo-native-code.so anyway. No lo_main() any more. <sal/main.h> should not be included ever when compiling for Android of iOS now. Lots of stuff binned from vcl's androidinst.cxx, in the (vain?) hope that it will reduce the amount of never invoked GUI code that gets linked in. Change-Id: I25f584864c40110774c728a23151e089620442d9
2012-11-07move CppunitTest_sal_osl_process to gb_Module_add_check_targets callRene Engelhard
Change-Id: I602e1d42fde19b9557e1a21ba4d3fe704dd3f834
2012-11-06Add some rtl::Bootstrap unit testStephan Bergmann
...there is still additional old cruft in sal/qa/rtl/bootstrap/, some of it might be worthwhile to resurrect. Change-Id: Ie334431abc8de839fa2e655cbd3dc4d014c38f15
2012-10-07When DISABLE_DYNLOADING don't even provide any module loading/unloading APITor Lillqvist
Will then cause compilation errors where they are used, which will be noticed and taken care of. (The code chanaged to either use direct linking instead, when it makes sense, or to just bypass the functionality that requires dynamic loading.) Much better than waiting until run-time to notice where dynamic loading is attempted. Change-Id: Ib0cb5a2524b5c63f8e27670e7d72e37ce2a8e6e9
2012-09-11fdo#39625 Make existing cppunittests workRadu Ioan
Make sal_rtl_uri cppunittest work - removed call to simpleheader.hxx - added call in Module_sal.mk for sal_rtl_uri - created mk for cppunittest for sal_rtl_uri - removed duplicate include - change from t_print to printf Change-Id: I928ade62eb51ba1cb0a74e347411b344d57e97d0 Reviewed-on: https://gerrit.libreoffice.org/590 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2012-09-10what gets tested here turns out to be out of date nowCaolán McNamara
Change-Id: I61b96b8d0e9c821f0e6228430eece1617871a916
2012-09-10fdo#39625 Make existing cppunittests workRadu Ioan
Make sal testHelperFunctions cppunit work - removed call to simpleheader.hxx - added call in Module_sal.mk for sal_testHelperFunctions - created mk for cppunittest for sal_testHelperFunctions - removed unused and unusefull function Patch#2 - remove some unusefull include - add bug number to commit message Change-Id: I2f4e831cea0213a07f440bb00e0302eb1c4d7dc1 Reviewed-on: https://gerrit.libreoffice.org/588 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2012-08-25fdo#39625 Make existing cppunittests workRadu Ioan
Make rtl uuid cppunit work - removed call to simpleheader.hxx - added call in Module_sal.mk for rtl_uuid - created mk for cppunittest for sal_rtl_uuid Second patch: - removed makefile.mk as Stephan suggested - modified CppunitTest_sal_rtl_uuid.mk header Change-Id: If090843203e38d3eced14941b58e6122d27bdb09 Reviewed-on: https://gerrit.libreoffice.org/422 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-08-07No point with these executables for non-desktop OSesTor Lillqvist
Change-Id: If2e086cf2783c187f2cdb479608aa91561e0d674
2012-07-16allow using rtl::OUString etc. simply as OUString, without rtl::Luboš Luňák
http://lists.freedesktop.org/archives/libreoffice/2012-April/029940.html The RTL_USING #define (set by gbuild for anything that's not public API) allows to use such classes simply by their name, without having to use the namespace or do explicit using rtl::OUString (which half of the sources do anyway). Change-Id: I7edaf12cd278489cdc1d5ff782f0a86361c13c0a
2012-03-31sal: use CustomTarget makefileMatúš Kukan
2012-03-29No CppunitTest_sal_osl_process for iOS eitherTor Lillqvist
2012-02-22Do build cppunittester and don't build osl_process_child for iOSTor Lillqvist
2012-02-15Merge sal_textenc into sal just on AndroidTor Lillqvist
2012-02-15Don't bother with a separate libsal_textenc when merging libsTor Lillqvist
2012-01-27CppunitTest_sal_osl_file fails on WindowsTor Lillqvist
2012-01-21sal: make more tests runningMatúš Kukan
generated by cgit (git 2.34.1) at 2024-06-30 02:35:13 +0000