summaryrefslogtreecommitdiff
path: root/sal/osl/unx
AgeCommit message (Collapse)Author
2016-11-08Use the larger stack size for ASan/UBSan builds on macOS, tooStephan Bergmann
At least on my macOS 10.12.1, PTHREAD_STACK_MIN is 8192 (so stacksize was substantially smaller than 12MB), and without this change there were randomly looking failures in e.g. JunitTest_chart2_unoapi with a -fsanitize=address build. Change-Id: Icfe989a0e5097a9a0ae76c6e0f6ffcca18271245
2016-11-02loplugin:unusedfieldsNoel Grandin
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-30osl_getSocketOption shall return the new lengthStephan Bergmann
regression introduced with c89f22ffcd4191f7cb8ef0e68adb2a0f0ec6c74e "INTEGRATION: CWS pj72" Change-Id: Icea8bc43e346dbe4cf7cbfdf1176704d52b339f4
2016-08-05loplugin:countusersofdefaultparams in oox..sdNoel Grandin
Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01 Reviewed-on: https://gerrit.libreoffice.org/27902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05Clarify calculation precedence tdf#39440Muhammet Kara
Use parentheses to clarify the code. Change-Id: I864dc6dacadb5b9ba9dca8e0abd9fa4e6db1eddc Reviewed-on: https://gerrit.libreoffice.org/25677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29move #includes to top of fileNoel Grandin
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-20switch to EHs on windowsMarkus Mohrhard
This seems to be a good idea based on several discussions in the project. In the end catching SEH exceptions is just going to cause strange platform dependent bahavior. This patch is based on on http://thread.gmane.org/gmane.comp.documentfoundation.libreoffice.scm/39102/focus=55516 and includes some additional cleanup of the sal signal code. Change-Id: Iedc998e37e6495afec445eccb60fa1c2b1a7defd Reviewed-on: https://gerrit.libreoffice.org/26497 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-19loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-05-30tdf#100021 - format argument issue in process.cxxRichard PALO
avoid warning whether pid_t is long or int Change-Id: I533175b53166cb233169902d277906f5ce979421 Signed-off-by: Richard PALO <richard@NetBSD.org> Reviewed-on: https://gerrit.libreoffice.org/25593 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-05-18limit scanf string field widthJochen Nitschke
Change-Id: I9070bae914d923171b6eaf8209de00922dc87be7 Reviewed-on: https://gerrit.libreoffice.org/25052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-16fix typoMarkus Mohrhard
Change-Id: Icfc4b73d5664c205ad642c660af5227f403d20ff Reviewed-on: https://gerrit.libreoffice.org/25021 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ib67f7cb71255a32810f09a6b7e528f024bbef9df
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-05clang-tidy modernize-loop-convert in oox to saxNoel Grandin
Change-Id: If0d87b6679765fc6d1f9300c6972845cf3742b9c Reviewed-on: https://gerrit.libreoffice.org/24674 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-02sal_Bool -> boolStephan Bergmann
Change-Id: I6e86cb7ffbd8c8cbf3cccaef656cf7b7e755e24f
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I0164df28e2d05f4f73bd640d3ca3cc3220b57df6
2016-04-22Is __OPENTRANSPORTPROVIDERS__ (still) neededStephan Bergmann
...to be set before including Carbon/Carbon.h? Was originally introduced with c34f2e30bbad1a6b92308d0daabe413bd1bc161b "INTEGRATION: CWS pj51: #i61959# patch applied", but might just be cargo cult these days. Change-Id: I20cdc938d28e075614f6711a06ab785700833aff Reviewed-on: https://gerrit.libreoffice.org/24293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I6c656f991999791469015500aff1905fdb16ba65
2016-04-14Work around -Werror=logical-op (GCC 6)Stephan Bergmann
...when SIG_DFL happens to be defined as nullptr, by initializing the Signals array to SIG_DFL in the first place Change-Id: Ie9183540e2e8fd795aa288bf30266bc5d9af3e69
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I0a8dc9591c00188d0a31feb784d14ec53f389f27
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-07Drop pointless "internal" directory level for already internal include filesTor Lillqvist
Change-Id: I496fdbab3e17c806c2d16513412c4c1b9120bc3c
2016-03-31Fix Windows part of 97858ca008fd8cf405e52795c8db415ef6c5afb3Stephan Bergmann
"tdf#93548 Refactor sal signal to reduce code duplication" Change-Id: Ib0a872fb6023b6989c7931f4d57d911ddf76936f
2016-03-30loplugin:staticanonymousStephan Bergmann
cf. <https://gerrit.libreoffice.org/#/c/23630/> "tdf#97966 Compiler plugin"; in code not covered by Tamás's pending "tdf#97966 Drop 'static' keywords" changes. Change-Id: Ifbaef83fdb1fde7e25fafd5746cdbf99c334c5be
2016-03-29tdf#93548 Refactor sal signal to reduce code duplicationAleksas Pantechovskis
Change-Id: Iff331a48fadc23da8b24f9ca3a841000313a03dd Reviewed-on: https://gerrit.libreoffice.org/23477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-29handle failure to expand ~ in path elements.Michael Meeks
This can occur in some online corner-cases. Change-Id: Id8b419179d775a21110d682ba76d8a02f45eb828 Reviewed-on: https://gerrit.libreoffice.org/23577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-11Better fix for -Werror=shadowStephan Bergmann
Change-Id: I2dff3eeef6e9d2bcf089f054475c164c8c641941
2016-03-10-Werror=shadowStephan Bergmann
Change-Id: I82d2d44fd43ff2a641df74b9e05aea01991d001c
2016-03-10Remove unnecessary typedefs (that introduced reserved identifiers)Stephan Bergmann
Change-Id: I42d09cccf07dca6733f763b1026f6c138cb70a61
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I309985d65752c4aa041cdb7c060c32d4312d442d
2016-03-10Remove unnecessary typedefs (that introduced reserved identifiers)Stephan Bergmann
Change-Id: I726ca611cce66d7e25dc91b8baaec7e588eb1b8e
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I074b5c4b9caec0a1c22f36e153a84104c5187e91
2016-03-10Drop __osl_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann
Change-Id: I725783d10bc1e6300c480542c536d409433ff532
2016-03-10Drop __osl_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann
Change-Id: I68e51e09ffea9328034254b694b01082dbb4e3bd
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: If19a3029bd7d312e40eead77856fb705d12b5fc6
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: I29c643a972c10f22328022b66c57c6b86f748cfe
2016-03-10Rename _imp_get/setProcessLocale (avoid reserved identifiers)Stephan Bergmann
Change-Id: Iab013039d3f99ee06efc1556b768f16ec8bcee2a
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: I6d60bbf938a5e609efeb56d9c7650e83dd9bbbdb
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: I2b8e5e4736fab924c02fca81aabb37c4e2361265
2016-03-08tdf#98407 PathSubstitution: Add substitution for $(username)Samuel Mehrbrodt
This allows to use the username as a placeholder in the config paths (Autotext, Gallery, etc) Change-Id: I76434e980cd8ec8785a5587d0bc5fdd67dc42de2 Reviewed-on: https://gerrit.libreoffice.org/22901 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07sal: UNX: in oslDoCopy, rename into destination directory ...Michael Stahl
... not into the source one as that will likely fail with EXDEV if source and target are on different mounts => osl_File_E_EXIST. This broke the xmlsecurity test SigningTest::testOOXMLAppend(). Change-Id: I07ada1d5564fd72a059d588e127a5906a499aca4
2016-03-04Remove write-only g_nSocket* debug varsStephan Bergmann
Change-Id: Ie8a1d015242450094928863013030b4cb0bb1f4e
2016-03-04Clean up a SAL_WARN_IFStephan Bergmann
Change-Id: I8a945f3e83559f421aa1a0b4fbfcec1b25932ef7
2016-03-03tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
Change-Id: If329cf8257684e7bd2936641b8f14ec3e9b9f733 Reviewed-on: https://gerrit.libreoffice.org/22647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-02tdf#98210 do not require R_OK for pipe dirHank Leininger
Also better error handling if pipe dirs are really not usable. Change-Id: I1c865b9a9f1f08d2cffd07343494feca585ec75e Reviewed-on: https://gerrit.libreoffice.org/22727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-18coverity#1352316 Explicit null dereferencedCaolán McNamara
Change-Id: Ieb80209e0254080bf78fb3b5201b849d7d30880c
2016-02-07Platforms that need CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT for sockets usuallyDamjan Jovanovic
need it for pipes too, and even if it isn't necessary it can't hurt. In particular, on FreeBSD 11-CURRENT it seems pipes no longer wake up from accept when closed in other threads, so let's deal with that before FreeBSD 11 is released. Reported by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e> Patch by: me Tested by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e> (cherry picked from commit e18ecd4f644cfbe5d6b871c7ff6c76bd5c220504) Change-Id: I1b4c0438fbcc2ea53625f235906936fc1403e195
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-07loplugin:nullptrStephan Bergmann
Change-Id: I8c1ef744be34eea2130b458ed3a09d90804219cc