summaryrefslogtreecommitdiff
path: root/sal/qa
AgeCommit message (Collapse)Author
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-17fdo#70319 "exponent followed by at least on digit" also for special case 0.0Stephan Bergmann
Change-Id: I07e7917417b8a22cf6d64f2b7a447f9084b9fa2d
2013-10-14resolved fdo#70319 exponent must be followed by at least one digitEike Rathke
Change-Id: Icdd22fa0f1efcdd18cfea7cb48e1cbf2cf8d3533
2013-10-08CID#982700 silence coverityCaolán McNamara
Change-Id: I01fddeeca503ebc045c2f0e53c5917e6218e9d6e
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I5740a22f0d768b9b1d7449f54b859bcb40401367
2013-10-02-Werror,-Wunused-functionStephan Bergmann
Change-Id: I1b966095f764a197c4c5e823fa41b9914cb34ebe
2013-09-22sal: rename "cppunit/cppunittester" executableMichael Stahl
... and put it in OOO layer since it's used by the smoketest instset. It was in subdirectory for hysteric reasons, to pick up libraries from module local output directories in the dmake build system. Change-Id: I73b66672b17ede52c03071eb2ddee1a23c059ea9
2013-09-12WaE: unused variable suToken, aEmpty, aEmpty2.Andrzej J.R. Hunt
Change-Id: I2eaa32e0ec09b239e03d3efa776f5b47c2fb5c6d
2013-09-11-Werror,-WformatStephan Bergmann
Change-Id: I24a060d1d5592a23f9a991ef3b39f31818ea0d84
2013-09-11fdo#39625 Make existing cppunittests workJelle van der Waa
Change-Id: Ia3a59456fe82926141ccb2921aa47df4183ead86 Reviewed-on: https://gerrit.libreoffice.org/5905 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-11-Werror,-WformatStephan Bergmann
Change-Id: Iae7da0146c670d77a4bdc2431a55c901318eef8d
2013-09-11sal: fdo#39625 Make existing cppunittests workJelle van der Waa
Change-Id: I6bd34f0deaf246bc5898532377d996fcefc88cbc Reviewed-on: https://gerrit.libreoffice.org/5906 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-23fix hex escape sequenceCaolán McNamara
Change-Id: I8bc9d3812977589e96f5440afa8d46bfe4d3b88e
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-19Rename SOLAR_JAVA to ENABLE_JAVA and HAVE_FEATURE_JAVATor Lillqvist
Change-Id: Ib451bdb3c1c2ca42347abfde44651d5cf5eef4f3
2013-08-01Mark as constTakeshi Abe
Change-Id: Idd1d0641d5b7d8594f354c7d2e2a9093ecc6b2f7
2013-07-17Fix memory leak with osl_getCurrentSecurity ().Mark Wielaard
The result of osl_getCurrentSecurity () should always be deleted again with osl_freeSecurityHandle (). Change-Id: If0991937fcb24207d1f78166f61c4be22d423629 Reviewed-on: https://gerrit.libreoffice.org/4947 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-06-25coverity : #984128 and 21 others : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: If801818c2efc8cdec651ff259243075abac41d20 Reviewed-on: https://gerrit.libreoffice.org/4497 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-19Delete unused sal testsDavid Ostrovsky
Change-Id: Iba1eeb8d8fd0582f216b7552dc9ae21b69e66b4e Reviewed-on: https://gerrit.libreoffice.org/4326 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-13Introduce O[U]String::toUInt32Stephan Bergmann
...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39 "Handle oveflow in O(U)String::toInt() functions" reduces values in the range (SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied on getting a correct (unsigned) value for the whole input range ["0" .. "FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3 "Revert overflow checks in O[U]String::toInt{32,64} again"). Audited all uses of toInt32/64 with non-decimal radix. (There is still a TODO comment in oox/source/helper/attributelist.cxx, and stoc/source/typeconv/convert.cxx will still need some love and test code.) Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
2013-05-31rewrite OUString test to not trigger literalalternative plugin warningsLuboš Luňák
Change-Id: Ic359209c44171ab42fa21cd300b433facd3c5ea6
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-05-10soltools: remove Package_inc and empty unistd.h nonsenseMichael Stahl
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-22Revert "fdo#62096: Replaced some compareTo with =="Fridrich Štrba
This reverts commit dd47994722eaead16099145e593fbf878072d52b.
2013-04-22fdo#62096: Replaced some compareTo with ==Sameer Deshmukh
Change-Id: I1151dafcef91abdb2ce08abe3547a49fe3f4a67c Reviewed-on: https://gerrit.libreoffice.org/3509 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-09no mkdtemp on AIX eitherCaolán McNamara
Change-Id: I9103f86a5b8414c9cdf5fd3a2d662725343f0ed8
2013-04-04remove HAVE_SFINAE_ANONYMOUS_BROKENLuboš Luňák
Since we no longer support the old Apple SDK using gcc-4.0.1, we can remove the cruft to work around its problems. Woohoo. Change-Id: Idf275e76449443f1f0314e75dab993f213a77eb7
2013-03-25remove external include guardsThomas Arnhold
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
2013-03-25Add test case for toInt overflow detectionStephan Bergmann
Change-Id: I1c5b66888baac8aa1bc99c06579e0ef3638a4877
2013-03-20Deprecate confusing rtl::OUString::compareToAscii(asciiStr, maxLength)Stephan Bergmann
Change-Id: I3a41036ec03cdaefea94b19dbedf59e5a5e37dc8
2013-03-20use #if instead of #ifdef for testing config_xxx.hxx macrosLuboš Luňák
http://lists.freedesktop.org/archives/libreoffice/2013-March/047769.html Change-Id: I81ed4500878ff3193e028410a1f0205e28d17fc3
2013-03-19further OUString cleanupThomas Arnhold
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Reviewed-on: https://gerrit.libreoffice.org/2835 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: I47b35af71277fdda19767a553c960bf12164b92f
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-04doubled includesThomas Arnhold
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-02-23Fix typo accessable/accessibleJulien Nabet
Change-Id: I2f6d00a6361243a52a593acaaf2bf624d8a2730e
2013-02-22silence warning.Michael Meeks
Change-Id: Ibf82038c15c9ecf6de502bae1dd21e2393cafe09
2013-02-22Fix misspellings detected by https://github.com/lyda/misspell-checkTor Lillqvist
Just as a test to check the usefulness of that tool. It needs some improvement before really usable. Change-Id: I875e79c1992ed5f3b695736b0d49938ad0ba2d55
2013-02-21Fix type unkown -> unknownJulien Nabet
Change-Id: I8d55d5ae5ae38ae2b252859b5400e36301f19ef0
2013-02-05testOUBoolean should test with OUString, not OStringLionel Elie Mamane
Change-Id: I103ca7d72e6bae6c20605719451579dd156504ce
2013-02-04OK for boolean() to take true bool argumentStephan Bergmann
...instead of sal_Bool; this would cause C4800 performance warnings with MSVC, but we disable them anyway. Also, added unit tests that are actually executed. Change-Id: Ib405132565918be72d93b3fc24180edcb6e565c7
2013-02-04Strings: boolean() as a replacement for valueOf(sal_Bool)David Ostrovsky
valueOf(?) has been superseded by number(?). O(U)String::valueOf(sal_Bool) has been deprecated without providing an alternative method. Use boolean() method as a replacement for it. Change-Id: I7eb74574fa8f1a3cf007cb0cbc32e681007ffb92 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-01-28consolidate the float number testsLuboš Luňák
And remove some unneeded ones (the float actually didn't have the necessary precision on 32bit anyway). Change-Id: I52dd387fd319dd6a5b44333a71d012ebaaecbf18
2013-01-26Remove redundant braces around for loopsStephan Bergmann
...that had once been workarounds for compilers that did not yet support the C++98 scoping rules for declarations in for-init-statements. Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
2013-01-18long and long long can be the same size (and thus also sal_Int64)Luboš Luňák
Change-Id: I3961ec27d23915b038c3a803dc71e7d937ca331c
2013-01-18Create OUString and OString number(*) methods.Noel Grandin
API CHANGE: Adds new methods (several overloads) OString::number() OUString::number() and marks all of the existing fromValue() methods as deprecated. The purpose of this change is to clean up call sites by hiding the necessary casts. The casts are necessary because of overload resolution rules which are somewhat vague about which methods to choose when using integer types. See mailing list discussion here: http://nabble.documentfoundation.org/replacing-OUString-valueOf-static-cast-lt-sal-Int32-gt-td4027989.html Subject: "replacing OUString::valueOf(static_cast<sal_Int32>) ??" Change-Id: Id3d150a6525eb0334e41e2ec6640bb06cd790b43 Reviewed-on: https://gerrit.libreoffice.org/1625 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>