summaryrefslogtreecommitdiff
path: root/sal/qa
AgeCommit message (Collapse)Author
2015-03-02V805: Decreased performanceCaolán McNamara
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
2015-02-28Typo: excute->executeJulien Nabet
Change-Id: I8c73d95d92dc4a30dd6a71260817ab4fc3096f27
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-14Related: tdf#63690 - remove rtl_logfileThorsten Behrens
This was unused since the earlier cleanup. Change-Id: Ia56641c4242037a0ce501e43939b8dc862499f0e
2015-02-06O[U]StringBuffer::appendUninitialized unit testsStephan Bergmann
Change-Id: I55f0a5bd01a3e250764e1eb34d674b535b85b56f
2015-01-28Some more loplugin:cstylecast clean-upStephan Bergmann
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
2015-01-20Some more loplugin:cstylecast: salStephan Bergmann
Change-Id: Ie54d340478412e62b87d66e287fd8a3963e97898
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07loplugin:cstylecast: salStephan Bergmann
Change-Id: I0ad9681a8b31d78cefce5b66040415154a1c7a99
2014-12-20TyposJulien Nabet
Change-Id: I3475be796cf2655d9b619b86c9686aeef4b97b82
2014-12-19No need for RTL_FAST_STRING in addition to LIBO_INTERNAL_ONLYStephan Bergmann
Change-Id: I5514898f588b21bafceefca95e3276826cb9a882
2014-12-19No need for RTL_USING in addition to LIBO_INTERNAL_ONLYStephan Bergmann
Change-Id: Iaa65658aed6bb4abb20a4d95dc9c6caf7c1c764b
2014-12-19Remove unused */qa/checkapi/Stephan Bergmann
...superseded by CppunitTest_odk_checkapi Change-Id: I5df89a1a12f496984deab153f0ba2734323c1293
2014-12-17Fix 32-bit buildsStephan Bergmann
Change-Id: I09049db51668176b90dabe2c82d525b2fab60299
2014-12-17rtl::OUStringLiteral to the rescueStephan Bergmann
...for cases where ? "a" : "bb" does not work, as well as to work around the MSVC bug for cases like ? "a" : "b". Change-Id: Id404716047aca5cc81440f291616d92365379b8f
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-16sal: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I4382504549eb1e3a8c34495a21d6df10a86ac23b
2014-12-12sal: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I568c2e0c9b5b234d941e17d57bcb53374626909e
2014-12-02-Werror,-Wkeyword-macroStephan Bergmann
Change-Id: I4a42c9f795cfbaa0f6c7b68d8189204a63da2321
2014-11-24typo: unknownAndras Timar
Change-Id: If89443c1668ca01c826c8fc353b20097c7da7bf4
2014-11-18More iwyu suggested headers removalRiccardo Magliocchetti
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-14Remove spurious cpu_countStephan Bergmann
Change-Id: Ic90e806d279f8180d78f78597dbc549264338295
2014-10-14sal: cleanup unit tests whitespace.Michael Meeks
Change-Id: If067f755b99480b7b7bd0bd3bb7a71a447794273
2014-10-09More specificStephan Bergmann
Change-Id: I7e6490c5b50a236a5f070e98d4501e7dd5a90307
2014-10-09disable environment equality test under valgrindCaolán McNamara
Change-Id: I9e0e06331f134fe89c9942f93b7546b0e67bb821
2014-10-08Document how rtl::Uri::convertRelToAbs normalizes an absolute URL's pathStephan Bergmann
Change-Id: Ibf4f2d46bfbb977f0ba27110d86d7b7f1173631c
2014-10-02remove checks of __GCC_MINOR__ that are always true in GCC 4.6 or laterMichael Stahl
Change-Id: I4412a0c1e4dee94cd717f24b8df5e257d895f721
2014-10-01We require OS X SDK 10.8 or newer nowTor Lillqvist
Change-Id: I68eee76c8710c89af8e3c1e1006345f908923ece
2014-09-30Get rid of some auto_ptrStephan Bergmann
Change-Id: Icd477e433f0c294c823c64147d49fb4ac6bfb447
2014-09-24fdo#39625 Delete unused cppunittestsTobias Madl
As discussed with Stephan Bergmann, these files, which contained unused cppunittests, could be removed. Change-Id: I91844b96967e3c3e0e8367452f2dda420f479ffe Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-13WaE: Unreferenced function definitionTor Lillqvist
Change-Id: I1b5d3f881e82cea90fcc4e97c837251e340abffe
2014-08-13textenc: disable failing tests on Windows for nowThomas Arnhold
They were never working, at least since 65f82ca62922e2c487ba72b6d67ea7e3a03f8ebc Which changed some mappings, for example: -check( RTL_TEXTENCODING_IBM_437, RTL_TEXTENCODING_IBM_437 ); +check( RTL_TEXTENCODING_IBM_437, RTL_TEXTENCODING_MS_1252 ); But I don't know if that's the root of the problem. Change-Id: I09f640a6c92a782f99d79405aab5f5dd2b992c6d
2014-08-13warning C4706: assignment within conditional expressionThomas Arnhold
quite useful in this case Change-Id: I2f9a5ef8ea9faf7a1ce62bd9b4925b3f36b19d1a
2014-07-31sal_osl_process: fix "Parent and child environment not equal" for OSX <10.6Douglas Mencken
It fails with "assertion failed": - Expression: compare_environments() [osl_process.cxx:370] - Expression: compare_merged_environments(different_child_env_vars) [osl_process.cxx:428] Just disable it (yet) for OSX <10.6 as it's already done for Windows. Change-Id: I88e838481a25ee7e977512e33e23afa2b9d394ff Reviewed-on: https://gerrit.libreoffice.org/10641 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-07-08Include <algorithm> for std::min() and max()Tor Lillqvist
Change-Id: Ic3ab061ab8d3578130dfa8a637e5351d4f5d766e
2014-07-01New loplugin:stringconcatStephan Bergmann
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-27loplugin:unreffun: also warn about unused function templatesStephan Bergmann
Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: Ia4111a0fb76c848d3bd2d01f3835995e4c007b6b
2014-06-01fdo#68849: Add header guards to all include filesJens Carl
Added header guards to files in directories sal/, sal/, and scripting/ Change-Id: Ieb7f224f2d27bd671618c516f47f5b7f08c1d294 Reviewed-on: https://gerrit.libreoffice.org/9582 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-24coverity#982175 Unchecked return value from libraryCaolán McNamara
Change-Id: I7acba38a00dfc1101e6217bff098ef7d6f032497
2014-05-23coverity#1079283 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib849ff0839bba80d5695c0f78dd18448b668ec78
2014-05-23coverity#1079282 Uninitialized scalar fieldCaolán McNamara
Change-Id: If20b1108af89dec75d8c6a232290ab28e51d09d4
2014-05-23coverity#1079281 Uninitialized scalar fieldCaolán McNamara
Change-Id: I17dc424d485053d3eb09e8eb0dd01dd4b4672bfd
generated by cgit (git 2.34.1) at 2025-02-08 15:29:33 +0000