summaryrefslogtreecommitdiff
path: root/sal/workben
AgeCommit message (Collapse)Author
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2 Reviewed-on: https://gerrit.libreoffice.org/21245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-13cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ife26f55c28c4631aec4ba4105225bfca72da8bff
2015-10-28com::sun::star->css in sal,saxNoel Grandin
Change-Id: I24e202b1f8071fe918e4e164b5fa1c08a561cb24 Reviewed-on: https://gerrit.libreoffice.org/19626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini
Change-Id: Ia41f4f0ca30ae3346d0720271478ec5bcdab797b Reviewed-on: https://gerrit.libreoffice.org/18967 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-08-23tdf#39440 cppcheck: redundantAssignmentMichael Weghorn
This addresses some of cppcheck's "redundantAssignment" warnings ("Variable '<varName>' is reassigned a value before the old one has been used"). Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e Reviewed-on: https://gerrit.libreoffice.org/17926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2014-12-19fdo#39440 sal: reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Id5f90757571e76a2c05a4cbd37020e1f6a6b2033 Reviewed-on: https://gerrit.libreoffice.org/13544 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-25fix encoding: iso-8859-1 -> utf8Thomas Arnhold
Change-Id: I3643c38345ec253b7c396a67b9f350a51f6aaf40
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-20cpplint: [readability/utf8] Line contains invalid UTF-8Julien Nabet
Change-Id: I8052539d86fbda5631b31f3163b1c51666153c8c
2014-04-03Kill superfluous vertical whitespaceTor Lillqvist
Change-Id: I8c37b9ec45836f9c0e2dc0cf232f96f23c7c36d3
2014-03-29typo: inteface -> interfaceThomas Arnhold
2014-03-01Remove visual noise from salAlexander Wilms
Change-Id: Idf07c7d31c0a523f929aded9ff3183a3f01b16b9 Reviewed-on: https://gerrit.libreoffice.org/8297 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2013-12-17fdo#72598 Remove SunStudio cruft from code baseJelle van der Waa
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc Reviewed-on: https://gerrit.libreoffice.org/7104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-07-17Fix memory leak with osl_getCurrentSecurity ().Mark Wielaard
The result of osl_getCurrentSecurity () should always be deleted again with osl_freeSecurityHandle (). Change-Id: If0991937fcb24207d1f78166f61c4be22d423629 Reviewed-on: https://gerrit.libreoffice.org/4947 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-06-27Translate German comments.Chris Hoppe
Change-Id: Ida59dcca7c9a0305aecddaa68f4e585321144458
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-17fdo#62096 - replace some O(U)String compareTo with ==Artur Dryomov
Change-Id: I98d04d7da4c2b7ea0b769df9c2bfa8c1ad86bf2d Reviewed-on: https://gerrit.libreoffice.org/3422 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: I47b35af71277fdda19767a553c960bf12164b92f
2012-12-25Get rid of (most uses of) GUITor Lillqvist
GUI only takes values UNX or WNT, so it is fairly pointless. One can check whether OS is WNT or not instead. Change-Id: I78ae32c03536a496a563e5deeb0fca78aebf9c34 Reviewed-on: https://gerrit.libreoffice.org/1304 Reviewed-by: Peter Foley <pefoley2@verizon.net> Tested-by: Peter Foley <pefoley2@verizon.net>
2012-11-27Make python3 work with custom VALGRIND_CFLAGSStephan Bergmann
Change-Id: Ia4b08a1b20bf46af4d06c0478ed8e795ee543703
2012-11-21re-base on ALv2 code. Includes:Michael Meeks
Patch contributed by Herbert Duerr: #i118662# remove berkeleyDB from module xmlhelp (author=orwitt) http://svn.apache.org/viewvc?view=revision&revision=1213188 #i119141# remove ISCII converter for now http://svn.apache.org/viewvc?view=revision&revision=1306246 make exceptions for cppunittester verbose http://svn.apache.org/viewvc?view=revision&revision=1174831 Patches contributed by Pedro Giffuni: Avoid some uses of non portable #!/bin/bash in shell scripts. http://svn.apache.org/viewvc?view=revision&revision=1235297 Patch contributed by Oliver-Rainer Wittmann 88652: applied patch, remove unicows deps http://svn.apache.org/viewvc?view=revision&revision=1177585 drop OS/2 code, remove in-line assembler ARM atomics, and obsolete armarch header.
2012-08-08remove include comments and boxesThomas Arnhold
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-07-27Use memset and memcpy insteadof rtl_zeroMemory and rtl_copyMemory in salArnaud Versini
Change-Id: I4f9649ca61c988d425b59e41549d1c46bb808f2c
2012-07-02Remove unused definesThomas Arnhold
Some of them were commented out for documentation purpose. Change-Id: I29a6b2cbe774b527f0c3a0be5675160817a7f3ce
2012-06-27targetted re-work of cppunit pieces.Michael Meeks
2012-06-22re-base on ALv2 code.Michael Meeks
Change-Id: I8018d9b5fa01d1720c0392dc5fdc4a0656f25a35
2012-06-21re-base on ALv2 code.Michael Meeks
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21re-base on ALv2 code.Michael Meeks
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-09Remove superfluous empty lines on topThomas Arnhold
More than two lines are removed for readability. Change-Id: Ibff6cf68d7c512e240a54065b54a225bb23a782b
2012-06-02targeted string re-workNorbert Thiebaud
Change-Id: I145731d9f28faf0065f5960f2c5a32f27d8c8620
2012-06-01targeted string re-workNorbert Thiebaud
Change-Id: I6b23bd671c3c090a7c3b60d5301c59da5f9354d5
2012-04-05Translated German comments to English in folder 'sal'.Mark Wolf
sal/qa/rtl_strings/rtl_old_testostring.cxx contains some German comments still but the code itself uses test strings in German. When the test strings appear in the comments, they were left unchanged to maintain consistency. Mark Wolf
2012-02-21WaE: unreadVariableThomas Arnhold
2011-12-06normalize Red Hat, Inc. spellings, and bump to latest templateCaolán McNamara
2011-11-27remove include of pch header from salNorbert Thiebaud
2011-11-21poke __cplusplus into workben comparison toolCaolán McNamara
2011-11-18cppcheck: unread variablesKorrawit Pruegsanusak
These variables are set, but unused.
2011-10-07cppcheck reduce scope of var in sal/... cbptest.cxx and cbvtest.cxxPierre-André Jacquod
2011-10-07cppcheck reduce scope of var in sal/...cbcpytest.cxxPierre-André Jacquod
2011-09-12sb140: #i113503# mixing system CppUnit and OOo STLport does not work, backed ↵Stephan Bergmann
out a6913c9677c2 For LibO, that just means replacing sal/cppunit.h with sal/precppunit.hxx.
2011-06-27Remove tgetpwnam.cxx, it is unused.Francois Tigeot
2011-06-05__cdecl -> SAL_CALLChristina Rossmanith