summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2012-09-20Make rtl::O[U]String::isEmpty return true boolStephan Bergmann
...instead of sal_Bool, to work around MSVC warning C4805: unsafe mix of type 'sal_Bool' and type 'bool'. Change-Id: Ia3477539ccc23aa9daec49d633f023d414f2b4bf (cherry picked from commit 8ee7c47404cdf408bcd3b6ea0267fbe54193c93f) Reviewed-on: https://gerrit.libreoffice.org/650 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2012-09-19fix system-clucene/-boost build with gcc 4.4Rene Engelhard
Change-Id: I95d23e6728571b3f3a6421a05fec814f7c5d059c Signed-off-by: Fridrich Strba <fridrich.strba@graduateinstitute.ch>
2012-09-10fdo#38913: Prevent invalid parameter handler crashesStephan Bergmann
It appears that on Windows at least some jvm.dll versions can cause calls to _fileno(NULL), which leads to a call of the invalid parameter handler (see <http://msdn.microsoft.com/en-us/library/ksazx244%28v=vs.80%29.aspx> "Parameter Validation: Visual Studio 2005"). The default handler causes the application to crash, so install a "harmless" one instead. Change-Id: Id6a3ffb63f70b0c65546bc933e994c8dbf35203c (cherry picked from commit a82e532ce006c54b2740de74d1da5d11307da7c1) Reviewed-on: https://gerrit.libreoffice.org/564 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2012-08-21Related fdo#46249: FileStatus can have fewer fields than requestedStephan Bergmann
Turns out 608fe962cc649ad62c489811d3a8666e0e06e5e7 "Let osl::FileStatus getters assert programming errors" was overly optimistic and misunderstood that osl_getFileStatus(..., nMask) /can/ return a FileStatus for which isValid(nMask) is false, esp. for stuff like file names and URLs of Windows drives and servers. That in turn leads to existing code now calling rtl::OUString(_aStatus.ustrFileName) etc. with null argument and crashing. Change-Id: Icd2168e209aa1c7a6df30cd954513d01034923db Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2012-08-20fdo#53252: _toupper is unreliableStephan Bergmann
<http://msdn.microsoft.com/en-us/library/45119yx3%28v=vs.80%29.aspx> "toupper, _toupper, towupper, _toupper_l, _towupper_l: Visual Studio 2005" states: "In order for toupper to give the expected results, __isascii and isupper must both return nonzero." But a community comment clarifies: "This is incorrect, and should refer to '_toupper' (the macro form), not 'toupper'." (Which makes sense, as otherwise toupper would violate the C Standard.) And indeed, at least for some LO built against MSVC 2008 Express on Windows 7, _toupper('C') = '#' is broken, while toupper('C') = 'C' is good. (And the unexpected '#' then causes all sorts of errors in the code.) Change-Id: Iddaddcaf0cc3ffb30e55b0f410a6cfe9118accc8 Signed-off-by: Petr Mladek <pmladek@suse.cz>
2012-06-18fdo#50603: Close fds across a restart of soffice on Mac OS XStephan Bergmann
...where the restart is directly from the old soffice instance, via exec, so the restarted soffice would inherit all open fds from the old one. The easiest approach appears to close fds upon startup. Change-Id: I89bb1c78f3adf2da1cd3cbd58c22df276133a883 (cherry picked from commit d5e9c2e3e85a2bcdd6a0b2088253fc133e52e831)
2012-06-14Revert MSVC ABI incompatible URE change (public -> protected)Stephan Bergmann
...the mangled names of the corresponding symbols change with MSVC if you change a member from public to protected. This had been changed with 6e67c03dc0225fc66343546b14e902b9d238b1a3 "Enable -Wnon-virtual-dtor for GCC 4.6" but should only be necessary for GCC, not for MSVC, so can simply be reverted under _MSC_VER. Change-Id: Id22aadaff3d7f30ed824f39fe22eab7ca39bd408 (cherry picked from commit 271c4e2fe53c6fe159789db27507804133e72814)
2012-06-13trying to fix mingw buildFridrich Štrba
Change-Id: I86c06fc3f7dcd0a24898a602a60c10abdc588b81 Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>
2012-06-13Bring back the Duden hackFridrich Štrba
Change-Id: I062179fca29034602ffc18ad7e2b7de2988dac2f Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>
2012-06-02targeted string re-workNorbert Thiebaud
Change-Id: I145731d9f28faf0065f5960f2c5a32f27d8c8620
2012-06-01targeted string re-workNorbert Thiebaud
Change-Id: I2c166c63e9d2ab7d60bb404f643045678ef239a2
2012-06-01targeted string re-workNorbert Thiebaud
Change-Id: I368b9538e3c2e6242fcdcabb4f8c716e17b02d88
2012-06-01targetted cppcheck variable scope revertMichael Meeks
Change-Id: I757615e134eddc1f212533e3e950827e7180c278
2012-06-01targeted string re-workNorbert Thiebaud
Change-Id: I6b23bd671c3c090a7c3b60d5301c59da5f9354d5
2012-05-31Add a BGR to RGBA twiddling JNI functionTor Lillqvist
Change-Id: Iafa2c1805eea2f521479dc97d5668d82b1c91bef
2012-05-30Some cppcheck cleaningJulien Nabet
More information on this thread: http://nabble.documentfoundation.org/Advice-needed-about-some-cppcheck-reports-td3986408.html Change-Id: Ib70532ad72e8418e1036bd52c07dc6452508cd12
2012-05-30Add temporary test JNI method createWindowFoo()...Tor Lillqvist
Change-Id: I8f99399faa3b0762bdea2aac09f1b849639cd191
2012-05-29Some cppcheck cleaningJulien Nabet
see http://nabble.documentfoundation.org/Advice-needed-about-some-cppcheck-reports-td3986408.html Change-Id: I4b3b2c87031ab48641e78fce56bd7f86c606b48b
2012-05-24fdo#50162 merge rtlbootstrap.mk into configure.inDavid Ostrovsky
Change-Id: I241be2704a069ec1f6be5861084039569673cc12
2012-05-23removed unused temporary rtl::OUStringTakeshi Abe
Change-Id: I9d118a5fbe2306465d8bcdb9ddd0596588137e5e
2012-05-22android: use existing SAL_DLLPUBLIC macros instead of attributesMichael Meeks
2012-05-18fdo#42865: privatized unique empty string symbol:Michael Stahl
Unfortunately this --enable-dbg-util only problem (caused by _GLIBCXX_DEUBG) resurfaced, perhaps because of new std::string based logging in sal; adapt all map files to export the unique symbol.
2012-05-17drop debug_oustring now that gdb pretty-printers existCaolán McNamara
Change-Id: Ie7d17f0ceb2e549b84c0cc16768604511e0e51a5
2012-05-16Create the redirection thread in detached stateTor Lillqvist
Change-Id: I293fa84452f00a41f4a33d4a45eee6d1a32ff761
2012-05-16Add stdout and stderr redirection to the Android logTor Lillqvist
On a (non-rooted) device it is not possible to set the log.redirect-stdio property so that it would be effective (i.e. read by the Zygote process when it starts). Such redirection has to be done in-process. Add a (JNI-callable) method to set it up: Point file descriptors 1 and 2 at pipes that are read by a thread that logs each line through the Android logging API. Code based on Android's own logwrapper.c. Change-Id: Id5308293595096a44a2ffed2dbc0c252be109de7
2012-05-14Generate a proper (?) rtlbootstrap.mk for a MSC build, tooTor Lillqvist
Change-Id: I35a1a270f5eab2250ed0ef50c6bf6c9dbec4f42e
2012-05-10normalize variable names in gbuild user makefilesMichael Stahl
Variables should have module name as prefix to prevent collisions.
2012-05-09EasyHack fdo#42783: get rid of CPU define/build system variableThomas Collerton
Change-Id: I6a178f7ff9c8306e15bcfa847ad1e5e4f8476504
2012-05-09gbuild: remove gb_Helper_abbreviate_dirs_nativeMatúš Kukan
Change-Id: I0a3ad6553692fc21eaf96cf35e9c343b4d716c21
2012-05-08sal: work around spurious signed overflow warningsMichael Stahl
gcc version 4.6.3 20120306 (Red Hat 4.6.3-2) (GCC): /rtl/string.hxx:1037:67: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow]
2012-05-04fdo#48253 Expand SAL_STATIC_CAST and SAL_CONST_CASTThomas Arnhold
Change-Id: I50f0887ceb4517d7ef234f970ca2ba679d533382
2012-05-02Related: fdo#49208 implement operator== with faster equalsCaolán McNamara
we have an optimized equals which checks that the strings being compared for equality share the same underlying pImpl, but out operator== implementations don't use it! Change-Id: Ie5c464494ff875315a5ca369a2da80c22c29f431
2012-04-29make gbuild the default assumption of build.plBjoern Michaelsen
this removes dmake completely out of the build for migrated modules build.pl now assumes modules to be gbuild, unless there is a prj/dmake file Change-Id: I674a036b182ee13c5ec093e83cb3d38133112d3b
2012-04-28Bin the unused vague SAL_IMPLEMENT_MAIN_WITH_GUI ideaTor Lillqvist
Change-Id: I66dae812f3aea0534907316a7fb41b35ad37be48
2012-04-26improve error messageMarkus Mohrhard
2012-04-23doxygen warning fixesLuboš Luňák
2012-04-19Revert "Remove unnecessary hack on Linux by using pthread_mutexattr_settype"Arnaud Versini
Build error on tinderboxes.
2012-04-19Remove unnecessary hack on Linux by using pthread_mutexattr_settypeArnaud Versini
2012-04-19Removed obsolete commentStephan Bergmann
2012-04-19clang warning for osl_detail_ObjectRegistry_getMutex() in the .cxx file tooLuboš Luňák
2012-04-17More informative warning messageTor Lillqvist
2012-04-16Recognize unoexceptionprotector and unobootstrapprotectorTor Lillqvist
2012-04-15fix ambiguous call on windowsMarkus Mohrhard
2012-04-15autofill increment needs a bit more tolerance, fdo#37424Markus Mohrhard
2012-04-13WaE: initialization orderMichael Stahl
2012-04-13push and pop protectors around runner run, hopefully fixes windows buildCaolán McNamara
2012-04-13setup/teardown default component context once before/after all testsCaolán McNamara
avoids the problems of dangling uno singletons invalidated after the first dispose and the chain of other singletons that don't expect to need to re-initialize, etc. reenable editeng cppunit test inherit i18npool cppunit test from unotest base drop LibreOfficeProtector, do "throwable" work in setUp/tearDown not in ctors/dtors
2012-04-13WaE: unknown warning group '-Wreturn-type-c-linkage'Tor Lillqvist
2012-04-10make OSL_ASSERT print the failed expression, not just "OSL_ASSERT"Luboš Luňák
2012-04-10disable clang warning about something that cannot be fixed without BIC changeLuboš Luňák