summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2016-03-29tdf#93548 Refactor sal signal to reduce code duplicationAleksas Pantechovskis
Change-Id: Iff331a48fadc23da8b24f9ca3a841000313a03dd Reviewed-on: https://gerrit.libreoffice.org/23477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-29handle failure to expand ~ in path elements.Michael Meeks
This can occur in some online corner-cases. Change-Id: Id8b419179d775a21110d682ba76d8a02f45eb828 Reviewed-on: https://gerrit.libreoffice.org/23577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-29sal: re-enable most getSystemPathFromFileURL tests.Michael Meeks
Change-Id: If03ec4f8705b75b9d007078260ef8cca5155a8f3 Reviewed-on: https://gerrit.libreoffice.org/23576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-22tdf#84323: Make osl::Thread::wait more readableGurkaran
It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16Remove code that has been commented-out for longTor Lillqvist
Commented-out in a198aa60a9d346128043e3e65ae82bb8ff670272 in 2005. Change-Id: Id174dae6632fa8d8e9845b06b916a8515cd6acf3
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-11Better fix for -Werror=shadowStephan Bergmann
Change-Id: I2dff3eeef6e9d2bcf089f054475c164c8c641941
2016-03-10-Werror=shadowStephan Bergmann
Change-Id: I82d2d44fd43ff2a641df74b9e05aea01991d001c
2016-03-10Remove unnecessary typedefs (that introduced reserved identifiers)Stephan Bergmann
Change-Id: I42d09cccf07dca6733f763b1026f6c138cb70a61
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I309985d65752c4aa041cdb7c060c32d4312d442d
2016-03-10Remove unnecessary typedefs (that introduced reserved identifiers)Stephan Bergmann
Change-Id: I726ca611cce66d7e25dc91b8baaec7e588eb1b8e
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I074b5c4b9caec0a1c22f36e153a84104c5187e91
2016-03-10Drop __osl_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann
Change-Id: I725783d10bc1e6300c480542c536d409433ff532
2016-03-10Drop __osl_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann
Change-Id: I68e51e09ffea9328034254b694b01082dbb4e3bd
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: If19a3029bd7d312e40eead77856fb705d12b5fc6
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: I29c643a972c10f22328022b66c57c6b86f748cfe
2016-03-10Rename _imp_get/setProcessLocale (avoid reserved identifiers)Stephan Bergmann
Change-Id: Iab013039d3f99ee06efc1556b768f16ec8bcee2a
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: I6d60bbf938a5e609efeb56d9c7650e83dd9bbbdb
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: I2b8e5e4736fab924c02fca81aabb37c4e2361265
2016-03-10Drop __rtl_random_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann
Change-Id: Ibb7e6fc2a0fdc357e31f02d8b88e6d3c0ae02f44
2016-03-10Drop __rtl_digest_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann
Change-Id: I9baa60e56cc1f0086218f1ee633e0041436a8f2a
2016-03-10Drop __rtl_cipher prefix from static entities (avoid reserved identifiers)Stephan Bergmann
Change-Id: I4f72ded322d563c6d429e0cfbf4120e4faa85c98
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08tdf#98407 PathSubstitution: Add substitution for $(username)Samuel Mehrbrodt
This allows to use the username as a placeholder in the config paths (Autotext, Gallery, etc) Change-Id: I76434e980cd8ec8785a5587d0bc5fdd67dc42de2 Reviewed-on: https://gerrit.libreoffice.org/22901 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07sal: UNX: in oslDoCopy, rename into destination directory ...Michael Stahl
... not into the source one as that will likely fail with EXDEV if source and target are on different mounts => osl_File_E_EXIST. This broke the xmlsecurity test SigningTest::testOOXMLAppend(). Change-Id: I07ada1d5564fd72a059d588e127a5906a499aca4
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-04Work around -Werror,-Wunused-macros with clang-clStephan Bergmann
clang-cl as-is does not provide the intrinsics provided by MSVC; you need to explicitly include Intrin.h (provided by clang) for that. So, as a hack, specify CC/CXX as clang-cl.exe -FIIntrin.h ... to have the intrinsics always available. But Intrin.h includes stdlib.h, so by the time sal/osl/w32/random.c defines _CRT_RAND_S before including stdlib.h, the latter has already been included without _CRT_RAND_S support. So, as a second hack, specify CC rather as clang-cl.exe -D_CRT_RAND_S= -FIIntrin.h ... But then clang-cl starts to emit -Werror,-Wunused-macros, as defining _CRT_RAND_S in the main file has no effect here. Change-Id: I5dfe9872dea7e8eb476d9260f17ab8d8893f48af
2016-03-04Use existing "sal.osl" log areaStephan Bergmann
Change-Id: I7d48c1543b0d3239c8e646ca0765421f933cfecc
2016-03-04Probably better to not disable this cache in all debug modesStephan Bergmann
(f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals" had changed it from OSL_DEBUG_LEVEL > 1 to > 0) Change-Id: I40714993fb55ec27b80d225cec28c64f2959ab73
2016-03-04Spurious spacesStephan Bergmann
Change-Id: I60bb1e303f7a26b4324cccf2858258a375b53f34
2016-03-04This is test code, OK to unconditionally print to stdoutStephan Bergmann
...and where appropriate use CPPUNIT_ASSERT_EQUAL to have no need to always print out certain values Change-Id: Iad2ccb235b09852fffd3f010cf069c45b36e2d4b
2016-03-04This is test code, OK to unconditionally print to stdoutStephan Bergmann
Change-Id: I419aba8728b3a65fca69c82a4f950daaf4815187
2016-03-04Remove write-only g_nSocket* debug varsStephan Bergmann
Change-Id: Ie8a1d015242450094928863013030b4cb0bb1f4e
2016-03-04Clean up a SAL_WARN_IFStephan Bergmann
Change-Id: I8a945f3e83559f421aa1a0b4fbfcec1b25932ef7
2016-03-04-Werror,-Wunused-macrosStephan Bergmann
Change-Id: I5402d52ec42fa27c58b276eeb22eeb270c3d7948
2016-03-03tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
Change-Id: If329cf8257684e7bd2936641b8f14ec3e9b9f733 Reviewed-on: https://gerrit.libreoffice.org/22647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-03sal: replace boost::bind with C++11 lambdasMichael Stahl
Change-Id: If8e16b7805b5b25dafe053e35cd98079abbea83c
2016-03-02tdf#98210 do not require R_OK for pipe dirHank Leininger
Also better error handling if pipe dirs are really not usable. Change-Id: I1c865b9a9f1f08d2cffd07343494feca585ec75e Reviewed-on: https://gerrit.libreoffice.org/22727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-21WaE vs2015: pointer to int castingNorbert Thiebaud
Change-Id: I3be393ef5a9d1ed732f44037cd1115960a6186d2 Reviewed-on: https://gerrit.libreoffice.org/22592 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-21WaE vs2015: int to pointer castingNorbert Thiebaud
Change-Id: I201e4b44e2a26ff0566f30c7e7c12c0df90a54e6 Reviewed-on: https://gerrit.libreoffice.org/22591 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-19tdf#97703 Removed a few redundant calls to setUp and tearDownJaskaran
Calls to CppUnit::TextFixture::setUp and CppUnit::TextFixture::tearDown have been removed. I hope that saves a few milliseconds of build time :) Change-Id: I611db2f5c5673ab86bf8f92beb4f6e8a70443b34 Reviewed-on: https://gerrit.libreoffice.org/22496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-18coverity#1352316 Explicit null dereferencedCaolán McNamara
Change-Id: Ieb80209e0254080bf78fb3b5201b849d7d30880c
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-16coverity#1352448 Use of untrusted scalar valueCaolán McNamara
and coverity#1352449 Use of untrusted scalar value I suspect this will fix the warning, given that "Casting narrower unsigned pBuffer[i] to wider signed type short effectively tests its lower bound", so if we pass it though as-is we probably quieten these Change-Id: I2ece08f7301f5d548d905d221e5a6af0da51a2bb
2016-02-15Rename rtl::isValidCodePoint -> rtl::isUnicodeCodePointStephan Bergmann
...and fix its documentation, and use it throughout the code base. Change-Id: I349bc2009b1b0aa7115ea90bc6ecd0a812f63698
2016-02-11Avoid duplicate declarationTor Lillqvist
The same extern declaration is already in alloc_impl.hxx which the source file includes earlier. Change-Id: Idacadc8cf938d88892c99b1af3723c52fcae5298
2016-02-10loplugin:nullptr, loplugin:overrideStephan Bergmann
Change-Id: If4500b8b41915a05a2bfb2c776259f49ad9bfc85
2016-02-10Add existing CppUnit test for sal/rtl/randomChristoph Brill
The tests itself already existed, we were just missing the .mk file Change-Id: I662eba5d955aa5cbd774dbb3b4c9f9010dc1d7d6 Reviewed-on: https://gerrit.libreoffice.org/22249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>