summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2013-09-28General cleanup in sal module for all and unix.Arnaud Versini
Remove useless comments and header, and de duplicate a small declaration. Change-Id: I0d4475cbbd61ea964f8e586cf0e1f68eb91c4948 Reviewed-on: https://gerrit.libreoffice.org/6016 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2013-09-26malloc returns void*; must be cast to real ptr typeDavid Tardon
Change-Id: Ic19707b99b1a53005ac319887219fc52b3e60e89
2013-09-26typo fixes in commentsAndras Timar
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-22sal: rename "cppunit/cppunittester" executableMichael Stahl
... and put it in OOO layer since it's used by the smoketest instset. It was in subdirectory for hysteric reasons, to pick up libraries from module local output directories in the dmake build system. Change-Id: I73b66672b17ede52c03071eb2ddee1a23c059ea9
2013-09-22gbuild: remove libraries from OUTDIR and WORKDIRMichael Stahl
Refactor everything to find and link libraries directly in INSTDIR. - add gb_LinkTarget_get_linksearchpath_for_layer, and use it to set up -L paths for T_LDFLAGS in such a way that only allowed libraries can be linked against; i.e. it's not possible to link URE linktargets against OOO or not-installed libraries - gb_Library_get_target is now same as the gb_LinkTarget_get_target (TODO: this needs cleanup) - since a pattern rule won't work for linking libraries in INSTDIR, add a separate per-file rule for every INSTDIR lib - pattern rule can't find link target in the clean target any more so add a LINKTARGET variable - disable gb_Library_add_auxtarget, no auxtargets need to be copied - tweak the call to gb_Library_Library_platform to pass in a path in sdk/lib for the versioned URE libs - fix the Library clean target - add LAYER parameter to gb_LinkTarget_LinkTarget - adjust platform link commands - MSVC link command now uses explicit -manifestfile and -pdb parameters to keep misc. files out of INSTDIR - remove gb_Helper_OUTDIR_FOR_BUILDLIBDIR - adjust Extension, CppunitTest, JunitTest, PythonTest, Gallery, various CustomTargets to search INSTDIR - remove SDK library symlinks and import libs from odk/Package_lib - on Mac OS X, put .dylib symlinks into sdk/lib even though those are not packaged and would be created by the SDK configury; we need these to be somewhere for linking anyway - add a (unfortunately cyclic) dependency on Package ure_install to sal Change-Id: I70d88742f8c8232ad7b9521416275c67b64fe6cf
2013-09-22gbuild: make the versioned library the linktarget on UnixesMichael Stahl
If there is a SOVERSION then the versioned library is a real file and the unversioned one just a symlink; better to have the real file be the target. - add gb_Library_UDK_MAJORVER variable for SOVERSION - remove version parameter of gb_Library_set_soversion_script; instead hardcode the SOVERSION since it must be included in the file name in gb_Library_FILENAMES anyway - store the unversioned symlink in the ILIBTARGET variable - via new gb_Library_get_workdir_target_versionlink function - removed gb_Helper_install call that resulted in both versioned and unversioned libs in instdir Change-Id: I2c6f1698f0e39fdb2c07964d43ed9485cbca0b30
2013-09-17Revert "fix-linkoo.diff: Fix linkoo to work again."Matúš Kukan
This reverts commit 904e5801aea86a79d6256fcbc3cfdba4535ca8a9. We don't use linkoo and SAL_ALLOW_LINKOO_SYMLINKS anymore. Conflicts: sal/osl/unx/file_url.cxx Change-Id: I1a0211295afef79f72356677d9b3bc6c5211d496
2013-09-12WaE: unused variable suToken, aEmpty, aEmpty2.Andrzej J.R. Hunt
Change-Id: I2eaa32e0ec09b239e03d3efa776f5b47c2fb5c6d
2013-09-11CID#707531 silence coverityCaolán McNamara
Change-Id: I7fd4b5684cd5d54860c60fdb00ac2431943eece3
2013-09-11-Werror,-WformatStephan Bergmann
Change-Id: I24a060d1d5592a23f9a991ef3b39f31818ea0d84
2013-09-11fdo#39625 Make existing cppunittests workJelle van der Waa
Change-Id: Ia3a59456fe82926141ccb2921aa47df4183ead86 Reviewed-on: https://gerrit.libreoffice.org/5905 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-11typo fix: wether -> whetherAndras Timar
Change-Id: Iad4182d7150f851df06a7208a811d482351f736a
2013-09-11-Werror,-WformatStephan Bergmann
Change-Id: Iae7da0146c670d77a4bdc2431a55c901318eef8d
2013-09-11sal: fdo#39625 Make existing cppunittests workJelle van der Waa
Change-Id: I6bd34f0deaf246bc5898532377d996fcefc88cbc Reviewed-on: https://gerrit.libreoffice.org/5906 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-07Remove confusing casts between synonymsLionel Elie Mamane
oslMutex and oslMutexImpl* are synonyms (via two typedefs). Casting between them makes the reader believe some more nefarious trick is at hand. Change-Id: Ib0e609fd1facca4d47242392ed2f8ff08451346b
2013-09-05update pchThomas Arnhold
Change-Id: I6d5e8d3fd69189935a3338fee19b60022f70a7eb
2013-09-03dezimal -> decimalJesús Corrius
Change-Id: I196026cc7f2f885664e9719557f662a32a7187b8
2013-09-03Don't compile all of the sal library as Objective-C++ on OS X after allTor Lillqvist
I doubt it affects ABI, but let's not take the risk. Instead, just compile the uunxapi.cxx file (which has no public API) as Objective-C++, as that is now the only one where Objective-C API is used. This reverts part of d22c94dbf16d18bce39f060aa21f3083169426ca Change-Id: I240dbb36529c419b81b062f6fe860a9e621c2400
2013-09-02MacOSX 10.6 does not like id as a variable nameNorbert Thiebaud
Change-Id: Id1029f777e4f1d03ce7d3fb85ced38deeefca619
2013-08-30WaE: C4334: '<<' : result of 32-bit shift implicitly converted to 64 bitsTor Lillqvist
1UL is not a portable way to get a size_t -sized one. Change-Id: I8fac16b7e1f1b8bbccb4bd11eacc9449fc3f8c33
2013-08-30WaE: possible loss of dataTor Lillqvist
Change-Id: I2a1d47cc3eca40ddd7e9502ffe71337ab2268858
2013-08-27fdo#67313: Use "lo" suffix for private URE libsStephan Bergmann
...(like is done for most of LO's non-URE libs already) to reduce likelihood of name clashes, esp. on Windows where URE libs are found via PATH. This introduces PRIVATELIBS_URE, and removes now-unused UNOLIBS_URE. Change-Id: Ib95dd45f18de140a54e62d632dbf2239f83c232e
2013-08-26Use strncmp()Tor Lillqvist
Change-Id: I593ce24ce83cd3034d23297adc3de5f6de18f3a9
2013-08-26Be careful not to access a string out of boundsTor Lillqvist
Change-Id: Ibc43ffa0c535e0baf1bb6d8b213320da345a3d65
2013-08-25Fix "Save As" when sandboxed on OS XTor Lillqvist
Change-Id: Ibe2ea21265a0bb9c4fedcef137626df2a8019116
2013-08-25TypoTor Lillqvist
Change-Id: Icfb6c58d8a73e45d7d9c5629ac0d808f7afcf9ff
2013-08-25More work on a sandboxed LibreOffice on OS XTor Lillqvist
In particular, surround also the ftruncate() operation that osl_setFileSize() does with access through a security scope bookmark for the file, if available. This fixes file saving in a sandboxed LibreOffice. (But oh boy, does simply saving an ODT document go though a weird dance of file operations.) Luckily the C++ oslFileHandle abstraction keeps the pathname that the file was opened with, so even if ftruncate() as such takes only the file descriptor, we can get at the pathname to retrieve our security scope bookmark. Change-Id: I8acb1b2f3fb3ec0cea833697b7f1d4a1912ed551
2013-08-25Switch from OSL_TRACE to SAL_INFO()Tor Lillqvist
Change-Id: I2222a8db929e2f17aff9f72ff2ae1ca6e081e576
2013-08-25Do more syscalls using a security scope bookmark on OS X when sandboxedTor Lillqvist
Move the handling of the bookmarks to the wrappers in uunxapi.cxx, and add wrappers for open() and utime(). Change-Id: I92f9941152b567545eea60f2aaae6a3b8d35e792
2013-08-24A slash is a slash, a dot is a dotTor Lillqvist
Bin pointless abstraction. Change-Id: I193842dff5a86f58f53827712e2f16f6bdd83c3d
2013-08-24Bin "temporary hack" code that has been commented-out since 2002Tor Lillqvist
Change-Id: If228820b35927d24a1ae2e19c184767a447f829b
2013-08-24Simplify osl_getSystemPathFromFileURL_Ex()Tor Lillqvist
It was always called with the bAllowRelative parameter as false anyway. Change-Id: I6c4bf739e3f8c1d52dbe8af5df13e97dc9be96e5
2013-08-24Remove function that has been commented-out since 2000Tor Lillqvist
Change-Id: I18ed3ba6f1567ec40f3a87d988863680c55f665b
2013-08-24Cleanup some weird or inconsistent indentaion and bin some pointless commentsTor Lillqvist
Sometimes one just can't resist. Change-Id: I3550f30cc206e2efe361a669b4f8e740d9c3c339
2013-08-24Bin line of code commented out since 2009Tor Lillqvist
Change-Id: I89c2cf3c82617bada72053678a6fb6013bfbca13
2013-08-23Bypass the alias resolving completely when sandboxedTor Lillqvist
Attempting to look up the bookmark data for a file will try acessing its resource fork, causing messages like: soffice(83685) deny file-read-data /Users/tml/Documents/b.odt/..namedfork/rsrc Change-Id: I1b2b0b493a46aa629581b921c94c5014f994e75c
2013-08-23Make our File>Recent Documents work better when sandboxedTor Lillqvist
Store security scope bookmarks for files selected in the file picker in the user data. (I looked into storing it in the LO "registry" in the Histories/PickList thingies, but that was horribly complex.) When opening a file, if we have stored a security scope bookmark for it, use that while opening the file. Change-Id: I347ae2dd815299441c17467d9b66a226061d0ed2
2013-08-23fix hex escape sequenceCaolán McNamara
Change-Id: I8bc9d3812977589e96f5440afa8d46bfe4d3b88e
2013-08-22Various undefined behavior involving signed integersStephan Bergmann
as flagged by Clang -fsanitize=undefined Change-Id: Iff1aa4473d960009890b923fba734257ecd8b3ef
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21osl_getThreadIdentifier(0) -> osl::Thread::getCurrentIdentifier()Stephan Bergmann
Change-Id: Ida9785c4b9fda0459769957734952e69d7a9de44
2013-08-20rtl::compareAsciiIgnoreCase cannot be used hereStephan Bergmann
...as its assert requires that both input characters are ASCII, which need not be the case in these compareIgnoreAsciiCase functions. (Even if they take one literal argument that must be strictly ASCII, the other argument can be an arbitrary Unicode string in the case of OUString or an arbitrary 8-bit string in the case of OString). The logically correct version of rtl::compareAsciiIgnoreCase would arguably be one that requires its two arguments to be valid UTF-32 code units, but that could not be used in these places either, as for OUString they operate on individual UTF-16 code units. rtl::compareAsciiIgnoreCase likely makes less sense after all than assumed in c8e39e66528affb66f1ae121fa36dd4ab31a9b0b "Introduce rtl::compareIgnoreCase and deprecate rtl/character.hxx equivalents," which this commit partly reverts. Change-Id: Ib2eed3a1896e83d9c66b0479a03f9ec51e1c4dc0
2013-08-19Introduce rtl::compareIgnoreCase and deprecate rtl/character.hxx equivalents.Arnaud Versini
Change-Id: Id90935fd2b0f904f89477792edc8140cfc31e91f Reviewed-on: https://gerrit.libreoffice.org/5412 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-19Rename SOLAR_JAVA to ENABLE_JAVA and HAVE_FEATURE_JAVATor Lillqvist
Change-Id: Ib451bdb3c1c2ca42347abfde44651d5cf5eef4f3
2013-08-18Use subfolder names from <config_folders.h>Tor Lillqvist
Change all instances of hardcoded "program", "share" etc subfolder names to use those from <config_folders.h> instead. In normal builds, the end result will not change. Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-08-18Bypass the O_NONBLOCK resetting for now when sandboxed on OS XTor Lillqvist
The fcntl fails. Will have to check later whether we should also drop using O_NONBLOCK when opening then. Change-Id: I529a4d728563eb323e35487782f7fee88b2faa0c
2013-08-15Mark as constTakeshi Abe
Change-Id: Ic7ee570935b5d827dc01a483877ea5021da5abea
2013-08-08Add SDT probes for interning rtl_uStrings.Mark Wielaard
This adds RTL_LOG_STRING_INTERN_NEW and RTL_LOG_STRING_INTERN_DELETE which are connected to SDT probes if available. It introduces two new SDT probes. new_string_intern_16 and delete_string_intern_16 (there is currently no interning for 8-bit rtl_Strings). For consistency both have the same 4 arguments as new_string_(8|16) and delete_string_(8|16). new_string_intern_16 has as 5th argument the address of the original rtl_uString being interned (which may or may not be the same as $arg1). Change-Id: Ib117bba932c1908abc70a7fdd4140c0af76d54cb Reviewed-on: https://gerrit.libreoffice.org/5308 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-03Add SDT probes for RTL_LOG_STRING_NEW/DELETE.Mark Wielaard
Change-Id: I938259f90aee9d277c9ff5b72c9120b93311cbd3 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-08-02CFErrorRef is apparently not always initialized by the calleeNorbert Thiebaud
on 10.6 SDK this coredumped in some case in CFRelease(cferror) Maing sure that cferror is initialized to NULL avoid the problem Change-Id: I5624416867670bfd4c8db9b35e3b3d37494f79fd