summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2014-02-10Do not do RTL_LOG_STRING_NEW on null pointerStephan Bergmann
Change-Id: Ie972599650620324fa7af5ed2b2843bfc1f34c43
2014-02-06typo fixes in commentsAndras Timar
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06Typo: seam(s) -> seem(s)Julien Nabet
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
2014-02-06coverity#705403 Argument cannot be negativeCaolán McNamara
Change-Id: I0cf67a4bd5ec95e135511611c236350d4347895e
2014-01-28bool improvementsStephan Bergmann
Change-Id: I7ae2b02e435d21390843c6c56877a8ce3a73f9f2
2014-01-28Apparently missing "== nError1"Stephan Bergmann
Change-Id: I9096e00db4c94b318406b022f675bb866f568d7e
2014-01-28coverity#440521 Dereference before null checkCaolán McNamara
Change-Id: I653b78d9404764d1c89d11154fd8e6a767df9cb0
2014-01-28coverity#440520 Dereference before null checkCaolán McNamara
Change-Id: Id0e2c8e5579ae81c368cf886e52c8306f271c067
2014-01-28coverity#440519 Dereference before null checkCaolán McNamara
Change-Id: I78cfe1a807e59d63dc22fbec8bcadfa7596d5a96
2014-01-28coverity#440517 Dereference before null checkCaolán McNamara
Change-Id: I9c09333d0879ba8dc9ef8c4cb2c1d9f0b3654d45
2014-01-27coverity#982254 Same on both sidesCaolán McNamara
Change-Id: Ibb3b8b4a3f29b46ada9824f7c7d15a0d87d60e23
2014-01-27Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Change-Id: Ibf43c5ded609b489952e1cc666cac1e72ffa2386
2014-01-25coverity#440167 Dereference after null checkNorbert Thiebaud
Change-Id: I05bb7592600ab157d7a5e9dc6280168519d7b5bd
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-13Handle osl_createThread failureStephan Bergmann
Change-Id: I58144461d3941359f8ea6c2bd547486b2c8ae81a
2014-01-10Use boolStephan Bergmann
Change-Id: I46c30a62fb39c2223a369f91010a860372efc72f
2014-01-10Use boolStephan Bergmann
Change-Id: I12f0a6331c435c1eac692e5c20a173ce84830290
2014-01-10Use boolStephan Bergmann
Change-Id: I4349f4560ca34610351f4f07ff6e406e09b488e7
2014-01-09some notes about COM threading in LO generally and winaccessibilityMichael Stahl
- document general COM threading architecture in vcl README - document winaccessiblitiy locking in README - define _ATL_APARTMENT_THREADED for UAccCOM Change-Id: I7c3fd952f2cdee7d245a818bf33c477e7ea20fc2
2014-01-09sal: remove OSL_ENSURE_FILE, better use SAL_LOG/SAL_INFOMichael Stahl
Change-Id: I43d77cbf572acc4c27785990e28b43b35d71c96d
2014-01-09Bin duplicate definitions (already in file_error.h)Tor Lillqvist
Change-Id: I82628046e8a40d45b0e711079e1cab9be89d69a9
2014-01-07remove unnecessary sal_Unicode casts in OUStringBuffer::append callsNoel Grandin
Convert code like: buf.append( static_cast<sal_Unicode>('!') ); to: buf.append( '!' ); Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2013-12-23TyposJulien Nabet
Change-Id: I27ada8b5154968e521d9e67f21473aa85776e70e
2013-12-21Print file and not pointer value in SAL_INFOTor Lillqvist
Change-Id: I96e7ac419f4300a1dd62a5c24611c1467ef3b19a
2013-12-20Spelling correction: s/retrive/retrieve/Tor Lillqvist
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-19Fix crash on AndroidTor Lillqvist
Fallout from 0e6a2601b39cbadaff7f7506ba9e804f108060db ("Convert code that calls OUString::getStr()[] to use the [] operator"). The code was a bit silly and "hand-optimized" in the first place so no wonder a bug was introduced accidentally in that commit. Make it simpler and more obvious. Change-Id: Idafb1c0741289e915dfbaa108383a926321764d2
2013-12-17fdo#72598 Remove SunStudio cruft from code baseJelle van der Waa
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc Reviewed-on: https://gerrit.libreoffice.org/7104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-16fdo#72598 Remove SunStudio cruft from code baseJelle van der Waa
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4 Reviewed-on: https://gerrit.libreoffice.org/7103 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-13fdo#72598 Remove SunStudio cruft from code baseJelle van der Waa
Change-Id: Ia6799c852eb95d496fbc8dcfdabde62dffc263a6 Reviewed-on: https://gerrit.libreoffice.org/7066 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-04HINSTANCE vs. HMODULE clean upStephan Bergmann
Change-Id: I6fc350f489863ec86c76822053f0a399cef5cd7f
2013-12-02Drop duplicate #includeTakeshi Abe
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
2013-11-27Unwind occurrences of deprecated sal_sChar, sal_uCharStephan Bergmann
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
2013-11-26No need for additional << overload hereStephan Bergmann
...non-explicit OString(rtl_String*) ctor already covers that Change-Id: I9e447795ddc585d765b48d1f7f41f3c795aecba2
2013-11-25WaE: C4100: 'pExcPtrs' : unreferenced formal parameterTor Lillqvist
Change-Id: Ic580c625c78802087a32f8669feec91fe79672cd
2013-11-25Related: #i123747# ignore single step and breakpoint SEH eventsHerbert Dürr
(cherry picked from commit 2a0a1e41bcca97caaf3fdfb375f5cebb330a0fcc) Change-Id: I107a73ad001647eeb25b44e521251ef9543cc83a
2013-11-25Resolves: #i123747# allow treating Window's SEH events as C++ exceptionsHerbert Dürr
The crash reporter facility can provide much better details about crashes. But if that facility is disabled then handling SEH events such as div-by-zero as C++ exceptions is a worthwhile alternative. It can provide a few interesting details and it allows a graceful shutdown of the application. (cherry picked from commit c9d10b167b37a9cb0bb310cafc8e80b6cce8ea7a) Conflicts: sal/osl/w32/signal.cxx Change-Id: I25324d6e02ab8acd8fd2b036b77039aac87cf262
2013-11-24this script talks about dmake. it must be out of its mind!Bjoern Michaelsen
Change-Id: Ic1863a2126c26cf703afc5fe250dea2bbddfef7d
2013-11-22remove unnecessary RTL_CONSTASCII_STRINGPARAMNoel Grandin
A final pass through the code, converting code to use the new OUString and OString methods that can detect string literals. Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-20Windows: Require at least Windows XP SP2Thomas Arnhold
* Windows XP SP2 is 0x0502, see http://msdn.microsoft.com/en-us/library/aa383745.aspx * If a module changes the Windows SDK version setting, this is done module wide now. So the overall behavior is as before. This seems to be the best compromise for now. * We need at least SP2 because of the bluetooth stuff used in sd/source/ui/remotecontrol. * Now, we require at least Internet Explorer 7.0. IE6 has been outdated for a long time. * Leave StdAfx.h file definitions, as those are Microsoft project specific precompiled header files. * All local definitions of WINVER are removed, because the global WINVER setting makes them obsolete now. To the relation of the three macros: Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION automatically to the same value as _WIN32_WINNT. WINVER and NTDDI_VERSION can be set idenpendently each for itself. Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb Reviewed-on: https://gerrit.libreoffice.org/6496 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString constructorNoel Grandin
Convert code like: OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OString aKeyName("NDX"); which compiles down to the same code Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii callsNoel Grandin
Convert code like: aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" )); to: aStrBuf.append( "ln(x)" ); which compiles down to the same code. Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-17bugs.freedesktop.org -> bugs.libreoffice.orgAndras Timar
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-14Use rtl::StaticStephan Bergmann
Change-Id: I391e027b2567c4239c1d02e132c6508b3f49d381