summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2014-10-16MAC_OS_X_VERSION_MIN_REQUIRED is always >= 1080 nowTor Lillqvist
Change-Id: I40d03ab9acb67ab72b9047017452f069ce88fd4b
2014-10-16MAC_OS_X_VERSION_MAX_ALLOWED is always >= 1080 nowTor Lillqvist
Change-Id: Ieae67cbf917cdf4bca2b0d6c1697eddc6137dbe2
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15cppunittester: make tracking down temp file leaks easierMichael Stahl
Temp files created before first test method don't see LO_TESTNAME Change-Id: Iff74abf574f5151980f463646f11c1b32ad0c241
2014-10-14Remove spurious cpu_countStephan Bergmann
Change-Id: Ic90e806d279f8180d78f78597dbc549264338295
2014-10-14sal: cleanup unit tests whitespace.Michael Meeks
Change-Id: If067f755b99480b7b7bd0bd3bb7a71a447794273
2014-10-10coverity#1240258 Operands don't affect resultCaolán McNamara
try and silence coverity#1240258 Operands don't affect result and coverity#1240255 Operands don't affect result Change-Id: If53ff385585567e9b46372f45420c4321811bca0
2014-10-10coverity#1240260 Operands don't affect resultCaolán McNamara
see can we silence these false positives coverity#1240259 Operands don't affect result coverity#1240254 Operands don't affect result coverity#1240264 Operands don't affect result coverity#1240267 Operands don't affect result Change-Id: Ieca40474c231e33a516b70f7693346ac73babd61
2014-10-09More specificStephan Bergmann
Change-Id: I7e6490c5b50a236a5f070e98d4501e7dd5a90307
2014-10-09disable environment equality test under valgrindCaolán McNamara
Change-Id: I9e0e06331f134fe89c9942f93b7546b0e67bb821
2014-10-08Document how rtl::Uri::convertRelToAbs normalizes an absolute URL's pathStephan Bergmann
Change-Id: Ibf4f2d46bfbb977f0ba27110d86d7b7f1173631c
2014-10-03fix buildCaolán McNamara
Change-Id: I997dfa3b1fe651db56ad2a6a24ec0cb6d5044550
2014-10-03fix clang 3.5 buildNoel Grandin
Change-Id: I86fe850b4b7bc8fc4c44717ca813772114ca70ff
2014-10-03coverity#1241327 Dereference after null checkCaolán McNamara
Change-Id: I214884e9ee1d49dcc4db71f8744513468b912691
2014-10-03coverity#1241080 Dereference after null checkCaolán McNamara
Change-Id: I82113fcd4182f9557ba0e7258498b5d4e798bf03
2014-10-03Fix unbalanced new/free() -> new/deleteMatthew J. Francis
(Spotted while valgrinding an unrelated issue) Change-Id: I2eab4c08e251d79f427fd01442c4dce20d7d89f0 Reviewed-on: https://gerrit.libreoffice.org/11785 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-02remove checks of __GCC_MINOR__ that are always true in GCC 4.6 or laterMichael Stahl
Change-Id: I4412a0c1e4dee94cd717f24b8df5e257d895f721
2014-10-01We require OS X SDK 10.8 or newer nowTor Lillqvist
Change-Id: I68eee76c8710c89af8e3c1e1006345f908923ece
2014-10-01Blind fix for AndroidStephan Bergmann
Change-Id: If997720635f99726e14c00132308529f96e639c8
2014-10-01sal: work around spurious Apple clang warning about pointer cast to intMichael Stahl
Change-Id: I4e4281ac8767c9a6b6b85bc759f28bcf074d8e39
2014-10-01Use sal/log.hxxStephan Bergmann
Change-Id: I54fd66b8788171884c6d3d6e7645871615d48080
2014-10-01sal/osl/unx/thread.c -> .cxxStephan Bergmann
Change-Id: I6cb46a51dda3fda51a3b6413656da15fc5bdb04d
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30Get rid of some auto_ptrStephan Bergmann
Change-Id: Icd477e433f0c294c823c64147d49fb4ac6bfb447
2014-09-29Pretend the app-specific "Documents" directory is the home directory on iOSTor Lillqvist
Change-Id: If8fda4b27adb2f83cbdfdbb20d90ced77e467a54
2014-09-24fdo#39625 Delete unused cppunittestsTobias Madl
As discussed with Stephan Bergmann, these files, which contained unused cppunittests, could be removed. Change-Id: I91844b96967e3c3e0e8367452f2dda420f479ffe Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-17The URE unorc is now set up in instsetoo_native/CustomTarget_setup.mkTor Lillqvist
So no need to expand it at configure time in ure/source/unorc, and no need to handle the related builddir!=srcdir complications. Change-Id: Ifa34d25fab9ad2da13ed039bf6c5921b0fb58703
2014-09-11sal: create threads on Linux with a larger stack for ASANMichael Stahl
The default on Fedora 20 is 8MB, which causes stack overflows from CPython code in some of the JunitTests when built with clang 3.4 -fsanitize=address. Change-Id: I3de9975564aad668e746cea74ae10931ef36a608 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10Typo: (N|n)ormaly->(N|n)ormallyJulien Nabet
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-09Make the "Mac-like" or "canonical" app bundle structure always used on OS XTor Lillqvist
In other words, only executable files go in the MacOS folder. Dynamic libraries and bundled frameworks (i.e., LibreOfficePython), and nothing else, go in the Frameworks folder, and all other files go in the Resources folder. Especially, note that Java class files and rc (.ini) files also go in Resources. Such an app bundle structure is what Apple strongly suggests one should use, and it has been hinted that future versions of code signing and/or Gatekeeper will require such a structure. There is still some ugliness thanks to traces of the historical separation of URE from "the office". Like there are two separate "unorc" files, one for URE, one for the LibreOffice application. IMHO, this should be cleaned up, but is probably controversial. (Eek! I now see there are actually *three* unorc files in the app bundle. Not intentional. Need to fix that later.) Change-Id: Idcf235038deb5b8e1d061734993e9f31869b7606
2014-09-04coverity#706611 Uncaught exceptionCaolán McNamara
Change-Id: I42bff46998b3d516161068af3d53bf92ee2f2b15
2014-09-03Missing include guardStephan Bergmann
Change-Id: I5a01e4e71e69824f23998d23fc0bea60ddb27cc2
2014-08-30Start of support for Android on AArch64Tor Lillqvist
The build does not get far before it runs into trouble in the GNU libstdc++ headers, though: android-ndk-r10/sources/cxx-stl/gnu-libstdc++/4.9/libs/x86/include/bits/opt_random.h:33:23: fatal error: x86intrin.h: No such file or directory Change-Id: I9d459c64980091ba8bf5b3d631d47342625f6be9
2014-08-25fix this C file for Microsoft Pascal compilerMichael Stahl
Change-Id: I08086caacb7abe0c85aeb184935b3f73666e9faf
2014-08-25set names on some UNIX-only threadsMichael Stahl
Change-Id: I4c247916256618312e7d98673d9db4d26e26fa39
2014-08-25set names on the Win32-only threadsMichael Stahl
Nice to see what weird threads are running. Change-Id: Ic9888aa3260d0aeb5858cde5415571ab23c75484
2014-08-15Don't do the security scope bookmark dance if not in a sandboxed processTor Lillqvist
No point in doing it in build-time tools like cppumaker which don't run as sandboxed processes. Just slows them down a lot, while cfprefsd consumes lots of CPU doing user preference lookups in vain for every file accessed through the uunxapi functions. Change-Id: I83e55a8e8d0c4f2c60c60ecad2c831e42c9e5bfd
2014-08-13WaE: Unreferenced function definitionTor Lillqvist
Change-Id: I1b5d3f881e82cea90fcc4e97c837251e340abffe
2014-08-13textenc: disable failing tests on Windows for nowThomas Arnhold
They were never working, at least since 65f82ca62922e2c487ba72b6d67ea7e3a03f8ebc Which changed some mappings, for example: -check( RTL_TEXTENCODING_IBM_437, RTL_TEXTENCODING_IBM_437 ); +check( RTL_TEXTENCODING_IBM_437, RTL_TEXTENCODING_MS_1252 ); But I don't know if that's the root of the problem. Change-Id: I09f640a6c92a782f99d79405aab5f5dd2b992c6d
2014-08-13warning C4706: assignment within conditional expressionThomas Arnhold
quite useful in this case Change-Id: I2f9a5ef8ea9faf7a1ce62bd9b4925b3f36b19d1a
2014-08-13update_pchThomas Arnhold
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-11"fixes" needed because ure/source/unorc is now expanded at configure timeTor Lillqvist
Argh, this is getting even uglier. We cheerfully ignore for now the theoretical possibility that the URE unorc used by build-time tools (i.e. the configure-expanded ure/source/unorc) could be different for HOST and BUILD (in case they use different --enable-canonical-installation-tree-structure), and use the HOST one for the BUILD tools. The right thing would probably be to construct the URE unorc in the relevant Makefile, like we do for fundamentalrc? Or then to just re-design the whole mess of rc files into some simpler (good luck). Change-Id: I654309503d0e696778910acadcbf2f6b90ffa02a
2014-08-08drop extra (David Tardon
Change-Id: Ib1b6abf7a2aca80e7206d792d31f2cdd0fbe3ff8
2014-08-08osl: kill check for ancient freebsd < 7 versionsRiccardo Magliocchetti
Change-Id: I082611edd88daae36181d62f9fc56b588630629b Reviewed-on: https://gerrit.libreoffice.org/10828 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-07move null termination outside ifdefs for both branchesCaolán McNamara
so the strncpy branch is guaranteed null terminated too Change-Id: I79df96d69633a4db76f865301690c7ce7533fce9
2014-08-07coverity#706155 Copy into fixed size bufferCaolán McNamara
Change-Id: Ib795dc1b64d908942a836d09bfcde9f19d318b1b
2014-07-31osl_areCommandArgsSet: ensure mutexes locked when accessing data.Andrzej Hunt
Change-Id: I6b1f10e74aafc47e5618290d92087563c60e3c49
2014-07-31sal_osl_process: fix "Parent and child environment not equal" for OSX <10.6Douglas Mencken
It fails with "assertion failed": - Expression: compare_environments() [osl_process.cxx:370] - Expression: compare_merged_environments(different_child_env_vars) [osl_process.cxx:428] Just disable it (yet) for OSX <10.6 as it's already done for Windows. Change-Id: I88e838481a25ee7e977512e33e23afa2b9d394ff Reviewed-on: https://gerrit.libreoffice.org/10641 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-07-28Include <algorithm> for std::minTor Lillqvist
Change-Id: I012027c38a6d2b06a4bb0cb53743d350b124ccf4
2014-07-24sal: avoid STL asserts in create_merged_environmentMichael Stahl
"Assertion failed: sequence not ordered" printed when running smoketest Change-Id: Id9b7541f43342adf62137718dc332c0187c32f57
generated by cgit (git 2.34.1) at 2025-01-19 14:23:01 +0000