summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2023-11-30sal: osl::File allow to create files in sandboxSzymon Kłos
"realpath" returns NULL for path which doesn't exist. Allow usage of non-existing paths if parent is allowed. This allows to successfully start the sandboxed kit. osl_setAllowedPaths will allow now to use: /foo/bar/nonexisting - previously it was ignored, is needed for LOK but /foo/bar/nonexisting/newlevel - still cannot be used isForbidden now checks parents of non-existing dir and assumes the same permissions, if parent doesn't exist - it tries with parent of parent, etc ... Change-Id: I1052747ca284d2f81dfd5c5fbf893936e7426220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160111 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2023-11-29sal: initial osl::File sand-boxing commit for Unix.Michael Meeks
Change-Id: If2c106fef9640499b82b5cf350cb5169beb219fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159838 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2023-10-06Revert "Fix iOS build breakages when building on macOS Sonoma"Caolán McNamara
This reverts commit 24d41f7e965ca0dab19bfde1570419c15508ee5d. Reason: pushed by mistake, not needed. Change-Id: I9f5278ab15687b8410fe6cfa8e0249531bd9f281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157645 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2023-10-06Fix iOS build breakages when building on macOS SonomaPatrick Luby
Change-Id: I347e48e9da69c8c9b15581a5afa5c61cdd1d380d
2023-02-24Add Emscripten ifdef to bootstrap_getExecutableFile()Tor Lillqvist
Change-Id: I15d31873a27ace544a76a64fe354edb97b144424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144039 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147563 Tested-by: Tor Lillqvist <tml@collabora.com>
2023-02-24Introduce lo_get_app_data_dir() for Emscripten, tooTor Lillqvist
And not just Android. Hardcoded to return "/instdir" to match what is in the emscripten_fs_image. Change-Id: I26d4ec5e02ec9900e35ca47f1565a13ad2b723b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144849 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147558 Tested-by: Tor Lillqvist <tml@collabora.com>
2022-12-19Fix the "Found char > 127" warning to check the correct charactersMike Kaganski
Change-Id: Ia4a713c8a5ddda11e9802cbc317dde9ff48b8fd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144026 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 15cce9806cff49d54a80b047dec33b021080d5cb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144429 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-04rtl bootsratp : use enum classArnaud VERSINI
Change-Id: Iea433a2a7be9b62f04b57883dbefaf25586f21d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-04osl : remove useless includesArnaud VERSINI
Change-Id: Ic350a924d3e5b58e8f1a60621edc701553d8cbab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-30We won't need Executable_osl_process_child for WASM in the foreseeable futureTor Lillqvist
Change-Id: I479b694cd1d02b39ad54deab8ba69b4eec64d7d4 Signed-off-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143489 Tested-by: Jenkins
2022-11-21sal/osl win32 : use non recursive mutexes in file and threadArnaud VERSINI
Change-Id: I7e0e7f7a8bdc3fa92beca10935bb3c62d57f92fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-17Revert "TempFile: clear handle on close"Stephan Bergmann
This reverts commit 0d9613b77fc653c6144b5e4f0136c0536300c0db: As discussed in the comments at <https://gerrit.libreoffice.org/c/core/+/142344/2#message-c52fe7b2037e717525e89dd20a8f320142654ae0> "TempFile: clear handle on close", that change was intended to reset *pHandle to null in cases where osl_createTempFile returns an error and has already set *pHandle. But that is obviously not what the change actually does, it rather sets *pHandle to null in (only some of the) cases where osl_createTempFile returns an error and has not modified *pHandle. Given that there may potentially be clients that rely on osl_createTempFile not modifying the passed in *pHandle when it returns an error, and given that the sal/osl/unx/tempfile.cxx implementation of osl_createTempFile now inconsistently set *pHandle to null in only some of the cases where it returns an error while the sal/osl/w32/tempfile.cxx implementation of osl_createTempFile never sets *pHandle to null when it returns an error, it appears best to just revert that change. Change-Id: Ia68353d04a488b024573ad03de0c5e5bd6e2a2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142798 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-11Drop useless std::move of const objectStephan Bergmann
...introduced with d8b60f77f389a248f98aa45592e6e1045baafbe1 "rtl_String->OString in DirectoryItem_Impl". (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: I3df2e6fb9dbf97adba6fbeda51d24cf025f5b207 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-08A better fix for C++23 P2266R1Stephan Bergmann
After 6d6a143913603b040c10a5db83c2103557899011 "Address some of the sprintf in vcl/source/fontsubset/cff.cxx", --with-latest-c++ builds that pick up a C++23 compiler that implements <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1: Simpler implicit move" started to fail with something like > vcl/source/fontsubset/cff.cxx:2061:16: error: no viable conversion from returned value of type 'char[64]' to function return type 'OString' > return aDefaultGlyphName; > ^~~~~~~~~~~~~~~~~ [...] > include/rtl/string.hxx:313:5: note: candidate constructor [with T = char[64]] not viable: expects an lvalue for 1st argument > OString( T& value, typename libreoffice_internal::NonConstCharArrayDetector< T, libreoffice_internal::Dummy >::Type = libreoffice_internal::Dummy() ) > ^ etc. So I figured there should be something better than 433ab39b2175bdadb4916373cd2dc8e1aabc08a5 "Adapt implicit OString return value construction to C++23 P2266R1" (which this commit reverts, modulo its conflicts in comphelper/source/xml/xmltools.cxx and sc/source/filter/xcl97/XclExpChangeTrack.cxx) to address the underlying issue in a way that keeps code that works up to C++20 also working in C++23. (The fix is only relevant for non-explicit constructors that involve NonConstCharArrayDetector and non-const lvalue references, not for other functions involving those. OUString has a similar constructor but which is explicit, and OUStringBuffer doesn't have any similar constructors at all, so this only affects OString and OStringBuffer constructors.) Change-Id: I31cf16b9507899f5999243f8467dfa24bc94c5ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142455 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-07file: Use callocDr. David Alan Gilbert
Current code does, malloc->memset, that's what calloc is for. Change-Id: Ie3a4872249f78442b96f98c9dad9d7170afe784c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-07TempFile: clear handle on closeDr. David Alan Gilbert
If we close the file on error, then clear the handle we returned to the caller so it doesn't try and close it again or do anything else with it. Change-Id: Idd054f92f4f3cbc3427896ec9795e588471292d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142344 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-05-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): salStephan Bergmann
Change-Id: I668a8b4c6ce3458baa6975161be7ed0cb160968f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142331 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-27rtl uuid : remove useless endian conversionArnaud VERSINI
Change-Id: I65a4dad0aceb83f2449c86c438cb478937c8b90a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138229 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-09-23tdf#151117: Process non-existent long paths correctlyMike Kaganski
Regression after commit 92e835dbf00590c9c29509d2995cc7918a9bbb90 Author Kunal Pawar <hellokunalpawar@gmail.com> Date Fri Feb 18 19:15:04 2022 +0530 tdf#98705 Replace GetCaseCorrectPathName with GetLongPathNameW The fix tries to keep the performance improvement, and when the path exists, it will only call GetLongPathNameW once. Anyway, for unclear reason, this normalization only happens on long paths. Change-Id: I1cf9a47dfc35046ec1b5eebbbcaca09edb1c471a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140516 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-16OUString::matchIgnoreAsciiCase returns boolStephan Bergmann
Regression introduced with d2272426cc79d9aacf4a34c5fd7744b59c29e95b "Use some more C++ in sal/osl/w32", found with loplugin:implicitboolconversion. Change-Id: I5d929dd64bc02559318b8c89cb66bb0f5bba33f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140072 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-15tdf#150877: Add support for Kamenický and Mazovia encodingsJulien Nabet
...as referenced e.g. at <https://docs.microsoft.com/en-us/previous-versions/visualstudio/foxpro/aa975345(v=vs.71)> "Code Pages Supported by Visual FoxPro". That source lists those two encodings with "code page" values 895 and 620, resp. (which might be what we call "Windows code pages" in include/rtl/tencinfo.h) and "code page identifier" values 0x68 and 0x69, reps. (which might be what we call "Windows charsets" in include/rtl/tencinfo.h. But I deliberately left these two new RTL_TEXTENCODING_* values without any mappings to such Windows codepages etc., as I didn't find any authoritative sources. What I used is the information available at <https://en.wikipedia.org/wiki/Kamenick%C3%BD_encoding> and <https://en.wikipedia.org/wiki/Mazovia_encoding>. (And while at it, I also updated the instructions what to do "Whenever some encoding is added here" in include/rtl/textenc.h.) This commit is building on some prior, abandoned work by Julien Nabet at <https://gerrit.libreoffice.org/c/core/+/139819> "tdf#150877: DBF Mazovia encoding (0x69)". Change-Id: Iae8af4ebab8915411499ae7ef951339b335aa857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140014 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-13cid#1509290, cid#1509240: Silence "Use of 32-bit time_t (Y2K38_SAFETY)" for nowStephan Bergmann
We'll eventually need to do something about the 32 bit TimeValue::Seconds, but as it is unsigned we should be fine for another 80 years (until "06:28:15 UTC on Sunday, 7 February 2106", according to <https://en.wikipedia.org/wiki/Year_2038_problem#Solutions>). Change-Id: I74e680be0b2f0ef8cd84d6bc0faef436efc8d3cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139859 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-13cid#1509232 silence Out-of-bounds accessCaolán McNamara
Change-Id: I53f0e0ead728c718d1241d1791135c3c60311303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139608 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-09-07Be careful with failed reallocStephan Bergmann
Change-Id: I809e70487b9174ae902d3a11cc2845ec310d009f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139610 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-30Use some more C++ in sal/osl/w32Mike Kaganski
Change-Id: I407bd4b044143a42d5652dc4164421b602cfe486 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-23cid#1509185 Logically dead codeCaolán McNamara
do oslDoCopyFile only for S_ISREG. openFilePath (called from oslDoCopyFile) returns osl_File_E_INVAL for !S_ISREG so use EINVAL as the error code here to produce osl_File_E_INVAL too. Change-Id: I25a6c091799e051fe58c7dbfc2e7e062f16fe517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-23tdf#148430 Use std math functions instead of rtl::mathLiu Hao
Revert the changes in rtl unit tests. Add some new unit tests to demonstrate the behavior of std functions is same as rtl functions. Change-Id: I12603e2502b8d0951ff5e1650dc8fa193d67c856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138696 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-19tdf#148430 Use std math functions instead of rtl::mathLiu Hao
Change-Id: I6bcb33d51c3974d0e8905e1ffeac556a99870aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138294 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-08-16rtl : use a local std::mutex instead of the global mutexArnaud VERSINI
Change-Id: I95a35fe451e459276dcb8c9b90d515d0a34fe36c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-09crashreporting: frequent crash seen in PackedFile::flushCaolán McNamara
at: if (osl::File::E_None == osl::FileBase::createTempFile(nullptr, &aHandle, &aTempURL)) { .... if (osl_File_E_None == osl_writeFile(aHandle, ... createTempFile is returning osl::File::E_None but presumably we are missing setting a possible error state here https: //crashreport.libreoffice.org/stats/crash_details/ea4b4050-dd0f-42b1-b30f-b67612806371 Change-Id: Ib2d0c3c91e40fe985571e79822b91f2faf401471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138013 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-08-05Fix typoStephan Bergmann
...introduced in f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals" Change-Id: I4ead69b3fac4ab51602c3cbd25c8481e749a3e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137835 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-20tdf#141421 xml export: default stacksize for threads on macOS is too smallChristian Lohmaier
libxslt usage means lots of recursion for the sample document and the default for non-main threads is 512kB, see https://developer.apple.com/library/archive/qa/qa1419/_index.html and contrary to linux it doesn't default to the value set via ulimit. https://docs.microsoft.com/en-us/windows/win32/procthread/thread-stack-size says default for Windows is 1MB, so use that as a new default. (on linux it effectively is 8MB via ulimit, if not specified it would default to 2MB for most architectures) Change-Id: I10bd25301b0aea83e5bbb0c2103a0dd47a7e0736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137269 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-02fix --enable-macosx-sandbox buildNoel Grandin
after commit eecc113e6f6e51e5e37059235c1069dc9c4c1cc8 Date: Sat May 21 08:30:29 2022 +0200 rtl_String->OString in sal Change-Id: I1b71858ae39ae3551a281b0fa5c47652f5bc1b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-24Let rtl_[u]stringbuffer_insert throw std::bad_alloc on overflowStephan Bergmann
Prior to a95c585433246813096e8890b7ed6ef4fe30c621 "Pump XInputStream into an SvMemoryStream rather than an OStringBuffer", this change would have caused > $ truncate -s 3G test.xml > $ instdir/program/soffice test.xml to open an effectively empty draw document (after apparently catching the std::bad_alloc now thrown from within OrcusFormatDetect::detect; see that commit's commit message for details) rather than crashing. This works because rtl_[u]stringbuffer_insert happen not to be decorated with SAL_THROW_EXTERN_C(). But even if they were (or when they are called from an external C program), it wouldn't be worse to let the process terminate due to the unexpected C++ std::bad_alloc exception than to let it crash due to an overflown signed integer computation and out-of-bounds memory write. Change-Id: I21e353367e2b978e8893a2886ac875367a75abd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136352 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-30Avoid uninitialized temp_file_handleStephan Bergmann
...in case osl_create_temp_file_impl_ doesn't assign to it, for whatever osl_error reason, which then apparently leads to <https://crashreport.libreoffice.org/stats/crash_details/e47a9fbb-a6f1-4020-ade8-ab51549b727a> SIGSEGV at (relative to libreoffice-7-1) > 0 libuno_sal.so.3 osl_closeFile sal/osl/unx/file.cxx:1154 > 1 libuno_sal.so.3 osl_createTempFile sal/osl/unx/tempfile.cxx:330 > 2 libmergedlo.so PackedFile::flush include/osl/file.hxx:310 > 3 libmergedlo.so comphelper::BackupFileHelper::tryPush_file comphelper/source/misc/backupfilehelper.cxx:2090 [...] Change-Id: I2e81bbeab7daaaa3c19de4accce8a76ad24faa47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135111 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-23Revert "[API CHANGE] call ftruncate instead of ftruncate_by_name"Noel Grandin
This reverts commit 1d58828f2285064635ed776e0641e83ee26d34da. because we need the filename for "sandboxed LibreOffice on OS X" functionality Change-Id: I598759de0f4bd9e6387df66038fc060e8a08027e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23rename osl_getSystemPathFromFileURL_Ex->getSystemPathFromFileURL_ExNoel Grandin
so I can more readily distinguish between functions that are actually in the OSL API and functions that are not Change-Id: Ie113c30ea15d05457633396d56bca08057e38b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23no need to override 'operator new' in FileHandle_ImplNoel Grandin
it's been a while since we had our own allocator Change-Id: I091c69c94a9592657dd845387530a3fa587a8c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23rtl_String->OString in DirectoryItem_ImplNoel Grandin
Change-Id: Id7b97cbc4160b0d5953c5e378b11a2006292a9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-22[API CHANGE] call ftruncate instead of ftruncate_by_nameNoel Grandin
The actual point of this change is making osl_fileOpen faster by avoiding constructing and storing an OString. But that requires changing to using ftruncate on the filehandle, which is arguably more correct anyway, using the filename to truncate in the presence of unlink() is dubious Change-Id: I8bc5022e1d1afb53fb4e2fd920e43e5daaf74ec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134704 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-21rtl_String->OString in salNoel Grandin
Change-Id: I259c0dbe56fad2292f5ac0dc8e8f1047ead343c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134699 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-18Extend loplugin:redundantcast to trivial reinterpret_cast from T to itselfStephan Bergmann
Change-Id: I7c0be7b435d6b5f97bdd40484023584146638d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134506 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-17clang-tidy modernize-pass-by-value in salNoel Grandin
Change-Id: If05c5cf0e333d0dbba31475af69c517486bf8923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14pthread_mutex_t->std::mutex in lookupThreadIdNoel Grandin
Change-Id: Ic9dfcfef5c604e778dfe527d627137042c8deb49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-13Use calloc instead of malloc and memsetdante
Change-Id: I591ee7f5360a30779f831f6492cdbe71ab94099e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-12-Werror,-WformatStephan Bergmann
> sal/cppunittester/cppunittester.cxx(553,65): error: format specifies type 'unsigned int' but the argument has type 'DWORD' (aka 'unsigned long') [-Werror,-Wformat] > printf("\tat unknown (Error in SymFromAddr=%#08x)", GetLastError()); > ~~~~~ ^~~~~~~~~~~~~~ > %#08lx and DWORD should presumably always be a typedef for unsigned long according to <https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/262627d8-3418-4627-9218-4ffe110850b2> "2.2.9 DWORD" Change-Id: Ib1394c54fd649108bb6f6c748a5b7eae798884ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-12-Werror,-Wunused-variableStephan Bergmann
...since 92f93f300371d2011b53d48d3491870b24cff0b4 "output error code when SymFromAddr fails" Change-Id: I9d831e363fe98068cb55102628c98aa9d4ad5d3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134213 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-11Revert "Disable -fsanitize=float-divide-by-zero in rtl_math_atanh"Stephan Bergmann
This reverts commit 6a4504bba84dcbaeb71869ec5c9ed6dfdc090619, which is no longer necessary after 6f75ec6115f0152517be634070607bc61bf96dd0 "tdf#148430 Use atanh from <cmath> instead of our own" changed the implementation of rtl_math_atanh. Change-Id: I11094f8c9fb0bb7b635541e7360e460816d3c171 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134161 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-11tdf#148430 Use atanh from <cmath> instead of our ownofftkp
Change wrapper in rtl::math::atanh to use atanh from <cmath>. Also changed all occurrences of rtl::math::atanh on files that use this function to directly use the standard atanh instead. Change-Id: Idc5c456f67291f5816756f023b61afde844b5ceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133965 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
generated by cgit (git 2.34.1) at 2024-06-30 11:49:48 +0000