summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2015-05-09coverity#1297235 Uncaught exceptionCaolán McNamara
Change-Id: I6b135f6d47352c1fbb729788848913402b7bb742
2015-05-08Use bool instead of intStephan Bergmann
Change-Id: Ib5920745f9f464493b7b134f871e090726d17d0c
2015-05-01Actually, let's just delete the now commented-out SAL_INFO linesTor Lillqvist
(It was I who added them in the first place.) Next time somebody (falsely?) suspects a problem with mutex use and really needs tracing, it's trivial to add temporary SAL_DEBUGs. Change-Id: I3db02be777a728fbf4a1d1962f0ccfa16c630f15
2015-05-01Let's disable these too then for consistencyTor Lillqvist
Change-Id: I17d17b1cad83a55f9a2c0db80e272c419529b45a
2015-05-01sal: disable some over-eager SAL_INFOMichael Stahl
These call malloc so often that valgrind forgets where the things i'm looking for were freed, because the address has already been re-used. Change-Id: I8e1a0f739a774972d3afe750250ee79262c79b85
2015-04-30provide a way to execute single test case from test suiteMarkus Mohrhard
CPPUNIT_TEST_NAME is the environment variable that needs to be set and contain the name of the tests. The test names need to be fully qualified to be recognized. Examples: CPPUNIT_TEST_NAME="ScFiltersTest::testOutlineODS ScFiltersTest::testRangeNameXLS" make CppunitTest_sc_subsequent_filters_test CPPUNIT_TEST_NAME="ScFiltersTest" make CppunitTest_sc_subsequent_filters_test Change-Id: I78a8a076638e19c918ca1c411086bb353f5100a2 Reviewed-on: https://gerrit.libreoffice.org/15579 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-27More loplugin:simplifyboolStephan Bergmann
Change-Id: I9414d9167213c0156fb97559a8af5e55a4e1c1de
2015-04-23cppcheck: uselessAssignmentArgCaolán McNamara
Change-Id: I94be63174d996069fc5ec9c93d14ccd5a39cb029
2015-04-23cppcheck: redundantAssignmentCaolán McNamara
Change-Id: Ib296edde6e1f3996cbfe46c77810bb5c3da6db73
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-21cppcheck: redundantCopyCaolán McNamara
Change-Id: I209b55a6ef962d4a350327e56c4d16c8180a21e0
2015-04-20Clean up new rtl/surrogates.hStephan Bergmann
Change-Id: Iec781bdbbf216cb14c9ba5be5955123273d7699c
2015-04-20duplicate surrogate codeCaolán McNamara
Change-Id: I9fad024e4b5c8a4ca272f2387df07351198cf5dc
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-10Update @since tags LO 4.5 -> 5.0Stephan Bergmann
Change-Id: Idb2e46fcaa080d6763d2e3ed963f7673a2353eb2
2015-04-09WaE: VarDecl, use "bool" instead of "sal_Bool"Tor Lillqvist
Change-Id: I0b868edad579f9ccf46f6d9f6015086557e528da
2015-04-09Change from <osl/diagnose.h> to <sal/log.hxx> and add more loggingTor Lillqvist
Change-Id: Iee8c093f5aa8306c3e5336d6dd5e801df6df87a4
2015-04-08tdf#43157: remove osl/diagnose.h dependency from sal/osl/unx/socket.cxxJorge Cunha Mendes
Change-Id: I2becc1cbb875270e2a1e8ed6b7cb0f9b6bdbf2f9 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-04-08-Werror=maybe-uninitializedStephan Bergmann
Change-Id: I7d3c36e564b3a5286ebd32527575472313119587
2015-04-08tdf#88169: Do not return ..._INFO_SRCBUFFERTOSMALL when ..._FLAGS_FLUSHStephan Bergmann
...in accordance with <http://www.openoffice.org/udk/cpp/man/spec/textconversion.html> Change-Id: I62013f89c421722770123db8a5794e63d3572e6b
2015-04-04Typo: creat->createJulien Nabet
Change-Id: I5e57e6d506504933096f4c8e371b0ddc93c04cbd
2015-04-02Move osl::LibreOfficeKit stuff to comphelper for nowTor Lillqvist
Let's see where it actually will be needed. Sal is a "picky" place for new API, even inside LIBO_INTERNAL_ONLY. Change-Id: Ia0c5ee8cfc6ee526c5ad34d2f8aab0b14b5f805b
2015-04-01Add API to check whether being used through LibreOfficeKitTor Lillqvist
LibreOffice code, when used in a program through LibreOfficeKit, needs to be aware of that in certain crucial spots, to avoid behaviour and functionality that makes no sense in a LibreOfficeKit scenario. As LibreOfficeKit uses a normal LibreOffice installation to perform its job, this can't be a compile-time choice. Also, none of the existing run-time "headlessness" modes fully match what is needed. Change-Id: Iaccf7f958c549f019b508854800519f54dcadb11
2015-03-31Use OUString::unacquiredStephan Bergmann
found with git grep -E '\* *\<reinterpret_cast\>[^>]+\<OUString\>' Change-Id: I9306d4ad8e3b1664f54cb7df86f2d79bfd3c6cb9
2015-03-31loplugin:redundantcastStephan Bergmann
Change-Id: I6c405287266572598a86b534552ed2f7bdff7fa2
2015-03-31V597: introduce a rtl_secureZeroMemoryCaolán McNamara
Change-Id: Id28046eb318cd3b2ed0b813fd266617547cf6ee2
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: Ic03728b2824eb59b9b6351a88ec355bfb93154cb
2015-03-30Return value 0 from connect() is not an error, errno is not setTor Lillqvist
No need to SAL_WARN it, it is a common non-exceptional case (when attempting to start a second LO instance). Change-Id: I26f2939d2f5b97ddfcc9e912e578b706567b3912
2015-03-30Bootstrap.initVCL is not used by our Android app any moreTor Lillqvist
Change-Id: Id1e58547cf2b0786d7a2ca29eae8bbcdd644fdd5
2015-03-29Minor simplificationTor Lillqvist
Change-Id: Idcf9158d0446107ec783fd8691078791d7b25e31
2015-03-29loplugin:cstylecastStephan Bergmann
Change-Id: Iec37e09d0da181f6af268fa0c8c43a2e1fef5dbe
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I5e370445affbcd32b05588111f74590bf24f39d6
2015-03-27loplugin:staticfunctionNoel Grandin
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I03e43d219a65aa270f73a91896e0e7a567d424bc
2015-03-24loplugin:constantfunction: variousNoel Grandin
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-23Sanitize a few SAL_INFOsTor Lillqvist
Change-Id: Ib5e7e9250f90a9282c25446b606166499fc9d369
2015-03-19CppCheck cleaning : scope reduction and printf formatMichaël Lefèvre
Change-Id: I43ba76194ee135ffe2398267ed810cca116a1e43 Reviewed-on: https://gerrit.libreoffice.org/14854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-16tdf#89361 Remove remnants of Gopher supportAdolfo Jayme Barrientos
Change-Id: Ib2038a43b0d49a525199329a2c79d5779f5322fa Reviewed-on: https://gerrit.libreoffice.org/14471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-03-13CppCheck cleaning : avoid static string comparisonMichaël Lefèvre
Change-Id: I6a7375901fcec63892041aec8cc2d55ce7789724 Reviewed-on: https://gerrit.libreoffice.org/14848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-12sal: add comment re: V718 'CreateThread' should not be called from 'DllMain'Michael Stahl
Change-Id: I6e444e6c3dd4f5e158fe9b649b97ccb5ca32c3a7
2015-03-11better way to check for empty stringsMarkus Mohrhard
Change-Id: Ib52b3f958e9e346194d4427bf59c6f62ee8ed105 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-03-05sal: replace usage of deprecated socket functionsMichael Stahl
inet_ntoa, gethostbyname, gethostbyaddr are all deprecated in the Windows SDK 8.1; use the replacement functions unless targetting WinXP. Change-Id: Ic290ce925835c97f0ca0c611d1fd2675d0045ec7
2015-03-05sal,sd: use newer InetPtonW API when not building for WinXP targetMichael Stahl
... i.e. decide based on target instead of SDK version. Change-Id: I225588d34f961c19e223ed9c1b9a934cd5196cf7
2015-03-03TyposJulien Nabet
Change-Id: I0aef0c185457687aa0e40a4a1e8024d9e691093f
2015-03-03Work around missing InetPtonWStephan Bergmann
...in certain Windows build environments (whatever it is exactly that causes some Windows builds to fail with "error C3861: 'InetPtonW': identifier not found" while others succeed). Unclear what the original reason was for setting _WIN32_WINNT here, but removing it hopefully does not break anything. Change-Id: I83222ad010d428cf2b9c447760ea47381552d04a
2015-03-02Turn function-like macro into true functionStephan Bergmann
Change-Id: I70330b1f4844f33779f814377afaf90e0a219b1d
2015-03-02typoStephan Bergmann
Change-Id: Ifc03631b126ec19cb98cb42a258ca4880e868385
2015-03-02V805: Decreased performanceCaolán McNamara
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
2015-03-02V804: Decreased performanceCaolán McNamara
Change-Id: I53c2d11e81edb3f6d00984b3dc90994af5765164
generated by cgit (git 2.34.1) at 2025-01-15 03:19:22 +0000