summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2017-01-01ofz#358 SJIS_84 table mnLeadEnd is out by oneCaolán McNamara
sjis 82 and 83 correctly denote the last index available while 84 reports one past the last available index 0x84BE is the last value to map, not 0x84BF Change-Id: Idcadc2d554ee59586f6e2f2775301fe69c94d55a
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23tdf#97283: Merge sal rtl tests to one makefileMatúš Kukan
Change-Id: I1b78276e08feef9b6f49e5abe002391c50a8d2cc Reviewed-on: https://gerrit.libreoffice.org/32143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-12-23tdf#97283: Merge sal osl tests to one makefileMatúš Kukan
Leave sal_osl_security alone because it does not use CPPUNIT_PLUGIN_IMPLEMENT. Change-Id: Iced8bb80c3ae661d371c087d7178a373ffd802e0 Reviewed-on: https://gerrit.libreoffice.org/32142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-12-20Don't malloc between for and execStephan Bergmann
...at least macOS doesn't like that; change from OSL_TRACE (effectively doing nothing unless running a debug build with SAL_LOG=+INFO) to SAL_INFO (calling std::stringstream -> malloc in debug builds, regardless of SAL_LOG env var) in a005fbeddc4e615cfff56a9bd84355f8d42c1c8c "OSL_TRACE->SAL in framework..sal" made the mistake obvious. Change-Id: I43d35524a0861998a1ef58c6f448085a2fb01cd5
2016-12-20keep salinit for non-DESKTOP but not for ANDROID/IOSCaolán McNamara
Change-Id: I6b97345c9d927d1ae1d89f85611c2b5de7b5f0d4
2016-12-20salinit for non-DESKTOP tooCaolán McNamara
Change-Id: Icb368b676199038bf8588b42ef50a2796468d185 Reviewed-on: https://gerrit.libreoffice.org/32228 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-20bootstrap building with --disable-dynloading on standard linuxCaolán McNamara
Change-Id: I5baf70f0053612cba8b74f54aff11ce25cdeb95a Reviewed-on: https://gerrit.libreoffice.org/32202 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-20add an option to pipe log output to fileMarkus Mohrhard
The target file and the option are controlled by SAL_LOG_FILE. The variable should contain the target file in a system dependent notation. Change-Id: Ie1ce9c39740c8b7a989e5af222be21a3e3142084 Reviewed-on: https://gerrit.libreoffice.org/32176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-19this textenc hack is for android and disable-dynamic-loadingCaolán McNamara
Change-Id: If2191161e82fc1e05b1442ae4b3b729cc1b8994d Reviewed-on: https://gerrit.libreoffice.org/32038 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-17Make OUStringLiteral more usefulStephan Bergmann
...by: * making the OUStringLiteral ctor non-explicit (to be exploited in a follow-up commit) * adding (LIBO_INTERNAL_ONLY) overloads to OUString/OUStringBuffer functions that can now take OUStringLiteral in addition to taking "real" string literals (Keeping the number of overloads smaller by replacing the ConstCharArrayDetector overloads with ones taking OUStringLiteral (for LIBO_INTERNAL_ONLY, at least) and relying on the now-implicit conversion from "real" string literals to OUStringLiteral unfortunately would not work: Both OUString and OUStringLiteral argubably need implicit conversions from "real" string literals, so any function overloaded for OUString and OUStringLiteral would be ambinguous when called with a "real" string literal. And removing the OUString ctor taking a "real" string literal and relying on an implicit conversion chain from "real" string literal to OUStringLiteral to OUString doesn't work because it would involve two user- provided conversions.) Change-Id: I14433fc1605b048807f60b3a3e14f92221d3a226 Reviewed-on: https://gerrit.libreoffice.org/32097 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-16-Werror,-Wstrict-prototypes (clang-cl)Stephan Bergmann
(sal/inc/rtllifecycle.h only hits on Windows as that is the only platform that happens to actually include it in a C compilation unit, sal/osl/w32/dllentry.c) Change-Id: I2878b52daf713ea45eaa2968cc5d2686b86abfe6
2016-12-16Typo in meant-to-be-overloading function nameStephan Bergmann
Change-Id: I65ab9176b39a436afce23e6bd4423ebf76219166
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-14I guess FREEBSD doesn't need this implementation of fcvtStephan Bergmann
The only actual use of fcvt across the codebase has been removed in 2002 with 31cb31335f3bf7e6e57d70ca61bf5a2a536d1e6e "GetStringFromDouble: replaced that fcvt() and temporary LocaleDataWrapper instance crap" even before this implementation for FREEBSD was introduce in 2003 with c61bf41c39daa97d30016eedcd7a0b687c2d8558 "INTEGRATION: CWS ooo11rc: join: from ooo11beta2". Change-Id: Ieea9499f001c6eac6383c344afb9050dfc70f43c
2016-12-13Reuse existing sal.osl log areaStephan Bergmann
Change-Id: Ib1fc80c79355322489b7ebd37cbbbbb6614ec67a
2016-12-13fix windows build after OSL_TRACE->SAL changesNoel Grandin
Change-Id: I345343f84f66299e8b91b31af0290ed0c622bf8d
2016-12-13OSL_TRACE->SAL in avmedia..canvasNoel Grandin
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
2016-12-13OSL_TRACE->SAL in framework..salNoel Grandin
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9 Reviewed-on: https://gerrit.libreoffice.org/31903 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12[API CHANGE] Remove salcpprt static libraryStephan Bergmann
...containing replacements for global operator new/delete (that can be linked into executables), but which is no longer used. The mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2012-March/028690.html> "operator new no longer routes through rtl_AllocMemory in libsalcpprt under gbuild link rules" has the details of how this was used on some platforms (but not on others) before the switch to gbuild, and has been "lost" ever since---but apparently a loss not mourned much over the years. For the SDK, c5f974287fd04bb529de145113133b9e35687702 "INTEGRATION: CWS jsc3: #i62434# copy libsalcpprt.a" added the library (under Linux) and 6db9c5af960f9787e33e4addc56bddbb1695a402 "INTEGRATION: CWS jsc3: #i62434# extend link options for executbales to link libsalcpprt.a, LINUX only" added its use to odk/settings/settings.mk, but fc0ca57f2cd649c6330171445a06b80e2143a0e9 "INTEGRATION: CWS jsc21" removed that use again (for no documented reason). So this is an incompatible change, but unlikely to actually affect any users of the SDK. Change-Id: Ia38b4c439f21fca3f5d9af7d1a34054e992054e9 Reviewed-on: https://gerrit.libreoffice.org/31810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-06Comment cppcheck accessForwarded as harmlessStephan Bergmann
Change-Id: I2692ba63f010b61e7b4c1fe54368f4dac9c42d60
2016-12-06new loplugin/rewriter comparisonwithconstantNoel Grandin
As per sberg' suggestion Limit it to == and !=, because some people like the flow of inequalities like: "0 < a && a < 42" The changes to sal/ were made using the rewriter. The rewriter still has one bug, in pipe.cxx, it managed to pick up some random piece of macro. No idea why. Change-Id: I01305f9c5396a4b6c7421d6e92f1b4b529388e82 Reviewed-on: https://gerrit.libreoffice.org/30962 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-01loplugin:unnecessaryoverride (dtors) in salStephan Bergmann
Change-Id: I498bb634f2a5800f5effab99227aa4699ed91aae
2016-11-29Don't change ustrHostname in case of errorStephan Bergmann
Change-Id: I78e85db2794b01286be49e1be70b53ac4f058cbe
2016-11-25loplugin:stringconstant: look into 'char const * const var = "..."'Stephan Bergmann
Change-Id: I52a97b8ec273509131c2200e47527221cb62d7ee
2016-11-23Remove dead sal/workben/ stuffStephan Bergmann
All this is probably dead for ages, yet it repeatedly got modified over the years by clean-up commits, be they driven by cppunit or grep. Change-Id: I69443f5b25f24bb5735e7179c915f27b4742fcb5
2016-11-22trivial makefile cleanupsMichael Stahl
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-21remove dep on unotest from osl_Pipe testDavid Tardon
Change-Id: I5f5862a684e52bd3d1336fa9f8cffa77cdebbe4c
2016-11-21fix for 'warning C4702: unreachable code'Jochen Nitschke
on windows vista and higher only Change-Id: I19cc63ad7e96b58fa8eb341801f5ad55260abf85 Reviewed-on: https://gerrit.libreoffice.org/31021 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08Use the larger stack size for ASan/UBSan builds on macOS, tooStephan Bergmann
At least on my macOS 10.12.1, PTHREAD_STACK_MIN is 8192 (so stacksize was substantially smaller than 12MB), and without this change there were randomly looking failures in e.g. JunitTest_chart2_unoapi with a -fsanitize=address build. Change-Id: Icfe989a0e5097a9a0ae76c6e0f6ffcca18271245
2016-11-02loplugin:unusedfieldsNoel Grandin
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01loplugin:oncevar in sal..scriptingNoel Grandin
Change-Id: Id9ab12f3a61eb83a2288b2fd4d99ab77f5833e1b Reviewed-on: https://gerrit.libreoffice.org/30461 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26sal::detail::logFormat is no longer neededStephan Bergmann
...since 97354578d7195bce927f0c00c4e2ae9cd7344776 "Remove the obsolete functionality originally underlying osl/diagnose.h" Change-Id: I7c920bca9cdddb37fcbbc15d8629d01c21eb0787
2016-10-19loplugin:expandablemethodds in reportdesign..salNoel Grandin
Change-Id: Idb133e442b881d263fcb83a4858c4a08b451c0f0 Reviewed-on: https://gerrit.libreoffice.org/30032 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14CppunitTest_desktop_lib: fix loplugin:cppunitassertequals warningsMiklos Vajna
And also address a few new warnings in sal, plus silence such warnings in salhelper till we can't print typeids out of the box. Change-Id: I38049146710b6885f6a874bf74eedbc38b4d4651 Reviewed-on: https://gerrit.libreoffice.org/29809 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-13approxEqual: check isFinite()Eike Rathke
Necessary as all comparisons involving a Nan evaluate to false and the assert() in isRepresentableInteger() was hit by crash test documents where approxEqual() was called with a least one Nan. Change-Id: I9e8f41c36c0cf14cabf47c3df773c601d32682d6
2016-10-13SOCKET_USE_AUTODIAL is dead codeStephan Bergmann
...ever since 010f71130b0d55079d01fbda38d45901de98b133 "INTEGRATION: CWS sal01: #105958# Remove usage of wininet.dll autodial functions" wrapped its central code in #ifdef SOCKET_USE_AUTODIAL instead of removing it properly. Change-Id: I4c077c71ce8eda3a3f8b83286178d0d7907a6e02 Reviewed-on: https://gerrit.libreoffice.org/29742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-12Don't allow O[U]StringBuffer in string concatenationStephan Bergmann
...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html> "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
2016-10-10Handle loplugin:fpcomparison false positives by whitelistStephan Bergmann
Change-Id: I58e2beb0695a27922856bd8f8988d9e4508aceb6
2016-10-07New rtl::splitSurrogates, remove code duplicationStephan Bergmann
Change-Id: Ic96b64244f817196ccdfe06b97f7f31291adf372
2016-10-07tdf#100302: gbuild: always use $(LFS_CFLAGS)Michael Stahl
Currently LFS_CFLAGS are only used in a handful of libraries but there's no obvious reason why it can't just be set everywhere. Also set it in windows.mk, i have no idea if it's needed for MinGW (certainly not for MSVC). Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
2016-10-04isRepresentableInteger: assert(fAbsValue >= 0.0)Eike Rathke
Change-Id: Idf140b312617e2a3a739cb5571d1b29ef700315c
2016-10-04At least MSVC 2015 doesn't find sal/osl/w32/time.hStephan Bergmann
...when included as <time.h> (our rather sick convention, for include files other than standard headers) rather than "time.h" Change-Id: I5aacfb81de95ae4254e39badffc9c83c7ac0f58f
2016-10-04@since tag; sortingStephan Bergmann
follow-up to 2135eae2a97c17d89cb47a2074830fd2d7b2226f "let approxEqual() not scale too early for large representable integer values" Change-Id: I628e01297fea08915d0ca1c95f3ba13f7ce15db8
2016-10-04clang-cl loplugin: salStephan Bergmann
Change-Id: If04d3f07dc8bffac8887773b5424c09848cd8f1a Reviewed-on: https://gerrit.libreoffice.org/29404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-03-Werror,-Wdeprecated-declarationTor Lillqvist
'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0. Change-Id: I3a95cbd4ff6ff4924bb7fe1a4c1bac4fad405856
2016-10-02unit test cases for approxEqual() and approxSub()Eike Rathke
Change-Id: I4aa53d83feaccd3d08c69a35cee2fa84f1ec0964 Reviewed-on: https://gerrit.libreoffice.org/29429 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-01let approxEqual() not scale too early for large representable integer valuesEike Rathke
And since this is now too much code for inline move implementation to math.cxx Which again made it necessary to give libreofficekit lokdocview.cxx its own implementation that doesn't even claim to build against sal ... Change-Id: I0f80be9d9172ee20693b9babde715206f2c3d8c1 Reviewed-on: https://gerrit.libreoffice.org/29428 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I6aeda978911b25caa45d4e459e581fc743e93d2c Reviewed-on: https://gerrit.libreoffice.org/29442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Fix typosAndrea Gelmini
Change-Id: Icfc61fcc5ace717bca4bea988243674afe31e6f8 Reviewed-on: https://gerrit.libreoffice.org/29435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-27 15:57:31 +0000