Age | Commit message (Collapse) | Author |
|
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
Change-Id: I27ada8b5154968e521d9e67f21473aa85776e70e
|
|
Change-Id: I96e7ac419f4300a1dd62a5c24611c1467ef3b19a
|
|
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
|
|
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
|
|
Fallout from 0e6a2601b39cbadaff7f7506ba9e804f108060db ("Convert code that
calls OUString::getStr()[] to use the [] operator"). The code was a bit silly
and "hand-optimized" in the first place so no wonder a bug was introduced
accidentally in that commit.
Make it simpler and more obvious.
Change-Id: Idafb1c0741289e915dfbaa108383a926321764d2
|
|
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc
Reviewed-on: https://gerrit.libreoffice.org/7104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
|
|
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4
Reviewed-on: https://gerrit.libreoffice.org/7103
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Ia6799c852eb95d496fbc8dcfdabde62dffc263a6
Reviewed-on: https://gerrit.libreoffice.org/7066
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Convert code like
if( !aStr.isEmpty() && aStr[0] == 'x' )
to
if( aStr.startsWith("x") )
Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
|
|
Change-Id: I6fc350f489863ec86c76822053f0a399cef5cd7f
|
|
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
|
|
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
|
|
...non-explicit OString(rtl_String*) ctor already covers that
Change-Id: I9e447795ddc585d765b48d1f7f41f3c795aecba2
|
|
Change-Id: Ic580c625c78802087a32f8669feec91fe79672cd
|
|
(cherry picked from commit 2a0a1e41bcca97caaf3fdfb375f5cebb330a0fcc)
Change-Id: I107a73ad001647eeb25b44e521251ef9543cc83a
|
|
The crash reporter facility can provide much better details about crashes.
But if that facility is disabled then handling SEH events such as div-by-zero
as C++ exceptions is a worthwhile alternative. It can provide a few interesting
details and it allows a graceful shutdown of the application.
(cherry picked from commit c9d10b167b37a9cb0bb310cafc8e80b6cce8ea7a)
Conflicts:
sal/osl/w32/signal.cxx
Change-Id: I25324d6e02ab8acd8fd2b036b77039aac87cf262
|
|
Change-Id: Ic1863a2126c26cf703afc5fe250dea2bbddfef7d
|
|
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.
Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
|
|
* Windows XP SP2 is 0x0502, see
http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
this is done module wide now. So the overall behavior
is as before. This seems to be the best compromise for
now.
* We need at least SP2 because of the bluetooth stuff
used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
project specific precompiled header files.
* All local definitions of WINVER are removed, because
the global WINVER setting makes them obsolete now.
To the relation of the three macros:
Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.
WINVER and NTDDI_VERSION can be set idenpendently each
for itself.
Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
|
|
Convert code like:
OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
OString aKeyName("NDX");
which compiles down to the same code
Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
|
|
Convert code like:
aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
aOStringBuf.append( " is missing )" );
which compiles down to the same code.
Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
|
|
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
|
|
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
|
|
Change-Id: I391e027b2567c4239c1d02e132c6508b3f49d381
|
|
Change-Id: I6197f2f9c3359ebe6c3c639f15c3e19d66434f3e
|
|
Change-Id: I5dd8f718cb96c4442e2fce08a8dc4130e934c68d
|
|
Change-Id: Id218a6123037bf624044a6297edaede924bd4a9a
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
Document the "calling" macros for the strtmpl.cxx template file.
And remove unnecessary use of those macros in the calling file.
Change-Id: I20e0dd74150773363b9fb557884b84692ce22f11
Reviewed-on: https://gerrit.libreoffice.org/6504
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Change-Id: Id99ba394b898b7da0057d4a145ce8dce46122782
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Replace uses with CPUNAME instead, and get rid of the horrible
postgresql patch that worked around environment leakage.
Change-Id: I38ccabfc438360524a272901bb9332ea708e274c
|
|
Those have no effects with current windows SDKs.
Change-Id: I6fb2f8045fe1fc0ed4beef51dde487b7a7dfdc28
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
Change-Id: I63c32289c7ac6a428c8c50e49650fbac98c8c5e3
|
|
So there is no need to do this locally, too.
Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
Change-Id: I07e7917417b8a22cf6d64f2b7a447f9084b9fa2d
|
|
Change-Id: Icdd22fa0f1efcdd18cfea7cb48e1cbf2cf8d3533
|
|
Change-Id: I318bb78b148564f64373dcb87bfb458c10f87489
|
|
... was missing from 1acaa577b67158c060d2f57414f7aea86504a489.
Change-Id: I9098f4587f1c201328abbbcfb34d42f09d2e8203
|
|
Change-Id: I491ca9ccfc5622afcec163e75792aa03a3a24a4f
|
|
... to set up a fake command line. This is used from pyuno, when
invoked from the "python" executable as "import uno".
On WNT there is an API to get the actual command line, so just use that
even in the "fake" case; on UNX just fake something up.
Just for the record the whole osl_setCommandArgs() is called exactly once
assumption should work out _unless_ there is a program that uses SAL_MAIN
_and_ does a python-level "import uno" _before_ it wants to create a
python-based UNO service (via pyuno_loader::CreateInstance), since
pyuno already takes care to call Runtime::initialize() at most once.
Change-Id: Ifd23de733ea3e6b694d46ab039b6aa4fd3e7fc1b
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...introduced in 2001 with a Sun-internal bug ID as
3b1d10acc297db493b1f4e1999f6ba71f72db7f1 and
54007bb90c30469a5357c56056b8fdba3a233e24 "#84715# osl_getThreadTextEncoding
first defaults to contents of environment variable SOLAR_USER_RTL_TEXTENCODING."
Change-Id: I991b4777c27a24419bf066cf41b3c4545d0fa681
|
|
Change-Id: I266d5cf5b98827617f7ed65c94a772e28808f386
|