summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)Author
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-21WaE vs2015: pointer to int castingNorbert Thiebaud
Change-Id: I3be393ef5a9d1ed732f44037cd1115960a6186d2 Reviewed-on: https://gerrit.libreoffice.org/22592 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-21WaE vs2015: int to pointer castingNorbert Thiebaud
Change-Id: I201e4b44e2a26ff0566f30c7e7c12c0df90a54e6 Reviewed-on: https://gerrit.libreoffice.org/22591 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-19tdf#97703 Removed a few redundant calls to setUp and tearDownJaskaran
Calls to CppUnit::TextFixture::setUp and CppUnit::TextFixture::tearDown have been removed. I hope that saves a few milliseconds of build time :) Change-Id: I611db2f5c5673ab86bf8f92beb4f6e8a70443b34 Reviewed-on: https://gerrit.libreoffice.org/22496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-18coverity#1352316 Explicit null dereferencedCaolán McNamara
Change-Id: Ieb80209e0254080bf78fb3b5201b849d7d30880c
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-16coverity#1352448 Use of untrusted scalar valueCaolán McNamara
and coverity#1352449 Use of untrusted scalar value I suspect this will fix the warning, given that "Casting narrower unsigned pBuffer[i] to wider signed type short effectively tests its lower bound", so if we pass it though as-is we probably quieten these Change-Id: I2ece08f7301f5d548d905d221e5a6af0da51a2bb
2016-02-15Rename rtl::isValidCodePoint -> rtl::isUnicodeCodePointStephan Bergmann
...and fix its documentation, and use it throughout the code base. Change-Id: I349bc2009b1b0aa7115ea90bc6ecd0a812f63698
2016-02-11Avoid duplicate declarationTor Lillqvist
The same extern declaration is already in alloc_impl.hxx which the source file includes earlier. Change-Id: Idacadc8cf938d88892c99b1af3723c52fcae5298
2016-02-10loplugin:nullptr, loplugin:overrideStephan Bergmann
Change-Id: If4500b8b41915a05a2bfb2c776259f49ad9bfc85
2016-02-10Add existing CppUnit test for sal/rtl/randomChristoph Brill
The tests itself already existed, we were just missing the .mk file Change-Id: I662eba5d955aa5cbd774dbb3b4c9f9010dc1d7d6 Reviewed-on: https://gerrit.libreoffice.org/22249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I74585aa5a50cd335f4fd0a3ba4fed230b98993c3
2016-02-07Platforms that need CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT for sockets usuallyDamjan Jovanovic
need it for pipes too, and even if it isn't necessary it can't hurt. In particular, on FreeBSD 11-CURRENT it seems pipes no longer wake up from accept when closed in other threads, so let's deal with that before FreeBSD 11 is released. Reported by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e> Patch by: me Tested by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e> (cherry picked from commit e18ecd4f644cfbe5d6b871c7ff6c76bd5c220504) Change-Id: I1b4c0438fbcc2ea53625f235906936fc1403e195
2016-02-05cppcheck-suppress sizeofwithsilentarraypointerCaolán McNamara
Change-Id: I794cb2f3f31e9ce48f3568bd5a4afc52abf0f934 Reviewed-on: https://gerrit.libreoffice.org/22160 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-26fix the new CPPUNIT_TEST_NAME codeMarkus Mohrhard
Change-Id: I45260555778a733a8c8ba9e39e9ffcce0c9ab78d Reviewed-on: https://gerrit.libreoffice.org/21818 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-26support unnamed namespaces with CPPUNIT_TEST_NAMEMarkus Mohrhard
Change-Id: I1ce50ce0ce8a4a461d1b2a34de132cbf57dd7d25 Reviewed-on: https://gerrit.libreoffice.org/21802 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-26Bin leftover cruftTor Lillqvist
Change-Id: I15a4237a1ab6d7c180b52c3f8d2834c0e034b7db
2016-01-20drop obsolete cruftDavid Tardon
Change-Id: Ia9b9431252c010d910ed0e9461398651de1de260
2016-01-19loplugin:unusedmethods in sc/Noel Grandin
Change-Id: I2c24d06d9fad26c65fa13cdcaa2c3f908971106c
2016-01-18loplugin: unused return valuesNoel Grandin
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18Trade a little weaker test against loplugin:stringconstantStephan Bergmann
(what prompted writing that very fundamental test now anyway?) Change-Id: I83884908f8f5b1e4d58575960c77b411183f2fbb
2016-01-16sal: (rtl) test OUString::isEmpty()Chris Sherlock
Change-Id: If7a6eb598a1e121c1c74e520f7e2238016a3e6e0 Reviewed-on: https://gerrit.libreoffice.org/21506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-14use ::std::swap() to reverse bufferEike Rathke
Change-Id: I7e18e57636416f0a3ed96c2fa3adc004fb3ba013
2016-01-14use getN10Exp(x) instead of pow(10.0,x)Eike Rathke
Change-Id: Ib7e49126cbffc510fa941c25a8d57222bad51c46
2016-01-14unit test for negative decimal places rounding, tdf#96918 relatedEike Rathke
Change-Id: Ib2f3ffaa7c4216b66479c750465c2beab927405a
2016-01-14handle negative decimal places for rounding, tdf#96918 relatedEike Rathke
Change-Id: Ifa423eabc64ead519c4f4a3370a06e88ea5c7466
2016-01-13Keep MSVC happyStephan Bergmann
(warning C4305 when converting 9007199254740993 from __int64 to double) Change-Id: I0e2b92a01ba5ae1824d609ee2e557f1a1cc85cbd
2016-01-13loplugin:defaultparamsStephan Bergmann
Change-Id: I507a16e1d87460dead79b78621202c68ee12c2c8
2016-01-13sal: as always C++ is too stupid to deduce parameter types of minMichael Stahl
Change-Id: Ib00f29a6024e22c65a30bf4a45332e550994f03f
2016-01-13unit test for tdf#96918 display accurate integer double valuesEike Rathke
Change-Id: I619e0cb0fbbfd0dfba3b2fe9c3476be55a3eea8e
2016-01-13tdf#96918 display accurate integer double values up to (2^53)-1Eike Rathke
Change-Id: I42001583c72bc3faab94489a4eabfa183cab5ae2
2016-01-13sal: avoid " at:\n" at the end of SAL_DEBUG() messagesMiklos Vajna
This reverts one hunk of commit c995196ff0e9f7041b03fc513d703d6e60b8c867 (Fixup SAL_DEBUG_TRACE macro., 2016-01-12). Change-Id: Icbf611c4aaa909b8c495bed1280fad73ba876e8c
2016-01-12Fixup SAL_DEBUG_TRACE macro.Michael Meeks
Change-Id: I276ce9a356086001c208902ba94641863c2f2fdb Reviewed-on: https://gerrit.libreoffice.org/21408 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-01-11PCH support on LinuxAshod Nakashian
Fixes and improvements to support Precompiled Headers on Linux. Change-Id: I8145c146b0dba56c7a4d0fdf9c330164b67ada53 Reviewed-on: https://gerrit.libreoffice.org/21307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2 Reviewed-on: https://gerrit.libreoffice.org/21245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-07loplugin:nullptrStephan Bergmann
Change-Id: I8c1ef744be34eea2130b458ed3a09d90804219cc
2016-01-07loplugin:nullptrStephan Bergmann
Change-Id: I9b12524ddbe3cd26800af53415fa593984f2b816
2016-01-06tdf#39631 - branch hints: comment, and tweak variously, also use.Michael Meeks
Find a few million mis-predicted branches (according to callgrind) and annotate them. Mark string acquire/release as hot, and a number of deprecated methods as cold. Change-Id: I678b3981794221c97f9ebb70fd0161c0fda5dceb
2015-12-20sal: replace a list with vectorMichael Stahl
std::stable_sort requires random access iterators, which std::list does not provide, so this is not actually supposed to work, but strangely does. But there's no reason why this couldn't be a vector. Change-Id: I98ec5c28204d01a7352d15ed783748fc17bd8105
2015-12-17OString/OUString: move constructors and operator=Noel Grandin
Change-Id: Icdc5f7137cca8360f116d5d4c7b0bf4a4c526e1d Reviewed-on: https://gerrit.libreoffice.org/20712 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-15Use %tx to print ptrdiff_t.Damjan Jovanovic
Patch by: me (cherry picked from commit 7d41b0a9559a388fe558cf7e8d81e4909a785af3) Change-Id: I5e087de043bf454268e4a3ccf24d9e25de3735ee
2015-12-15Use %p to print pointers in sal backtraces..Damjan Jovanovic
instead of 0x%x + conversion to integer. Patch by: me (cherry picked from commit 25f185144085ebe06405a5d8f19a11544ed7f794) Change-Id: I49197aed7bc2dc92a4b54d9aa6a7dce95ebadcfb
2015-12-10More loplugin:nullptr automatic rewrite (within templates)Stephan Bergmann
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
2015-12-04Fix includeStephan Bergmann
Change-Id: I8dd2624cf70dbb34f6fe0a1744c3266dcef07198
2015-12-04Missing includeStephan Bergmann
Change-Id: I97c7a1c3c8a1dca0227477b54c4ce17530bd6b33
2015-12-02sal: add SAL_DEBUG_TRACE debugging API for Windows, with UNX stub.Michael Meeks
Change-Id: I2fdbc2ac10f483eee154bdf69479ba217a91ef7f Reviewed-on: https://gerrit.libreoffice.org/19605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-12-02Adapt new/delete exception specs for MSVCStephan Bergmann
...where plain operator new/delete are reportedly predefined (cf. <www.geoffchappell.com/studies/msvc/language/predefined/index.html>) without any exception specs, then redeclared in C:/PROGRA~2/MICROS~1.0/VC/include/new with exception specs that are ignored by MSVC (so it presumably doesn't even complain about the mismatching redeclarations, just effectively ignores them); and array operator new/delete are declared in C:/PROGRA~2/MICROS~1.0/VC/include/crtdbg.h without any exception specs. clang-cl would warn about those inconsistencies. Change-Id: I4dd15e4cfcedc3de5e8617b43769b5371cafa71f
2015-12-02Fix quotingStephan Bergmann
Change-Id: I4a4a7c4a1596837c2f221d856228d7d26482ede3
generated by cgit (git 2.34.1) at 2025-02-08 18:06:21 +0000