summaryrefslogtreecommitdiff
path: root/sax/qa
AgeCommit message (Collapse)Author
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-29loplugin:unreffunStephan Bergmann
Change-Id: I31e62926ddfddc8bbdab681a55cdc381d3275794
2016-05-28sax2/ unit tests.Mohammed Abdul Azeem
Test xml files are added, string is built for each file and namespaces are handled. Change-Id: I0ab799ca5c9de7311ccca2a6033a96e02598064f Reviewed-on: https://gerrit.libreoffice.org/25468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-22-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I286afa5f5f849217c282c8408822522d9ce5a10b
2016-05-19loplugin:unreffun and loplugin:nullptrNoel Grandin
Change-Id: I0b8e094d5f5db4b9add46894c4a606256c2d6904 Reviewed-on: https://gerrit.libreoffice.org/25159 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19First cut at adding sax2/ unit tests.Mohammed Abdul Azeem
This is a first-step towards implementing the legacy parser using the XFastParser. Change-Id: I37fc0419dbef1d6f067e45e0b1f2fd6051fb158d Reviewed-on: https://gerrit.libreoffice.org/24883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-17sax: use CPPUNIT_ASSERT_THROWMatúš Kukan
Change-Id: I34b0b559a91e77cc497e14d8ffad7e2c80e43d79 Reviewed-on: https://gerrit.libreoffice.org/21531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2015-12-24loplugin:unusedfieldsNoel Grandin
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I54bf272b404d2302cafbde73ec5061ea2cd966ab
2015-10-20new loplugin: badvectorinitNoel Grandin
look for places calling the 1-argument vector fill constructor and then immediately called push_back, which is generally a sign that its leaving empty slots. Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517 Reviewed-on: https://gerrit.libreoffice.org/17525 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-08-27sax: tdf#88206 replace cppu::WeakImplHelper*Takeshi Abe
with the variadic variants. Change-Id: Id8d0c61b0454652abbbd09be0c72696a057dc2d2 Reviewed-on: https://gerrit.libreoffice.org/18008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-01-20Some more loplugin:cstylecast: saxStephan Bergmann
Change-Id: I3ded4f19f73a094dabd2d2da54917290ffe468f5
2014-09-19Remove unused XFastTokenHandler functionsMatúš Kukan
Change-Id: I0d8072f1194aa837932dcffd6dc6a3761bbdc74e
2014-09-19Use FastSaxParser directlyMatúš Kukan
Change-Id: I2f21438a0ccc6bc096f3257c48e088c4114d9f45
2014-09-18fastparser: Use dummy token handler in unit test instead of an oox one.Matúš Kukan
Change-Id: I4562156858982857a17e8837106c4c946f175be7
2014-05-14various loplugin:passsequencebyrefNoel Grandin
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-02-12Improve output in case of test failureStephan Bergmann
Change-Id: If094349998d41972f50e12363a5a223ee87fdcec
2013-12-19css.xml.sax service ctor clean-upStephan Bergmann
Change-Id: I556904861e93a145cfe65f61218926851e4e8eb0
2013-12-17Improve CPPUNIT_ASSERTsStephan Bergmann
Change-Id: I971602ce562ae0e11be5ac7b4d1eefbd342b625c
2013-12-10sax, xmloff: fix ODF import/export of text:time/text:time-valueMichael Stahl
The value written for an Impress time field is something like text:time-value="0000-00-00T23:28:07" (in LO 3.5+) or text:time-value="0-00-00T23:28:07" (in OOo 3.3) which contains an invalid all-zero date. Such values are actually rejected by the ODF import since commit ae3e2f170045a1525f67e9f3e9b7e03d94f2b56b. Actually there was no real support to read the RelaxNG type timeOrDateTime before. So fix that by: - adding convertTimeOrDateTime/parseTimeOrDateTime functions to sax::Converter - recognizing and ignoring the 2 invalid all-zero values written by LO 3.5 and historic OOo respectively - writing a bare "time" in text:time-value if the DateTime struct contains zero Date members (Older OOo versions and AOO cannot actually read that, but everything they _can_ read is invalid ODF...) Change-Id: I754076caee74a5163ed3f972af0f23796aa14f9f
2013-10-21Remove comphelper::ComponentContextStephan Bergmann
Change-Id: Idc5974e5a2ec68e8f1b2312a88fab15092c82788
2013-10-21FastTokenHandler service should apparently have a default constructorStephan Bergmann
Change-Id: Iad5c4e05832128b5f41860cc4ae96f0472c37491
2013-10-17sax: fix build: needs explicit typeMatúš Kukan
Change-Id: I5a5c52215b0177d663f0694515240c3f95a3ab40
2013-10-17sax: add unit test for FastAttributeListMatúš Kukan
Change-Id: Ie87c80383991dca84b4f6e2074c5c53567ded0b6
2013-10-17sax: add unit test for FastSaxParserMatúš Kukan
Adapt FastSaxParser so that it does not require XFastDocumentHandler. Change-Id: I7af49752dfbb4b55b8dde094fe6b762bd179be78
2013-08-04fixup SAL_INFO macros to actually print the stringsLionel Elie Mamane
Change-Id: I26bf8376d27f7fcbf8a83b7356d252dce9061fcb
2013-08-04sax converter unittest: test accept trailing zeros in fractional secondsLionel Elie Mamane
Change-Id: I3b6080df1cf8c13b5c0781c34c7806ac3c2cfbc7
2013-07-15i#108348: support DateTimeWithTimezone in user defined Document PropertiesMichael Stahl
- fix interface of sax::Converter to allow passing time zones (rename the parsing methods while at it to reduce pointless overloading) - SfxDocumentMetaData supports DateWithTimezone and DateTimeWithTimezone in user-defined properties - add some ugly hacks to SfxCustomPropertiesPage to preserve existing time zones (which are not displayed in UI currently) Change-Id: Ice94112b9d79c285f80b5beda15f0ace91db97f3
2013-07-15i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.Michael Stahl
Add IsUTC member to: com.sun.star.util.DateTime com.sun.star.util.DateTimeRange com.sun.star.util.Time Add new stucts with explicit time zones: com.sun.star.util.DateTimeWithTimezone com.sun.star.util.DateWithTimezone com.sun.star.util.TimeWithTimezone Adapt the sax::Converter to read/write timezones, and fix the unit test. Everything else just uses default (no time zone), this commit is just to fix the API. STRUCT: /UCR/com/sun/star/util/DateTime nFields1 = 7 != nFields2 = 8 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/DateTimeRange nFields1 = 14 != nFields2 = 15 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/Time nFields1 = 4 != nFields2 = 5 Registry2 contains 1 more fields Conflicts: sc/source/filter/oox/unitconverter.cxx Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18 Reviewed-on: https://gerrit.libreoffice.org/4833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-06-29i#108348 sax::Converter: support negative date and dateTimeMichael Stahl
Change-Id: Ie2726c7ec941a5690e053d39212d7f516e2c27ba
2013-04-18date/time IDL datatypes incompatible changeLionel Elie Mamane
- nanosecond precision - signed (allowed negative) year Also: assorted improvements / bugfixes in date/time handling code. Some factorisation of copy/pasted code. Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-02-19fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan
- replaced osl_trace with sal_info - added new log areas to log-area.dox Change-Id: Ib47c4b4c9604bca1f8a635dd01bb89702b47b591 Reviewed-on: https://gerrit.libreoffice.org/2010 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2012-08-15warning C4310: cast truncates constant valueMichael Stahl
Change-Id: I3ebaec3953f86e8f42937e29fad54bafe87900fa
2012-08-15sigh.. MSVC warning C4146: unary minus applied to unsigned type?Michael Stahl
Change-Id: Ic2bbde637fd0a074f89b5ffa7af6e87d7cb408c5
2012-08-15oops forgot #include limitsMichael Stahl
Change-Id: I49161e270eda68d693181c3fff578ba5511bc6d4
2012-08-15overflow in implicit constant conversion [-Werror=overflow]Michael Stahl
Change-Id: I4fa1168a06118066c72a66801d911a49653f425f
2012-08-15decodeBase64 test is done and workingArtur Dorda
Change-Id: I4dfc20e0e577f986c626d4c4bab5b4e3214e4567
2012-08-15encodeBase64 test is workingArtur Dorda
Change-Id: I598ea47ff02b15fdb1d7ff3992d2c660f5a41c95
2012-08-15added some extreme values in string-to-measure testArtur Dorda
Change-Id: I8fd9029f42159444e7bb56f89eeb83fdb3745732
2012-08-15'string to number' test coveredArtur Dorda
Change-Id: Ib8a81edce168be5babd1bcd62746199de77c2ade