Age | Commit message (Collapse) | Author |
|
Change-Id: Iddf4e29005aaa510af00c7345487996b75f41c41
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
Change-Id: I624ca41c3e51ba785e359649c429feb61cc9a647
|
|
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
|
|
Change-Id: Ica31580f72b43456c33b2f6abbf2140a79efae1a
Reviewed-on: https://gerrit.libreoffice.org/8299
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9225b4ffd507fa3d666862a55dae349c9a76e91d
|
|
Change-Id: I3983da2d585762d81446902a710e9a97c6354669
|
|
Change-Id: I1602678c24c1aeec60acee05801e7decc914560f
|
|
Change-Id: I15f6c6288e2a951543702a15e777167f2240899e
|
|
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.
Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
|
|
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.
As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.
Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
|
|
Most of the constructors are supposed to be only a call of
new TheInstance(arguments)
or an equivalent; so let's just change the constructor caller accordingly, to
accept unacquired new instance.
If there are exceptions that need to do more heavy lifting, they do not have
to use the constructor feature, or there can be a wrapper for the real
implementation, doing the additional work in their (C++) constructor.
Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
|
|
There is no need to use different styles for writing the same thing.
It also makes it easier in future to use search & replace.
But of course, there are also some more complicated functions.
Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
|
|
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
|
|
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
|
|
boost::optional appears to show up rather heavily on many profiles.
We already use mnElementToken == DONTKNOW to flag / use these guys.
Change-Id: Ibf2b0167f259cc601da2fb9703e880b78e60886e
|
|
Change-Id: Iae455f53f8317eecb8edc38d111c9ef7398a36fb
|
|
Change-Id: I06c0f9dc742736f632ed9210ae954e0dc19ca19d
|
|
Change-Id: Ibe4b4d3785535816b40d46fd0baa60f01e1f9d33
|
|
amazingly std::stack::top() takes 146 pseudo-cycles to do not much,
so instead cache the result in a single pointer in lieu of burning
that code.
Change-Id: Ie326be47da6cbad0850e5f1026a1632bb840b6b8
|
|
Change-Id: I70e1597f917c2a8dedb5b38807dfde7ec05a1a39
|
|
Change-Id: I564e35aa63e4c01cc1a0fb45f674dc1a2a0e89ec
|
|
Remove erroneous assert: maSavedException is indeed empty for
XML parser reported exceptions. Clean cut/paste code, and comment.
Change-Id: Ia538bcc87a7efcd079d3021e00ac4d2eb62f3e8d
|
|
...to directly call constructor functions of ComponentContext-based C++
implementations of (non-single-instance) UNO services. The case where these
calls would need to be bridged across different environments (e.g., from gcc3
to gcc3:affine) is not yet implemented.
bootstrap.component and expwrap.component are adapted accordingly as a proof-of-
concept (which had previously been adapted to use the prefix="direct" feature,
which may become unnecessary again in the end, depending on how to handle
single-instance services/singletons). More to follow.
Change-Id: I18682d75bcd29d3d427e31331b4ce8161dbb846d
|
|
Change-Id: Iba701c520ad27925bb5e67697e22132b53160ab2
|
|
Use more anonymous namespaces, de-duplicate code, bin some comments.
Makes the library smaller.
Change-Id: Id0cefdcaa72a74741303fc27e36038488ef8b059
|
|
Change-Id: I6f8c6827c00db50184a46f39968f882b944d18d4
Reviewed-on: https://gerrit.libreoffice.org/6967
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
|
|
Change-Id: I243ec20015beec6b98ee0af55eb7c387008f32f1
|
|
Change-Id: Ia6c481bbf5353db4c2801a53ae1455534c6978bd
|
|
Change-Id: Ibfd9bf626a40c3ec4eb18d09944e8943163595c8
|
|
Useful when we just need to check if the stream has a certain namespace
defined. Calling getNamespaceURL() may throw SAXException in such case.
Change-Id: Ib2b7b202492390158270d87bab95d1793c9d8a70
|
|
Change-Id: I356b26947d1018276d8a9ff6012fdad3ca2c0fd8
|
|
Change-Id: Ie2cff194c1db5eaa992c4bcaaa06ec9a419d85a7
|
|
Change-Id: I4aec1d45edb47ea16adaa8d2ac23340b8f421bae
|
|
|
|
Change-Id: I978a692fbf464b476811b445b16c7e1b0eec9e25
|
|
|
|
|
|
|
|
Change-Id: I4c09aaa12b53181e50662de2721d170c195c7c86
|
|
Change-Id: I99a39e91c684adb1fc92cdb466477cfa90104961
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d
Reviewed-on: https://gerrit.libreoffice.org/6423
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I9783f03e656049b4f3b7f0a26a7ae626db5a13f6
|
|
Change-Id: I6f4eac6103821227bc72de8c3bb0fb89a7a8bc9d
|
|
Determined by XInputStream::available().
Change-Id: I450f4796d9c072b395393582bfc3e1e7768e243b
|
|
Change-Id: I1e12fbeeb90d6020d0566d05fc0318082e1da5fc
|
|
Instead of allocating and freeing the memory all the time.
Change-Id: I53800abaca51d42d7d44a98fb271de7df7f90f58
|
|
Change-Id: I7fe1435addc6dce5a74a8411f7825cea331a5b3f
|