summaryrefslogtreecommitdiff
path: root/sax/source
AgeCommit message (Collapse)Author
2014-09-18Better to throw than crash, if token handler is not set.Matúš Kukan
Change-Id: If6b2d39b487b5f673d5b6b2945a6e7d08777594e
2014-08-30Use plain bool parameter hereMatúš Kukan
Change-Id: Ic948889a0fac32adc48a7a4fb1e7f82ce8b08ba4
2014-08-07Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann
Change-Id: I2d4e4be562cc752e7545792b148d5ed0cf551f25
2014-07-11fdo#81214 - tolerate exceptions thrown inside XFastParser callbacks.Michael Meeks
Not an ideal solution; ideally we should not throw the exceptions, and stop the parser as soon as something bad like this happens; but hopefully exception throwing is reasonable exceptional. Change-Id: If619592533b2929c671e2b03eb8a83480bd92c54
2014-07-03FastSaxSerializer: update documentationMiklos Vajna
Change-Id: I5e374c426a4741a88d43848392fc83e2368dbf92
2014-07-03fdo#80748: Fix for file corruption due to framePrRohit Deshmukh
-For framePr Unit test is there in ooxmlexport.cxx -http://opengrok.libreoffice.org/xref/core/sw/qa/extras/ooxmlexport/ooxmlexport.cxx#3578 Change-Id: Ic1fd4c7a863d8ab57c6495e20bff6863eb941688 Reviewed-on: https://gerrit.libreoffice.org/10045 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-06-30Use a new fast parser instance for each XML fragment.Kohei Yoshida
Otherwise a crash ensues when the threaded XML parsing kicks in. Change-Id: Ic41e5a29bbb860d7b63b70f2f0d8896264d9d53e
2014-06-30Check for empty() before calling top().Kohei Yoshida
Else it might crash sometimes. Change-Id: I6a24fff83c3d36346debae5c0f2b8c0646a15c01
2014-06-30Don't go further and pop the stack if it's empty.Kohei Yoshida
Change-Id: I27bd30ca65cf0066cd022b4b060757913ea01fed
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: If21a079134f659a91f0b0ce400aef56bd095effe
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-27css already means ::com::sun::starThomas Arnhold
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
2014-05-26coverity#982640 Missing break in switchCaolán McNamara
Change-Id: If2a14edafb72844061dcdd1ee3507d7a215220f1
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-10coverity#707979 Uninitialized pointer fieldCaolán McNamara
Change-Id: Id41ba6ab2c6f0a43f439c2b45d20d7d76a3cbe82
2014-04-24Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: I047fd88a89900153089a55b6af123f11fb8bde55
2014-04-14typo: choosen -> chosenThomas Arnhold
2014-04-09Remove unused functionsStephan Bergmann
Change-Id: Iddf4e29005aaa510af00c7345487996b75f41c41
2014-04-07sax: sal_Bool->boolNoel Grandin
Change-Id: I8d9dd585c509fd4c1f09ee817d828f3e600e31d5
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-05sax: FastAttributeList - add attribute in a specific namespaceTomaž Vajngerl
This change is inspired by startElementNS & singleElementNS which have namespace as first parameter to define the namespace of an element. Some attributes of a element can be in different namespace but until now FastAttributeList "add" method did not have a namespace parameter. This commit adds "addNS" which accepts namespace as a first parameter. Change-Id: Iebf8b5e890c17f00a56923efc3506580eed070a9
2014-03-02remove whitespacesMarkus Mohrhard
Change-Id: I624ca41c3e51ba785e359649c429feb61cc9a647
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from saxAlexander Wilms
Change-Id: Ica31580f72b43456c33b2f6abbf2140a79efae1a Reviewed-on: https://gerrit.libreoffice.org/8299 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25remove unused code sax_fastparser::FastSerializerHelper::copyTopMarkPop()Noel Grandin
Change-Id: If1dd0e99d83f8211c58fa3b5d1ba56a74bc2157f
2014-02-25remove unused code sax_fastparser::FastSerializerHelper::copyTopMarkPush()Noel Grandin
Change-Id: I4569e53f0423783bc5c9ee95b07d0de51b75b466
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21[API CHANGE] fix endCDATA to allow throwing css::xml::sax::SAXExceptionCaolán McNamara
coverity#1158397 Uncaught exception Change-Id: Iabf0b1f0500cb4218d8cb3aff372777471e8f287
2014-02-11Related: #i97873# (coverity#705407) Improper use of negative valueCaolán McNamara
a pity the other one wasn't fixed when the first one was fixed back in 2002 with 0645e6a1a1917fef833358f328b5d56396380698 Change-Id: Ia7ac0f57a6805dc8ff09668198d0530b1cfc31db
2014-02-11sax: my suggestion was not as good as i thought...Michael Stahl
... as indicated by the failing unit test. Change-Id: I1a8a8b933b10673e71261726dc8887dfe1d3e2ee
2014-02-11fdo#72468 avoid out of bounds array accessArnaud Versini
Change-Id: I2bccdf1aaeb290a3cb8f76cd831a419e1776e92f Reviewed-on: https://gerrit.libreoffice.org/7775 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-08coverity#1130446 Uncaught exceptionCaolán McNamara
Change-Id: I9225b4ffd507fa3d666862a55dae349c9a76e91d
2014-02-07Use rtl::ReferenceStephan Bergmann
Change-Id: Ia14ad80f13bffe4c1d0078da0198a3ae6eae581e
2014-02-07Avoid css::uno using directives (Reference ambiguities)Stephan Bergmann
Change-Id: Ia702572bef47738531b526addeecd86e7b39aad2
2014-01-251158273 Uncaught exceptionCaolán McNamara
Change-Id: I3983da2d585762d81446902a710e9a97c6354669
2014-01-23coverity#1158443 Uninitialized pointer fieldCaolán McNamara
Change-Id: I1602678c24c1aeec60acee05801e7decc914560f
2014-01-23coverity#1158444 Uninitialized scalar fieldCaolán McNamara
Change-Id: I15f6c6288e2a951543702a15e777167f2240899e
2014-01-23coverity#1158445 Uninitialized pointer fieldCaolán McNamara
Change-Id: I14dc2197543bf98763190b5aea3a366e823312b4
2014-01-23coverity#1158493 Uninitialized scalar fieldCaolán McNamara
Change-Id: I26de8ab1fa4a20bc08e800f04716507469430612
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-18Unify ctor functions for component implementations.Matúš Kukan
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
2014-01-15Unify ctor functions to have _get_implementation suffix.Matúš Kukan
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
2014-01-15Use const& arguments parameter for ctor functions.Matúš Kukan
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
2014-01-14fastparser: avoid boost::optional where it is un-necessary.Michael Meeks
boost::optional appears to show up rather heavily on many profiles. We already use mnElementToken == DONTKNOW to flag / use these guys. Change-Id: Ibf2b0167f259cc601da2fb9703e880b78e60886e
2014-01-10Use boolStephan Bergmann
Change-Id: Iae455f53f8317eecb8edc38d111c9ef7398a36fb
generated by cgit (git 2.34.1) at 2024-07-19 22:24:13 +0000