Age | Commit message (Collapse) | Author |
|
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
|
|
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Id41ba6ab2c6f0a43f439c2b45d20d7d76a3cbe82
|
|
Change-Id: I047fd88a89900153089a55b6af123f11fb8bde55
|
|
|
|
|
|
Change-Id: Iddf4e29005aaa510af00c7345487996b75f41c41
|
|
Change-Id: I8d9dd585c509fd4c1f09ee817d828f3e600e31d5
|
|
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
|
|
This change is inspired by startElementNS & singleElementNS which
have namespace as first parameter to define the namespace of an
element. Some attributes of a element can be in different namespace
but until now FastAttributeList "add" method did not have a namespace
parameter. This commit adds "addNS" which accepts namespace as a
first parameter.
Change-Id: Iebf8b5e890c17f00a56923efc3506580eed070a9
|
|
Change-Id: I624ca41c3e51ba785e359649c429feb61cc9a647
|
|
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
|
|
Change-Id: Ica31580f72b43456c33b2f6abbf2140a79efae1a
Reviewed-on: https://gerrit.libreoffice.org/8299
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If1dd0e99d83f8211c58fa3b5d1ba56a74bc2157f
|
|
Change-Id: I4569e53f0423783bc5c9ee95b07d0de51b75b466
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
coverity#1158397 Uncaught exception
Change-Id: Iabf0b1f0500cb4218d8cb3aff372777471e8f287
|
|
Change-Id: If094349998d41972f50e12363a5a223ee87fdcec
|
|
a pity the other one wasn't fixed when the first one was fixed
back in 2002 with 0645e6a1a1917fef833358f328b5d56396380698
Change-Id: Ia7ac0f57a6805dc8ff09668198d0530b1cfc31db
|
|
... as indicated by the failing unit test.
Change-Id: I1a8a8b933b10673e71261726dc8887dfe1d3e2ee
|
|
Change-Id: I2bccdf1aaeb290a3cb8f76cd831a419e1776e92f
Reviewed-on: https://gerrit.libreoffice.org/7775
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I9225b4ffd507fa3d666862a55dae349c9a76e91d
|
|
Change-Id: Ia14ad80f13bffe4c1d0078da0198a3ae6eae581e
|
|
Change-Id: Ia702572bef47738531b526addeecd86e7b39aad2
|
|
Change-Id: I3983da2d585762d81446902a710e9a97c6354669
|
|
Change-Id: I1602678c24c1aeec60acee05801e7decc914560f
|
|
Change-Id: I15f6c6288e2a951543702a15e777167f2240899e
|
|
Change-Id: I14dc2197543bf98763190b5aea3a366e823312b4
|
|
Change-Id: I26de8ab1fa4a20bc08e800f04716507469430612
|
|
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.
Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
|
|
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.
As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.
Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
|
|
Most of the constructors are supposed to be only a call of
new TheInstance(arguments)
or an equivalent; so let's just change the constructor caller accordingly, to
accept unacquired new instance.
If there are exceptions that need to do more heavy lifting, they do not have
to use the constructor feature, or there can be a wrapper for the real
implementation, doing the additional work in their (C++) constructor.
Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
|
|
There is no need to use different styles for writing the same thing.
It also makes it easier in future to use search & replace.
But of course, there are also some more complicated functions.
Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
|
|
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
|
|
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
|
|
boost::optional appears to show up rather heavily on many profiles.
We already use mnElementToken == DONTKNOW to flag / use these guys.
Change-Id: Ibf2b0167f259cc601da2fb9703e880b78e60886e
|
|
Change-Id: Iae455f53f8317eecb8edc38d111c9ef7398a36fb
|
|
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
Change-Id: I06c0f9dc742736f632ed9210ae954e0dc19ca19d
|
|
Change-Id: Ibe4b4d3785535816b40d46fd0baa60f01e1f9d33
|
|
amazingly std::stack::top() takes 146 pseudo-cycles to do not much,
so instead cache the result in a single pointer in lieu of burning
that code.
Change-Id: Ie326be47da6cbad0850e5f1026a1632bb840b6b8
|
|
Change-Id: I70e1597f917c2a8dedb5b38807dfde7ec05a1a39
|
|
Change-Id: I564e35aa63e4c01cc1a0fb45f674dc1a2a0e89ec
|
|
Remove erroneous assert: maSavedException is indeed empty for
XML parser reported exceptions. Clean cut/paste code, and comment.
Change-Id: Ia538bcc87a7efcd079d3021e00ac4d2eb62f3e8d
|
|
Change-Id: I556904861e93a145cfe65f61218926851e4e8eb0
|
|
...to directly call constructor functions of ComponentContext-based C++
implementations of (non-single-instance) UNO services. The case where these
calls would need to be bridged across different environments (e.g., from gcc3
to gcc3:affine) is not yet implemented.
bootstrap.component and expwrap.component are adapted accordingly as a proof-of-
concept (which had previously been adapted to use the prefix="direct" feature,
which may become unnecessary again in the end, depending on how to handle
single-instance services/singletons). More to follow.
Change-Id: I18682d75bcd29d3d427e31331b4ce8161dbb846d
|
|
Change-Id: Iba701c520ad27925bb5e67697e22132b53160ab2
|