Age | Commit message (Collapse) | Author |
|
Change-Id: If1dd0e99d83f8211c58fa3b5d1ba56a74bc2157f
|
|
Change-Id: I4569e53f0423783bc5c9ee95b07d0de51b75b466
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
coverity#1158397 Uncaught exception
Change-Id: Iabf0b1f0500cb4218d8cb3aff372777471e8f287
|
|
Change-Id: If094349998d41972f50e12363a5a223ee87fdcec
|
|
a pity the other one wasn't fixed when the first one was fixed
back in 2002 with 0645e6a1a1917fef833358f328b5d56396380698
Change-Id: Ia7ac0f57a6805dc8ff09668198d0530b1cfc31db
|
|
... as indicated by the failing unit test.
Change-Id: I1a8a8b933b10673e71261726dc8887dfe1d3e2ee
|
|
Change-Id: I2bccdf1aaeb290a3cb8f76cd831a419e1776e92f
Reviewed-on: https://gerrit.libreoffice.org/7775
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I9225b4ffd507fa3d666862a55dae349c9a76e91d
|
|
Change-Id: Ia14ad80f13bffe4c1d0078da0198a3ae6eae581e
|
|
Change-Id: Ia702572bef47738531b526addeecd86e7b39aad2
|
|
Change-Id: I3983da2d585762d81446902a710e9a97c6354669
|
|
Change-Id: I1602678c24c1aeec60acee05801e7decc914560f
|
|
Change-Id: I15f6c6288e2a951543702a15e777167f2240899e
|
|
Change-Id: I14dc2197543bf98763190b5aea3a366e823312b4
|
|
Change-Id: I26de8ab1fa4a20bc08e800f04716507469430612
|
|
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.
Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
|
|
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.
As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.
Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
|
|
Most of the constructors are supposed to be only a call of
new TheInstance(arguments)
or an equivalent; so let's just change the constructor caller accordingly, to
accept unacquired new instance.
If there are exceptions that need to do more heavy lifting, they do not have
to use the constructor feature, or there can be a wrapper for the real
implementation, doing the additional work in their (C++) constructor.
Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
|
|
There is no need to use different styles for writing the same thing.
It also makes it easier in future to use search & replace.
But of course, there are also some more complicated functions.
Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
|
|
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
|
|
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
|
|
boost::optional appears to show up rather heavily on many profiles.
We already use mnElementToken == DONTKNOW to flag / use these guys.
Change-Id: Ibf2b0167f259cc601da2fb9703e880b78e60886e
|
|
Change-Id: Iae455f53f8317eecb8edc38d111c9ef7398a36fb
|
|
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
Change-Id: I06c0f9dc742736f632ed9210ae954e0dc19ca19d
|
|
Change-Id: Ibe4b4d3785535816b40d46fd0baa60f01e1f9d33
|
|
amazingly std::stack::top() takes 146 pseudo-cycles to do not much,
so instead cache the result in a single pointer in lieu of burning
that code.
Change-Id: Ie326be47da6cbad0850e5f1026a1632bb840b6b8
|
|
Change-Id: I70e1597f917c2a8dedb5b38807dfde7ec05a1a39
|
|
Change-Id: I564e35aa63e4c01cc1a0fb45f674dc1a2a0e89ec
|
|
Remove erroneous assert: maSavedException is indeed empty for
XML parser reported exceptions. Clean cut/paste code, and comment.
Change-Id: Ia538bcc87a7efcd079d3021e00ac4d2eb62f3e8d
|
|
Change-Id: I556904861e93a145cfe65f61218926851e4e8eb0
|
|
...to directly call constructor functions of ComponentContext-based C++
implementations of (non-single-instance) UNO services. The case where these
calls would need to be bridged across different environments (e.g., from gcc3
to gcc3:affine) is not yet implemented.
bootstrap.component and expwrap.component are adapted accordingly as a proof-of-
concept (which had previously been adapted to use the prefix="direct" feature,
which may become unnecessary again in the end, depending on how to handle
single-instance services/singletons). More to follow.
Change-Id: I18682d75bcd29d3d427e31331b4ce8161dbb846d
|
|
Change-Id: Iba701c520ad27925bb5e67697e22132b53160ab2
|
|
Use more anonymous namespaces, de-duplicate code, bin some comments.
Makes the library smaller.
Change-Id: Id0cefdcaa72a74741303fc27e36038488ef8b059
|
|
Demonstrating on expwrap library.
There is hope, this will bring code size savings for mobile
platforms, where we don't need every implementation.
Change-Id: I3519fb6148fd7a47ed9df092c73779ea6add552f
|
|
Change-Id: Iddf93a116cb333db6465a915dae692c33a60241a
|
|
Change-Id: I30c4005e5983f5007edfed692b74f07b31899755
|
|
...so that is what the std::min was good for that the previous commit erroneously removed.
Change-Id: I0cb08ab79f85ce4b919232845994c9b8bae35646
|
|
Change-Id: Ia7c62d57c56a27e097dbe252b6c6cac8fba7ace5
|
|
...otherwise at least my --disable-dbgutil --disable-debug Linux x86_64 build
failed the CppunitTest_sax_cpputest with 8999999 vs. 9000000 nanoseconds.
Change-Id: I05e0febf413f9f9e01227a0cc4e0f46a5243fe61
|
|
Change-Id: I971602ce562ae0e11be5ac7b4d1eefbd342b625c
|
|
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
|
|
Change-Id: I6f8c6827c00db50184a46f39968f882b944d18d4
Reviewed-on: https://gerrit.libreoffice.org/6967
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
|
|
The value written for an Impress time field is something like
text:time-value="0000-00-00T23:28:07" (in LO 3.5+) or
text:time-value="0-00-00T23:28:07" (in OOo 3.3) which contains an
invalid all-zero date. Such values are actually rejected by the
ODF import since commit ae3e2f170045a1525f67e9f3e9b7e03d94f2b56b.
Actually there was no real support to read the RelaxNG type
timeOrDateTime before.
So fix that by:
- adding convertTimeOrDateTime/parseTimeOrDateTime functions to
sax::Converter
- recognizing and ignoring the 2 invalid all-zero values written by
LO 3.5 and historic OOo respectively
- writing a bare "time" in text:time-value if the DateTime struct
contains zero Date members
(Older OOo versions and AOO cannot actually read that, but everything
they _can_ read is invalid ODF...)
Change-Id: I754076caee74a5163ed3f972af0f23796aa14f9f
|
|
Change-Id: I243ec20015beec6b98ee0af55eb7c387008f32f1
|
|
Change-Id: I447218101e1791375273580a313dd54708303d7a
|
|
Change-Id: Ia6c481bbf5353db4c2801a53ae1455534c6978bd
|
|
Change-Id: Ibfd9bf626a40c3ec4eb18d09944e8943163595c8
|
|
Useful when we just need to check if the stream has a certain namespace
defined. Calling getNamespaceURL() may throw SAXException in such case.
Change-Id: Ib2b7b202492390158270d87bab95d1793c9d8a70
|