summaryrefslogtreecommitdiff
path: root/sax
AgeCommit message (Collapse)Author
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-05sax: FastAttributeList - add attribute in a specific namespaceTomaž Vajngerl
This change is inspired by startElementNS & singleElementNS which have namespace as first parameter to define the namespace of an element. Some attributes of a element can be in different namespace but until now FastAttributeList "add" method did not have a namespace parameter. This commit adds "addNS" which accepts namespace as a first parameter. Change-Id: Iebf8b5e890c17f00a56923efc3506580eed070a9
2014-03-02remove whitespacesMarkus Mohrhard
Change-Id: I624ca41c3e51ba785e359649c429feb61cc9a647
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from saxAlexander Wilms
Change-Id: Ica31580f72b43456c33b2f6abbf2140a79efae1a Reviewed-on: https://gerrit.libreoffice.org/8299 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25remove unused code sax_fastparser::FastSerializerHelper::copyTopMarkPop()Noel Grandin
Change-Id: If1dd0e99d83f8211c58fa3b5d1ba56a74bc2157f
2014-02-25remove unused code sax_fastparser::FastSerializerHelper::copyTopMarkPush()Noel Grandin
Change-Id: I4569e53f0423783bc5c9ee95b07d0de51b75b466
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21[API CHANGE] fix endCDATA to allow throwing css::xml::sax::SAXExceptionCaolán McNamara
coverity#1158397 Uncaught exception Change-Id: Iabf0b1f0500cb4218d8cb3aff372777471e8f287
2014-02-12Improve output in case of test failureStephan Bergmann
Change-Id: If094349998d41972f50e12363a5a223ee87fdcec
2014-02-11Related: #i97873# (coverity#705407) Improper use of negative valueCaolán McNamara
a pity the other one wasn't fixed when the first one was fixed back in 2002 with 0645e6a1a1917fef833358f328b5d56396380698 Change-Id: Ia7ac0f57a6805dc8ff09668198d0530b1cfc31db
2014-02-11sax: my suggestion was not as good as i thought...Michael Stahl
... as indicated by the failing unit test. Change-Id: I1a8a8b933b10673e71261726dc8887dfe1d3e2ee
2014-02-11fdo#72468 avoid out of bounds array accessArnaud Versini
Change-Id: I2bccdf1aaeb290a3cb8f76cd831a419e1776e92f Reviewed-on: https://gerrit.libreoffice.org/7775 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-08coverity#1130446 Uncaught exceptionCaolán McNamara
Change-Id: I9225b4ffd507fa3d666862a55dae349c9a76e91d
2014-02-07Use rtl::ReferenceStephan Bergmann
Change-Id: Ia14ad80f13bffe4c1d0078da0198a3ae6eae581e
2014-02-07Avoid css::uno using directives (Reference ambiguities)Stephan Bergmann
Change-Id: Ia702572bef47738531b526addeecd86e7b39aad2
2014-01-251158273 Uncaught exceptionCaolán McNamara
Change-Id: I3983da2d585762d81446902a710e9a97c6354669
2014-01-23coverity#1158443 Uninitialized pointer fieldCaolán McNamara
Change-Id: I1602678c24c1aeec60acee05801e7decc914560f
2014-01-23coverity#1158444 Uninitialized scalar fieldCaolán McNamara
Change-Id: I15f6c6288e2a951543702a15e777167f2240899e
2014-01-23coverity#1158445 Uninitialized pointer fieldCaolán McNamara
Change-Id: I14dc2197543bf98763190b5aea3a366e823312b4
2014-01-23coverity#1158493 Uninitialized scalar fieldCaolán McNamara
Change-Id: I26de8ab1fa4a20bc08e800f04716507469430612
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-18Unify ctor functions for component implementations.Matúš Kukan
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
2014-01-15Unify ctor functions to have _get_implementation suffix.Matúš Kukan
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
2014-01-15Use const& arguments parameter for ctor functions.Matúš Kukan
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
2014-01-14fastparser: avoid boost::optional where it is un-necessary.Michael Meeks
boost::optional appears to show up rather heavily on many profiles. We already use mnElementToken == DONTKNOW to flag / use these guys. Change-Id: Ibf2b0167f259cc601da2fb9703e880b78e60886e
2014-01-10Use boolStephan Bergmann
Change-Id: Iae455f53f8317eecb8edc38d111c9ef7398a36fb
2014-01-07remove unnecessary sal_Unicode casts in OUStringBuffer::append callsNoel Grandin
Convert code like: buf.append( static_cast<sal_Unicode>('!') ); to: buf.append( '!' ); Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-03WaE: C4101: 'e' : unreferenced local variableTor Lillqvist
Change-Id: I06c0f9dc742736f632ed9210ae954e0dc19ca19d
2013-12-31don't call top on an empty stackCaolán McNamara
Change-Id: Ibe4b4d3785535816b40d46fd0baa60f01e1f9d33
2013-12-31fastparser: avoid std::stack::top() - cache it's results.Michael Meeks
amazingly std::stack::top() takes 146 pseudo-cycles to do not much, so instead cache the result in a single pointer in lieu of burning that code. Change-Id: Ie326be47da6cbad0850e5f1026a1632bb840b6b8
2013-12-20fastparser: move lclGetErrorMessage into the anonymous namespace.Michael Meeks
Change-Id: I70e1597f917c2a8dedb5b38807dfde7ec05a1a39
2013-12-20fastparser:: move Entity:: code into the anonymous namespace.Michael Meeks
Change-Id: I564e35aa63e4c01cc1a0fb45f674dc1a2a0e89ec
2013-12-20fastparser: fix load regressionMichael Meeks
Remove erroneous assert: maSavedException is indeed empty for XML parser reported exceptions. Clean cut/paste code, and comment. Change-Id: Ia538bcc87a7efcd079d3021e00ac4d2eb62f3e8d
2013-12-19css.xml.sax service ctor clean-upStephan Bergmann
Change-Id: I556904861e93a145cfe65f61218926851e4e8eb0
2013-12-19Add .component <implementation constructor="..." featureStephan Bergmann
...to directly call constructor functions of ComponentContext-based C++ implementations of (non-single-instance) UNO services. The case where these calls would need to be bridged across different environments (e.g., from gcc3 to gcc3:affine) is not yet implemented. bootstrap.component and expwrap.component are adapted accordingly as a proof-of- concept (which had previously been adapted to use the prefix="direct" feature, which may become unnecessary again in the end, depending on how to handle single-instance services/singletons). More to follow. Change-Id: I18682d75bcd29d3d427e31331b4ce8161dbb846d
2013-12-18Change from ServiceManager- to ComponentContext-based implementationsStephan Bergmann
Change-Id: Iba701c520ad27925bb5e67697e22132b53160ab2
2013-12-18sax: various clean up. Move _getFactory next to the implementation.Matúš Kukan
Use more anonymous namespaces, de-duplicate code, bin some comments. Makes the library smaller. Change-Id: Id0cefdcaa72a74741303fc27e36038488ef8b059
2013-12-18Allow UNO component libraries to have each implementation in its own function.Matúš Kukan
Demonstrating on expwrap library. There is hope, this will bring code size savings for mobile platforms, where we don't need every implementation. Change-Id: I3519fb6148fd7a47ed9df092c73779ea6add552f
2013-12-17sax: avoid usage of double for parsing nanoseconds here tooMichael Stahl
Change-Id: Iddf93a116cb333db6465a915dae692c33a60241a
2013-12-17...and nDigits > 9 is harmless in following for loop and need not be cappedStephan Bergmann
Change-Id: I30c4005e5983f5007edfed692b74f07b31899755
2013-12-17readUnsignedNumberMaxDigits can read more than maxDigits charsStephan Bergmann
...so that is what the std::min was good for that the previous commit erroneously removed. Change-Id: I0cb08ab79f85ce4b919232845994c9b8bae35646
2013-12-17Fix namingStephan Bergmann
Change-Id: Ia7c62d57c56a27e097dbe252b6c6cac8fba7ace5
2013-12-17Avoid inaccurate floating-point computationsStephan Bergmann
...otherwise at least my --disable-dbgutil --disable-debug Linux x86_64 build failed the CppunitTest_sax_cpputest with 8999999 vs. 9000000 nanoseconds. Change-Id: I05e0febf413f9f9e01227a0cc4e0f46a5243fe61
2013-12-17Improve CPPUNIT_ASSERTsStephan Bergmann
Change-Id: I971602ce562ae0e11be5ac7b4d1eefbd342b625c
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
generated by cgit (git 2.34.1) at 2024-12-28 21:37:23 +0000