summaryrefslogtreecommitdiff
path: root/sc/inc/cellsuno.hxx
AgeCommit message (Collapse)Author
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2014-10-31i#90076: avoid double-free race condition for ScCellRangesBaseMichael Stahl
This is similar to fdo#72695, just with SfxBroadcaster in Calc. Solve it in a similar way, by putting a WeakReference to "this" into the UNO object so its Notify() can return if another thread is already in the dtor waiting for the SolarMutex. ==11581==ERROR: AddressSanitizer: heap-use-after-free on address 0x6170006fdb08 at pc 0x2b2c4f5b8e3e bp 0x2b2c0b2ad9f0 sp 0x2b2c0b2ad9e8 READ of size 8 at 0x6170006fdb08 thread T262 (cppu_threadpool) #0 0x2b2c4f5b8e3d in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1448 #1 0x2b2c4f643914 in ScCellRangeObj::~ScCellRangeObj() /sc/source/ui/unoobj/cellsuno.cxx:4751 #2 0x2b2c4f697624 in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053 #3 0x2b2c4f69648d in ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6052 #4 0x2b2c4f69661f in non-virtual thunk to ScCellObj::~ScCellObj() /sc/source/ui/unoobj/cellsuno.cxx:6053 #5 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204 #6 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752 #7 0x2b2c4f64de58 in ScCellRangeObj::release() /sc/source/ui/unoobj/cellsuno.cxx:4800 #8 0x2b2c4f6a2c08 in ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6093 #9 0x2b2c4f6a5f0f in non-virtual thunk to ScCellObj::release() /sc/source/ui/unoobj/cellsuno.cxx:6094 #10 0x2b2c053b96fb in bridges::cpp_uno::shared::freeUnoInterfaceProxy(_uno_ExtEnvironment*, void*) /bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:43 #11 0x2b2b2bae80fb in (anonymous namespace)::s_stub_defenv_revokeInterface(__va_list_tag (*) [1]) /cppu/source/uno/lbenv.cxx:383 0x6170006fdb08 is located 264 bytes inside of 728-byte region [0x6170006fda00,0x6170006fdcd8) freed by thread T264 (cppu_threadpool) here: #3 0x2b2c49c980f5 in cppu::OWeakObject::operator delete(void*) /include/cppuhelper/weak.hxx:87 #4 0x2b2c4f5b840a in ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1442 #5 0x2b2c4f5b858f in non-virtual thunk to ScCellRangesBase::~ScCellRangesBase() /sc/source/ui/unoobj/cellsuno.cxx:1458 #6 0x2b2b2c58b6af in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:204 #7 0x2b2c4f5c50ff in ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1752 #8 0x2b2c4f5c65ff in non-virtual thunk to ScCellRangesBase::release() /sc/source/ui/unoobj/cellsuno.cxx:1753 #9 0x2b2c4af84583 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() /include/com/sun/star/uno/Reference.hxx:104 #10 0x2b2c4f5bc66f in ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1570 #11 0x2b2c4f5bdf0d in non-virtual thunk to ScCellRangesBase::Notify(SfxBroadcaster&, SfxHint const&) /sc/source/ui/unoobj/cellsuno.cxx:1645 #12 0x2b2b31dda705 in SfxBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/SfxBroadcaster.cxx:41 #13 0x2b2c4b03f2e4 in ScDocument::InsertTab(short, rtl::OUString const&, bool, bool) /sc/source/core/data/document.cxx:510 #14 0x2b2c4e7ed861 in ScDocFunc::InsertTable(short, rtl::OUString const&, bool, bool) /sc/source/ui/docshell/docfunc.cxx:3007 #15 0x2b2c50b1f415 in ScViewFunc::InsertTable(rtl::OUString const&, short, bool) /sc/source/ui/view/viewfun2.cxx:1855 #16 0x2b2c502e075f in ScDBFunc::ShowDataPilotSourceData(ScDPObject&, com::sun::star::uno::Sequence<com::sun::star::sheet::DataPilotFieldFilter> const&) /sc/source/ui/view/dbfunc3.cxx:2056 #17 0x2b2c4fa8924d in ScDataPilotTableObj::insertDrillDownSheet(com::sun::star::table::CellAddress const&) /sc/source/ui/unoobj/dapiuno.cxx:1286 Change-Id: I4cd0fca46b9b81311bddfab2229ab9abf4c06c4e
2014-06-25remove whitespaceMarkus Mohrhard
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-17coverity#1223091 Uncaught exceptionCaolán McNamara
Change-Id: I7aacf97a32360ea3c7e17e19d7f5e51e96fcc070
2014-06-10coverity#1187810 Uncaught exceptionCaolán McNamara
Change-Id: Icfd867bbe24ca738ad409001115d1b0470041de4
2014-04-23sc: sal_Bool->boolNoel Grandin
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-19fixincludeguards.sh: scThomas Arnhold
sorry, huge one...
2014-04-15Remove this duplicate, and use the one in ScCellFormat.Kohei Yoshida
Change-Id: I2410c8805ef5be950d5ce1e24f845ed910615442
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-15fdo#71491: Adjust reference during undo of drag-n-drop of cell range.Kohei Yoshida
Also with this commit, the signature of SvtListener::Notify() changes, by dropping the first argument which nobody uses. This change was necessary in order to call it directly without needing to pass any broadcaster instance. Change-Id: I6a1e97f0fb1e070d1d8f7db614690b04c9e8024e
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-24coverity#737458 Uncaught exceptionCaolán McNamara
Change-Id: Ida42725016395d9629bb97bd8cf0b660195c4f1c
2014-02-24coverity#737430 Uncaught exceptionCaolán McNamara
Change-Id: I1db24114b331970d75b01c0869708b1656be3836
2014-02-24coverity#737424 Uncaught exceptionCaolán McNamara
Change-Id: I8779bf79dd2342f183643767c4c424e7a5500cca
2014-02-24coverity#737422 Uncaught exceptionCaolán McNamara
Change-Id: Ieca32131ad7b1019338af8042ab6905e3ba152d6
2014-02-24coverity#737388 Uncaught exceptionCaolán McNamara
Change-Id: I55fd2311d6439a6f8616f9c21fa1e7222efde794
2014-02-24coverity#737363 Uncaught exceptionCaolán McNamara
Change-Id: I29717d8379a69eede5ef44b57934c2fe70c04248
2014-02-21coverity#706691 Uncaught exceptionCaolán McNamara
Change-Id: I130f80a45f3d207c34bdc2b4b3cff9536fbe185c
2014-02-21coverity#737447 Uncaught exceptionCaolán McNamara
Change-Id: I416d5b7d42a5ea49f40a18aaf4e1041307914c33
2014-02-08coverity#1169853 Uncaught exceptionCaolán McNamara
Change-Id: I3f10fbc70e72f6788e8ecc6244cc89d0c6cfa07b
2014-02-08coverity#1169854 Uncaught exceptionCaolán McNamara
Change-Id: Id119394ea892dc44ec7f4c4679d1e3cd64203946
2014-02-08coverity#1169862 Uncaught exceptionCaolán McNamara
Change-Id: I13d12586b8f76b61e3b728858fb7228eb7be723e
2014-02-06coverity#1038388 Uncaught exceptionCaolán McNamara
Change-Id: I87953c40c3110cd15553f1b3f77f25a772436ad7
2014-02-03Revert "fix Worksheet.Cells by now allowing TableSheet..." fdo#70079Noel Power
This reverts commit 70aff4a7f7abe0c768238733ca8900b746e60189. Change-Id: I8f8b423353ae1a825be91bd94308e87844948525 Signed-off-by: Noel Power <noel.power@suse.com>
2014-01-29coverity#737429 Uncaught exceptionCaolán McNamara
Change-Id: I7188ded009509b933958e4ada4d5f76d9ef1d742
2014-01-29coverity#737449 Uncaught exceptionCaolán McNamara
Change-Id: I617f272a7ae80669eb26c0e7bfb6022a632be552
2014-01-29coverity#1079002 Uncaught exceptionCaolán McNamara
Change-Id: I57d0d07165c2cb31c3077fd4f4afffae5a0d181c
2014-01-27coverity#1158336 Uncaught exceptionCaolán McNamara
Change-Id: Id798449d60021d209c47ddfd11579bec6ddc1bd5
2014-01-27coverity#1158337 Uncaught exceptionCaolán McNamara
Change-Id: I951ff26682d2391e6657be169eb4e7da36078a02
2014-01-27coverity#1158338 Uncaught exceptionCaolán McNamara
Change-Id: I212915e1f0fd3594e276e9a8dd702aab800b0b4f
2014-01-27coverity#1158339 Uncaught exceptionCaolán McNamara
Change-Id: If25f58b45ce6f312eb53cb4ef48b41bf8dcae381
2014-01-27coverity#1158340 Uncaught exceptionCaolán McNamara
Change-Id: I6d920feeebe45c2f82dd1bfe37370ac005ad9a69
2014-01-27coverity#1158341 Uncaught exceptionCaolán McNamara
Change-Id: If88cddfb13ea2db24a5c95ea0c367e51b87b75c4
2014-01-27coverity#1158342 Uncaught exceptionCaolán McNamara
Change-Id: Ia6cad30b9ad262168d86c52eb72f08efb65af790
2014-01-27coverity#1158343 Uncaught exceptionCaolán McNamara
Change-Id: Idbab8cb1051c7f01b5fa53db7d9bb99fd882f680
2014-01-27coverity#1158344 Uncaught exceptionCaolán McNamara
Change-Id: Ifae42003982f74f30e946edb8d19ecc02bd33a46
2014-01-27coverity#1158345 Uncaught exceptionCaolán McNamara
Change-Id: I41e85755825ae90f1243597814b17d61e81adddb
2014-01-25coverity#1158346 Uncaught exceptionCaolán McNamara
Change-Id: Ifd85f727dc741b2d59bfc9eebabbff24e0e69e1d
2014-01-25coverity#1158347 Uncaught exceptionCaolán McNamara
Change-Id: Iacaf59724b71d810270545d1e9dd04d59125cc92
2014-01-25coverity#1158348 Uncaught exceptionCaolán McNamara
Change-Id: I89dea1733a1c914a913fe31bb66b6e30c1e55dc9
2014-01-25coverity#1158349 Uncaught exceptionCaolán McNamara
Change-Id: I9c6ff59dbb3a286a37dcef8e47f38226f6765621
2014-01-25coverity#1158350 Uncaught exceptionCaolán McNamara
Change-Id: Ia2775cc9b93eb6805ec01a30391bcc22b175a7d3
2014-01-25coverity#1158351 Uncaught exceptionCaolán McNamara
Change-Id: I8549a8fe7cbb262712c5a4996802a8c724ea3645
2014-01-25coverity#1158352 Uncaught exceptionCaolán McNamara
Change-Id: Idd0b4fae13523a0839ea2b42dce663277f586925
2014-01-25coverity#1158353 Uncaught exceptionCaolán McNamara
Change-Id: Ib30c3f702a0f16922e5f7ab305bbe1f593714219
2014-01-25coverity#1158355 Uncaught exceptionCaolán McNamara
Change-Id: Ie40808c0fe78beca5b9c30b3ea5d60452b3212a4
2014-01-25coverity#1158355 Uncaught exceptionCaolán McNamara
Change-Id: I60dff924402b026c1f5d678ce81889396a0f8bd8
2014-01-20sal_Bool->boolNoel Grandin
Change-Id: I7c60759d199da6b0d1494cf31e1577808e618627
generated by cgit (git 2.34.1) at 2025-01-31 18:57:56 +0000