Age | Commit message (Collapse) | Author |
|
... and comment on what to do if we really wanted a copy-swap-idiom.
The need to doc comment about not to use assign() after default ctor is
also gone with the temporary swap.
Change-Id: I2a49091b2a41cf155e912e3c373dbbe81c7f9737
|
|
... that only results in a performance penalty.
Change-Id: Ia161ab7fb03f2d32cf966ce9da9d0319d919fc4c
|
|
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7
Reviewed-on: https://gerrit.libreoffice.org/17263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
When undoing row deletion (and possibly other similar undo's). And
write test for it.
Change-Id: I04b4fd9932f4236f124dcd25967355c6055dec33
|
|
Change-Id: If5f9122213d2f35aabcc66ca70c3d432120995cc
|
|
sorry, huge one...
|
|
Change-Id: Ic5d31107aa7653cd8e3fae096888bd633696074f
|
|
Specifically:
ScCellValue::ScCellValue(EditTextObject const&)
ScCellValue::ScCellValue(ScFormulaCell const&)
ScCellValue::hasNumeric() const
ScCellValue::hasString() const
ScCellValue::set(ScFormulaCell const&)
Change-Id: Ief8c07d6e2c7df6c6037fb3e59c00c37e3e0a49a
|
|
Change-Id: I2f91a7b6b471d655f19f1f0ed94c4e1d0273ed80
|
|
This is a very common operation. Let's speed it up a bit.
TODO : Handle cell comments.
Change-Id: I5442bf19008475a9427b889c1eb641cacd8ff161
|
|
With this, both ScColumn and ScMatrix store svl::SharedString as their
string values, instead of OUString.
Change-Id: I3faece94d98f774881fd72b3ed5f6143504cd350
|
|
Because mtvelements.hxx is very slow to parse by the compiler, and
cellvalue.hxx is included everywhere. Hopefully this will speed up the
compilation time of sc...
Change-Id: Ic9a9b8483c8325e4a91021f071f2391db8b57806
|
|
ScEditUtil::GetString() iterated over the paragraphs of an
EditTextObject where GetText() does not resolve field content but
returns the embedded field markers. To resolve field content an
ScFieldEditEngine is needed.
This makes it necessary to pass an ScDocument* to obtain the
ScFieldEditEngine from, or for cases where there is no ScDocument in the
context use a static ScFieldEditEngine which unfortunately is not
capable of resolving document specific fields of course, such as
DOCINFO_TITLE and TABLE.
Also added unit test.
Change-Id: Ife3c23b2fec2514b32303239d276c49869786eb5
|
|
If we don't clone this, the original string value would become invalid
after the first insertion, which may cause a reallocation of the array
that stores the cell.
Change-Id: I5b1bb5f378ed5503169fce75fcbc7aeb85c5ed6e
|
|
The old style cell storage is no more. Currently the code is buildable,
but crashes during unit test.
Change-Id: Ie688e22e95c7fb02b9e97b23df0fc1883a97945f
|
|
Change-Id: Ifbce13bc8a941e548b1ba647519cf9765b7f55d0
|
|
Change-Id: Ie2b6819652f330a493b7f9fe557736b27e402803
|
|
Change-Id: I93f83a840874c973cdc0821ddeb1913be7f09767
|
|
It directly points to the original cell value instance.
Change-Id: I638ec8b931873d237871b6d8fa9f0e1277520d0f
|
|
This took me a whole day....
Change-Id: Ida757b1efa284fc9d071a225f45666c340ba89ea
|
|
Change-Id: I8b39adaaff3874e26709579530fb74b2bf0543be
|
|
Change-Id: Icdbf2af7bc552bc8f4914cc8bd036ed45934c461
|
|
This can be used outside the undo code, like change tracking code.
Change-Id: Iad936acef0dacbd19d8c179da4713b1cdc7f9c84
|