summaryrefslogtreecommitdiff
path: root/sc/inc/compiler.hxx
AgeCommit message (Collapse)Author
2018-05-08tdf#42949 Fix IWYU warnings in sc/inc/[bc]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie63df2185e0586d1fc7db4ed2825a7aa8d8dde73 Reviewed-on: https://gerrit.libreoffice.org/53950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-28tdf#114479: compute implicit sum ranges for ocSumIf,ocAverageIf...Dennis Francis
and update the sum-range token in RPN array while creation of the RPN array itself. + Adds unit tests. + In ScParallelismTest unit test, enable threading in its setUp() method and restore the original setting in tearDown(). Change-Id: Iee9b7759210a82950181a418eb92766a6cf891fc Reviewed-on: https://gerrit.libreoffice.org/49465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-17coverity#1422192 include param field in string fieldEike Rathke
Change-Id: Ia2ef910fd9b4b74c8cf227717fde93c562bbb1b6
2017-11-16Straighten use of MAXSTRLEN to be maximum string lengthEike Rathke
... plus limiting 0-character, and not buffer length in (only) some cases where max len then was MAXSTRLEN-1, accompanied by a mix of >= and > comparisons. Change-Id: I5b8452db52b1d464eb1410e31990043f7997af20
2017-10-27loplugin:finalclasses in scNoel Grandin
Change-Id: I83438eaf2c1045a9212a63ed9fd8b3371e9b06aa Reviewed-on: https://gerrit.libreoffice.org/43896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24loplugin:constparam in sc part3Noel Grandin
Change-Id: I8abc44b9f0bcd5e39fd8a94abafaf80aadcd26ca Reviewed-on: https://gerrit.libreoffice.org/41496 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23loplugin:constparam in sc part2Noel Grandin
Change-Id: I4fd18096d7d22d8c146a2437906187d5df1cb268 Reviewed-on: https://gerrit.libreoffice.org/41447 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields in sc part3Noel Grandin
Change-Id: I7323e8644e5d336d52fa21b063264b0847b5e780 Reviewed-on: https://gerrit.libreoffice.org/39064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-23drop the SCsROW/SCsCOL/SCsTAB typedefsNoel Grandin
which are exactly the same as the regular SCROW/etc typedefs, and have been this way since commit 43a21999a92c99867bc3417291719996776b0647 Author: Oliver Bolte <obo@openoffice.org> Date: Fri Jun 4 09:00:39 2004 +0000 INTEGRATION: CWS rowlimit (1.1.2); FILE ADDED Change-Id: Ia7f75d71227ca3167b5fd56019bb9bdf0697d1b0 Reviewed-on: https://gerrit.libreoffice.org/37911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-23enhance useuniqueptr lopluginNoel Grandin
teach it to look for the following sequence in a destructor: delete m_pfoo; m_pfoo = nullptr; Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380 Reviewed-on: https://gerrit.libreoffice.org/37900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18Always set a grammar when constructing ScCompilerEike Rathke
Otherwise mxSymbols is null, which is rather unexpected as the past has shown, see commit 63843a97262ccfa38d838a9cbbc3faadba8290a6 Change-Id: Id4c13a5f50e711513a71a7d6cd6f87b4112b1f1d
2017-05-10Hold ParamClass at FormulaByteToken instead of bool, tdf#107724 prepEike Rathke
* change IsInForceArray() to GetInForceArray() * add IsInForceArray() to keep previous functionality Change-Id: I64c891486e548a66539646846a4691a213c783ac
2017-05-10Change IsForceArrayParameter() to GetForceArrayParameter(), tdf#107724 prepEike Rathke
Change-Id: Icd3400e4ee1c69860908a2ad0ca6e52879f2f725
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-19loplugin:expandablemethodds in scNoel Grandin
Change-Id: Idda64b23ea91ec457b60279d851b7f01d8c02881 Reviewed-on: https://gerrit.libreoffice.org/30033 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23convert formula error codes to scoped enumNoel Grandin
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-03try and silence uninit_memberCaolán McNamara
Change-Id: Iac633a1793a79049aa6e7adde1692b469b03b74b
2016-09-01cosmeticsEike Rathke
Change-Id: I22d4c04db2917f96e3c9ca1a71c628e859ad13c5
2016-09-01move comment to where it belongsEike Rathke
Change-Id: Ia3110b911e6d367a3b5d246a95384efc2f72f9f8
2016-09-01No more need for ScRawTokenBaseStephan Bergmann
...since 05eda0dc19af81ed0d5167bdd0a92113e6e8bc60 "loplugin:unusedfields in sc" Change-Id: Id80ec49fc93a6d599e2b36727c0424af77fae693
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20convert SC_COMPILER to scoped enumNoel Grandin
Change-Id: Ib8fdce056847b2b2514f61da18c106bb3e78631c Reviewed-on: https://gerrit.libreoffice.org/25079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13recognize #REF! particles of invalidated references, tdf#86575 follow-upEike Rathke
... so they result in an invalid reference again producing a #REF! error instead of a bad string producing #NAME? error. This way we can handle the invalid #REF!.A1 and similar references that were wrongly written to ODFF between 2013 and 2016 until 5.1.4 As a benefit, this is now also the case in UI, e.g. when recompiling changed names with already invalidated references. Change-Id: I117d709f594b7c37d899528a51220c1855b7817d
2016-04-11clang-tidy performance-unnecessary-value-param in formulaNoel Grandin
Change-Id: I9f90c55f74216c2f3452e5b30d85b304668330b3
2016-03-18adjust other-sheet-local relative sheet references, tdf#96915Eike Rathke
... so they still point to the same sheet as if used on the original local sheet. Change-Id: Id40378deaf70c1645bfa52ea28aa39775d16aec5
2016-03-18Resolves: tdf#96915 implement other-sheet-local named expressionsEike Rathke
Change-Id: I0d62536caa6eb455473a755067abc585662cd9a5
2016-03-18loplugin:constantparam in formulaNoel Grandin
Change-Id: I3adeed435b62ae60b5d0d4b763dceced5675cd85 Reviewed-on: https://gerrit.libreoffice.org/23330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03loplugin:unuseddefaultparams in sc (part2)Noel Grandin
Change-Id: I356a86bfca20cbf2c52185697042dce5237e847d
2015-11-23loplugin:unusedfields in scNoel Grandin
Change-Id: If5123e676a27302f3e11475309bc748977c6f430
2015-11-18rename FormulaToken HasForceArray to IsInForceArrayEike Rathke
... to name it was it does and to distinguish from ScParameterClassification::HasForceArray(OpCode) which IS about a function having ForceArray parameters. Change-Id: I8af4e1d0353cdb5ad0a9b837ae0763dc77242734
2015-11-16-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: I3bb2764b625d44f6e0cecbdde3363440faef63b5
2015-11-16Resolves: tdf#95670 propagate ForceArray per parameterEike Rathke
Regression of b5cd11b4b02a85a83db77ba9d8d1763f0cd88cb1 It was always wrong to propagate ForceArray already if a function had a ForceArray parameter *somewhere*, we need to do this per parameter instead. Change-Id: If188d45366279d9a7bf641edc7e4dd7095d6d035
2015-10-28com::sun::star->css in scNoel Grandin
Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-07-22loplugin:unusedmethods scripting,scNoel Grandin
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7 Reviewed-on: https://gerrit.libreoffice.org/17263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-23in OOXML save references of named expressions with col,row=0,0 base positionEike Rathke
Saving relative references of named expressions to OOXML never worked, upon reload they pointed to a different position offset by the value of the original base position. This at least saves positive relative references correctly, while generating #REF! for negative offsets which is slightly better than having them point to a wrong location and silently calculate different values.. Also, this is a prerequisite for TableRef ThisRow references in named expressions to be saved correctly in A1 notation, which results in a relative row 0 value. Change-Id: I3734f910794ceab4b9224b214ad11c64d1d18e67
2015-05-07remove unused code; bMapDupToInternal in struct AddInMapWinfried Donkers
is not used apart from getting a value. Conflicts: sc/source/core/tool/odffmap.cxx Change-Id: I26e942f6357970c6d9de27b5d5cf00b451193732 Reviewed-on: https://gerrit.libreoffice.org/15658 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-18const all CreateString... FormulaToken*Eike Rathke
Change-Id: I0e0f064357543e5dc86b178ce30ee005e5483e04
2015-04-09TableRef: correct GetToken() logicEike Rathke
Ensure that only desired tokens are obtained and the resulting new token is actually the current one upon return. Change-Id: I624c324b861d8658accf3285cad2cfc5a598b450
2015-04-09TableRef: lookup column specifierEike Rathke
Change-Id: I73109e5a862b2f4bc456dff512bddf5d23586a6d
2015-03-12TableRef: parse item specifiersEike Rathke
Change-Id: If1419844544be08fa14b6c78c755abba35fff353
2015-03-11add TableRef stackEike Rathke
Change-Id: If781e6ab13eb5ad175352e330379776d6ca4fcd8
2015-03-05add Item enum to ScTableRefTokenEike Rathke
Change-Id: Ie35d717fd55e6bbde958d3f2be4dac5f489467f9
2015-03-05use ScTableRefToken in ScRawToken::CreateToken()Eike Rathke
Change-Id: I895f142667a593bc5fc4f33f2417cbee991e503a
2015-03-05add HandleTableRef()Eike Rathke
Change-Id: I95e80bfa11177e1a52f3215d27448f4642091bad
2015-03-05rename confusing HandleSingleRef() to more appropriate HandleColRowName()Eike Rathke
Change-Id: Ib2e6d5cd9863ac1f9b0ba9b192f5d17d489ed19f
2015-02-13tdf#89330 preserve file name case in an unresolvable external named rangeJan Kantert
Change-Id: Ib8728a4a9c793b162de07a0cef66e242879f2aa1 Reviewed-on: https://gerrit.libreoffice.org/14474 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-11-16callcatcher: update unused codeCaolán McNamara
pleasing cleanup of whacky ScRawToken::sbyteOffset, etc. Change-Id: I5ad97f8dab7c5dc9d5f0286bf606b619126c22c9
generated by cgit (git 2.34.1) at 2025-02-19 19:10:35 +0000