summaryrefslogtreecommitdiff
path: root/sc/inc/conditio.hxx
AgeCommit message (Collapse)Author
2018-03-13loplugin:useuniqueptr in ScConditionEntryNoel Grandin
Change-Id: Ifcb2949fd932de249b71322ec9827e1ba3b1fe1b Reviewed-on: https://gerrit.libreoffice.org/51206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-03Fix typoAndrea Gelmini
Change-Id: I401b74b4c95bfe653509edb55ed042ff31398e5d Reviewed-on: https://gerrit.libreoffice.org/50641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-02forcepoint #15 notify FormatsContext if Format deletedCaolán McNamara
Change-Id: Icb7b0c3b1fc3d38e2d7e44e0a8bdb03529c5b41d Reviewed-on: https://gerrit.libreoffice.org/50621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-15More loplugin:cstylecast: scStephan Bergmann
Change-Id: Iaaa5b99cdff49bc1e88443ee23d98c005ff84911
2018-01-01loplugin:passstuffbyref improved return in scNoel Grandin
Change-Id: I487cfe96e9fe65f9be39b2488880410bc7b4baea Reviewed-on: https://gerrit.libreoffice.org/47228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11tdf#95295: don't add duplicate conditional formatsMike Kaganski
This tries to make sure that on copy, any conditional formatting that has same entries (conditions and formats) as another condition in the table, is not appended to the conditions list, but updates existing condition's range. This should prevent multiplication of entries with duplicating conditions and formats, and fragmenting ranges. Existing unit tests had to be adjusted, because they had ensured exactly that behaviour that is changed in this commit: that new items are added to the list, and e.g. multiple elements are created when a single cell is copied to a range. Change-Id: I46adb883bab7249571b912d56fea0c7918b3516d Reviewed-on: https://gerrit.libreoffice.org/45656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-30Deduplicate conditional formats loaded from .odsTor Lillqvist
If there are several separate conditional format elements that can be represented as just one (with several ranges), try to do that. A particular customer document used to take 3 minutes 20 seconds to load, and it contained so many (tens of thousands) conditional formats that the Format> Conditional Formatting> Manage... dialog was practically impossible to use. Now loading that document takes 15 seconds and there are just a handful of separate conditional formats. Also add a simple unit test to verify the deduplication. Change-Id: I7c468af99956d4646ee5507390f1476caff52325 Reviewed-on: https://gerrit.libreoffice.org/45460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-28Factor out a code snippet copy-pasted four timesTor Lillqvist
Change-Id: I29fb16ea51873b396c4f884f6acf454ce2b229e6 Reviewed-on: https://gerrit.libreoffice.org/45363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-28The aStrNmsp[12] fields can be constTor Lillqvist
Change-Id: I257b2be52b13c8ce76dbcc06e080e348af9e1b68 Reviewed-on: https://gerrit.libreoffice.org/45359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-27The eTempGrammar[12] fields can be constTor Lillqvist
Change-Id: Ibf3f0f9fed7c2158c4ad366f0c865b075943f2a8 Reviewed-on: https://gerrit.libreoffice.org/45321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-26Add debug output operator<< for ScFormatEntry::TypeTor Lillqvist
Change-Id: I4e23f17a59e995d76258420f07818079c7a9b94b Reviewed-on: https://gerrit.libreoffice.org/45288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-26Add debug output operator<< for ScConditionModeTor Lillqvist
Change-Id: I031d080dc8cbfcc5619bf7d5ee6112dde0a2ef04 Reviewed-on: https://gerrit.libreoffice.org/45277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-26Convert ScFormatEntryType to scoped enumTor Lillqvist
Change-Id: I9a6b3fb05255630852a96ebf74d901b869a581f4 Reviewed-on: https://gerrit.libreoffice.org/45276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-25Avoid a trivial typedefTor Lillqvist
Change-Id: Iea8700f168c5d13ebf1b98f435eeabea425b8259 Reviewed-on: https://gerrit.libreoffice.org/45275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-25Convert ScConditionMode to scoped enumTor Lillqvist
Change-Id: I9b6aaa64e7f649581b27f0238e2908026ab6e0bd Reviewed-on: https://gerrit.libreoffice.org/45157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-24consistently use sal_uInt32 for number formats in scNoel Grandin
instead of a mix of short/sal_uLong/sal_uInt32 Change-Id: Ie5bd26e1a6f716c0c4e174a6d560827084b3f421 Reviewed-on: https://gerrit.libreoffice.org/45159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22loplugin:constparam in sc part1Noel Grandin
Change-Id: I82fba7ebb3b4f018721642c96bbfa615c6a382c3 Reviewed-on: https://gerrit.libreoffice.org/41419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07C++11 remove std::binary_function bases from functorsJochen Nitschke
std::binary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::binary_function base class was used by deprecated std::bind2nd, this was solved in individual commits. The members first_argument_type and second_argument_type were used in chart2/source/controller/dialogs/DataBrowserModel.cxx: DataBrowserModel::implColumnLess and are inlined in this commit. Change-Id: I60ded60a8d4afd59e15ac15a58e18d2498c9be5a Reviewed-on: https://gerrit.libreoffice.org/39659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-29no need to manually keep track of listener rangeMarkus Mohrhard
Change-Id: I833a2336f0c0ce8cc61eab4c56e1ffac3e36ae62 Reviewed-on: https://gerrit.libreoffice.org/39319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-08support undo of whole conditional format list, tdf#95617Markus Mohrhard
Change-Id: I3ff0ddb05f794064e33164c60cd1b4e6b89dbcca Reviewed-on: https://gerrit.libreoffice.org/36295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-03use actual UNO enums in scNoel Grandin
Change-Id: I51dbe623178e3c463dc4c941f23edac04fbfe349 Reviewed-on: https://gerrit.libreoffice.org/35968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25loplugin: unnecessary destructor scNoel Grandin
Change-Id: I877bc0927aff7d175c1978fdf3db55d2e048d3b9 Reviewed-on: https://gerrit.libreoffice.org/33510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-18extract the code to get the max key id to own methodMarkus Mohrhard
Change-Id: I56bd53e03a7ea97b15895528ec02a09a73d877b6 Reviewed-on: https://gerrit.libreoffice.org/28994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-14loplugin:constantparamNoel Grandin
clean up the plugin a little, and try to catch params which are default constructed, which doesn't seem to be working yet Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12 Reviewed-on: https://gerrit.libreoffice.org/28861 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-10loplugin:constantparam in scNoel Grandin
Change-Id: I82c78dd880c98532db407b0183a43705be2de67c Reviewed-on: https://gerrit.libreoffice.org/28777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24loplugin:unusedmethods in scNoel Grandin
Change-Id: Ic378126a30be853d10fe174c451cee3c6ded404f Reviewed-on: https://gerrit.libreoffice.org/25109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25be explicit about what it does, CreateFlatCopiedTokenArray()Eike Rathke
Change-Id: I3652e4e46f85343488fb77bc4169bf6825086cf4
2016-04-14loplugin:passstuffbyref in scNoel Grandin
Change-Id: I75c483972db787ea9c941eaac0df023f1929b09c
2016-04-12clang-tidy performance-unnecessary-value-param in scNoel Grandin
Change-Id: Ia2255e1e3f7a8834a4b5d2a6bbab2c6dd498d356
2016-04-05tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctorsSteven Guo
Replaced boost::noncopyable with play C++11 deleted copy ctors in sc/inc/* files. Change-Id: I2e6310f2f2bac673dd3b5d14e80ce80a98795672 Reviewed-on: https://gerrit.libreoffice.org/23059 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-26fix indentationMarkus Mohrhard
Change-Id: Ibd65797b70cac33eb3302ad2020ffe38a01a2d85
2016-03-26switch to a listener based cond format update, tdf#95437Markus Mohrhard
Change-Id: Iaee665a37a9637c40cd02a89a19240ade6e5af37
2016-01-15loplugin:unusedmethods unused return value in scNoel Grandin
Change-Id: I3ccc98d2e042120093e2e8508518681588692393
2016-01-05Revert "Time wraparound validation feature"Markus Mohrhard
This reverts commit c01bcbc88522c5f86820105a45e2e5593ae01501. It still needs to be determined if this really was a good idea or a brain fart from me. There are some serious interop issues around the issue.
2016-01-05Time wraparound validation featureBenjamin Ni
Change-Id: I49305167b1062dbe8158fdb446859138ba283da2 Reviewed-on: https://gerrit.libreoffice.org/16136 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-09-18boost->stdCaolán McNamara
Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea Reviewed-on: https://gerrit.libreoffice.org/18677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-13replace boost::ptr_container with std::container<std::unique_ptr>Derrick Rocha
Change-Id: I8fd1121577c6443f9100b181402083d1b7c30b6b Reviewed-on: https://gerrit.libreoffice.org/18525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31replace boost::ptr_vector with std::vector<std::unique_ptr>Derrick Rocha
Change-Id: I3f75ad585ca288f0369e91dd5bc90151270346dc Reviewed-on: https://gerrit.libreoffice.org/18048 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-19sc: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
Change-Id: I966069726fd7dbc57e03e93514bec62d8bbb2ba0 Reviewed-on: https://gerrit.libreoffice.org/17862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-22loplugin:unusedmethods scripting,scNoel Grandin
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7 Reviewed-on: https://gerrit.libreoffice.org/17263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-09execute the terrible bottle neck loop only if there are conditional formatsEike Rathke
Change-Id: Ic8bd65a728289c9fa1a0721b0ecbd9b4a48672ca
2015-03-30implement one more methodMarkus Mohrhard
Change-Id: I3483b2004c0afb8bea651d9eec35d1cbf9aff2a1
generated by cgit (git 2.34.1) at 2024-12-28 07:05:24 +0000