summaryrefslogtreecommitdiff
path: root/sc/inc/dbdata.hxx
AgeCommit message (Collapse)Author
2018-05-10tdf#42949 Fix IWYU warnings in sc/inc/d*Gabor Kelemen
Found with bin/find-unneeded-includes Mostly removal proposals are dealt with here and a few trivial substitutions in small headers Change-Id: Ic4b2e48f1e55fc5d10e3dab16cfee1e358a8e917 Reviewed-on: https://gerrit.libreoffice.org/54005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-27ofz#7121 NamedDBs::insert takes ownership of its argumentCaolán McNamara
at one point this was based on std::auto_ptr and didn't free its arg on failure Change-Id: I8aeed6876d80b7ebe4ebb5e2cfd12e00420bd207 Reviewed-on: https://gerrit.libreoffice.org/51932 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15Resolves: tdf#115046 don't restore a sheet-local DBData from temporaryEike Rathke
And don't clear AutoFilter button flags in the new temporary range. Change-Id: I273de1e04632ac99c267523b2843665d257fd361
2017-12-08Adapt description to realityEike Rathke
Change-Id: I24133fb6c52bd7500037364120cb11d1b1f099c2
2017-08-24loplugin:constparam in sc part3Noel Grandin
Change-Id: I8abc44b9f0bcd5e39fd8a94abafaf80aadcd26ca Reviewed-on: https://gerrit.libreoffice.org/41496 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07C++11 remove std::binary_function bases from functorsJochen Nitschke
std::binary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::binary_function base class was used by deprecated std::bind2nd, this was solved in individual commits. The members first_argument_type and second_argument_type were used in chart2/source/controller/dialogs/DataBrowserModel.cxx: DataBrowserModel::implColumnLess and are inlined in this commit. Change-Id: I60ded60a8d4afd59e15ac15a58e18d2498c9be5a Reviewed-on: https://gerrit.libreoffice.org/39659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-23drop the SCsROW/SCsCOL/SCsTAB typedefsNoel Grandin
which are exactly the same as the regular SCROW/etc typedefs, and have been this way since commit 43a21999a92c99867bc3417291719996776b0647 Author: Oliver Bolte <obo@openoffice.org> Date: Fri Jun 4 09:00:39 2004 +0000 INTEGRATION: CWS rowlimit (1.1.2); FILE ADDED Change-Id: Ia7f75d71227ca3167b5fd56019bb9bdf0697d1b0 Reviewed-on: https://gerrit.libreoffice.org/37911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18Revert "Fix typos"Stephan Bergmann
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-16remove unused HEADER from ScDBDataPortion enumNoel Grandin
Change-Id: I744a945f9aab152c8cddac2bd88567610540471c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-04-12clang-tidy performance-unnecessary-value-param in scNoel Grandin
Change-Id: Ia2255e1e3f7a8834a4b5d2a6bbab2c6dd498d356
2016-02-03tdf#34873 : Better way to show autofilter countDennis Francis
This patch modifies the commit 3536fe8f4cdbacf5702e743407f34d918b6f4d38 by keeping the filtered row count inside ScDBData instead of ScTable as suggested by Eike Rathke. This significantly reduced the code complexity involved. Change-Id: I30ac26061d9665ce7a749e23a636f7fb3f69b176 Reviewed-on: https://gerrit.libreoffice.org/21720 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-18boost->stdCaolán McNamara
Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea Reviewed-on: https://gerrit.libreoffice.org/18677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-08factor out duplicated code into NamedDBs::initInserted()Eike Rathke
Change-Id: Idc95d4b8acae9dcd4ed0092c43986e6687f06c11
2015-09-07TableRef: move swap to empty names to InvalidateTableColumnNames()Eike Rathke
Change-Id: I495377786bd0add1521d37490c8c57d4d30f541e
2015-09-07TableRef: introduce InvalidateTableColumnNames()Eike Rathke
Change-Id: I3dcefc3ba55c33f9cfef6ff4bf9aa2242a866c14
2015-09-06loplugin:returnbyref (Fix TB Linux F19-x86-64)Julien Nabet
Change-Id: Ibf00b617a10e2bbe1c1e722c235bb2b75dee79a6 Reviewed-on: https://gerrit.libreoffice.org/18354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-09-04use GetHeaderArea() for simplificationEike Rathke
Change-Id: Ib06b35a117db3c02826cb18754f7ca11875c91c8
2015-09-04TableRef: update table column names when cell content changedEike Rathke
Change-Id: Id699358c7dae635b13ed4b981326a6490255a4d4
2015-09-03remove unused ScDBCollection::RefreshTableColumnNames(const ScRange&)Eike Rathke
Change-Id: Ia97d6913351a012d62f9d991dd42c54d8247a824
2015-09-03TableRef: add RefreshTableColumnNames() from rangeEike Rathke
Change-Id: I32a47e306469aec5fe366a6621129e14b0d49c13
2015-09-02TableRef: introduce ScDBDataPortion enumEike Rathke
... to replace * bool bStartonly=false with ScDBDataPortion::AREA * bool bStartonly=true with ScDBDataPortion::TOP_LEFT and provide means to look at header row only with ScDBDataPortion::HEADER as needed for TableRef. Change-Id: I9f6affd04c15a6204193687b2379160eb975f56e
2015-09-01TableRef: fall back to stored table column name if header cell is emptyEike Rathke
... during token string creation, as an empty column specifier is the last thing we want to see.. which still can happen though if the stored name was synced with the existing cell data and copying the older original name was not possible, for example due to name clashes. Change-Id: I6a0d313a02efafc092f0bbf7725fb3b3e77e486f
2015-08-31TableRef: refresh table column names before savingEike Rathke
... to match reality and be able to re-load structured references in range names once we save TableRefs as well. Change-Id: I5f8fc858be2a773d7841816c3e4bf21590d37e64
2015-08-31TableRef: write OOXML tableColumns,tableColumnEike Rathke
Change-Id: I535f2dc600f3b4fdac2c7fa817eb8430848bbae6
2015-08-19sc: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I2a56ebf8edb30b5f16e09237f9480484a699170e Reviewed-on: https://gerrit.libreoffice.org/17861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19sc: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
Change-Id: I93bdb33a442a358b0067d57499b11d73bfbaa2d9 Reviewed-on: https://gerrit.libreoffice.org/17860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-22loplugin:unusedmethods scripting,scNoel Grandin
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7 Reviewed-on: https://gerrit.libreoffice.org/17263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16Resolves: tdf#88402 remember sort "has headers" at anonymous database rangesEike Rathke
Change-Id: I4a126f40589fd401f3a63f74be5e86e3df947ef6
2015-06-25TableRef: add ScDBData::GetColumnNameOffset()Eike Rathke
Change-Id: Id80b9e8d1f54a8b795d0f4209bdf2f980f9a5344
2015-06-25TableRef: invalidate table column names on most sheet operationsEike Rathke
Kept only on insertions and deletions, but even that may not be useful as the names aren't updated at any time so even a mere cell change will bring this out of sync. But serves as a starting point for further implementation. Change-Id: Idfede4b03b9f554cd35f984502fce625c725853c
2015-06-24TableRef: add ScDBData::maTableColumnNamesEike Rathke
Change-Id: Ifb95f76f518646e32d1df45a77f146ad3a255087
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-01add totals to ScDBData ctorEike Rathke
Change-Id: I798376268b15f8b2f340d48fd2e38d68e53dbc6f
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-16Revert "make more classes dllpublic"David Tardon
This reverts commit add2ca7b3ab10ed9d18e60d8e50020168d922836. It causes too much breakage on windows. It is better to start again from scratch.
2015-04-16fix windows build, part 4David Tardon
error C2487: member of dll interface class may not be declared with dll interface Change-Id: I467670d483112ddbe8e608a7884a9c4e168e470d
2015-04-16make more classes dllpublicDavid Tardon
... to fix asan+ubsan+dbgutil build Change-Id: I1400774d383879bbff9bf28251a104cd53bafaed
2015-04-07TableRef: add Totals to ScDBDataEike Rathke
Change-Id: Ie38eaba48abbfc4f54304b349f5d2b135f4f7046
2015-01-03Add deleteOnTab for ScDBCollection::AnonDBsJulien Nabet
and use it instead of just using remove_if which is useless nothing! Change-Id: I37d8254b05123e50b076ddbb6f67726198ec4d6c Reviewed-on: https://gerrit.libreoffice.org/13723 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-04-19fixincludeguards.sh: scThomas Arnhold
sorry, huge one...
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-12coverity#1158232 Fix ownership of NamedDBs::insert argumentStephan Bergmann
f70d03436b7b501e0ed1d745935a204b9b97b855 "coverity#1158232 have a stab at silencing warning with function markup" claimed that NamedDBs::insert always takes ownerhip of its argument, but boost::ptr_set::insert(std::auto_ptr<U> x) simply calls insert(x.release()), so only takes ownership when it returns true. ScDBDocFunc::AddDBRange (sc/source/ui/docshell/dbdocfun.cxx) relies on this behavior, deleting the argument when insert failed. ScDBDocFunc::RenameDBRange (sc/source/ui/docshell/dbdocfun.cxx) relied on this behavior, deleting the argument when insert failed, until f55cc330dec0dec60c755e2ce28a840c7fca1956 "Fixed the fallout of the changes in ScDBCollection" removed the delete (presumably in error?). I put it back in now. All other uses of NamedDBs::insert ignored the return value (witnessed with SAL_WARN_UNUSED_RESULT). Some are insert-if-not-found cases, where I added asserts now (Sc10Import::LoadDataBaseCollection, sc/source/filter/starcalc/scflt.cxx, is not entirely clear to me, so I added a TODO), while others would have potentially leaked the argument, in which cases I fixed the code. Change-Id: Iad40fbeb625c8ce6b0a61cbf16298d71cdc7de80
generated by cgit (git 2.34.1) at 2025-02-07 08:52:48 +0000