summaryrefslogtreecommitdiff
path: root/sc/inc/formulacell.hxx
AgeCommit message (Collapse)Author
2017-05-24Clean up a commentTor Lillqvist
Change-Id: I9ee47a3de42087fb63e5d3e931ecee538017f3cc
2017-05-24tdf#107945: properly iterate over mtv during pivot cache loading.Kohei Yoshida
This reduces the total time required for populating the pivot cache by ~60%. Change-Id: I6a8511959c20231a8a5dbd0b0a9a3d0930a1fa0c Reviewed-on: https://gerrit.libreoffice.org/37971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-19Add Dump() method to ScFormulaCell.Kohei Yoshida
I'm surprised I didn't add one till now. Change-Id: I36c9257013f92804cecaeefd0778db1d25759c2f Reviewed-on: https://gerrit.libreoffice.org/36652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-23convert ScMatrixMode to scoped enumNoel Grandin
and fix a bug in ScChangeActionContent::SetValueString where it was passing the grammar as the ScMatrixMode to the ScFormulaCell constructor. Change-Id: I7c1a174cdd8365dedc30cff0b26e3079bb8b84f3 Reviewed-on: https://gerrit.libreoffice.org/35552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10Resolves: tdf#104711 adjust range reference constructed of named anchorsEike Rathke
A constructed range reference of named anchors (i.e. extended during expression compilation) forms a range listened at that needs to be adjusted if the cell is shifted and one or both anchor parts are individually named relative references. Currently the resulting range (ScComplexRefData aka DoubleRef) does not know to distinguish between whether its anchors are the result of a literal range in a named expression or the result of individually named anchors, so such RelName DoubleRef needs to be adjusted unconditionally when shifting or moving the formula cell. Change-Id: I75e2cc79ac60116671acce7641567337d5f5f7ed
2016-11-16remove anything svHybridValueCell related, it's nowhere set anymoreEike Rathke
Change-Id: I9887d7ca83ffc012fec1a78ef9ef537d2188a7e3
2016-11-16tdf#96475 restore the EmptyDisplayedAsString condition during loadEike Rathke
So also "empty" result cells with a number format applied are displayed empty, instead of 1899-12-30 for example. Change-Id: I5280d0213b8a809a04c5cb152ded58028706493a
2016-11-11loplugin:countusersofdefaultparams in sc(part2)Noel Grandin
Change-Id: I1e2a0969ca7e9e0f75079a171150269dfed26507 Reviewed-on: https://gerrit.libreoffice.org/30755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23convert formula error codes to scoped enumNoel Grandin
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-22sc: convert SC_CLONECELL_... to typed_flagsJochen Nitschke
Change-Id: I4ce14eecaa9fbdc007bbb39f0543099c75f2ffcb Reviewed-on: https://gerrit.libreoffice.org/27428 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-22sc: convert MatrixEdge... to typed_flagsJochen Nitschke
remove some unhelpful or obvious comments replace numeric values in last loop of ScTable::HasBlockMatrixFragment Change-Id: If7115b504689ce31b5caadbcae8ce2f5466e5b2a Reviewed-on: https://gerrit.libreoffice.org/27378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-09change number format for formula results if of different typeEike Rathke
... so =IF(B1,B1) changes from FALSE to the content of B1 instead of TRUE if B1 was empty or 0 on the first run but another value on the next run, with some logic to not override user applied formats. Change-Id: I0207adf0d71844f7bc2bb0f51ff308cca65aec52
2016-04-14loplugin:passstuffbyref in scNoel Grandin
Change-Id: I75c483972db787ea9c941eaac0df023f1929b09c
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-05tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctorsSteven Guo
Replaced boost::noncopyable with play C++11 deleted copy ctors in sc/inc/* files. Change-Id: I2e6310f2f2bac673dd3b5d14e80ce80a98795672 Reviewed-on: https://gerrit.libreoffice.org/23059 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-23loplugin:constantparam in scNoel Grandin
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
2016-03-18let FindRangeNamesInUse() collect also sheet-local names, tdf#96915 relatedEike Rathke
... though CopyRangeNamesToClip()/copyUsedNamesToClip() don't handle them yet. Change-Id: I570c13725ed6448688d1a2ce877f8bc1d1ff9916
2016-02-19new loplugin: find write-only fieldsNoel Grandin
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15loplugin:unusedmethods unused return value in scNoel Grandin
Change-Id: I3ccc98d2e042120093e2e8508518681588692393
2015-11-23loplugin:unusedfields in scNoel Grandin
Change-Id: If5123e676a27302f3e11475309bc748977c6f430
2015-11-18use unique_ptr for pImpl in sc/Noel Grandin
Change-Id: I2516c83f8dfca1f1217be7dcb2a28f5dcd2f704e
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-02Revert "Make fewer calls to officecfg::...::UseOpenCL::get()"Tor Lillqvist
Was not liked. This reverts commit e4ddba2b5f8ff32dd35e8c8f66f145597407be42. This reverts commit ab092bdc0f8c45e174cad403de9d2342adc01fb6. Change-Id: If2e9e032a135530da92b5bd166f5b559b10b0b91
2015-10-02Make fewer calls to officecfg::...::UseOpenCL::get()Tor Lillqvist
Change-Id: I5f7f52b6f2fb92c46e2b24e0edf95b4ccd17671d
2015-09-17ENABLE_THREADED_OPENCL_KERNEL_COMPILATION has been zero for a long timeTor Lillqvist
And I doubt we will try to turn it on again, so remove dead code. Change-Id: Iaa8908fdb5a197ef0d1da5eaf08ae08df2a86ee7 Reviewed-on: https://gerrit.libreoffice.org/18404 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2015-09-15stab MM_FAKE, it's a zombieEike Rathke
Change-Id: Iee70d0d027197c431926ab1194e0daa5eb429caf
2015-09-08reactivate fixed mempool for ScFormulaCellEike Rathke
... it got lost with 8b252f30267d043522ff2cbf2bf42275bb7a6ec6 Change-Id: I1a7c9bbaa1fd70d24c168d53aae6691a45c29085
2015-09-08Revert "USE_MEMPOOL is not defined anywhere"Eike Rathke
Well.. then let's remove the ifdef instead of the implementation, dammit.. This reverts commit 64c6b0ed6c67d169021732d276ec02706e139261.
2015-09-08USE_MEMPOOL is not defined anywhereTor Lillqvist
Change-Id: I4d3c87aac31c6690cd061ce41e7efae113055c12
2015-07-22loplugin:unusedmethods scripting,scNoel Grandin
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7 Reviewed-on: https://gerrit.libreoffice.org/17263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-10tdf#89972: also copy external reference statusMike Kaganski
fixes regression from commit 4467c67dc8bf17c67c70985c0d0ea64636884f9f, where the new optimized code path failed to properly register ScFormulaCell with ScExternalRefManager. Introduces a new public method in ScExternalRefManager: insertRefCellAsTmpl that registers a formula cell to listen to the same external references as template cell Introduces new property to ScFormulaCell: mbIsExtRef that indicates that some external references are referenced by this cell Also introduces new method ScExternalRefManager::hasCellExternalReference (for use in unit test, will be posted immediately) Change-Id: Iee07d7b51949fd31953b5fa662a213052eb85181 Reviewed-on: https://gerrit.libreoffice.org/16066 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-04-08convert RECALCMODE_ constants to scoped enumNoel Grandin
Change-Id: Ice2e45a3db59adc34a160b4b410cc51c750835f2
2015-02-07Introduce SetResultError()Tor Lillqvist
Change-Id: I0645b7a58e9f3dfc6c431844805ab87add8745ad
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Ieeca9fe957e7bc6a4cf9d7d6ac57f9ed150aab78
2015-02-04Check number of cells referenced by group instead of group sizeTor Lillqvist
Put using it in #if 0 for now, though. This reverts commit 2021275f8fc33d9917d5fef58959a95da1dc7e6f. Change-Id: Ia6541df12ee97747badbbedd758873688190b00c
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-07Revert "Check number of cells referenced by group instead of group size"Tor Lillqvist
This reverts commit cc4dbc0c4613b169045341d1f02bc4c47a407fa0.
2014-12-19Check number of cells referenced by group instead of group sizeTor Lillqvist
It's more relevant when deciding whether to use OpenCL or not. Note that we won't use OpenCL for a single formula cell, no matter how large a calculation it invokes (like =SUM(A1:A1000000), for instance), as a single cell is not a group. Change-Id: I66b03c197431c2b4cef96f46b010d99d3e0624fc
2014-12-15Reduce the size of ScFormulaCell by packing the matrix flag value.Kohei Yoshida
Change-Id: I07ee4f03ba74415c11188f7b63879ccad542537c
2014-11-25Adjust ref undo to ensure group area listeners are used.Kohei Yoshida
When undoing row deletion (and possibly other similar undo's). And write test for it. Change-Id: I04b4fd9932f4236f124dcd25967355c6055dec33
2014-11-20No need to start listening in CalcAfterLoad for xls import.Kohei Yoshida
We do that prior to it, and in fact, doing it here would unregister all group area listeners and re-register non-group ones, which is massively slower with huge documents. Change-Id: I693f681df05f036eb1aa53554e601066c469f49a
2014-11-18Dedicated listener type tailored for formula groups.Kohei Yoshida
Right now, it's only used when loading an xlsx file. But eventually this one should be used everywhere. Change-Id: I216c3a9a33c4b8040e8284d59299e0637471fb50
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-22Set script type to latin for formula cells with numeric results.Kohei Yoshida
But only when the column contains only standard number format types. Change-Id: I83982d2e87f9776cf03754beaf183e35675be992
2014-10-02New feature to allow converting formula cells to static values.Kohei Yoshida
You used to have to convert formula cells to static values by copying them and pasting them as values onto the original place. Why not just allow converting them in place? This is something I've always wanted to implement.
generated by cgit (git 2.34.1) at 2024-07-19 07:50:01 +0000