summaryrefslogtreecommitdiff
path: root/sc/inc/markmulti.hxx
AgeCommit message (Collapse)Author
2022-03-04set properly attributes for cells in unallocated Calc columnsLuboš Luňák
ScTable::ApplySelectionCache() was setting attributes only for allocated columns, so e.g. selecting a whole column and making it bold didn't actually set all of it bold. Make sure it set it for all columns, and make use of the default attribute for unallocated columns to avoid allocating columns just to set them the same attribute. Change-Id: Ie9886317d7a91c6a43951af69b717f9ba32a1c9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130984 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-03improve ScMark* classes a bitLuboš Luňák
Bin pointless empty destructors, make trivial functions inline, return value by simply returning it. Change-Id: Ia71e73262802bbe6b022ca4bafb2b958ffdf39f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130915 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17sc: Drop 'typedef std::vector<ScMarkArray> MapType'Michael Weghorn
Its only use is in the next line, and it's not even a map anymore, but a vector. Change-Id: Ib7920c420f5e3e18658f3530244097a4b1633951 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125411 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-23tdf#124176 Use pragma once in s*Vincent LE GARREC
sc, scaddins, sccomp, scripting Change-Id: Ia99fec9e238033821cb784810edd4762c09bd5db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112049 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-10-30convert some tools::Long->sal_Int32Noel
in places where it is obvious we only need a sal_Int32, because we are dealing with rows and columns, and not even calc needs more than 32 bits for that. Change-Id: I114417e639c224d45bfd9fc6838122ab195eefa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20use tools::Long in scNoel
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-30pass ScSheetLimits aroundNoel Grandin
instead of MAXROW, MAXCOL. In preparation for more conversion work that needs to be done to make jumbo sheets work. Change-Id: I4698b8fe111e060ae2a965afc7276b7e7bfb482a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-17use std::vector in ScMarkArray, instead of re-inventing the wheelNoel Grandin
and compact the ScMarkEntry record, this stuff shows up on perf profiles Also make these classes so we don't need to #include the cxx into a unit test. Change-Id: Id806385ae877a576ec25e7772c972448dada130b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-14sc: rowcol: convert mark dataNoel Grandin
with this patch I can finally load a 3201 column document Change-Id: I880d485b3f628836e7aed92c276e660466a3b19c Reviewed-on: https://gerrit.libreoffice.org/85139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03cid#1456145 Missing move assignment operatorCaolán McNamara
Change-Id: I55ed7d87def93a66668f5cf4f90fed1e1e5bcbee Reviewed-on: https://gerrit.libreoffice.org/84256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16loplugin:unusedfieldsNoel Grandin
Change-Id: I021cd75685a091c1afd3ff3c144def6f9a784bee Reviewed-on: https://gerrit.libreoffice.org/82972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11sc: rowcol: tdf#50916 convert mark data structuresNoel Grandin
Change-Id: I9b706c9bcc2925f72cc024142ffe72af5ddea82a Reviewed-on: https://gerrit.libreoffice.org/82419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-18tdf#125254 Performance: A spreadsheet opens too slow, part2Noel Grandin
Optimise bulk construction of ScMarkArray. This takes the opening time from 46s to 40.5s for me. Change-Id: I3955fe9b2c3113dac2ae3cda97d692de1975e762 Reviewed-on: https://gerrit.libreoffice.org/72418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-02tdf#120445 File-open ODS: Slower as compared to LibO 4.4.7.2Noel Grandin
This takes opening the file from 21s to 9.4s on my machine Change-Id: I38248f3c9acfa413fc105fcbe9ece06192389d46 Reviewed-on: https://gerrit.libreoffice.org/70073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05sc: Enhance binary search for ScMarkArraySerge Krot
Change-Id: I0fe6a0b8987fb3c3229c5aabcbf056cfb365650c Reviewed-on: https://gerrit.libreoffice.org/61373 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-05-29tdf#42949 Fix IWYU warnings in sc/inc/m*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I43882919048c23e9b8d305f8cbba8f120207bb93 Reviewed-on: https://gerrit.libreoffice.org/54824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-02lok: sc: overlays and edit view misplaced by other view actionsMarco Cecchetti
The edit view, the cell cursor and the cell selection overlays become misplaced when another user inserts, deletes or resizes a row. The same is true for columns. The solution takes care of the current tab each view is displaying and of undo/redo actions. Change-Id: I24c94f774f3b18028c9356a904e1b14b07c5c61a Reviewed-on: https://gerrit.libreoffice.org/40016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-06-04Perf-sc: tdf#100709 avoid segment tree with ScMultiSelIter where possibleEike Rathke
* create ScFlatBoolRowSegments in ScMultiSelIter only if necessary * create ScMultiSelIter only for affected columns in ScTable::MergeSelectionPattern() using ScMarkData::GetMarkedColSpans() * obtaining a full ScRangeList in ScMarkData::GetMarkedColSpans() was completely unnecessary, use existing selection containers instead and also if possible avoid creating a segment tree that needs to be converted to vector, directly use a vector instead Improvement: * under ScDocShell::Load() previous: Ir: 26 454 571 612 now: Ir: 18 811 368 362 * thereof under ScTable::MergeSelectionPattern() previous: Ir: 4 104 164 533 now: Ir: 664 738 808 Change-Id: I95895a3a000c1a0b7895fb0696b0889c6d6b4d49
2017-05-23drop the SCsROW/SCsCOL/SCsTAB typedefsNoel Grandin
which are exactly the same as the regular SCROW/etc typedefs, and have been this way since commit 43a21999a92c99867bc3417291719996776b0647 Author: Oliver Bolte <obo@openoffice.org> Date: Fri Jun 4 09:00:39 2004 +0000 INTEGRATION: CWS rowlimit (1.1.2); FILE ADDED Change-Id: Ia7f75d71227ca3167b5fd56019bb9bdf0697d1b0 Reviewed-on: https://gerrit.libreoffice.org/37911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-02-10Refactor ScMarkData for tdf#50916Dennis Francis
Made the container for storing multimarks dynamic. Also let the full row marks to be stored in a dedicated ScMarkArray object rather than in the multimarks container. Unit tests for ScMarkData and ScMultiSel will come in a follow up patch. Change-Id: I300ff80bebd6f4f39c284c1e8cb7deece82c1bec Reviewed-on: https://gerrit.libreoffice.org/22163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2025-01-15 08:57:39 +0000