summaryrefslogtreecommitdiff
path: root/sc/inc/refdata.hxx
AgeCommit message (Collapse)Author
2022-06-06ScSingleRefData::TabValid: for absolute reference take sheets into accountEike Rathke
Change-Id: I56e7e34f127345e2633b5bef07c2783ed8ffbbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135456 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-02-14remove use of MAXCOL/MAXROW from address.hxxLuboš Luňák
Change-Id: Icfc00584b0190ee90e506f80c73231e12f155cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129853 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-23tdf#124176 Use pragma once in s*Vincent LE GARREC
sc, scaddins, sccomp, scripting Change-Id: Ia99fec9e238033821cb784810edd4762c09bd5db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112049 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-12cid#1472119 Uninitialized scalar fieldCaolán McNamara
experiment to see what coverity does with this syntax Change-Id: I028a111ceee5b327a04979b5497a4bc2e1e61819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15cid#1472119 silence Uninitialized scalar fieldCaolán McNamara
Change-Id: I0a8a12e8bb823fc650212f5cf946ad9139395030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14tdf#133858 reduce the double-ref range to data contentDennis Francis
in certain matrix formulas like SUM(IF(A1=G:G, H:H)*B1/B2) where whole columns are used for comparison in the condition of IF ultimately followed by a reducer like SUM. In such cases we can safely reduce the double-refs involved in the comparison to the sheet area where there is data before converting the data to ScMatrix. This is a more restricted version of Noel's fix in 37ffe509ef011357123642577c04ff296d59ce68 Change-Id: I1c2e8985adedb3f4c4648f541fb0e8e7d0fae033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109050 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 65167a9265acfea04733b5ff6ee3220a9da624f4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109118 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: If621bb2585fda4afef4be9a189c7f4c00008d358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104029 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-23some places where ScDocument* is never passed a nullptrCaolán McNamara
and so some nullptr checks can be removed Change-Id: I7dedc2c6d054d9749db9766eaa3a5681842b2b69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-23ScRefAddress::GetRefString never passed a null ScDocument*Caolán McNamara
so the nullptr check can be removed and some more along that vein Change-Id: Ic0c1f98564b6bd457edd0d3ba2a4382b7945e806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-23some places where ScDocument* is never passed a nullptrCaolán McNamara
allow some never-hit null checks to be dropped Change-Id: I27a3979af19b556bc9a8e4f893bf0e65cdc439a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-13toAbs always dereferences its ScDocument*Caolán McNamara
Change-Id: I6bddbca2289074ecf333227b3fc1a49da4b431a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102529 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-14sc: rowcol: tdf#50916 convert Valid* methodsNoel Grandin
which means we end up passing around ScDocument* __everywhere__ Change-Id: I44d235ca5e9d57519f068b6880ee7d66f3ceb529 Reviewed-on: https://gerrit.libreoffice.org/83548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13sc: rowcol: tdf#50916 pass ScDocument* around in filter/Noel Grandin
Change-Id: Id328ee85b852eddf755876d2cde9ef75b40cfca1 Reviewed-on: https://gerrit.libreoffice.org/85090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29sc: rowcol: tdf#50916 convert core/toolNoel Grandin
Change-Id: I0fe5a7ef4a79d0832802945ce1b9da4752f1d5fc Reviewed-on: https://gerrit.libreoffice.org/81598 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03Resolves: tdf#122011 fix ValidExternal() checkEike Rathke
Tab==-1 may have been the condition 10 years ago, but at least since commit 296baa2fb6dd4150a7855114093a9703cdc18b09 CommitDate: Tue Oct 5 18:14:37 2010 -0400 Ported calc-extref-interpreter-rework-*.diff from ooo-build. that's not the case anymore. The check is only used in ScRefTokenHelper::compileRangeRepresentation() that is only used when creating chart data sources and sequences, thus may have gone undetected. Change-Id: I2eeb20ec740d286918b6ea29c017c32d03f970ad Reviewed-on: https://gerrit.libreoffice.org/80163 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-06-04tdf#42949 Fix IWYU warnings in sc/inc/r*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here and a bit of fallout management Change-Id: I5dd272c6c5fa305113f4446ed49c130c6c007146 Reviewed-on: https://gerrit.libreoffice.org/55096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-24tdf#105908: restore previously deleted range references upon undo.Kohei Yoshida
Change-Id: If1932a5eb10da4c50fbcc3329af75f2e7a0a5137 Reviewed-on: https://gerrit.libreoffice.org/35607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-09sticky end col/row anchor for range references, tdf#92779Eike Rathke
In range references referring more than one column/row where the end col/row points to the maximum column or row number that col/row is not decremented when the range is shrunken. Incrementing an end col/row is not done past the maximum column or row number, so such references do not yield #REF! errors anymore. This is also done in named expressions if the end col/row is an absolute reference. Change-Id: Iafa2d62abd3e816a1c56c3166af92807e55b75ce
2015-07-07(re-)introduce ScComplexRefData::PutInOrder(), tdf#92468Eike Rathke
Change-Id: If551e02a77a416b95f74266de896391d1d72eb3c
2015-06-26use ScComplexRefData::IsEntireCol() and IsEntireRow()Eike Rathke
Change-Id: I4287019f5492825f6d295c4e364405f0d7329eb7
2015-06-18Resolves: tdf#83365 push proper references in INDIRECTEike Rathke
... that take relative/absolute addressing and sheet 3D flag into account to be fed to reference extension via range operator. Change-Id: Iabe13ae384577e2d71ca87af6482ddccbf7ad0ac
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-04-19fixincludeguards.sh: scThomas Arnhold
sorry, huge one...
2014-02-27remove unused data ScComplexRefData::IsDeleted()Noel Grandin
Change-Id: I06d44a709f18b457c3d3381e2c6f4636fbffd4f0
2013-07-30Now the reference object no longer stores both absolute and relative.Kohei Yoshida
This is exactly what we needed. Change-Id: I0e8d3064d1ea52c8d502d89f322b41435284d717
2013-07-30Clean this up a bit.Kohei Yoshida
Change-Id: Ia984c17eda507dc625e2b038818abd2d4e9e5103
2013-07-30Now nobody accesses reference members directly. Make them private.Kohei Yoshida
Change-Id: If4499dbee52532cc8a95c380bbe840719fe9279b
2013-07-30Organize the reference dumping code a bit.Kohei Yoshida
Change-Id: I97bfdc85ba1391cfe4f11148adb91d5e6960225a
2013-07-30More on avoiding direct access to data members.Kohei Yoshida
Change-Id: I5fdc0d248fe9c36418fd02a1e652e4e35a638c8a
2013-07-24Work on remving direct access to ScSingleRefData's data members.Kohei Yoshida
This broke the shared formula import from xls and xlsx. Disabling the tests for now. Change-Id: I75d802b00947b21083db19b5c07204a0c3d4f369
2013-07-24Make these non-inline.Kohei Yoshida
Change-Id: I99cf45edfe584f69fb6465de84cdcff5842e37a6
2013-07-24CalcRelFromAbs() is no more.Kohei Yoshida
Change-Id: I974d8282eaf49a6c6d56fe209012f5e54170acc2
2013-07-24More on removing CalcRelFromAbs().Kohei Yoshida
Change-Id: I6474926d9cd8f9273bae3d8179bd14ee19422357
2013-07-24Remove CalcAbsIfRel() since nobody uses this anymore.Kohei Yoshida
Change-Id: Ie52e83b9e476b822e878488e231d60d0ce196cf4
2013-07-24Don't mark all of column, row, and sheet indices to be invalid in toAbs().Kohei Yoshida
When only one of them is invalid. This messes up the displaying of an invalid reference. Change-Id: I2b5a614434417160d605dd889ca4d3b54fcaffc2
2013-07-24Handle reference adjustment in response to sheet deletion.Kohei Yoshida
Change-Id: Ia6039d8a38a73d8d461743f128f01c347a2c51ad
2013-07-24More on this.Kohei Yoshida
Change-Id: I9571c903c11e92984ac29818c68d66c2fd9c30d2
2013-07-24More on replacing CalcAbsIfRel() with toAbs().Kohei Yoshida
Change-Id: I7f658e15a1ab6bdabd5f774e129e12c48a032f1a
2013-07-24Add methods to avoid accessing data members directly.Kohei Yoshida
Change-Id: I7285a267e4e77e95c8d9bdfc5bad807111ead909
2013-07-24Start replacing CalcAbsIfRel() with toAbs().Kohei Yoshida
To avoid changing the state of reference just to get absolute reference position with respect to the base position. I'm not finished with it yet. Change-Id: I4a9db6dbf74aefb0a77de927a933cf4dab94bfd5
2013-07-24SmartRelAbs() is no more.Kohei Yoshida
Change-Id: I8822d6dc36f49fe1e77100275616d8017b0a7627
2013-07-24Nobody uses this. Chuck it.Kohei Yoshida
Change-Id: I07672678a25be4600872ecc3916ceb8f64cf2620
2013-07-24Bool cleanup in refdata.?xx.Kohei Yoshida
Change-Id: Ibe5471b909f32939fac5e8a80e67faa0863ea2c4
2013-07-09These header inline methods cause linkage error on Windows.Kohei Yoshida
When the whole class / struct is marked SC_DLLPUBLIC. Change-Id: Id420a3ba083c8cdee71a99a282857d6abec55a31
2013-07-09Modifying comments to meet Doxygen standardsNourah.AlShoeibi
Change-Id: I9c498c8c2147a19c5f97e48bc8a0e149e6858e23 Reviewed-on: https://gerrit.libreoffice.org/4769 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-05-20Collect all empty broadcasters and remove them in one go later.Kohei Yoshida
This is to avoid repeated calls to set_empty() on the broadcaster array which causes array reallocation on each call. Instead, we can store the segments of broadcasters to be deleted later, and call set_empty() on those segments to reduce the number of calls to set_empty(). The meat of this is not implemented yet, as EndListeningContext is still empty. Change-Id: I914bc2881acee3902c4fec0f6c21aaf4d2489df8
2012-12-04re-base on ALv2 code. Includes:Michael Meeks
Patches contributed by Herbert Duerr i#118735 prevent endless loop if vlookup/hlookup doesn't find anything http://svn.apache.org/viewvc?view=revision&revision=1239673 Patches contributed by Andre Fischer remove lp_solver http://svn.apache.org/viewvc?view=revision&revision=1199180 i#118160: Added external CoinMP library. http://svn.apache.org/viewvc?view=revision&revision=1233909 Patches contributed by Armin Le-Grand i#118485 - Styles for OLEs are not saved. http://svn.apache.org/viewvc?view=revision&revision=1182166 i#118524: apply patch, followup fixes to 118485 http://svn.apache.org/viewvc?view=revision&revision=1186077 Patches contributed by lihuiibm i#108860 - Fix range validation. http://svn.apache.org/viewvc?view=revision&revision=1242846 i#118954 Chart data will lost after copy to different file http://svn.apache.org/viewvc?view=revision&revision=1301345 Patches contributed by Ariel Constenla-Haile Fix Linux build breaker: extra qualification on member http://svn.apache.org/viewvc?view=revision&revision=1301591 i#118696 - i#118697 - Fix some Sheet Tab Color API issues http://svn.apache.org/viewvc?view=revision&revision=1225428 i#118697 - Fix uninitialized variable http://svn.apache.org/viewvc?view=revision&revision=1225859 i#118771 - ScUndoImportTab should preserve tab background color http://svn.apache.org/viewvc?view=revision&revision=1230356 i#118921 - Repaint linked sheet tab background color after updating link http://svn.apache.org/viewvc?view=revision&revision=1245177 i#118927 - Undo/Redo "Update Link" does not reset sheet tab color http://svn.apache.org/viewvc?view=revision&revision=1245241 i#118747 - Copy tab color when transferring sheets across documents http://svn.apache.org/viewvc?view=revision&revision=1230355 Patch contributed by Oliver Rainer-Wittman i#118012 - methods <ScBroadcastAreaSlot::AreaBroadcast(..)> and <ScBroadcastAreaSlot::AreaBroadcastInRange(..)> adapt stl-container iteration in order to avoid destroyed iterators during iteration. http://svn.apache.org/viewvc?view=revision&revision=1297916 Patches contributed by Mathias Bauer gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1396797 http://svn.apache.org/viewvc?view=revision&revision=1397315 Patch contributed by Daniel Rentz calc69: #i116936# fix VBA symbol Cells http://svn.apache.org/viewvc?view=revision&revision=1172135 Patches contributed by leiw: i#118546 CPU 100% on switched off AutoCalculate with Conditional Formatting on date values http://svn.apache.org/viewvc?view=revision&revision=1301380 Re-add new function documentation. Many various cleanups. Add missing calc66: #o11817313# also look at formula result number format, remove redundant binaries.
2012-07-02Remove unused definesThomas Arnhold
Some of them were commented out for documentation purpose. Change-Id: I29a6b2cbe774b527f0c3a0be5675160817a7f3ce
2011-03-10Merge commit 'ooo/DEV300_m101' into integration/dev300_m101Kohei Yoshida
generated by cgit (git 2.34.1) at 2025-02-02 21:59:37 +0000