summaryrefslogtreecommitdiff
path: root/sc/inc/scabstdlg.hxx
AgeCommit message (Collapse)Author
2016-11-11loplugin:countusersofdefaultparams in sc(part2)Noel Grandin
Change-Id: I1e2a0969ca7e9e0f75079a171150269dfed26507 Reviewed-on: https://gerrit.libreoffice.org/30755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31return dialog pointers using VclPtr<>Noel Grandin
or their ref-count could drop to zero before they actually get used Change-Id: I5af7a0cc8650e3d779c870144c23b6de19c8cc45
2016-10-31This needs to be VclPtr tooJulien Nabet
Avoid this segfault: Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. 0x00002aaad2a20e4e in VclReferenceBase::acquire (this=0x9999eeeef579c129) at /home/julien/lo/libreoffice/include/vcl/vclreferencebase.hxx:38 38 assert(mnRefCnt>0); (gdb) bt 0 0x00002aaad2a20e4e in VclReferenceBase::acquire (this=0x9999eeeef579c129) at /home/julien/lo/libreoffice/include/vcl/vclreferencebase.hxx:38 1 0x00002aaad37325ae in rtl::Reference<AbstractScImportAsciiDlg>::Reference (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/rtl/ref.hxx:63 2 0x00002aaad37321b5 in VclPtr<AbstractScImportAsciiDlg>::VclPtr (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:89 3 0x00002aaad3731e25 in ScopedVclPtr<AbstractScImportAsciiDlg>::ScopedVclPtr (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:305 4 0x00002aaad373055e in ScFilterOptionsObj::execute (this=0x555558d8d450) at /home/julien/lo/libreoffice/sc/source/ui/unoobj/filtuno.cxx:179 5 0x00002aaad1c03f50 in (anonymous namespace)::handleFilterOptionsRequest_ (xContext=uno::Reference to (cppu::ComponentContext *) 0x5555559ec960, rRequest=..., rContinuations=uno::Sequence of length 2 = {...}) at /home/julien/lo/libreoffice/uui/source/iahndl-filter.cxx:259 6 0x00002aaad1c044f4 in UUIInteractionHelper::handleFilterOptionsRequest (this=0x555558c1b400, rRequest=uno::Reference to (RequestFilterOptions *) 0x555558d5edf8) at /home/julien/lo/libreoffice/uui/source/iahndl-filter.cxx:315 Change-Id: I50f9f5c4c63328a0aaa3ecb2d83a902de6a38add Reviewed-on: https://gerrit.libreoffice.org/30410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28these need to be VclPtrsCaolán McNamara
Change-Id: I83616728289e398c97e50f33b5dd1de404deaa27
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-19tdf#96453, tdf#100793 rework transfer of data between cond format dlgsMarkus Mohrhard
The xml based transfer of information was a bad idea from the start. It can obviously not transport the temporary conditional format information from the manager dialog. Therefore the whole handling here was completely broken and deleted formats came back, changed formats were not saved and added formats got applied directly to the document. Now the document fornat list and the one from the manager are indepedent again and as long as the manager has not been closed with ok nothing is written to the document. Change-Id: I9802be11cd15c2d2d877e55c91d836735fe0e0ff Reviewed-on: https://gerrit.libreoffice.org/28995 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-10loplugin:constantparam in scNoel Grandin
Change-Id: I82c78dd880c98532db407b0183a43705be2de67c Reviewed-on: https://gerrit.libreoffice.org/28777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-18screenshots: dialog doesn't even have a help buttonKatarina Behrens
So drop helpID argument from its ctor (not to mention the fact that a help text with ID .uno:TabBgColor doesn't exist either) Change-Id: I0624f0474334cc799d67f7f292e11194de5195fa
2016-07-26sc: convert SC_SCENARIO_.. defines typed flags ..Jochen Nitschke
ScScenarioFlags add ScScenarioFlags::NONE for 0. replace uses of '-= flag' with '&= ~flag'. Change-Id: I003c0ca1f59b060f52935fec8bb6282fd9981805 Reviewed-on: https://gerrit.libreoffice.org/27464 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24convert PIVOT_FUNC to scoped enumNoel Grandin
Change-Id: I6d50ad6fa0dbe7b21ad73e14dc2df3c854d08153 Reviewed-on: https://gerrit.libreoffice.org/25076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31sequence->vector in scNoel Grandin
Change-Id: I3edf08fe5db798dbc1190db375cfb82c5b9bc5da Reviewed-on: https://gerrit.libreoffice.org/23696 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-23loplugin:constantparam in scNoel Grandin
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
2016-03-10loplugin:constantparam in scNoel Grandin
Change-Id: Ia7bc394fdc0dba720751c2a58d55bfe34b239098
2016-03-03loplugin:unuseddefaultparams in sc (part2)Noel Grandin
Change-Id: I356a86bfca20cbf2c52185697042dce5237e847d
2016-01-22Move sc/source/ui/dbgui/validate.cxx from scui to scStephan Bergmann
8d1a24dae03690b576310e3539369916f31ac475 "Make virtual ~ScValidationDlg non-inline" caused the RTTI for ScValidationDlg to only be emitted in library scui instead of (weakly) wherever needed. That causes UBSan to fail when it uses the RTTI in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in library sc, to check that operations on VclPtr<ScValidationDlg> pDlg indeed operate on an ScValidationDlg object). The cleanest fix appears to be to move ScValidationDlg from scui to sc. As Moggi put it on IRC, "that dialog should be in sc as it is a modeless dialog; no idea why it works for that dialog but all other modeless calc dialogs have to be in sc to avoid linker problems." One remaining question is whether it is save nowadays in ScCellShell::ExecuteDB (sc/source/ui/view/cellsh2.cxx) to clean up the ScValidationDlg pointed to by pDlg when that VclPtr<ScValidationDlg> variable goes out of scope, instead of doing the PostUserEvent(... DelayDeleteAbstractDialog) dance that was there before because "after end execute from !IsModalInputMode, it is safer to delay deleting." Lets see. Change-Id: I3ecfd4fafc7b37b2f30e75974ece9b0a23311ef4
2015-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-25loplugin:unusedfields in include/sfx2/Noel Grandin
Change-Id: I3eb27ed10e82ee56b33866ac576c1b1f8c9756b9
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-10-28com::sun::star->css in scNoel Grandin
Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
2015-10-26convert InsertDeleteFlags to use o3tl::typed_flagsNoel Grandin
Change-Id: I3f6a97195d3364b2a0964f62f11e9c0de9493d64
2015-09-22convert SC_PASTE constants to scoped enumNoel Grandin
Change-Id: I2c1b2cd5a89b3124a2e452800bf397e100cc885b Reviewed-on: https://gerrit.libreoffice.org/18734 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22loplugin:unusedmethods scNoel Grandin
Change-Id: I7bdb1889a942d63370731764a58f4ab524dedd8a Reviewed-on: https://gerrit.libreoffice.org/17287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-12tdf#60573 Conditional formatting does not allow scrollingHenry Castro
If you need to apply conditional formatting to a cell not shown presently on your screen you cannot scroll to the position you would like to use. Change-Id: I18549316d2c725ce032a65cffb969bed21b771c3 Reviewed-on: https://gerrit.libreoffice.org/14258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-04create type-safe bitfield for sc insert/delete flagsNoel Grandin
The most important part of the change is in sc/inc/global.hxx It creates a type-safe struct that prevents the accidental interaction between regular integer types and the flags struct. It also provides utility methods that make combining and testing the flags type-safe. Change-Id: Ibc5b20058b1655df913490682b679afd1297b36d Reviewed-on: https://gerrit.libreoffice.org/11071 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-05-11fix-includes.pl: scThomas Arnhold
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-04-19fixincludeguards.sh: scThomas Arnhold
sorry, huge one...
2014-04-09convert data validation tab page to .uiCaolán McNamara
Change-Id: I1a4f1f4f06ec1ab0b28637380a8bfcb3bc64ee30
2014-03-30coverity#1194921 Overflowed return valueCaolán McNamara
Change-Id: I872835c3a20eda807d571fa27794dbe2bf858e7a
2014-03-17sc: prefer passing OUString by referenceNoel Grandin
Change-Id: I85e8823e872bf53182ce90576225e462edb1930a
2014-03-10convert pivot filter dialog to .uiCaolán McNamara
Change-Id: I795d296bae700d1e3a273fbe71fc842d145c5138
2014-03-06convert calc autoformat dialog to .uiCaolán McNamara
this dialog is hauntingly similar to the writer one, a copy and paste job Change-Id: Ic873038dba4ca4fd737690b917f6cd0d5144218a
2014-02-14sal_Bool->boolNoel Grandin
Change-Id: I240260ad63155a33ffcd0676175000c3bf65c613
2014-02-11convert change chart data source dialog to .uiCaolán McNamara
Change-Id: Iecccfbcd6b1eaec9d14c594812293c3e2acfda46
2014-02-05convert scenario dialog to .uiCaolán McNamara
Change-Id: I66f7fe04155ad4c6e42e6aa96bb2db71ba4f682f
2014-02-04convert select data source dialog to .uiCaolán McNamara
Change-Id: Iecca542c2c425a34184ba2c3ae0e34d093fa6a06
2014-02-02convert import options dialog to .uiCaolán McNamara
Change-Id: Iaf20b6d2306ba76f21cb5f7be231f40b403c790a
2014-01-28drop RID_SCDLG_INSCONT, etc. nowCaolán McNamara
Change-Id: Iee2eaf89f662b61fc4ec32b353b13417ee6b2610
2014-01-17convert pivot table subtotals data field dialog to .uiCaolán McNamara
Change-Id: I4ac7fb3a13cdc03d3c75cdd730bf39a7d814de99
2014-01-17convert data field dialog to .uiCaolán McNamara
Change-Id: I68da93c1227e8140511f3ad4071c87b3cf0443c0
2014-01-06CreateScColOrRowDlg is unusedCaolán McNamara
Change-Id: I1194d111eff8eeafb656d743af12d71523a65ac8
2014-01-04convert calc paragraph dialog to .uiCaolán McNamara
and that's the last TabDialog in calc converted Change-Id: Idecf1b4ba991f7b59e40ea0f0813a5dc5644dfd3
2014-01-04convert calc character dialog to .uiCaolán McNamara
Change-Id: I305b18bea24377dcd98b3e06c4cf75bdbdd4d717
2013-12-29convert tab background color to .uiCaolán McNamara
Change-Id: I121d4abd3227b96a274f1983e61ca313728419f7
2013-12-23convert validity tabdialog to .uiCaolán McNamara
Change-Id: Ib7be4172e2d9b80869dbfa47674b13f1e03877d3
2013-12-20convert row/col height/width dialogs to .uiCaolán McNamara
Change-Id: Ie97b9fcdd5fb93d195ea1beb536d5a0ac7bf7cc4
2013-12-19convert show sheets dialog to .uiCaolán McNamara
Change-Id: Ia32aa742b426872c6634a431170c441ae3c8c963
2013-12-19convert sort dialog to .ui formatCaolán McNamara
Change-Id: I9c82b504df0879c338f1858b16ed70a91d459e02
generated by cgit (git 2.34.1) at 2025-02-13 02:15:49 +0000