summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2015-07-24tdf#92256: Handle case when string ref syntax is unknownKatarina Behrens
i.e. the document doesn't have that property. Use CONV_A1_XL_A1 pseudoconvention for interpreting INDIRECT in such case Change-Id: If9bac9053029b4b8f79d3ac7ac0759adbb25803f Reviewed-on: https://gerrit.libreoffice.org/17311 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-07-23inline a handful of use-once #definesNoel Grandin
Change-Id: Id2654555c4042f8c0bdbd6bab6507e705f08326b
2015-07-22loplugin:unusedmethods scNoel Grandin
Change-Id: I7bdb1889a942d63370731764a58f4ab524dedd8a Reviewed-on: https://gerrit.libreoffice.org/17287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22loplugin:unusedmethods scripting,scNoel Grandin
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7 Reviewed-on: https://gerrit.libreoffice.org/17263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21loplugin:unusedmethods formulaNoel Grandin
Change-Id: I62ff278679638dda7e10c86c49b1966641418e8b Reviewed-on: https://gerrit.libreoffice.org/17223 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20Resolves: tdf#58838 do not use collation for Equal/NotEqual operatorsEike Rathke
Unicode collation ignores control characters and other specific characters, see http://www.unicode.org/charts/collation/chart_Ignored.html and thus is not suitable to be used for Equal/NotEqual operators. Change-Id: Ib84713e1da59d92e07bc974d93b6def8217bb067
2015-07-20tdf#92256: ODF save/load syntax for string referenceKatarina Behrens
Change-Id: Iec38867c2fa3750f052e4afc99c5f8d48808c373 Reviewed-on: https://gerrit.libreoffice.org/17017 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-07-17Resolves: tdf#77479 do not reset AutoFilter range for temporary operationsEike Rathke
Change-Id: I22f5e74ca91eb188ce669762927dd25604a256ff
2015-07-16Convert Alignment button to the generic controllerMaxim Monastirsky
Change-Id: I76ead43fa1cfe7ba1b62d2b13c4f4d7658a9f290
2015-07-16Convert FontWorkShapeTypeControl to the generic controllerMaxim Monastirsky
Change-Id: I7824136aa2780c4062a66f7a5284a342862f319a
2015-07-16Resolves: tdf#88402 remember sort "has headers" at anonymous database rangesEike Rathke
Change-Id: I4a126f40589fd401f3a63f74be5e86e3df947ef6
2015-07-16loplugin:unusedmethods svxNoel Grandin
Change-Id: I92158457b3ffaaf7c84c6f4c87708d766c8c9f61 Reviewed-on: https://gerrit.libreoffice.org/17117 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13renumber globstr.hrc STR_...Eike Rathke
and move STR_HEADER_RANGE_OR_EXPR and STR_HEADER_RANGE to proper positions. Renumbered sc/inc/globstr.hrc consecutively using sc/util/number-defines-consecutively.awk which closed a gap of six strings. Change-Id: Ibf643ad5b243caf7b01226af399e60bbe0433a15
2015-07-13Resolves: tdf#92709 conditional formats are applied to ranges, not expressionsEike Rathke
Hence we need a separate string as header in the dialog. Unfortunately I did not see this when applying 0cf38e7d0c5d2b67dca828aae1797bff58b6c5fe Change-Id: Ib60cef29e663e71a25849df1d5a926f0e871bb8b
2015-07-13Introduce generic sub toolbar controllerMaxim Monastirsky
Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-13editeng: make Link<> usage typedNoel Grandin
Change-Id: Iec36c7e4f4fbc2ee2ee25d4d0c8488340ba7d8c4 Reviewed-on: https://gerrit.libreoffice.org/16968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10Kill SID_TBXCTL_INSOBJMaxim Monastirsky
The associated toolbar doesn't exist anymore, and most of the buttons that were there in (at least) OOo 2.0 were moved to the Insert toolbar (it's the one that's pulled from the "Insert" button). So kill it, and make Insert Chart/Object visible by default in the Insert toolbar. Change-Id: I84ea43f560ea23ceff2e885e9ce615b9d76f3075
2015-07-10formula/random.hxx in pchCaolán McNamara
Change-Id: I0cb650fdaf6608abfab43b145ca8a299f8d4ddb4
2015-07-09execute the terrible bottle neck loop only if there are conditional formatsEike Rathke
Change-Id: Ic8bd65a728289c9fa1a0721b0ecbd9b4a48672ca
2015-07-08remove ScRange::Justify() and replace calls with PutInOrder()Eike Rathke
Change-Id: I350050ac085b1f220d5288d33c253ba0c9a5fd2c
2015-07-08sc: remove unused boost::random includesMichael Stahl
Change-Id: I91b5ad2319f7c2b57c890106e94f8de79cbefbc0
2015-07-07introduce ScTokenArray::AdjustReferenceOnCopy(), tdf#92468Eike Rathke
Change-Id: I0a7ac0d9d10e96223cd5f095a771aa6f9d271417
2015-07-07(re-)introduce ScComplexRefData::PutInOrder(), tdf#92468Eike Rathke
Change-Id: If551e02a77a416b95f74266de896391d1d72eb3c
2015-07-06unify code duplication in ScInterpreter::ScSum and IterateParametersWinfried Donkers
The code in ScSum is mostly identical with that in IterateParameters. Worse, functions like SUBTOTAL and AGGREGATE use IterateParameters for the SUM function. Now we have one set of code for all SUM-functions and averted the danger of diverting pieces of code which are supposed to do the same thing. Removed old-style bNull-method too. Change-Id: Ia4f22c21c4b3c3a244ea1cd10c30d8cfcaa8ef6c Reviewed-on: https://gerrit.libreoffice.org/15362 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-07-06tdf#92547 - incorrect input values shown in formula wizardBenjamin Ni
Change-Id: I55dd98b1613376c8e1c83af8ffdc66a58e022cb1
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04Fix typosAndrea Gelmini
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29no need to recompile the formula againMarkus Mohrhard
Change-Id: I03b72bd6a0b341ec89e0995f7b53287449ce9f61
2015-06-29Subformula evaluation in formula wizard treeBenjamin Ni
Change-Id: If4f6a608f261621e2e1ba40b36d71d39a137a453
2015-06-26use ScComplexRefData::IsEntireCol() and IsEntireRow()Eike Rathke
Change-Id: I4287019f5492825f6d295c4e364405f0d7329eb7
2015-06-25TableRef: add ScDBData::GetColumnNameOffset()Eike Rathke
Change-Id: Id80b9e8d1f54a8b795d0f4209bdf2f980f9a5344
2015-06-25TableRef: invalidate table column names on most sheet operationsEike Rathke
Kept only on insertions and deletions, but even that may not be useful as the names aren't updated at any time so even a mere cell change will bring this out of sync. But serves as a starting point for further implementation. Change-Id: Idfede4b03b9f554cd35f984502fce625c725853c
2015-06-24TableRef: add ScDBData::maTableColumnNamesEike Rathke
Change-Id: Ifb95f76f518646e32d1df45a77f146ad3a255087
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23sc: add ScModelObj::getTextSelection().Henry Castro
Calc copy part of copy&paste Change-Id: Id9d2d05b491849fa30b3c91c6b22abe60355e876
2015-06-23in OOXML save references of named expressions with col,row=0,0 base positionEike Rathke
Saving relative references of named expressions to OOXML never worked, upon reload they pointed to a different position offset by the value of the original base position. This at least saves positive relative references correctly, while generating #REF! for negative offsets which is slightly better than having them point to a wrong location and silently calculate different values.. Also, this is a prerequisite for TableRef ThisRow references in named expressions to be saved correctly in A1 notation, which results in a relative row 0 value. Change-Id: I3734f910794ceab4b9224b214ad11c64d1d18e67
2015-06-22sc tiled rendering: Set some minimal size of the document.Jan Holesovsky
Let's default to 12x36 cells. Change-Id: Ic39739ec036a6e5867d31b7e05b6da12ce2e46d2
2015-06-22TableRef: inherit RelName in generated reference if named expressionEike Rathke
Change-Id: I67621e59c6e20e7f3b5101772b5d274d8c745ce9
2015-06-21TableRef: make ThisRow work in named expressionsEike Rathke
... including reference update as named expressions don't hold RPN. Change-Id: Ieea19e24f1dcf71d489ff0249bc7d3644e4f0d2b
2015-06-18Resolves: tdf#83365 push proper references in INDIRECTEike Rathke
... that take relative/absolute addressing and sheet 3D flag into account to be fed to reference extension via range operator. Change-Id: Iabe13ae384577e2d71ca87af6482ddccbf7ad0ac
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17Resolves: tdf#86305 clone upper left of matrix result if double tokenEike Rathke
Change-Id: I541577e0b99b0144a755e5755adc890c0ca8d204
2015-06-11Resolves: tdf#89643 report builder function wizard segfaultsCaolán McNamara
regression from commit 3d6521280929ecacc53b7c358d29d0b5d31b3462 CommitDate: Thu Jul 31 22:14:25 2014 +0200 fix memory leak around function descriptions Found by Lsan. There are two implementations of getCategory, one (sc) returns a new one each time (hence the leak fix) and the other (reportdesign) returns a pointer to one that belongs to the manger (hence the crash). The code in formula really looks to me to expect that the getCategory return a pointer that "someone else" needs to look after, i.e. the reportdesign variant is the more correct so revert 3d6521280929ecacc53b7c358d29d0b5d31b3462 and to fix the leak make the sc own the ScFunctionCategories and just cache them like the reportdesign one does Change-Id: Ifd986301a54b4d20449e864697655cd973e0c4df
2015-06-11tdf#69552 [part 2] support all ODFF1.2 and Excel2013 variationsWinfried Donkers
of CEILING and FLOOR Change-Id: I9537d9bd8dbca2eac769e74e9d3d5b298b76f594 Reviewed-on: https://gerrit.libreoffice.org/16016 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-06-11loplugin:staticmethodsStephan Bergmann
Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9
2015-06-10tdf#89972: also copy external reference statusMike Kaganski
fixes regression from commit 4467c67dc8bf17c67c70985c0d0ea64636884f9f, where the new optimized code path failed to properly register ScFormulaCell with ScExternalRefManager. Introduces a new public method in ScExternalRefManager: insertRefCellAsTmpl that registers a formula cell to listen to the same external references as template cell Introduces new property to ScFormulaCell: mbIsExtRef that indicates that some external references are referenced by this cell Also introduces new method ScExternalRefManager::hasCellExternalReference (for use in unit test, will be posted immediately) Change-Id: Iee07d7b51949fd31953b5fa662a213052eb85181 Reviewed-on: https://gerrit.libreoffice.org/16066 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I700b727c048aff5c19411fb9d5bd9601b296cb06
2015-06-08\<the the\> -> theJan Holesovsky
Change-Id: I9d820446411eb7dfca37bb3baf5e994f4ba6f421
2015-06-05CALC: readd InsertRows/InsertColsPhilippe Jung
Following ESC decision, uno commands InsertRows / InsertColumns must be added to the current one InsertRowsBefore / InsertColumnsBefore and InsertRowsAfter / InsertColumnsAfter. This will guarantee ascending compatibility while making more explicit the behaviour thanks to the new commands. For Calc, these commands are equivalent to InsertxxxBefore Change-Id: I3aada5c9b03c504e6728c33cad2b2d569df1d60a Reviewed-on: https://gerrit.libreoffice.org/16099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>