summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2017-06-28repaint whole range for range based cond formats, tdf#105696Markus Mohrhard
The range based cond formats need to be repainted across the whole range. This ensures that a change in condition which affects all cells causes a repaint. Change-Id: Ie6dd10088a1c11c1bafd1faa9c429a35a6469ff2 Reviewed-on: https://gerrit.libreoffice.org/35302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-27add way to handle update refs for addresses, related tdf#107289Markus Mohrhard
Change-Id: I97d1724d7aa1652619edda1cbe6a4ae4db277563 Reviewed-on: https://gerrit.libreoffice.org/39316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-21convert ErrCode to strong typedefNoel Grandin
would have preferred to re-use o3tl::strong_int, of which this is a modified copy, but there are lots of convenience accessors which are nice to define on the class. Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a Reviewed-on: https://gerrit.libreoffice.org/38497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-20Remove unused ScColumn::mbDirtyGroupsEike Rathke
Change-Id: If8ed724ccec136653db5fcf43f9e74a82826add7
2017-06-15Prevent excess rows included in the resulting range list, tdf#95883 follow-upEike Rathke
Change-Id: Id2fdffa4d7bba8225ea5fcf583a562467342ad3d Reviewed-on: https://gerrit.libreoffice.org/38728 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-06-15Resolves: tdf#104875 defer filter detection to first load/update of externalEike Rathke
Attempting to access all linked external documents right on load time was specifically nasty for non-local URIs (unmounted smb, http, ...) Change-Id: If4a7414dfe36875b505c73b8c963b650eeffe204
2017-06-14Let CreateItemSet return unique_ptrStephan Bergmann
...and address resulting loplugin:useuniqueptr Change-Id: Ia79eb8d59ce5092b2d93b656eab687096baedf17
2017-06-13Let SfxSetItem ctor take SfxItemSet by unique_ptrStephan Bergmann
Change-Id: I219dd03477862169cd50eecc14822f6a023f879a
2017-06-12Use unique_ptr fro ScMergePatternState::pItemSetStephan Bergmann
Change-Id: I672785b273eaa8862f43112d7f25ae495b65b0c7
2017-06-12tdf#95883 Select Unprotected Cells in CalcGulsah Kose
Change-Id: I20a71f66154675de9c2c47ff32e859c899fe9103 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/37424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-12clang-tidy readability-delete-null-pointerNoel Grandin
which in turn triggered some loplugin:useuniqueptr Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64 Reviewed-on: https://gerrit.libreoffice.org/38281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-09clang-tidy readability-non-const-parameterNoel Grandin
Change-Id: I7b2680898dbfc49185fb949349d81f4ac615a470 Reviewed-on: https://gerrit.libreoffice.org/38593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-08Remove a TODO and explainEike Rathke
Change-Id: Ic648fd2b0a1424aa5ae5d924b29dfd2cb8dddbf9
2017-06-07Take new FormulaTokenArrayPlainIterator into use in one more placeTor Lillqvist
Change-Id: Ia93b7759939bce42a4baf9ff55ec3c2b01840d9d
2017-06-06first arg of ApplyBlockFrame is never nullCaolán McNamara
Change-Id: Ie65fce6041278c6758df266c4ef097a5758f75dd Reviewed-on: https://gerrit.libreoffice.org/38448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06nullptr never passed to ApplyFrameAreaTabCaolán McNamara
Change-Id: Iece6c99b6414eb2701af61a64d0ff80f52a0379d
2017-06-062nd arg of ApplySelectionFrame is always not nullCaolán McNamara
Change-Id: I50a5c9c3f0f2b7424fa1b9b27ceeee9ae9348413
2017-06-06add COVERITY_NOEXCEPT_FALSECaolán McNamara
to markup dtors that coverity warns might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4 Reviewed-on: https://gerrit.libreoffice.org/38318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06expand out FltError and eERR constantsNoel Grandin
they're just aliases for ErrCode and ERRCODE constants. It's not like I can even convert them to an enum since the relevant functions do not return only these constants, but also a variety of other error constants. This a cleanup commit prior to converting the ErrCode stuff to an o3tl::strong_int Change-Id: Ia9f506a24f6bd382d86b68e46bec36e4da7a4310 Reviewed-on: https://gerrit.libreoffice.org/38412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06replace SCERR_NONE with ERRORCODE_NONENoel Grandin
since the first is #define'd to the second, and offers no extra value Change-Id: I8268b4969ccdc090eeb8cd877e476bb32d2ddd1b Reviewed-on: https://gerrit.libreoffice.org/38410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06tdf#107945: prepare for future multi-threading of pivot cache...Kohei Yoshida
It's disabled for now. We need to first make the edit engine and a few other places thread-safe before we can parallelize this code. Change-Id: Ie09536964ece42d43f505afc5e2611d469cc5c95 Reviewed-on: https://gerrit.libreoffice.org/38424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-04Perf-sc: tdf#100709 avoid segment tree with ScMultiSelIter where possibleEike Rathke
* create ScFlatBoolRowSegments in ScMultiSelIter only if necessary * create ScMultiSelIter only for affected columns in ScTable::MergeSelectionPattern() using ScMarkData::GetMarkedColSpans() * obtaining a full ScRangeList in ScMarkData::GetMarkedColSpans() was completely unnecessary, use existing selection containers instead and also if possible avoid creating a segment tree that needs to be converted to vector, directly use a vector instead Improvement: * under ScDocShell::Load() previous: Ir: 26 454 571 612 now: Ir: 18 811 368 362 * thereof under ScTable::MergeSelectionPattern() previous: Ir: 4 104 164 533 now: Ir: 664 738 808 Change-Id: I95895a3a000c1a0b7895fb0696b0889c6d6b4d49
2017-06-02rework ScQProReader to take SvStream instead of SfxMediumCaolán McNamara
its only uses the stream anyway and this makes it far easier to build a fuzzer on Change-Id: I4aa8b56d4b041708c4de1730d503641ab23c14e8
2017-06-01tdf#107945: store rtl_uString pointers instead of heap OUString objects.Kohei Yoshida
Change-Id: I61079e041a79195f9e9cb77ce80368ef7e909cef Reviewed-on: https://gerrit.libreoffice.org/38288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-31disambiguate dual use of toolbar idsCaolán McNamara
for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-31tdf#107797 select all entries in the dropdownSzymon Kłos
Change-Id: I3ee33040744eab35f841d3622cb8981b49d04333 Reviewed-on: https://gerrit.libreoffice.org/38091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-05-24Clean up a commentTor Lillqvist
Change-Id: I9ee47a3de42087fb63e5d3e931ecee538017f3cc
2017-05-24tdf#107945: properly iterate over mtv during pivot cache loading.Kohei Yoshida
This reduces the total time required for populating the pivot cache by ~60%. Change-Id: I6a8511959c20231a8a5dbd0b0a9a3d0930a1fa0c Reviewed-on: https://gerrit.libreoffice.org/37971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-23drop the SCsROW/SCsCOL/SCsTAB typedefsNoel Grandin
which are exactly the same as the regular SCROW/etc typedefs, and have been this way since commit 43a21999a92c99867bc3417291719996776b0647 Author: Oliver Bolte <obo@openoffice.org> Date: Fri Jun 4 09:00:39 2004 +0000 INTEGRATION: CWS rowlimit (1.1.2); FILE ADDED Change-Id: Ia7f75d71227ca3167b5fd56019bb9bdf0697d1b0 Reviewed-on: https://gerrit.libreoffice.org/37911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-23enhance useuniqueptr lopluginNoel Grandin
teach it to look for the following sequence in a destructor: delete m_pfoo; m_pfoo = nullptr; Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380 Reviewed-on: https://gerrit.libreoffice.org/37900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-22Introduce ScRefListToken::mbArrayResult for reference results, tdf#58874Eike Rathke
Change-Id: Icd077a82ab0c951667a6566d5c5d47084c46d20d
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18Revert "Fix typos"Stephan Bergmann
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18Always set a grammar when constructing ScCompilerEike Rathke
Otherwise mxSymbols is null, which is rather unexpected as the past has shown, see commit 63843a97262ccfa38d838a9cbbc3faadba8290a6 Change-Id: Id4c13a5f50e711513a71a7d6cd6f87b4112b1f1d
2017-05-18New HintId and unit test for hidden rows and SUBTOTAL, tdf#93171 follow-upArul Michael
Adding new Hintid for HideRows so that we notify only formulas with subtotal and aggregate function for recalculation. Added unit testing. Change-Id: I44f2e45acaf697f91744bc8202f27b218faa5b43
2017-05-17tdf#43535: support additional sheet protection options.Kohei Yoshida
New options are: * insert columns. * insert rows. * delete columns. * delete rows. Change-Id: I076b0d01bee0fff0623e2f1137c09938a6110939 Reviewed-on: https://gerrit.libreoffice.org/37695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-16lok: sc: misplaced comment mark on inserting/deleting/resizing row/colMarco Cecchetti
A unique id has been introduced, in a similar way of what occurs in Writer. Change-Id: I7b2ef694867fb4184c4cfc616fe1c8f12da3b676 Reviewed-on: https://gerrit.libreoffice.org/36962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16loplugin:unusedfields improve write-only analysisNoel Grandin
by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15Typo: s/threashold/thresholdTor Lillqvist
Change-Id: I42af7f4c27084e41c63b8d3c8c3111dd814eb74d
2017-05-13use empty document in orcus gnumeric import, tdf#107828Markus Mohrhard
Change-Id: Ia7ee2de6f9b14a132a29c01f8d863889477c0a8d Reviewed-on: https://gerrit.libreoffice.org/37579 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-12convert SdrLayerId to strong_intNoel Grandin
Also - rename SetOfByte to SdrLayerIDSet - add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't allocate overlapping SdrLayerID values - add a new constant SDRLAYERPOS_NOTFOUND to be returned from SdrLayerAdmin::GetLayerPos Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8 Reviewed-on: https://gerrit.libreoffice.org/37467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12tdf#93171 Subtotal function with function indexes don't updateArul Michael
Calling InerpretTail during Hide rows by SfxHintId::ScDataChanged broadcast Change-Id: Ie78170bb6d49933a49d828a18637cb410796dc06 Reviewed-on: https://gerrit.libreoffice.org/37509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-11tdf#107258 Create show/hide all comments toggle button.Gulsah Kose
Created new show/hide all comments button for calc by ShowAnnotations command. Unifyied writer, calc and impress's ShowAnnotations slot. Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/36697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-10loplugin:checkunusedparams in sc(part3)Noel Grandin
Change-Id: I61fc2ba762983d7bafb6ed8baafba458590af59a Reviewed-on: https://gerrit.libreoffice.org/37458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10loplugin:checkunusedparams in sc(part2)Noel Grandin
Change-Id: I1d54d16dbe5648a21baa9bf96444e60fcd034c81 Reviewed-on: https://gerrit.libreoffice.org/37457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10loplugin:checkunusedparams in sc(part1)Noel Grandin
Change-Id: I8c4fca704fe8ed6f861728cc3f3782c676aba67c Reviewed-on: https://gerrit.libreoffice.org/37435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10Hold ParamClass at FormulaByteToken instead of bool, tdf#107724 prepEike Rathke
* change IsInForceArray() to GetInForceArray() * add IsInForceArray() to keep previous functionality Change-Id: I64c891486e548a66539646846a4691a213c783ac
2017-05-10Change IsForceArrayParameter() to GetForceArrayParameter(), tdf#107724 prepEike Rathke
Change-Id: Icd3400e4ee1c69860908a2ad0ca6e52879f2f725
generated by cgit (git 2.34.1) at 2024-08-05 13:40:07 +0000