summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2025-01-18cid#1640473 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Id8e440ea08e2d6a853e870dc0161d30e63b75cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180436 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-17sc: make data validy error dialog async (invalid value error)Pranam Lashkari
Change-Id: Icd077776b26e21b226b4dee5beb1a5ff6dcf301a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 495be2dcb34d22af59a2028d3a686a0d48774166) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180286 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-16tdf#150878: Add support for TOROW functionXisco Fauli
Change-Id: Ic1acb5c2fd08ecab7c3ee059888cf44aa45ee287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180308 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-15tdf#150879: Add support for TOCOL functionXisco Fauli
Change-Id: I0c8bfdd8f9b806a1260cceace1ced4be2b046abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180245 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-01-10ITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2025-01-09tdf#162286 Add a category to store favorite functions in FWAhmedHamed
Change-Id: Iec0d169570ba3d29501a4917d8858a9e9438f608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171828 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-03Drop unneeded forward declarations from include/Gabor Kelemen
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-23optimise ScBoundsProvider::GetIndexTowardsNoel Grandin
Especially when laying out rows in sheets with thousands of rows. By pushing the work down to a new GetRowForHeightPixels method, we can do the work in only a couple of iterations of the loop, because row heights are normally represented by only a few spans. Change-Id: If3f62a131a3e7a0794d7352d7c6c1a5de0ef2df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179086 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-23tdf#42989: don't set fake ATTR_VALUE_FORMAT for multi-format selectionMike Kaganski
Change-Id: Iaed133b19c4d870ff85fd9d2dd69db36318bb28e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179190 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-19tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I9834c891e4b15c650c5a2600435283516ca7b2c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177148 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-12-19tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: If16e686ce726f6f05d84224ef30fc95813600791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177146 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-19tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ibdda74f8a779097ab189f77a62adff7a12330bd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177145 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-10Silence -Werror,-Wunused-private-fieldStephan Bergmann
...in DBG_UTIL-only code introduced in 2e1f9da8a6359c8909e087a92239aefd4851b116 "Decouple ScPatternAttr from SfxItemPool", which only started to generate a warning now with Clang 20 trunk, presumably since <https://github.com/llvm/llvm-project/commit/d457100a8152cc2ebf8cd219caae92cc0f591156> "[Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (#116871)" (and only warns about m_nSerialNumber, which is only written to in the ctor, but not about m_bDeleted, which is also written to in the dtor, even though neither of them appears to ever be read) Change-Id: Id7fb1cc1e082464d4c5b935bdd194edf92704505 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178202 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-12-09tdf#157747 Add tooltip to Calc select all rowsAdesola Samuel
Added a tooltip that says "Click here to select all cells" to calc select all rows corner. The report shows a tooltip will suffice instead of an added icon Change-Id: I33f9bcb48f9185267be760219f58b196e4d5874d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178092 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-08Simplify ScCellRangesBase and descendantsMike Kaganski
Change-Id: I2416ab8a9263bd7858e0d62055067b3c6132e0b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-03Revert "sc: manage conditional format with simpler dialog"Pranam Lashkari
This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37. Change-Id: I500a96508684547c158cdd1814540a4b24f667d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341 Tested-by: Jenkins
2024-12-03Revert "sc: added date condition option in conditional format manage dialog"Pranam Lashkari
This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef. Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: now formula conditions can be managedPranam Lashkari
...from condition format manager" This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8. Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: now conditions can be edited from easy conditional format dialog"Pranam Lashkari
This reverts commit 8115c82f1f7f2621e2d99c93e1a3b2196279602a. Change-Id: Ie3f389561ee8f734ac76b3dec352382281f91c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177284 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177335 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03don't bother passing const std::[u16]string_view by referenceCaolán McNamara
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03Resolves tdf#127937 - Feedback for AutoCalculateHeiko Tietze
Shows an icon in the statusbar if autocalc is off; clicking the icon toggles autocalc on Change-Id: I7fb3296281647583f6f761427d35dcd79282f06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177418 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-02loplugin:unusedmethodsNoel Grandin
Change-Id: I85ef1d4e9391e211c9e5e7ac6e9de875e9f5f5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-02Remove unused empty stringAndras Timar
Change-Id: If29babb15d0e594e2746d6124218704e3f49728b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177670 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-11-28Simplify ScSubTotalParamMike Kaganski
Change-Id: I4c1840e377711ad065c3042bddacb2028481b88d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-27make calc Grid config listen for changesCaolán McNamara
Change-Id: I1015adf6f8a270569e48b8e66b141ef37f217a1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177400 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-26sc: prefix members of ScConditionalFormatXisco Fauli
Change-Id: Ib8d6b19f4ff1a5a641039f7e06083430b53a6edb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177301 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-25tdf#85976 Use correct labels in 'Handle Duplicate Records' dialogSahil Gautam
+ 'Records:' to 'Compare by:' + if row is selected in 'Compare:', 'Header:' checkbox should be labeled as 'Data contains column headers' and vice versa for column Change-Id: Ic9dfbab9a5636312c40b6945af3abdcd9b190310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177230 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
2024-11-24Turn SC_MOD macro to a functionMike Kaganski
Change-Id: I5fc11037902bc6200fdaf4749260efe8e658bdce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177070 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23Reduce copying of ScEditEngineDefaulter's SfxItemSetMike Kaganski
Change-Id: Ifea96f2cf586b4e5b63761e2f03944dade764430 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177073 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-22loplugin:unusedmethodsNoel Grandin
Change-Id: I24666a7746f8920ddf84731f204f3e1a5b9b0c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-22tdf#163486: PVS V1043 global object variable is declared in header (sc)Julien Nabet
Change-Id: Ie328b5120bc879702db351555c9db5d6b661be41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176990 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-21tdf#163486: PVS: variable is assigned values twice successivelyXisco Fauli
Since commit d0cacf09a1105d89bf3df84b18623d790e3aeb82 Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Date: Wed Apr 27 11:45:04 2022 +0200 tdf#99708 Save formula bar height to document V519 The 'pSettings[14].Name' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 3806, 3816. Change-Id: I7afcee42d10d692c2c9a84b6a6f0a97ceb913081 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176761 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-14tdf#160404 tdf#160535 tdf#160536 - sc improve sheet protectionBalazs Varga
tdf#160404: Fix FILEOPEN XLSX Pivot table is not imported if sheet protection has Pivot table editing enabled - Import correctly the pivot tables, even if the tab protection is not allowing to use them. tdf#160535: Support sheet protection option: Use AutoFilter - Add new option for tab protection to enable/disable to use autofilter on the sheet. Import/export correctly to odf/ooxml. Add new ext-odf attribute: XML_USE_AUTOFILTER tdf#160536: Support sheet protection option: Use PivotTable&PivotChart - Add new option for tab protection to enable/disable to use Pivot table on the sheet. Import/export correctly to odf/ooxml. Add new ext-odf attribute: XML_USE_PIVOT Change-Id: I5d34e3608aed1a3d004ec553f6125b6428e9c05e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176274 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-13tdf#163486: PVS: pointer not released in destructorXisco Fauli
V773 The 'pDefaults' pointer was not released in destructor. A memory leak is possible. Change-Id: I7df195d1f515b86e85993d6c0a6cf60bcaff3109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-12sc: prefix members of ScEnginePoolHelperXisco Fauli
Change-Id: I7c161ea0f30f6dce8cc64a841245f98f4ca8c507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176472 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-07loplugin:passstuffbyref in scNoel Grandin
Change-Id: Ic3ce1406aa2567ca676bb8f431c52f590fadaec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176198 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-06Related tdf#162262 - sc: odf import/export of "Summary below data"Balazs Varga
Add new LO_EXT "summary-below" attribute for table:subtotal-rules. Follow up commit: 26c08356d1b2a963efdca570979cb04388371400 (tdf#162262 sc add "Summary below data" option for Subtotal dialog) Change-Id: Ie7f43d3c76479cd9468552b5939de5dbb2082a02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176058 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-06tdf#162177 Adapt function EASTERSUNDAY to ODF 1.4Regina Henschel
This includes writing ORG.OPENOFFICE.EASTERSUNDAY for ODF 1.3 and ODF 1.2. Change-Id: Ifa19021060f0d0223234c1ca1109300908e2dda1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175736 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-11-04tdf#163736 - sc: fix searchmode cached values for lookup functionsBalazs Varga
Check the search mode option in cache for lookup functions, because different search modes can produce different results. Change-Id: I6127a644dc4eae6fad909a6bc83bde2c66e85201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175972 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-11-01tdf#163667 speed up spreadsheet with lots of cond formattingNoel Grandin
Attempt to avoid the cost of GetCondResult when dealing with large runs of identical cells Change-Id: If9192a9858e6785263ea1621e98d1b1d5de74c4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175909 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 7d7d94b7713d86e2fd972c3b81845eaffb5761e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175898 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-31tdf#85976 Make labels more intuitive in "Duplicate Records Dialog"Sahil Gautam
Records is not a very intuitive label for the the treeview section of the dialog. Change to "Rows: " and "Columns: " based on what's being displayed in the dialog Change "Compare: " to "Compare by: " Change-Id: Idff5f4a6935856f2c5a16f5b45bf8ce0ba169ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175704 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-10-28make quotes warning clearer for conditional format dialogPranam Lashkari
Change-Id: I70fcc98962c46be32352fad72d5717fa685b881e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175133 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d3bc1970fa9bd7acf7a6d0a2e1dba756cfc70e86) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175618 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins
2024-10-28tdf#162262 sc add "Summary below data" option for Subtotal dialogBalazs Varga
With this option we can set where the summary rows should appear, above or below the datas when we create a new Subtotal area. The default option is "True" (which means the summary rows are below the datas) when we create a new subtotal area. Unless if we already have one subtotal area on the same sheet, in that case the sheet level property, "TotalsRowBelow" contains where should the summary rows be for the new Subtotal's. TODO: add new ODF xml attribute for Summary below Change-Id: Icf86c85041d75c24919cb528846d5bb2b517ca78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175556 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-10-27add a visitor contraption to avoid Reference counting costsCaolán McNamara
brings my save times from 8.7s to to 5.85s Change-Id: I7f3ebbed78ee4d59f4ed9d04f1e35d2ea69a0c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175689 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-27move fetching svl::SharedString inside ScQueryEvaluator::compareByStringCaolán McNamara
so we can defer actually calling getCellSharedString until we need to, as a setup to avoiding copying svl::SharedString in a follow up Change-Id: Ibd565e3cec3d455d76df75b9f135b38bc00df270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-26Fix wrong string ID's for the sensitivity reportRafael Lima
Change-Id: I4fe860e29eaf11601c633ff32c44d0c4e67b0958 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175605 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-10-25we can remove a SharedString copy nowCaolán McNamara
given that there is no OUString* pValueSource2 case Change-Id: I5420ebf7cc7cd5d0b77256788e8ecd74d445a286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-25ScQueryEvaluator::compareByString now never has non-null pValueSource2Caolán McNamara
and always has non-null pValueSource1 Change-Id: I5774e8beefeb5e40d316ea8557c656a126f4a7ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175637 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-25speedup saving large XLS file with lots of query formula(2)Noel Grandin
reduce cost of OUString construction by avoiding initialising a temporary and then overwriting it. 12s to 10s Change-Id: I889152ba71947004ca7d5c96f073182c94d95ed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175539 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-22 01:56:19 +0000