Age | Commit message (Collapse) | Author |
|
Change-Id: I15c3a2b0696661de4ca6454b3ef047af3871eed3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88858
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Works with shapes and comments.
Change-Id: I2a91a6038ab618bf7e6fd4eb2d129a9485a47fef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88163
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: Ief2538fb61f4519e733ce7592cc7c441b94ac124
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88030
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
tweak plugin with the name of another clone method
Change-Id: I47193d31f53f48297c9e773da375c7255ddde282
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87852
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If2dee122bf07dc179fd8f6e766442ec1891a5f3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87845
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
With --enable-pch=full there's not much difference between a "public"
header in <module>/inc and a private one in <module>/src/somewhere/inc .
And since the script searches recursively, this apparently helps to
find even more headers for lower pch levels.
Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
which is much better for CPU cache, since the representation is more
compact, and since we almost always do insert() in pointer order,
there is surprisingly little sorting
Also add a count() method for compatibility with std::set and the
proposed std::flat_set
Change-Id: I2a3211dc59919cfec5cac1497530a4c3600d50ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87793
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icd8e75e42d2311396bfb68e50f2421f9dd61b22e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87588
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: Ib2465f040f12413560b2cec1c742cf3558461309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87404
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: I2c74c77115df7c9fd29ccf7722d00c71687046fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87402
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: Ic525a57880067fc589346b87237c08fae4644ac5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87403
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
This avoids problems with round-tripping Excel spreadsheets, where
previously a formula like =IF(ISNA(A1)=FALSE;"a";"b") was imported
as =IF(ISNA(A1)=0;"a";"b"), and when exported back, it didn't work
in Excel, because boolean values had a distinct type in it.
Change-Id: I672a631bfa1a4811349794f714293404c6b24381
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86238
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
and compact the ScMarkEntry record, this stuff shows up on perf profiles
Also make these classes so we don't need to #include the cxx into a
unit test.
Change-Id: Id806385ae877a576ec25e7772c972448dada130b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86907
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2908abc13f16b0011fcb326e8405080cc30df74a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86684
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This also changes AGGREGATE() 3rd and subsequent parameters'
classification from ReferenceOrRefArray to ReferenceOrForceArray
to force the expected array mode on inline calculations.
Change-Id: I53a5591e46bfbabbfa6a273f5b9590a69fad87a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86388
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I5f4c4b43067b99cd57f8ea941002481ef5977e09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86144
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I144a1dd7901c90a979a018576404b84ece36a79b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86222
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...after 4992d61600536fe14b97b718dbb11f00e936c6a9 "tdf#129228 speedup opening of
xlsx file with lots of comments" added
> ScTableSheetObj* pAnnosSupp = static_cast<ScTableSheetObj*>(getSheet().get());
> rtl::Reference<ScAnnotationsObj> xAnnos = static_cast<ScAnnotationsObj*>(pAnnosSupp->getAnnotations().get());
to Comment::finalizeImport in sc/source/filter/oox/commentsbuffer.cxx. (See
<https://ci.libreoffice.org/job/lo_ubsan/1493/>).
Change-Id: Ia8a99297151abfe4f052fbf46504795db1ba87b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86192
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I47f41b1eae327a0140f4e59184db7a0d7f5b0f67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86196
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Idc15fe4049dc6669b9e25cd1a8fb187e10df2b6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86186
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
de-UNOise the Comment::finalizeImport method, so we can build
a better custom import code path, that does not touch all the stuff
that updating a running UI needs.
The primary improvements comes from using setPropertyValues
to set a bunch of props together.
This takes the opening time from 61s to 53s for me.
Change-Id: I5506a5a37a9b4b84b6930f0563a775a8aa0a9e2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85947
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
by avoid some of the EqualPatternSets memcmp cost by using a
hashcode, memcmp with lots of large and similar arrays ends up
blowing the L1/L2 cache
Takes the time from 64s to 59s for me.
Change-Id: I6961aa34f4e7457a70cb75a37dfae50d5f328589
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iab0c301096118203466dd91c724c25f1283a0488
Reviewed-on: https://gerrit.libreoffice.org/85392
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I7e212a36898e71b03db88053647bfeee12a49cb5
Reviewed-on: https://gerrit.libreoffice.org/85690
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
these are duplicated in sfx2/sfxsids.hrc, with no easy way to
de-duplicate them without making stuff much harder to understand, so
wrap them in conditional defines
Change-Id: I83f53a224e83ba808acc03e116dd416a4291d77b
Reviewed-on: https://gerrit.libreoffice.org/85557
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
duplicates in same file
Change-Id: I3f700bf3d7641f544f007a2a662a414a579156e4
Reviewed-on: https://gerrit.libreoffice.org/85559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...after 113444f59dc7690850919155b9b164b1a686bbe7 "sc: rowcol: tdf#50916 create
ScSheetLimits to hold by rtl::Reference", due to the MSVC rules of emitting
definitions of implicit member functions of dllexport classes:
> In file included from sc/source/ui/condformat/condformathelper.cxx:14:
> In file included from sc/inc\conditio.hxx:30:
> In file included from sc/inc/tokenarray.hxx:24:
> include\rtl/ref.hxx(74,20): error: member access into incomplete type 'ScSheetLimits'
> m_pBody->acquire();
> ^
> sc/inc/tokenarray.hxx(69,5): note: in instantiation of member function 'rtl::Reference<ScSheetLimits>::Reference' requested here
> ScTokenArray( const ScTokenArray& ) = default;
> ^
> sc/inc/tokenarray.hxx(47,8): note: forward declaration of 'ScSheetLimits'
> struct ScSheetLimits;
> ^
Change-Id: I4e79340f52e92b88c43fa5b78aa69ed49b367705
Reviewed-on: https://gerrit.libreoffice.org/85260
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
with this patch I can finally load a 3201 column document
Change-Id: I880d485b3f628836e7aed92c276e660466a3b19c
Reviewed-on: https://gerrit.libreoffice.org/85139
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which means we end up passing around ScDocument*
__everywhere__
Change-Id: I44d235ca5e9d57519f068b6880ee7d66f3ceb529
Reviewed-on: https://gerrit.libreoffice.org/83548
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
ScTokenArray sometimes outlives the ScDocument that created it, which
means it accesses dead data when it tries to validate columns and rows.
So create the ScSheetLimits class, which ScTokenArray can hold by
reference counted pointer.
Change-Id: Ic5771734fe4962d12f024fc1b29232124c14208a
Reviewed-on: https://gerrit.libreoffice.org/85117
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: Id328ee85b852eddf755876d2cde9ef75b40cfca1
Reviewed-on: https://gerrit.libreoffice.org/85090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifa99d1c8d593e2a5dd81a3aaf4cd702d3ba96b89
Reviewed-on: https://gerrit.libreoffice.org/85060
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and can then remove some casting
Change-Id: Id821c32ca2cbcdb7f57ef7a5fa1960042e630ffc
Reviewed-on: https://gerrit.libreoffice.org/85022
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...which would contain copies of AutoCalcSwitch and ScBulkBroadcast that both do
things in their dtors. std::sort (into which BroadcastRecalcOnRefMoveHandler is
passed as function object argument) returns its function object argument, which
caused the BroadcastRecalcOnRefMoveHandler copies.
Better split the RAII part that holds AutoCalcSwitch and ScBulkBroadcast and
does things in their dtors into a BroadcastRecalcOnRefMoveGuard class of its
own. (And while at it, explicitly delete the copy/move functions of
AutoCalcSwitch and ScBulkBroadcast to avoid such issues in the future.)
(The RAII part of BroadcastRecalcOnRefMoveHandler had been added with
60d0b992ea3a910be79ae4a8e8b0bb32a358b18a "sc-perf: tdf#87101 add bulk scope for
BroadcastRecalcOnRefMove() calls". The issue was found with Clang 10 trunk
-Wdeprecated-copy-dtor.)
Change-Id: I45d6b81e7c8b34aed57b6f66c5e1e966a43a565d
Reviewed-on: https://gerrit.libreoffice.org/85063
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
needed to create a fake ScDocument for the external ref manager, since
it has no ScDocument at all
Change-Id: Ia786ac291133e3c438694e81ecfb2590729a853d
Reviewed-on: https://gerrit.libreoffice.org/85050
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...which silences various -Wdeprecated-copy-dtor warnings from Clang 10 trunk
about copy functions being implicitly defined as non-deleted even though the
class has a user-declared dtor
Change-Id: I3409d403c3c709de4ad94eccbc2d7869e41847cc
Reviewed-on: https://gerrit.libreoffice.org/85032
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...by explicitly defaulting the copy/move functions in cases where the user-
provided dtor is trivial (so could theoretically be replaced with an implicit
one, cf. <https://gerrit.libreoffice.org/#/c/85032/> "Remove some redundant
user-provided dtors") but is probably defined out-of-class because the class is
DLLPUBLIC
Change-Id: Iff5e86654b10c7a03333c06312dc5dfce925d947
Reviewed-on: https://gerrit.libreoffice.org/85041
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia9865271cf0a75ebf4b885ff376f7d0a152b2555
Reviewed-on: https://gerrit.libreoffice.org/84925
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia5d50e8be174869439400e0cd7d02d54429c7433
Reviewed-on: https://gerrit.libreoffice.org/85021
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...as seen after 331cafb1484597544bd94fa3f0e0a45b3328a4d8 "Related: tdf#129300
add ScLineBreakCell to provide a description" during CppunitTest_sc_ucalc:
> sc/inc/patattr.hxx:76:14: runtime error: downcast of address 0x60200056aaf0 which does not point to an object of type 'const ScShrinkToFitCell'
> 0x60200056aaf0: note: object is of type 'ScVerticalStackCell'
> 6f 00 00 60 70 7b f7 16 b0 7f 00 00 ff ff ff ff 86 00 02 00 02 00 00 00 ff ff ff 04 10 00 00 00
> ^~~~~~~~~~~~~~~~~~~~~~~
> vptr for 'ScVerticalStackCell'
> #0 in ScShrinkToFitCell const& ScPatternAttr::GetItem<ScShrinkToFitCell>(TypedWhichId<ScShrinkToFitCell>, SfxItemSet const&, SfxItemSet const*) at sc/inc/patattr.hxx:76:14
> #1 in ScPatternAttr::GetCellOrientation(SfxItemSet const&, SfxItemSet const*) at sc/source/core/data/patattr.cxx:152:9
> #2 in ScPatternAttr::GetCellOrientation(SfxItemSet const*) const at sc/source/core/data/patattr.cxx:170:12
> #3 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, unsigned short, int) at sc/source/core/data/column2.cxx:809:43
> #4 in (anonymous namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:92:17
> #5 in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:466:5
> #6 in ScDocument::SetOptimalHeight(sc::RowHeightContext&, int, int, short) at sc/source/core/data/document.cxx:4274:18
> #7 in ScDocFunc::AdjustRowHeight(ScRange const&, bool) at sc/source/ui/docshell/docfunc.cxx:156:26
> #8 in ScDocFunc::InsertCells(ScRange const&, ScMarkData const*, InsCellCmd, bool, bool, bool) at sc/source/ui/docshell/docfunc.cxx:2146:25
> #9 in Test::testFormulaRefUpdateInsertRows() at sc/qa/unit/ucalc_formula.cxx:2247:11
Change-Id: I12b95a8229bac8d67d85f2a5a90a5e2e286a6981
Reviewed-on: https://gerrit.libreoffice.org/84996
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ieb1a12f35cf8974c557c6e52eac0cd9fb7f80914
Reviewed-on: https://gerrit.libreoffice.org/84945
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If00a50a36cf2bb5c9b775a4ca1000af5c5be7bf4
Reviewed-on: https://gerrit.libreoffice.org/84892
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ief739616163c68e0e30d6287fdac90c1bcc9d13f
Reviewed-on: https://gerrit.libreoffice.org/84879
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
just default the params for now
Change-Id: I13ee78aeaa1133a167d57520b334d5e644e28ece
Reviewed-on: https://gerrit.libreoffice.org/84926
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8ed99f19ff6f4751c0867147fc1a60ac917f083b
Reviewed-on: https://gerrit.libreoffice.org/84876
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I628562f1013825e5ba3c0daaf5ee6b098616b6d0
Reviewed-on: https://gerrit.libreoffice.org/84866
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
by inheriting from SdrAngleItem
Change-Id: Ifcaf46b12d685e683984e15ba2264c191c0d1e5f
Reviewed-on: https://gerrit.libreoffice.org/84847
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
so its clear that it is not an override of baseclass EditEngine::SetText
Change-Id: I85ee9c9b212fe9248fb7e5fcb1ec83679ffb633d
Reviewed-on: https://gerrit.libreoffice.org/84553
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Mark some stuff SAL_DLLPUBLIC_RTTI in
include/vcl/metaact.hxx
in order to make ASAN happy.
Change-Id: I97febe0968bf58b9cbe60ce647f0ada25e6f4bb0
Reviewed-on: https://gerrit.libreoffice.org/84202
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|