Age | Commit message (Collapse) | Author |
|
|
|
|
|
SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones. To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.
|
|
We always need to remove the index map when removing a name.
|
|
When inserting a new named range, it should overwrite any existing
name if one exists. That was the old behavior in 3.3 prior to my
range name rework, and because of ptr_map not overwriting existing
key, that behavior had changed unintentionally.
Let's revert to the old behavior.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also, removed unnecessary reloading of the whole table data when
reference is updated.
|
|
For efficiency reasons. Otherwise, refreshing n tables individually
would require reloading the same data cache n times.
|
|
With this change, ScDPCacheTable should never clear pointer to the
data cache instance; it should keep the same data cache instance that
it is instantiated with.
|
|
|
|
|
|
|
|
When the internal data source range gets modified, we should also
update the affected range keys that are used to look up pivot caches.
Otherwise we'll end up creating a brand new cache, without removing
the old one that's no longer referenced.
|
|
...at least in ~ScAutoFormatObj it appears unnecessary and can lead to
crashes during Desktop::DeregisterServices (when ScGlobal::ppRscString
is already null and ScAutoFormat ctor calls ScGlobal::GetRscString).
Therefore split GetAutoFormat in two, GetOrCreateAutoFormat for cases
that probably need a non-null return and GetAutoFormat for those that
are OK with a null return.
|
|
|
|
Regression from 3.4.5.
|
|
Our 32bit builds have problems to generate more sheets and crash with a
std::bad_alloc
Increase this limit again as soon as we can handle std::bad_alloc
|
|
Otherwise it gets confused with normal arrow objects during re-
positioning.
|
|
|
|
|
|
Cell-anchored circular drawing objects would get distorted whenever
its bounding rectangle changes, either via insertion / removal of
columns / rows, or changing the row height / column width.
This commit fixes it by differentiating the validation circles, which
needs its own re-calc algorithm, from the normal circular drawing
objects.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Doing it this way avoids having to re-generate the data ranges in
Calc A1 before passing it to the chart backend in Calc. We need this
in order to remove the silly restriction that forces us to always pass
data range strings in Calc A1 format, which is error-prone.
This is also necessary in order to fix the bug that prevents editing
data ranges of an existing chart when the formula syntax is something
other than Calc A1.
|
|
|
|
|
|
|
|
|
|
When checking for svSingleRef or svDoubleRef, also check for
svExternalSingleRef or svExternalDoubleRef. Otherwise the dummy reference is
treated.
|
|
we now behave nearly the same way as excel does
|
|
|
|
support copying from an unsaved document and some improvements
still problems with MoveTab and missing dialog box if we have external
refs to unsaved docs while we save
|
|
Copying absolute sheet references between different documents now transforms absolute sheet
references into external references if the refered range is not copied.
Working:
References to already saved documents work already with:
-only transform reference into an external reference if range is not in
the copied range
-don't transform relative references
Missing:
handling for copying from not yet saved files
idea:
- add handling of external references to open documents that are not yet
saved through the temporary document name
- transform the url to the correct file url as soon as the source document is
saved
- if target document is saved first show warning message to the user and
save with temporary name as file url
|
|
|
|
Some parameters don't work with external references, however, such
as PROTECT, PREFIX and WIDTH.
|
|
For cell-anchored drawing objects. Failing to do so would result in
either one of
1) write error during file save,
2) drawing object disappearing upon reload, or
3) drawing object relocated to a wrong sheet, with wrong position
and size upon reload.
|
|
|