summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2017-08-14Removing unused SetVersionMap from scVarun Dhall
Change-Id: I16e4a80b721e8f419352ed2d546bd3d7197ed4f7 Reviewed-on: https://gerrit.libreoffice.org/41101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-13external data: reenable the test and adapt to new interfacesMarkus Mohrhard
Change-Id: I2d82b560e0bd499eb85c6ce22f5969f82dfe8937
2017-08-12external data: introduce a deterministic mode for the testsMarkus Mohrhard
Change-Id: I5804800216bd7d22b89a4e54d3f46cc3520f7c42 Reviewed-on: https://gerrit.libreoffice.org/41091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-11Add a unit test to be used to test parallelised calculations in CalcTor Lillqvist
Currently only tests SUMIFS. Yes, it would be nice if some of the already existing unit tests would work for this need, too. But there are various reasons wny not. Also, don't want to interfere in ongoing work by others. Change-Id: Ie9008a4a1a8c26eff4f2ab0bc91294b2239f0ae1
2017-08-11convert std::map::insert to std::map::emplace IINoel Grandin
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-10tdf#111318: Improve msg about pivot table/chart when removing a cell (take 2)Julien Nabet
Change-Id: I56e0fb1716d38471682084569d48907520922b26 Reviewed-on: https://gerrit.libreoffice.org/40991 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-10tdf#107797 UpdateAutoFilter handle more entriesTamas Bunth
Prepare UpdateAutoFilterFromMenu to handle more entries. Filter items can be hold by more than one entries. In that case we have to remove all the old entries before updating. E.g. setting AutoFilter from vba script results in more than one entries. Change-Id: I4f18f26281d0b8e689cd331f9a66f4c344fb6c6b Reviewed-on: https://gerrit.libreoffice.org/40967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-08-10Revert "tdf#111318: Improve message about pivot table/chart when removing a ↵Julien Nabet
cell" This reverts commit fac539889e32e5e47ca6b6da0a588abbe4cbe066. Change-Id: I1496f13119936e7be24345bc6f56469ce40b6080 Reviewed-on: https://gerrit.libreoffice.org/40990 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-10external data: move the copying to the document to ScDBDataManagerMarkus Mohrhard
Change-Id: Ic97dcc6418176630ceb50c0c6010c848f2302b59 Reviewed-on: https://gerrit.libreoffice.org/40958 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-10Add UI for the sc::dataproviderJaskaran Singh
Change-Id: I29acc8903d5694e46e7575133ee852bbaae6eeee Reviewed-on: https://gerrit.libreoffice.org/40851 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-09Removing unused SfxItemPool serialisation from scVarun Dhall
Change-Id: Ib8686d06f8cd477ff4fce948b0ac9c3fe463b129 Reviewed-on: https://gerrit.libreoffice.org/40901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-08tdf#111318: Improve message about pivot table/chart when removing a cellJulien Nabet
Change-Id: Ib27c20a7528c0376474586c7224eb9e4611147ce Reviewed-on: https://gerrit.libreoffice.org/40897 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-08loplugin:constantparamNoel Grandin
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07oovbaapi: screenUpdating, do not adjust heightTamas Bunth
Do not adjust row height if screenUpdating false, because it consumes significant time. Also change IsAdjustHeightEnabled boolean to a counter so it can be used several times in an overlapping manner too. Change-Id: Ie5c894481f3c1b4e07175164aac8303e504779ce Reviewed-on: https://gerrit.libreoffice.org/40443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-08-04Add debug output operator<< for ScQueryParam and its base classesTor Lillqvist
2017-08-04Add debug output operator<< for ScAddressTor Lillqvist
2017-08-03rename ID_FUNCTION_GRP_FINANZ->ID_FUNCTION_GRP_FINANCIALNoel Grandin
Change-Id: I9401c198d622542e8ae85a9b4bf004b3ddcac051 Reviewed-on: https://gerrit.libreoffice.org/40708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-01move resmgr to unotoolsCaolán McNamara
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01Bin default value for a bool parameter that was defaulted in only one placeTor Lillqvist
Change-Id: Ie5d4339639a034c4be991c9302576a116866b085
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31add initial file format representation for data import featureMarkus Mohrhard
Change-Id: I51143ecfe4eb1584f13bd1590f927743de8fa91e Reviewed-on: https://gerrit.libreoffice.org/40572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-27add test for update address code, related tdf#107289Markus Mohrhard
Change-Id: I955cf49fe5fa47fb38d2c8dacf4aadc8e3f7d651 Reviewed-on: https://gerrit.libreoffice.org/39317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-27lok: sc: copy / paste confusion -- workaroundMarco Cecchetti
Problem: 1. (a) copied April 2. (a) pasted -> April 3. (b) copied March 4. (a) pasted -> March [should have been April] where (a), (b) are different views Solution: A real solution would require to have one clipboard per view. This patch is only a workaround, which doesn't allow to paste content which has been copied in a different view; it takes also care to disable the "Paste" entry in the context menu. Change-Id: I3254f130af106299b0b519884a4ca03db08fc4c8 Reviewed-on: https://gerrit.libreoffice.org/40459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-26loplugin:unusedmethodsNoel Grandin
Change-Id: I7f26ee112ed89ee3e69c56930260565f66ff145b Reviewed-on: https://gerrit.libreoffice.org/40442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26tdf#99634 Change equal sign tooltip to 'Formula'Yousuf Philips
Change-Id: Ic1bedf1c6ca7fb2a5346aede6c12a6dab372d189 Reviewed-on: https://gerrit.libreoffice.org/40431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-25loplugin:unusedfields in scNoel Grandin
The *chart* fields in ScTabViewShell in sc/source/ui/inc/tabvwsh.hxx are unused since: commit 5021f298418f6efa7bb7b6540113b712599778fe Author: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Date: Mon Jul 28 12:11:08 2014 -0300 Remove some unused code The bEveryoneButMe field in ScChangeViewSettings is unused since commit 90e8ad7ab779740c7381d26ffe7d08acc3a9ff96 Author: Noel Grandin <noel@peralex.com> Date: Tue Jul 21 15:39:17 2015 +0200 loplugin:unusedmethods scripting,sc Change-Id: Ie9fbdf8f5e9177449316aaeb40ca3bd26df78a95 Reviewed-on: https://gerrit.libreoffice.org/40264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25tdf#107135 Add missing ODFF function FINDB.Winfried Donkers
Change-Id: I96bbca8e6d91448fbb27fe95a57ce62a78d1b2c5 Reviewed-on: https://gerrit.libreoffice.org/40242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-24SdrGlobalData::aUserMakeObjUserDataHdl is unusedNoel Grandin
ever since commit ddb1d5ebf0a81888001ffa1dbab883df70cdc279 Author: Felix Zhang <fezhang@suse.com> Date: Fri Nov 18 18:23:52 2011 +0800 remove unused Sdr methods removed the SdrObjFactory::MakeNewObjUserData method Change-Id: I95c167b2f20b436bcc0085b6b616406ac210045f Reviewed-on: https://gerrit.libreoffice.org/40363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22avoid unnecessary calls of AdjustRowHeightTamas Bunth
Change-Id: I2d164f69a7313d69f3fe5cabe1e3cc39aeba4d32 Reviewed-on: https://gerrit.libreoffice.org/40272 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-07-21de-hrc various thingsCaolán McNamara
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21migrate to boost::gettextCaolán McNamara
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-20Avoid unnecessary calls of AdjustRowHeightTamas Bunth
Check if attribute changed during ApplyAttributes. If it did not change, it is unnecessary to recalculate cell size, repaint etc. Change-Id: Ic3a3fa24efa9ad3619b8979a67e972a7635311cc Reviewed-on: https://gerrit.libreoffice.org/40198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-07-17extend loplugin useuniqueptr to OUString pointersNoel Grandin
Change-Id: Ieb5bab3895e1edaff497c4a1a88303ccac097edc Reviewed-on: https://gerrit.libreoffice.org/39948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-15emfplus: create a wmf/emf/emf+ primitive based importerArmin Le Grand
First steps to organize an importer that can read/interpret wmf/emf/emf+ and deliver a primitive representation for the content by parsing it. Use the same mechanisms as already applied for Svg, so to reuse abilities to keep original binary data to allow save again and embedding in files and have an implemented replacement bitmap based representation. For this, unify the used helper classes to handle more than just Svg. For 1st try, add test code and static bool switches Change-Id: I6e0a82943541d811a8f8d65a84115569fcd8cee7
2017-07-14extend loplugin useuniqueptr to POD typesNoel Grandin
Change-Id: I6ff24f048bd8f75bf87a78b718f37b57855d4781 Reviewed-on: https://gerrit.libreoffice.org/39932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-13loplugin:useuniqueptr in scNoel Grandin
Change-Id: I004e1f0292c8a40515880546574255ab835dbdbe Reviewed-on: https://gerrit.libreoffice.org/39875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10tdf#107135, add missing ODFF function REPLACEB.Winfried Donkers
Change-Id: I8d782b109eb390838b6c4f3a85e9b344ecef87ec Reviewed-on: https://gerrit.libreoffice.org/39606 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-07C++11 remove std::binary_function bases from functorsJochen Nitschke
std::binary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::binary_function base class was used by deprecated std::bind2nd, this was solved in individual commits. The members first_argument_type and second_argument_type were used in chart2/source/controller/dialogs/DataBrowserModel.cxx: DataBrowserModel::implColumnLess and are inlined in this commit. Change-Id: I60ded60a8d4afd59e15ac15a58e18d2498c9be5a Reviewed-on: https://gerrit.libreoffice.org/39659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06loplugin:unusedfields in scNoel Grandin
found a couple more by running make build-nocheck to exclude testing code Also, teach unusedfields loplugin about operator<<, since referring to a field in an ostream operator<< does not indicate a real use, it's normally for debugging Change-Id: I3dce22bf5afda2fd09e01de9bf1d0ef85e535aa8 Reviewed-on: https://gerrit.libreoffice.org/39625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06rework as a shared_ptrCaolán McNamara
mostly to try and track down a crash on exit of sw uwriter under windows Change-Id: Id67e93863056da319dd8225038d60a7f5783b103 Reviewed-on: https://gerrit.libreoffice.org/39604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-05Init CellInfo::bMerged againEike Rathke
Fallout from commit 9f4421039a40f385489cb2f3ad8a1b02fb32251c Date: Wed Jun 21 16:15:42 2017 +0200 loplugin:unusedfields in sc part3 that (luckily) led to massive warn:legacy.osl:26775:1:sc/source/core/data/document.cxx:4677: Attribut Null warn:legacy.tools:26775:1:svx/source/dialog/framelinkarray.cxx:621: svx::frame::Array::SetMergedRange - invalid cell ind ex warn:legacy.tools:26775:1:svx/source/dialog/framelinkarray.cxx:344: svx::frame::MergedCellIterator::MergedCellIterator - not in merged range output. Change-Id: Idd9c581490249efb4198b4f09db5dbef331f2b1c
2017-07-05Revert "With ScFormatFilterMissing gone we don't need ScFormatFilterPluginImpl"Stephan Bergmann
This reverts commit cc0524a724d0a9b9516ce9eaf499d845165863f8, which broke UBSan's -fsanitize=vptr, where Library_sc needs the RTTI typeinfo symbol for ScFormatFilterPlugin, but that would now only be emitted in Library_scfilt, together with the first non-pure, non-inline virtual function, and Library_sc cannot link against Library_scfilt (which already links against Library_sc).
2017-07-04Move definition of VAR_ARGS and PAIRED_VAR_ARGS to formula/funcvarargs.hEike Rathke
... to have it at one central place instead of two. And add comments why changing the value is not just easily done. Change-Id: I266ea55c79c02a653a0704c33f9fa712bbcd104e
2017-07-04loplugin:unusedfields in sc part3Noel Grandin
Change-Id: I7323e8644e5d336d52fa21b063264b0847b5e780 Reviewed-on: https://gerrit.libreoffice.org/39064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-03Translate German comments and debug strings (leftovers in dirs sal to sc)Johnny_M
Translates leftovers found using a custom regex and manually checking the rest of the affected file. Additionally: - A few spelling fixes Change-Id: I2b83bd11adf520b90bb29c8ea624990759dad3c6 Reviewed-on: https://gerrit.libreoffice.org/39427 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-02ScRange::ParseCols/Rows pDoc parameter is unusedStephan Bergmann
...ever since the code's introduction with f4e75ed9b00a4d8410fe685aae66735ec82837ec "INTEGRATION: CWS scr1c1", despite the "we may need this later" claim that also originated there Change-Id: I88e2b2a8d01fda8adf942ff78f84b6d8638dc154
2017-06-30With ScFormatFilterMissing gone we don't need ScFormatFilterPluginImplTor Lillqvist
Change-Id: I01288c953dd02707d017bfba95459b83254ef963 Reviewed-on: https://gerrit.libreoffice.org/39422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-06-29ScTable::VisibleDataCellIterator::ROW_NOT_FOUND can be constexpr and privateTor Lillqvist
Change-Id: Iee866c10dad9e401b5c507849efa11d877177357
2017-06-29ScRowBreakIterator::NOT_FOUND can be constexprTor Lillqvist
Change-Id: I33310e400ba8cdb15669704d96de8a3dbbe43be1 Reviewed-on: https://gerrit.libreoffice.org/39386 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-03 03:08:01 +0000