summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2022-08-11fix tsan data-raceNoel Grandin
this check is not necessary, we are using a 32/64 bit counter (depending on platform) for some years now WARNING: ThreadSanitizer: data race (pid=90197) Atomic write of size 4 at 0x7b08002f474c by thread T90: #0 ScInterpreter::Interpret() interpr4.cxx:? (libsclo.so+0xb99c26) #1 ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) ??:? (libsclo.so+0x95bfeb) #2 ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned long, unsigned long, unsigned int, unsigned int) column2.cxx:? (libsclo.so+0x754eea) #3 ScTable::CalculateInColumnInThread(ScInterpreterContext&, short, short, int, int, unsigned int, unsigned int) table1.cxx:? (libsclo.so+0x9e692b) #4 ScDocument::CalculateInColumnInThread(ScInterpreterContext&, ScRange const&, unsigned int, unsigned int) documen8.cxx:? (libsclo.so+0x83479f) #5 ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, bool&, bool&, int, int)::Executor::doWork() formulacell.cxx:? (libsclo.so+0x96b5e1) #6 comphelper::ThreadPool::ThreadWorker::execute() threadpool.cxx:? (libcomphelper.so+0x1cb0a1) #7 non-virtual thunk to salhelper::Thread::run() ??:? (libuno_salhelpergcc3.so.3+0x67f7) #8 threadFunc thread.cxx:? (libuno_salhelpergcc3.so.3+0x6aae) #9 osl_thread_start_Impl(void*) thread.cxx:? (libuno_sal.so.3+0x86245) Previous read of size 4 at 0x7b08002f474c by thread T89: #0 ScFormulaResult::SetToken(formula::FormulaToken const*) formularesult.cxx:? (libsclo.so+0xb0e11f) #1 ScFormulaResult::Assign(ScFormulaResult const&) formularesult.cxx:? (libsclo.so+0xb0e837) #2 ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) ??:? (libsclo.so+0x95caa3) #3 ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned long, unsigned long, unsigned int, unsigned int) column2.cxx:? (libsclo.so+0x754eea) #4 ScTable::CalculateInColumnInThread(ScInterpreterContext&, short, short, int, int, unsigned int, unsigned int) table1.cxx:? (libsclo.so+0x9e692b) #5 ScDocument::CalculateInColumnInThread(ScInterpreterContext&, ScRange const&, unsigned int, unsigned int) documen8.cxx:? (libsclo.so+0x83479f) #6 ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, bool&, bool&, int, int)::Executor::doWork() formulacell.cxx:? (libsclo.so+0x96b5e1) #7 comphelper::ThreadPool::ThreadWorker::execute() threadpool.cxx:? (libcomphelper.so+0x1cb0a1) #8 non-virtual thunk to salhelper::Thread::run() ??:? (libuno_salhelpergcc3.so.3+0x67f7) #9 threadFunc thread.cxx:? (libuno_salhelpergcc3.so.3+0x6aae) #10 osl_thread_start_Impl(void*) thread.cxx:? (libuno_sal.so.3+0x86245) Change-Id: I3e51db3a8a0a18fee1647657369ecebf5de108e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-09Use CharClass::uppercase() for AddIns' English UI names, tdf#135993 follow-upEike Rathke
... instead of OUString::toAsciiUpperCase(). English names should consist of ASCII alphanumeric only, but we don't know what an AddIn's author comes up with. Lookup in ScCompiler is done with CharClass as well. For this, use the static ScCompiler::GetCharClassEnglish() instance made public and guard creation with a mutex. Change-Id: Icb79d49d4c7339c8d01b141de2a34715d794dd92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138004 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-08-07clang-tidy modernize-pass-by-value in scNoel Grandin
Change-Id: Ia7ff651d1cbc119b36a9f8052594d03650988f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137848 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06Resolves: tdf#135993 Create ScFunctionList and ScFuncDesc with English namesEike Rathke
Used in Function Wizard and formula tooltips. Without, no matching name is found for AddIn English name and no tooltip/description/arguments are displayed. Change-Id: Ib0cf419c476dae495467c444f1ee1f84a55633a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137883 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-08-03Avoid multiple conversions to LanguageTag, specifically in loopsEike Rathke
Change-Id: I47a969d7476df32e0c9d525d416467c59358d9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137712 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-08-02Resolves: tdf#150203 Gather AddIn English names and provide for FunctionAccessEike Rathke
This works at least for the bundled AddIns from scaddins/. It may for others if en-US compatibility function names are provided, if not the local name will be continued to be used. Change-Id: I09e23f731c0f3d9753ef355ab59c2005bc567464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137708 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-30sc: allow undo of typing in 2 views independent from each otherNoel Grandin
This commit follows the same pattern as commit c72e500ccaf0ce2261c5233b80fba9342778f810 sw: allow undo of typing in 2 views independent from each other with some changes since calc and writer have different undo/redo infrastructure on top of SfxUndoManager. Change-Id: Ib6e7e21caccb94752c01c529b5013553dba8b4f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-27Unnecessary to remember mbFiltering at column, tdf#140968 tdf#140978 follow-upEike Rathke
It's inviting confusion and only needed for FilterEntriesHandler, so pass it there. Change-Id: I8056bf8e8f563b28358c46b19071e7caa69c88a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137513 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-27FilteredRow is not a property of the column, tdf#117276 follow-upEike Rathke
It's only needed in the FilterEntriesHandler, so pass it there. Change-Id: I5554ad13a43ccce6aafbba82b33418f060173a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137512 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-27Name FilteredRow what it is, not hidden; tdf#117276 follow-upEike Rathke
Also avoid defaulted parameter, it's only one more place to change. Change-Id: I64468fcd7085eff7a49bd0c359fdf14a31058af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137511 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-25use more o3tl::spanNoel Grandin
which means we can reserve precisely the right number of entries when building maps Change-Id: I580414699289369de4730caae09829bbd8759e82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137292 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-22tdf#117276 sc: Show hidden filter elements as inactive elementsBalazs Varga
Showing hidden values in the autofilter dropdown (as inactive when it was hidden by another row) - without changing the behaviour of autofilter. First those which belongs to non-hidden rows, then those which belongs to hidden rows. TODO: maybe we can add a global option where the user can switch on/off this feature. Change-Id: Iafeb43176efe7ab422b22697d399c68c95d0319d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136595 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-07-20move wintypes.hxx from tools to vclChris Sherlock
Change-Id: Ief9949fd4252de9e33df172af07aa7ed097b5520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136560 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-15tdf#148248 Text Color -> Font Color in AutoFilter/Standard FilterGabor Kelemen
Consistently with other places such as Formatting toolbar and Format Cells -> Font Effects tab page Change-Id: I7ec5733f01182b25b5d823a43a3639b21ee874e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137087 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2022-07-13basegfx: zoomIn() and zoomOut() should be sal_uInt16Chris Sherlock
All zoom functions use sal_uInt16 values. For some reason, basegfx used long when zoomIn and zoomOut were created in 2012 (see commit 315d2ddc16: "optimized zoom to use more common intervals"), this then got mass converted to tools::Long in commit 387a88fa25: "use tools::Long in basegfx..chart2". So fix is to change zoomIn/Out() to use sal_uInt16. Change-Id: I2a56d6f58e14f77aeb8741d332fe9bc282eb969f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135715 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-07-12elide some dynamic_castNoel Grandin
Change-Id: I32c804e64cf219364e27ad6d9549c68c1f737a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-06opencl: no need for unhelpful nullptr OUString * case.Michael Meeks
Change-Id: I0b3cad2247706901e1a6b9c3df7fbbc9f23ff987 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136816 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-05Related tdf#137145 tdf#137569 Capitalization + punctuation fixesAdolfo Jayme Barrientos
Change-Id: Icd8a631da83c86333c7e5bcee0069165899d3041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136822 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-06-27cid#1506511 silence Uncaught exceptionCaolán McNamara
and cid#1506512 Uncaught exception cid#1506513 Uncaught exception Change-Id: I964430a69ce4d4beb7f7a551d3ac454c8122a3fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136503 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-26fix ByValue lookups with ScSortedRangeCacheLuboš Luňák
My fix for tdf#149071 actually disabled the optimization for all ByValue lookups, because in fact all such lookups have maString set. So lookups where the cells are a mix of numeric and string values need different handling. A simple solution is detecting such a mix when collecting the values for ScSortedRangeCache and disabling the optimization in such a case. But it turns out that queries containing such a mix are not that rare, as documents may e.g. do COUNTIF($C:$C) where the given column has numeric values that start with a textual header. So bail out only if the string cell actually could affect the numeric query. Also fix ScSortedRangeCache usage depending on query parameters, different instances are needed for e.g. different ScQueryOp, because the ScQueryEvaluator functions may return different results (isQueryByString() is automatically true for SC_EQUAL). Change-Id: Ib4565cbf6194e7c525c4d10d00b1c31707952a79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136403 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-26more efficient recalculations from xlsx import of pivot tablesLuboš Luňák
The import of pivot tables in xlsx triggers recalculations, even though it's not necessary. Fixing that properly seems complex given how ScDPObject is designed, so at least ensure the calculation is efficient (formula grouping is otherwise done only after pivot table import). This can especially noticeable for formulas where groups make a big difference (e.g. COUNTIFS uses ScSortedRangeCache only for formula groups). Change-Id: I8dbdf854880707a9707cdc9dc3d73fc1d6b6b000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136362 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-25tdf#149647 LibreOffice Calc cursor not positioned correctlyNoel Grandin
Revert the offending commit commit feec8e3c34e08b621098a17f1011dccd0b4f7f4c reduce iteration in ScViewData::GetScrPos Change-Id: Id1df2bf7f87e6b800b40871c1472ed466b7eb6a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-23no need to explicitly spell out bodies of default functionsLuboš Luňák
Change-Id: I7ed48c3f1005a0efe42d5378ed25e57ae63dd712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136346 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-20use std::monostate in std::variantNoel Grandin
as suggest by llunak Change-Id: Id22253198bff16eeb596e1a15ddaba1f6ac227d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-18clean up Sc*CellValueNoel Grandin
after my recent commits (*) make more fields private (*) rename fields (remove suffix "1") now that I am sure I got everything. Change-Id: I0f8b9b1a534181c8b66532f9da5a0d16aa049cf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-18tdf#126109 calc slow when replacing string to numberNoel Grandin
Store SharedString inline in ScCellValue. Shaves 10% off time. Use std::variant to handle the complexities of correctly calling constructor and destructor of SharedString. Change-Id: I820de5339e31434fbdbde1a72e25abe207bf008d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-18create getter for ScCellValue::mpFormulaNoel Grandin
so we can assert that it has the correct tag type Change-Id: Iab13a6d6ea1783c69395f06f28732769e5fe8b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-17create getter for ScCellValue::mpEditTextNoel Grandin
so we can assert that it has the correct tag type Change-Id: I984c22ae2527d652f2d4194227dc1173793300c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-17create getter for ScCellValue::mpStringNoel Grandin
so we can assert that it has the correct tag type Change-Id: I8933919aefc2bb22694a283b54dc3de11d16e5a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16Resolves: tdf#147822 ScUnoListenerEntry container must be std::listEike Rathke
... instead of std::vector to not get invalidated iterators when the container is resized. Regression from commit f8defe59ff75df2b516ee407f1dac22b0ac72a19 CommitDate: Wed Sep 6 22:45:10 2017 +0200 Replace some lists by vectors in unoobj (sc) which was bad for this case. Change-Id: I8d3a001242865cadc82b359a3198906d26373a41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136007 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-16create getter for ScCellValue::mfValueNoel Grandin
so we can assert that has the correct tag type Change-Id: I0d626130cb014e19239e88a6988018c83d061f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16pass EditTextObject by unique_ptrNoel Grandin
to make the ownership passing obvious Change-Id: Icf4b94a422b91da3082fe1ce56eff149d390a649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16make meType in ScCellValue privateNoel Grandin
as a first step to wrapping up the internals of this class and adding some asserts Change-Id: Ic13ddd917948dbf3fd6d73f44b8efcc727726baf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135994 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16share ScSortedRangeCache between threadsLuboš Luňák
It's the same data for all threads, they access it as read-only, so it doesn't make sense for each thread to build its own copy. Change-Id: Ia1559c61d976bcce78661cae7e030bb8430aed7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135794 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-15tdf#126109 calc slow when replacing string to numberNoel Grandin
retain the column block iterator array during the process, shaves 20% off the time Change-Id: Id492cf142ecc34af6fd236135d87f49b5a630d5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-10loplugin:constantparamNoel Grandin
Change-Id: I8134744b6c1279c497d4763eddf614bb840f7f3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-07tdf#129674 Add GoTo Sheet commandLaurent BP
Insert command in menu Sheet > Navigate (alongs with To Previous/Next Sheet) Use .uno:JumpToTable command from Navigator Use its own Go To Sheet dialog Add a Search entry to type partial name of sheet Menu translation missing? Change-Id: I16b8b56a688c8396159617f04a2a7e034721ce31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134714 Tested-by: Jenkins Reviewed-by: Laurent Balland-Poirier <laurent.balland@mailo.fr>
2022-06-06ScSingleRefData::TabValid: for absolute reference take sheets into accountEike Rathke
Change-Id: I56e7e34f127345e2633b5bef07c2783ed8ffbbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135456 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-06Fix typosAndrea Gelmini
Change-Id: I36d81be6e591830ee3762a0d43357dbacd68ad93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135439 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-05restore %PRODUCTNAME to accessible descriptions that need themCaolán McNamara
The original problem was that %PRODUCTNAME wasn't replaced for accessibility descriptions (which are reused for extended tips) under gtk. Universally querying all a11y descs on load to potentially replace %PRODUCTNAME in a11y descs at runtime led to tdf146971 which was a huge startup slowdown. The half way 7.3 fix was to leave a11y descs alone, but do the replacement when querying for the extended tip case. So the extended tooltips were ok, but screen readers would still say a raw "%PRODUCTNAME" text, hence the rewording effort to remove %PRODUCTNAME from the a11y descs entirely for 7.4. But there is now a few cases where some options paths exists in the a11y descs which is not exactly correct wrt to the text shown in the options dialog. Reworking the options dialog to not have %PRODUCTNAME there at all and updating everything to fit that sort of change would not be popular. So move the cases where a11y descs really should have %PRODUCTNAME in them out of the .ui files and into .hrc files and use specific set_accessibility_description calls for them via ResID which will do the %PRODUCTNAME replacement automatically. Hopefully the a11y runtime cost for just this handful of cases is negligible in the overall scheme of things. Change-Id: Ieb17d26fd581cd5804a52b371b3bb5ea43023aa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-01pass ScRange around by valueNoel Grandin
it's a very small object, and trivially movable. No need to allocate it separately Change-Id: I0adf947433e73a425f39004297c450a93ac4e5f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30first arg of ApplyFrame is never nullLuboš Luňák
e4008dc0c3b43c9eacdd88511075be2b88 did this for ApplyBlockFrame() but didn't chagne ApplyFrame() which is only called from there. Change-Id: I9f1dce3dc7fda23b42e90432c13dfca0aa7f267e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135130 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-30no need to use unique_ptr for tokens in ScChartListenerNoel Grandin
since vector is a moveable type, and we always initialise this field Change-Id: Icd598ad942dcfbdf77c7c8eef9fa0b6b7c6fe1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-26WIP: dunno about "Hodler"Andrea Gelmini
Change-Id: I9fbee006237ccb70e31109023cf46b21aec325d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134668 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-22pass ScDocShell by reference in ctor to indicate never initially nullCaolán McNamara
Change-Id: I6b07f734aba06a643b6240562bb3e427e5c1e9ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21lok-calc: new callback for print rangesDennis Francis
With this callback the lok clients can read and draw the print ranges on each sheet of the Calc document. Conflicts: include/LibreOfficeKit/LibreOfficeKitEnums.h libreofficekit/source/gtk/lokdocview.cxx Change-Id: Ie19351d4420e0f3d4191f6a354ce99ab830aede2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134375 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit 172bc7a8f4eeab907adac077407186fbbd046a77) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134527 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> (cherry picked from commit 29b7b25d454e0a6cd07c00e13fdb83cc8a381583) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134614 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-05-20bump up Calc MAXTILEDROW to MAXROWLuboš Luňák
I.e. no restriction on number of rows for LOK. Change-Id: I248a70bafe18c68e59f604e33b9456474ab785c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134620 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-20Document sparkline related classes, functions and structsTomaž Vajngerl
No functional change. Change-Id: I822c6a9d270dc582aaae2900f833843a0d6f8ddc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134651 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-19don't allocate unnecessary columns when inserting a rowLuboš Luňák
Change-Id: I616ef20dc1295ce17c4877ff367815bb6a90b7a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134547 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-19ScTable::TestInsertRow() does not need to allocate all columnsLuboš Luňák
Change-Id: Ic213997edf6838282a38e444a638713a72397fb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134545 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>