summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2023-07-25follow tdf#154131 Treat also HMTL importLaurent Balland
Add Detect numbers in scientific notation option to HTML paste Still need some qa tests Change-Id: I553404a01ab2a61566b861b3c01d14bdc0c46668 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152591 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-07-25tdf#93315 sc: Only 84 empty row show in the Print PreviewCzeber László Ádám
Change in Calc behaviour, dropping the 84 line limit. This way, if all rows or columns are bordered, only up to the last cell containing data is displayed in the Print Preview. In other cases, all bordered cells are visible. Change-Id: I7d874a093d76d5ed92b1b63b645b97582d52629e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153256 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-07-13sc: remove duplicated table validity checks and other duplicationsTomaž Vajngerl
Remove the duplicated table validity checks and replace them with FetchTable(..) call, which returns nullptr if the table is not valid and available, or the table itself. This simpifies the code all around. When only the check if the table is available is needed, use HasTable(..) in those cases. The call TableExists(..) is identical to HasTable(..) and has been removed. Finally use GetTableCount(), which return a SCTAB type for the number of tables is used instead of static_cast<SCTAB>(maTabs.size()) that was used all over the code. Change-Id: Ibfd9777b1350ba8e0cbe577783db81589f95591c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154225 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-07-12sc: Theme color change undo/redo - styles and direct formatTomaž Vajngerl
This adds the code for undo/redo for change of theme colors in styles and direct formatting. Change-Id: I58568b18ab18562e6148ec8530d3d22c62ef2b95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154305 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-07-11tdf#123026 xlsx import: recalc optimal row height on importJustin Luth
This patch depends on the previous patch for this bug report, which allows each sheet to hold its own default row height. The given height for the row might not be enough to fit the content. If the row is set to use optimal height, that will be corrected as soon as the row is edited. Obviously, it should not require an edit to be correct on FILEOPEN, so this patch recalculates after loading the document. This might have a very negative effect on the time needed to open a file. I couldn't duplicate the XLS method because Library_scfilt.mk doesn't link to ScSizeDeviceProvider. The existing UpdateAllRowHeights wasn't designed to allow any performance improvements, so I made a new one. The new one is based on the newer ScDocRowHeightUpdater class - so perhaps the older method can be phased out. This new UpdateAllRowHeights could replace the XLS bSetRowHeights clause - with hopefully some performance benefit. I'm not sure I'm ready for the regression hate that would come from the inevitable performance implications. Testing however doesn't suggest a huge slowdown. I tested with time make sc.check before the fix I was getting 16m 4s +- 10s after the fix I was getting 16m 25s +- 10s Specific test showing the need for these patches: make CppunitTest_sc_subsequent_filters_test2 \ CPPUNIT_TEST_NAME=testTdf123026_optimalRowHeight Impacted unit tests (without the previous patch) are documented in earlier patchsets. make CppunitTest_sc_subsequent_export_test \ CPPUNIT_TEST_NAME=testMiscRowHeightExport make CppunitTest_sc_subsequent_export_test2 make CppunitTest_sc_jumbosheets_test CPPUNIT_TEST_NAME=testTdf134553 Change-Id: I6d020c1a5137dd4f05e20e82b1764a102b7f56d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140260 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-06ScAutoFontColorMode::Black is unusedNoel Grandin
since commit 3537cef02c25c2c2459d7900eed13eeec533b7ae Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Tue May 16 22:10:10 2023 +0900 sc: factor out color from setting vcl::Font from a ItemSet Change-Id: Ia8781d69ed4969eb9617c96c6991cc39ce162e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29loplugin:unusedmethodsNoel Grandin
Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29sc: use ComplexColor for font color (+others) in OOXML exportTomaž Vajngerl
Change-Id: I2544c7ece152323d84faafe1a544e4f89ca466d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152014 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27sc: import and prop. theme color support for cell bordersTomaž Vajngerl
Adds import for theme colors for cell borders and UNO properties for the cell border theme (complex) colors. Change-Id: I9d8dd7e71f74a623f916e19d59964058f43440bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153502 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27tdf#123026 sc xlsx: provide per-sheet optimal row height settingJustin Luth
This patch is a pre-requisite for a follow-up patch which will run SetOptimalRowHeight on all un-sized rows on FILEOPEN. XLSX sheets can provide a default height for all rows on that sheet. That imported/round-tripped well. However, if Calc optimizes these rows, the undefined rows likely will change height - since the default XLSX row height tends to be 300 twips, while Calc uses 256 (in ScGlobal::nStdRowHeight). This patch allows a sheet to define its optimal row height, so that running .uno:SetOptimalRowHeight doesn't change any row heights, and doesn't cause all kinds of new row definitions. make CppunitTest_sc_subsequent_filters_test2 \ CPPUNIT_TEST_NAME=testTdf123026_optimalRowHeight Change-Id: I35008107d71f66375c7e9469e559f3836cf14df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152909 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2023-06-26convert ScAutoFontColorMode to scoped enumNoel Grandin
Change-Id: Id34bac78719943bd4c4cbfa60e0cb86b4ca570f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-25sc: simplify and fix prop. mapping for cell BG and char theme colorTomaž Vajngerl
Change-Id: I461106200d37f0c605c07095c6b5871ea89e0e20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153501 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-23Speed up scrolling through large document with lots of patternsNoel Grandin
Cache visibility for use in ScPatternAttr::IsVisible Change-Id: Ia248a06b876b53115bbc3017d97538bbbc03830d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-22sc: factor out color from setting vcl::Font from a ItemSetTomaž Vajngerl
vcl::Font color parameter is deprecated so we need to handle the color separately from font data. This refactors GetFont into 2 separate functions - fillFontOnly and fillColor, where fillFont now does the same as previously GetFont function did. All GetFont calls have been changed depending on if we need only the font data or also color - where the color is now treated in a different call. There are a couple of calls where fillFont was used, because to change that needs a more complex refactoring. Change-Id: I0a2ce50a0cb28d196fcff87e1e80099a2bb60a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151858 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-21sc: add CharComplexColor and CellBackgroundComplexColor propertiesTomaž Vajngerl
Change-Id: I30153796a39b2aa3648cb107905974ed6f0f3851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151668 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-17Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)timeEike Rathke
Change-Id: I18567fdac512ee786ce4b0785b01b2ae6da7450e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153203 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-14online: speed up scrolling large excel documentNoel Grandin
the expensive part is the GetTiledRenderingArea(), so lets only do that once, instead of twice Change-Id: I2d18bce1ff116d6d711f0908502963c9743dea8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-09tdf#153437 sc: fix broken formatting without performance regressionCzeber László Ádám
Follow-up to commit 7be7e1ff95af485a9cb00748800d3d084f96387c "tdf#153437 sc: fix broken formatting at Undo of row/column insertion" by replacing that with a better version without performance regression. This keeps the original performance fix of commit 2e86718626a07e1656661df3ad69a64848bf4614 "don't allocate unnecessary columns when inserting a row" related to the support of 16k columns. The previous fix used extra memory to fix the broken formatting of the cells. I have now solved the error in tdf#153437 without taking extra memory. It doesn't change the reserved cells, it just deletes a row from the default attribute of the cells when deleting rows, so they don't slip. When deleting a column, the last column in the still reserved area loses its formatting. I copied the default value back here, as the other columns have this value. Change-Id: I35da1cb79ff4e3493e91d29766cc2b81412080eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152742 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-07tdf#155376 partially convert SvCTLOptions to officecfgNoel Grandin
When accessibility is enabled, Calc will add tens of thousands of listeners. We then spend a significant chunk of time creating SvCTLOptions objects (attached to ImpEditEngine) and adding and removing those objects from the related listener lists. But the required information is already globally cached by the officecfg module, so we can avoid that overhead and just fetch it directly from officecfg. Change-Id: I7ff55fd7c4926866eb7086812275ba8bd6e84c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152645 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-07Avoid signed integer overflowStephan Bergmann
For whatever reason e5fe8434110c1299527a0d03bf450e1b6d08ca57 "use a SIMD friendly hashcode for ScPatternAttr" had changed ScPatternAttr::mxHashCode from sizt_t to sal_Int32, better use unsigned sal_uInt32 to avoid > /sc/source/core/data/patattr.cxx:1444:17: runtime error: signed integer overflow: 31 * 887503681 cannot be represented in type 'int' during e.g. CppunitTest_chart2_geometry (<https://ci.libreoffice.org//job/lo_ubsan/2802/>) Change-Id: Ia561b245431d812f43586013477208426aa1cc11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-06use a SIMD friendly hashcode for ScPatternAttrNoel Grandin
which shaves 5% off load time of a large sheet with lots of formats. We are calculating a hash over a decent sized array of pointers, so unroll the loop and reduce data-dependencies to give the compiler (and the CPU) a chance to do work in parallel Change-Id: I3d58fcf547c9280437295b9c9ec10aff16419afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-04Move uppercase to SubStr ctorMike Kaganski
Change-Id: Ifeeaead20e3ad37705fea04a6c3b9efa4339ddc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152543 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-04ScUserListData::InitTokens can't produce different splitsMike Kaganski
... for the same input, because ScGlobal::cListDelimiter is a constant. This means, that the copy ctor and assignment operator can be default, and ScUserListData comparison can be simplified. Change-Id: I500892ab592fd0dd24550c5189151f670efed4d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152541 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-04Simplify a bitMike Kaganski
Change-Id: Iaea9a425fc93adc716bdb4944244a14175cf7538 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152540 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-04Optimize ScAppCfg::ReadSortListCfgMike Kaganski
Do not initialize defaults when using custom user list. Change-Id: I8428a20b65182011a25325f0b7298ea51998346b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152587 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-04Simplify ScUserList, don't use unique_ptr.Mike Kaganski
Change-Id: Idd0ce7bfff115a3b762e963dd6cea7927c78e295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152586 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-02Add Calc view separation for tiled renderingParis Oplopoios
Calc now uses different colors based on the current view theme to paint tiles when using tiled rendering Change-Id: I1ca84371141ff026ad49ec362518ca13c59c7c6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152137 Tested-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit f4eb56b8b9ff3492e0a02fb76eb4ea7b851f4774) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152440 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-05-31tdf#155321 sc: fix color of the highest value on percentile color scaleTibor Nagy
if the highest value occurs multiple times in the data set. Also for coloring based on the percentile, use always the end of the color scale for the highest values, like other spreadsheets do, i.e. not the first possible color in the case of repeating values. For example, the corner case in the test document is not a red and two yellow cells any more, but a red and two green cells. Note: color of the other repeating values still differs from MSO, but the same as in Google Sheets. Change-Id: I1d7eacec6e442c1112a9568e64dd6461e2ff2fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152117 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-05-29use more TypedWhichIdNoel Grandin
Change-Id: If7b4320e199a01f2614e3bf582e5d96fade22aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152353 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26tdf#154131 Add Detect scientific number optionLaurent Balland
Add a sub case of Detect special numbers for import CSV (SC_IMPORTFILE), paste unformated text (SC_PASTETEXT) and text to columns (SC_TEXTTOCOLUMNS). Following cases are treated: - If "Detect special numbers" is true, then "Detect scientific numbers" must be true and all special formats are treated (date, time, scientific notation) in addition to basic decimal numbers. - If "Detect special numbers" is false and "Detect scientific numbers" is true only scientific notation is treated in addition to basic decimal numbers. - If "Detect special numbers" and "Detect scientific numbers" are both false only basic decimal numbers are recognized as numbers. It is the new case treated by this change The new option bDetectScientificNumber is append to ASCII options Change-Id: I73dff9f75d2c7b07ce155daa29dcc4ca9f288664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152072 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-05-26use more TypedWhichIdNoel Grandin
Change-Id: Iaa7ce9165da835a638bcc1d633bed0a2ff2c4108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152308 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26use more TypedWhichIdNoel Grandin
which flushed out an inconsistency in how SID_NUMBER_TYPE_FORMAT was being used Change-Id: Ib59ae4c4950136703d18d7485db432a39e3dc39c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152300 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26use more TypedWhichIdNoel Grandin
Change-Id: Icc1cbd2717034c87bdaea1b62253b001243c6652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152290 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25use more TypedWhichIdNoel Grandin
Change-Id: I6c54c1276b36cbc71417486ffcee2ef9ef0cff7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-22tdf#155319 sc: fix conditional format data bar after copyingTibor Nagy
This is a follow up to commit I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6 (tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color scale) Change-Id: Iacc1f5af762e1f6a40ecd13c33384e4a3340822a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151860 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ief95f111350808f010539bb733a553007d30a9df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152006 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-19CppunitTest_sc_dataprovider: fix sanitizers failureMiklos Vajna
Type info for ScCondFormatItem is now needed, see <https://ci.libreoffice.org/job/lo_ubsan/2782/console>. Change-Id: I7cd7762bbd9f961e78d6f2fa98a808ff88a82269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151993 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-17tdf#154477: sc: copy cache values when clone color conditional formatHenry Castro
When clone a conditional format list, also copy the cache values that hold the min and max values, otherwise if clone occurs when copying to the clipboard the values have wrong data due to limiting range cells copied. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id9085a1488a3bde24842e0d2e062c9b425074157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151836 Tested-by: Jenkins
2023-05-17tdf#154477: sc: add "updateValues" method to conditional format listHenry Castro
When copying a range cells to a clipboard, if exists a color scale conditional format from different ranges, it should update the min and max values, otherwise the color scale conditional format could not calculate min and max values due to limiting range cell copied. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I660e18090a60b99ddf2b55ce1f713fd41121290e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151835 Tested-by: Jenkins
2023-05-15MCGR: consolidations/cleanups for changes so farArmin Le Grand (allotropia)
Change-Id: I85cf40e4803b0485bb40349d8e81adc8123666c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151706 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-13use more optional for SdrObjListIterNoel Grandin
Change-Id: Iffd99d820889a1a5be514d46191ffaa2a6fa6910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10reinforce the infobar warning when there are both external links...Caolán McNamara
and WEBSERVICE present. This information is also shown in the "help" in the infobar Change-Id: I1412dc472afba353153b0c91aac1524cefa76aee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151641 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-08tdf#95520 Autofilter: Sort by colorSamuel Mehrbrodt
Change-Id: I2c1455cc2c741d16f09eccee0bf489f8990684f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151064 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-07tdf#139083 Only resize if 'resize with cell' is setRegina Henschel
The copy&paste of ranges with shapes had the following further bugs: * For cell anchored shapes the position was taken from the source rectangle instead of the anchor. * Resizing was calculated from source and destination rectangle, but should only depend on size of object range. * tdf#125938 Shapes were moved without adapting the anchor. * tdf#155091 Source with filtered rows produced doubled objects in paste. * The CopyToClip method has a useless NbcMove(size(0,0)). NbcMove is a move 'by', not a move 'to'. * tdf#155093 Pasted object has same name as source object and thus is not accessible via Navigator. * tdf#155094 Transposed pasted objects have wrong position * tdf#155095 Objects over collapsed group are incorrectly resized * tdf#141437, tdf#141436 transposed objects have wrong size Only objects, which can really resize, are now resized. In case of transposing no objects are resized. Transposing would need to transpose the object geometry, but that is missing. The offset inside the start anchor cell is adapted to the size of the destination cell to keep the anchor in this cell. Object resizing considers that filtered rows are removed whereas collapsed or hidden rows are shown in pasted area. Object resizing does no longer use global factors but calculate the desired snap rectangle and fits the object into it. Change-Id: I42924b28a2d652d8b70cb8e1a1d7ca4324b09cf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150161 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-05-06tdf#154872 Add Poisson distribution to Random Number GeneratorsBartosz Kosiorek
Change-Id: I325a76423a98a405dfb0f69fbd89eb9253c36390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151439 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-27sc: pivot table compact layoutDennis Francis
This implements compact layout for pivot tables. In ooxml each row field can have a compact layout setting. Support for any such "mixed" layout of tabular/outline/compact per field is also implemented. This also implements expand/collpse toggle buttons to field labels to make pivot tables with compact layout more usable. Such buttons are also available if other layouts are used. Conflicts: sc/qa/unit/pivottable_filters_test.cxx sc/source/ui/cctrl/checklistmenu.cxx sc/source/ui/inc/checklistmenu.hxx Change-Id: Ieaa1f3bd282ebdec804d0b45a0af7b3d95a2027f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151057 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2023-04-26tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color scaleTibor Nagy
This is a follow up to commit 3f614f431475e1bf3bb3bbeac59b0681309628b7 (tdf#95295: don't add duplicate conditional formats) The above commit clearly describes how this fix works. Change-Id: I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150899 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-24tdf#139544 change boundary columns to rows in sort dialogArvind K
Change-Id: I7f525bea42e6efd3c7c4b62a21d2638b676cd836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150432 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-20Related: tdf#154915 #NULL! is not an "Internal syntactical error"Eike Rathke
... but "Error: No code or intersection". Change-Id: I8c161e6553084fc849092f689273cbe181033e22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150654 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-19loplugin::unusedmethodsNoel Grandin
Change-Id: I6a07860edb13588b83345babeb53675aedc43f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-26 12:52:40 +0000